December 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: netif: sctp.h: Introduce value_string for enum sctp_spinfo_state

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35280?usp=email ) Change subject: netif: sctp.h: Introduce value_string for enum sctp_spinfo_state ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I78a0bd8279a04f4011c7273e0f542981308e482f Gerrit-Change-Number: 35280 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 10 Dec 2023 11:32:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: fix unsigned rc in gprs_llc_lle_tx_xid_resp()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35299?usp=email ) Change subject: llc: fix unsigned rc in gprs_llc_lle_tx_xid_resp() ...................................................................... llc: fix unsigned rc in gprs_llc_lle_tx_xid_resp() Change-Id: I724a1052fff2a43484c8bbf58b115d0769050191 Fixes: CID#300608 --- M src/llc/llc.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/llc/llc.c b/src/llc/llc.c index dc1a7b6..48d1ba6 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -534,10 +534,10 @@ int gprs_llc_lle_tx_xid_resp(struct gprs_llc_lle *lle, uint8_t *l3par, unsigned int l3par_len) { uint8_t bytes_response[1024]; - unsigned int rc, i; + int rc; /* Replace the SNDCP L3 xid_field with response from our upper layer: */ - for (i = 0; i < lle->rx_xid_len; i++) { + for (unsigned int i = 0; i < lle->rx_xid_len; i++) { struct gprs_llc_xid_field *xid_field_l3; if (lle->rx_xid[i].type != OSMO_GPRS_LLC_XID_T_L3_PAR) continue; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I724a1052fff2a43484c8bbf58b115d0769050191 Gerrit-Change-Number: 35299 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: fix l3par check in gprs_llc_lle_generate_xid()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35300?usp=email ) Change subject: llc: fix l3par check in gprs_llc_lle_generate_xid() ...................................................................... llc: fix l3par check in gprs_llc_lle_generate_xid() A NULL pointer dereference is possible if this function is called with l3par being NULL, but l3par_len being greater than 0. Change-Id: I80c18a45a248b85901d455bfb17e81734fa5961d Fixes: CID#300602 --- M src/llc/llc.c 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/llc/llc.c b/src/llc/llc.c index 48d1ba6..f8c6ba1 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -475,7 +475,7 @@ xid_fields[2].type = OSMO_GPRS_LLC_XID_T_N201_I; xid_fields[2].val = lle->params.n201_i; - if (l3par_len > 0) { + if (l3par != NULL && l3par_len > 0) { xid_fields[3].type = OSMO_GPRS_LLC_XID_T_L3_PAR; xid_fields[3].var.val_len = l3par_len; if (l3par_len > 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I80c18a45a248b85901d455bfb17e81734fa5961d Gerrit-Change-Number: 35300 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: fix l3par check in gprs_llc_lle_generate_xid()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35300?usp=email ) Change subject: llc: fix l3par check in gprs_llc_lle_generate_xid() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I80c18a45a248b85901d455bfb17e81734fa5961d Gerrit-Change-Number: 35300 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 10 Dec 2023 11:31:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: fix unsigned rc in gprs_llc_lle_tx_xid_resp()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35299?usp=email ) Change subject: llc: fix unsigned rc in gprs_llc_lle_tx_xid_resp() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I724a1052fff2a43484c8bbf58b115d0769050191 Gerrit-Change-Number: 35299 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 10 Dec 2023 11:30:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-ci[master]: Revert "coverity: build osmo-trx with USRP1 support"

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35291?usp=email ) Change subject: Revert "coverity: build osmo-trx with USRP1 support" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f47bbcc1388fd7bbe6830481e6a8abcdc582029 Gerrit-Change-Number: 35291 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 10 Dec 2023 11:30:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmocore[master]: socket: Fix uninitialized mem ptr free in osmo_sock_init2_multiaddr2()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35290?usp=email ) Change subject: socket: Fix uninitialized mem ptr free in osmo_sock_init2_multiaddr2() ...................................................................... socket: Fix uninitialized mem ptr free in osmo_sock_init2_multiaddr2() The goto tag was wrong, probably due to a copy-paste mistype while reimplementing the function. Closes: Coverity CID#336546 Change-Id: I06b810fde7bf750fcb42d6d9e6223883e26f5f0b --- M src/core/socket.c 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/socket.c b/src/core/socket.c index c600732..5b7489d 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -905,7 +905,7 @@ if (family == AF_INET && loc_has_v6only_addr) { LOGP(DLGLOBAL, LOGL_ERROR, "Cannot bind an IPv6 address to an AF_INET socket\n"); rc = -EINVAL; - goto ret_freeaddrinfo; + goto ret_freeaddrinfo_loc; } } /* figure out remote side of socket */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I06b810fde7bf750fcb42d6d9e6223883e26f5f0b Gerrit-Change-Number: 35290 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in libosmocore[master]: socket: Fix uninitialized mem ptr free in osmo_sock_init2_multiaddr2()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35290?usp=email ) Change subject: socket: Fix uninitialized mem ptr free in osmo_sock_init2_multiaddr2() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I06b810fde7bf750fcb42d6d9e6223883e26f5f0b Gerrit-Change-Number: 35290 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 10 Dec 2023 11:29:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-bsc[master]: gsm_data: use ABIS_RSL_CHAN_NR_CBITS_* in gsm_pchan2chan_nr()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35289?usp=email ) Change subject: gsm_data: use ABIS_RSL_CHAN_NR_CBITS_* in gsm_pchan2chan_nr() ...................................................................... gsm_data: use ABIS_RSL_CHAN_NR_CBITS_* in gsm_pchan2chan_nr() Change-Id: Ic9370d8d7f13cce0f9c6e60a920d04161a7d6844 --- M src/osmo-bsc/gsm_data.c 1 file changed, 16 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 4d77e75..b11607e 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -460,22 +460,20 @@ if (vamos_is_secondary) cbits = ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Bm_ACCHs; else - cbits = 0x01; + cbits = ABIS_RSL_CHAN_NR_CBITS_Bm_ACCHs; break; case GSM_PCHAN_PDCH: if (lchan_nr != 0) return -EINVAL; - cbits = RSL_CHAN_OSMO_PDCH >> 3; + cbits = ABIS_RSL_CHAN_NR_CBITS_OSMO_PDCH; break; case GSM_PCHAN_TCH_H: if (lchan_nr >= 2) return -EINVAL; if (vamos_is_secondary) cbits = ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Lm_ACCHs(lchan_nr); - else { - cbits = 0x02; - cbits += lchan_nr; - } + else + cbits = ABIS_RSL_CHAN_NR_CBITS_Lm_ACCHs(lchan_nr); break; case GSM_PCHAN_CCCH_SDCCH4: case GSM_PCHAN_CCCH_SDCCH4_CBCH: @@ -488,21 +486,19 @@ lchan_nr = 0; else if (lchan_nr > 4) return -EINVAL; - cbits = 0x04; - cbits += lchan_nr; + cbits = ABIS_RSL_CHAN_NR_CBITS_SDCCH4_ACCH(lchan_nr); break; case GSM_PCHAN_SDCCH8_SACCH8C: case GSM_PCHAN_SDCCH8_SACCH8C_CBCH: if (lchan_nr >= 8) return -EINVAL; - cbits = 0x08; - cbits += lchan_nr; + cbits = ABIS_RSL_CHAN_NR_CBITS_SDCCH8_ACCH(lchan_nr); break; default: case GSM_PCHAN_CCCH: if (lchan_nr != 0) return -EINVAL; - cbits = 0x10; + cbits = ABIS_RSL_CHAN_NR_CBITS_BCCH; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic9370d8d7f13cce0f9c6e60a920d04161a7d6844 Gerrit-Change-Number: 35289 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in osmo-bsc[master]: gsm_data: fix wrong variable set in gsm_pchan2chan_nr()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35288?usp=email ) Change subject: gsm_data: fix wrong variable set in gsm_pchan2chan_nr() ...................................................................... gsm_data: fix wrong variable set in gsm_pchan2chan_nr() I believe the actual intention was to reset the 'lchan_nr' variable, and not the 'chan_nr'. The 'lchan_nr' is used to compose the 'cbits': cbits = 0x04; cbits += lchan_nr; If the value is 4, then the result is: cbits = 0x04 + 4 = 0x08 which corresponds to SDCCH8 (not SDCCH4), and is clearly wrong. Change-Id: Ic9c7c2e46e24dab0b721221e9adcbbae2ca56d23 Fixes: ec1b5a0e9 "gsm_ts2chan_nr(): add assertions for lchan_nr" Fixes: CID#336586 --- M src/osmo-bsc/gsm_data.c 1 file changed, 25 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 580fa84..4d77e75 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -485,8 +485,8 @@ * See osmo-bts-xxx/oml.c:opstart_compl(). */ if (lchan_nr == CCCH_LCHAN) - chan_nr = 0; - else if (lchan_nr >= 4) + lchan_nr = 0; + else if (lchan_nr > 4) return -EINVAL; cbits = 0x04; cbits += lchan_nr; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic9c7c2e46e24dab0b721221e9adcbbae2ca56d23 Gerrit-Change-Number: 35288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023