December 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: mme: Implement missing UE attach steps

by osmith

Attention is currently required from: daniel, dexter, fixeria, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367?usp=email ) Change subject: mme: Implement missing UE attach steps ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib4a69aef40bf9dd17d640f650e459668f8415aaa Gerrit-Change-Number: 35367 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 14:09:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-iuh[master]: Bump version: 1.5.0.3-a99b → 1.5.1

by osmith

Attention is currently required from: daniel, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/35374?usp=email ) Change subject: Bump version: 1.5.0.3-a99b → 1.5.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: As discussed with Daniel, preparing a new release that fixes https://osmocom.org/issues/6307 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/35374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I01d1cebfe4fdd0bce53260d69e3f037068194ea8 Gerrit-Change-Number: 35374 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 14:06:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-iuh[master]: Bump version: 1.5.0.3-a99b → 1.5.1

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/35374?usp=email ) Change subject: Bump version: 1.5.0.3-a99b → 1.5.1 ...................................................................... Bump version: 1.5.0.3-a99b → 1.5.1 Change-Id: I01d1cebfe4fdd0bce53260d69e3f037068194ea8 --- M debian/changelog M src/Makefile.am 2 files changed, 24 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/74/35374/1 diff --git a/debian/changelog b/debian/changelog index ff0fb0a..0720fa0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,14 @@ +osmo-iuh (1.5.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * ranap_transp_layer_addr_decode2(): Fix decoding X.213 IPv4 address len=7 + + [ Daniel Willmann ] + * iu_client: Use local variable to track conn_id + * iu_client: Handle empty CR and InitialUE Message in DATA.ind + + -- Oliver Smith <osmith(a)sysmocom.de> Fri, 15 Dec 2023 15:05:11 +0100 + osmo-iuh (1.5.0) unstable; urgency=medium [ arehbein ] diff --git a/src/Makefile.am b/src/Makefile.am index 146c8aa..5ae4cbe 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -61,10 +61,10 @@ # build the shared RANAP + SABP library # -HNBAP_LIBVERSION=1:0:1 -RANAP_LIBVERSION=8:0:1 -RUA_LIBVERSION=1:1:1 -SABP_LIBVERSION=2:0:1 +HNBAP_LIBVERSION=1:1:1 +RANAP_LIBVERSION=8:1:1 +RUA_LIBVERSION=1:2:1 +SABP_LIBVERSION=2:1:1 lib_LTLIBRARIES = libosmo-hnbap.la libosmo-ranap.la libosmo-rua.la libosmo-sabp.la libosmo_hnbap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) -no-undefined libosmo_hnbap_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/35374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I01d1cebfe4fdd0bce53260d69e3f037068194ea8 Gerrit-Change-Number: 35374 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: mme: Implement missing UE attach steps

by pespin

Attention is currently required from: daniel, dexter, fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367?usp=email ) Change subject: mme: Implement missing UE attach steps ...................................................................... Patch Set 1: (1 comment) File mme/MME_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367/comment/024a215f_596b… PS1, Line 701: //g_pars.ue_pars.bearer.s11_teid_remote := rx_bctx_ies.fullyQualifiedTEID[0].tEID_GRE_Key; > do you want to keep this? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib4a69aef40bf9dd17d640f650e459668f8415aaa Gerrit-Change-Number: 35367 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 14:05:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: mme: Implement missing UE attach steps

by pespin

Attention is currently required from: daniel, dexter, fixeria, laforge, osmith, pespin. Hello Jenkins Builder, daniel, dexter, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: mme: Implement missing UE attach steps ...................................................................... mme: Implement missing UE attach steps Related: OS#6294 Change-Id: Ib4a69aef40bf9dd17d640f650e459668f8415aaa --- M library/GTPv2_Templates.ttcn M library/NAS_Templates.ttcn M library/s1ap/S1AP_Templates.ttcn M mme/MME_Tests.ttcn 4 files changed, 318 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/35367/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib4a69aef40bf9dd17d640f650e459668f8415aaa Gerrit-Change-Number: 35367 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 6 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: mme: Implement missing UE attach steps

by osmith

Attention is currently required from: daniel, dexter, fixeria, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367?usp=email ) Change subject: mme: Implement missing UE attach steps ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File mme/MME_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367/comment/2e952457_1db4… PS1, Line 701: //g_pars.ue_pars.bearer.s11_teid_remote := rx_bctx_ies.fullyQualifiedTEID[0].tEID_GRE_Key; do you want to keep this? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib4a69aef40bf9dd17d640f650e459668f8415aaa Gerrit-Change-Number: 35367 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 13:53:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: LTE_CryptoFunctions.ttcn: Log NAS_UE_State on failure

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35365?usp=email ) Change subject: LTE_CryptoFunctions.ttcn: Log NAS_UE_State on failure ...................................................................... LTE_CryptoFunctions.ttcn: Log NAS_UE_State on failure Change-Id: Ib95d496f06f07f4c28d9b08b6a8059d8453e8acd --- M mme/LTE_CryptoFunctions.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/mme/LTE_CryptoFunctions.ttcn b/mme/LTE_CryptoFunctions.ttcn index dee0f22..9923541 100644 --- a/mme/LTE_CryptoFunctions.ttcn +++ b/mme/LTE_CryptoFunctions.ttcn @@ -145,7 +145,7 @@ f_rx_is_downlink(nus), data_with_seq); if (exp_mac != secp_nas.messageAuthenticationCode) { setverdict(fail, "Received NAS MAC ", secp_nas.messageAuthenticationCode, - " doesn't match expected MAC ", exp_mac, ": ", secp_nas); + " doesn't match expected MAC ", exp_mac, ": ", secp_nas, " | nus: ", nus); return false; } return true; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib95d496f06f07f4c28d9b08b6a8059d8453e8acd Gerrit-Change-Number: 35365 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: LTE_CryptoFunctions.ttcn: Immediate termination upon failure

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35364?usp=email ) Change subject: LTE_CryptoFunctions.ttcn: Immediate termination upon failure ...................................................................... LTE_CryptoFunctions.ttcn: Immediate termination upon failure Change-Id: I09170c17c5cbb552a8aeef31b4b8fa5c89a00887 --- M mme/LTE_CryptoFunctions.ttcn 1 file changed, 21 insertions(+), 12 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/mme/LTE_CryptoFunctions.ttcn b/mme/LTE_CryptoFunctions.ttcn index 687caab..dee0f22 100644 --- a/mme/LTE_CryptoFunctions.ttcn +++ b/mme/LTE_CryptoFunctions.ttcn @@ -12,6 +12,7 @@ module LTE_CryptoFunctions { import from General_Types all; +import from Misc_Helpers all; import from S1AP_Types all; import from S1AP_PDU_Descriptions all; @@ -53,8 +54,8 @@ return f_snow_3g_f9(k_nas_int, seq_nr, bearer, is_downlink, data); } case else { - setverdict(fail, "Unsupported EIA: ", alg); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unsupported EIA: ", alg)); + return '00000000'O; /* never reached */ } } } @@ -67,8 +68,7 @@ f_snow_3g_f8(k_nas_enc, count, bearer, is_downlink, data); } case else { - setverdict(fail, "Unsupported EEA: ", alg); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unsupported EEA: ", alg)); } } } @@ -168,19 +168,19 @@ nus.rx_count := 0; nus.alg_int := NAS_ALG_IP_EIA1; /* FIXME: from decoded inner message! */ if (not f_nas_check_ip(nus, secp_nas)) { - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_nas_check_ip() failed"); } return dec_PDU_NAS_EPS(secp_nas.nAS_Message); } case ('0001'B) { /* IP only */ if (not f_nas_check_ip(nus, secp_nas)) { - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_nas_check_ip() failed"); } return dec_PDU_NAS_EPS(secp_nas.nAS_Message); } case ('0010'B) { /* IP + ciphered */ if (not f_nas_check_ip(nus, secp_nas)) { - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_nas_check_ip() failed"); } f_nas_encrypt(nus.alg_enc, nus.k_nas_enc, nus.rx_count, 0, f_rx_is_downlink(nus), secp_nas.nAS_Message); @@ -189,7 +189,7 @@ case ('0100'B) { /* IP + ciphered; new EPS security context */ nus.rx_count := 0; if (not f_nas_check_ip(nus, secp_nas)) { - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_nas_check_ip() failed"); } f_nas_encrypt(nus.alg_enc, nus.k_nas_enc, nus.rx_count, 0, f_rx_is_downlink(nus), secp_nas.nAS_Message); @@ -198,8 +198,8 @@ //case ('0101'B) { /* IP + partially ciphered */ } //case ('1100'B) { /* Service Request Message */ } case else { - setverdict(fail, "Implement SecHdrType for ", secp_nas); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Implement SecHdrType for ", secp_nas)); + mtc.stop; /* make compiler happy about not returning. */ } } } @@ -218,8 +218,8 @@ } else if (encrypt == true and authenticate == true and new_ctx == false) { return '0010'B; } else { - setverdict(fail, "invalid sec_hdr conditions"); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Invalid sec_hdr conditions"); + return '0000'B; /* never reached, make compiler happy */ } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09170c17c5cbb552a8aeef31b4b8fa5c89a00887 Gerrit-Change-Number: 35364 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/L1CTL_Types: add missing L1CTL_GPRS_RTS_IND message

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35370?usp=email ) Change subject: library/L1CTL_Types: add missing L1CTL_GPRS_RTS_IND message ...................................................................... library/L1CTL_Types: add missing L1CTL_GPRS_RTS_IND message This commit fixes the following warnings: While RAW-decoding type '@L1CTL_Types.L1ctlMessageLV': Invalid enum value '37' for '@L1CTL_Types.L1ctlMsgType': Change-Id: I0772f5273ecc2fb0c3def1fd645828b216e3032f Related: osmocom-bb.git I1494e0aac7555f6e01b4b435b77140afc42c098e --- M library/L1CTL_Types.ttcn 1 file changed, 26 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index 73e09fc..2e1f34b 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -53,7 +53,8 @@ L1CTL_GPRS_DL_TBF_CFG_REQ, L1CTL_GPRS_UL_BLOCK_REQ, L1CTL_GPRS_DL_BLOCK_IND, - L1CTL_EXT_RACH_REQ + L1CTL_EXT_RACH_REQ, + L1CTL_GPRS_RTS_IND } with { variant "FIELDLENGTH(8)" }; type enumerated L1ctlCcchMode { @@ -353,6 +354,13 @@ octetstring data } with { variant (data) "BYTEORDER(first)" }; + /* payload of L1CTL_GPRS_RTS_IND */ + type record L1ctlGprsRtsInd { + uint32_t fn, + uint8_t tn, + uint8_t usf + } with { variant "" }; + type union L1ctlMsgPayload { L1ctlFbsbReq fbsb_req, @@ -384,6 +392,7 @@ L1ctlGprsUlBlockReq ul_block_req, L1ctlGprsDlBlockInd dl_block_ind, L1ctlExtRachReq ext_rach_req, + L1ctlGprsRtsInd rts_ind, octetstring other } with { variant (other) "BYTEORDER(first)" @@ -438,6 +447,7 @@ ul_block_req, header.msg_type = L1CTL_GPRS_UL_BLOCK_REQ; dl_block_ind, header.msg_type = L1CTL_GPRS_DL_BLOCK_IND; ext_rach_req, header.msg_type = L1CTL_EXT_RACH_REQ; + rts_ind, header.msg_type = L1CTL_GPRS_RTS_IND; other, OTHERWISE; )" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35370?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0772f5273ecc2fb0c3def1fd645828b216e3032f Gerrit-Change-Number: 35370 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: fix padding attribute for PCUIF_Message

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35371?usp=email ) Change subject: library/PCUIF_Types: fix padding attribute for PCUIF_Message ...................................................................... library/PCUIF_Types: fix padding attribute for PCUIF_Message This fixes tons of warnings like this one: dec_PCUIF_Message(): Data remained at the end of the stream after successful decoding: '00'O Change-Id: If34da75c21b023222c44504d561cd6f658a401cf Fixes: e0666ea5 "PCUIF: upgrade to PCUIF v12" Related: OS#6191 --- M library/PCUIF_Types.ttcn 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index 33b454f..5ed87b6 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -400,8 +400,8 @@ pag_req, msg_type = PCU_IF_MSG_PAG_REQ; app_info_req, msg_type = PCU_IF_MSG_APP_INFO_REQ; container, msg_type = PCU_IF_MSG_CONTAINER)" - /* PCUIFv10: 1006 * 8 = 8048 bits */ - variant "PADDING(8048)" + /* PCUIFv12: 1007 * 8 = 8056 bits */ + variant "PADDING(8056)" }; external function enc_PCUIF_Message(in PCUIF_Message pdu) return octetstring -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35371?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If34da75c21b023222c44504d561cd6f658a401cf Gerrit-Change-Number: 35371 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023