December 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnodeb[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/35191?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/35191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I239229c0f23f70a75155ca8790b51a7c39acca21 Gerrit-Change-Number: 35191 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:53:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35190?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I10bfc4150e10cac048f320641c040fa300f734c4 Gerrit-Change-Number: 35190 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:53:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-mgw[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35192?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I82ee4ce3c961976526a792862061c237a372e31b Gerrit-Change-Number: 35192 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:53:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-sgsn[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35188?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/35188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6b6aa5a5100cf0045dcba1b062acc9376d34b0ae Gerrit-Change-Number: 35188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:53:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-hlr[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/35189?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/35189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4319b688286845d2ffbd944e51e9cc2e5159563c Gerrit-Change-Number: 35189 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:53:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-bts[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I08b297ea78e7cd60f28f0df79f2096f70c0692c6 Gerrit-Change-Number: 35184 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:52:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-gbproxy[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/35187?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/35187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I80708f7394d2d6f407523628a7101ec9428e1443 Gerrit-Change-Number: 35187 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-e1d[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a8cb558816534ac942bc38ff0b178849d610457 Gerrit-Change-Number: 35186 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:52:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-cbc[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9897bf964880f2e35a59812d319851eb6e06de68 Gerrit-Change-Number: 35185 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:51:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-bsc-nat[master]: Use uniform log format for default config files

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I811f7ede8d8b5ae4036bfd9cb530b1100ba0fb07 Gerrit-Change-Number: 35183 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:51:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-mgw[master]: check_rtp_origin: drop special case for legacy IuUP hack

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35181?usp=email ) Change subject: check_rtp_origin: drop special case for legacy IuUP hack ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: See my comment in https://gerrit.osmocom.org/c/osmo-mgw/+/35176/ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I158dd046fdfcb10392cde3de8cc88dd095a05b40 Gerrit-Change-Number: 35181 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:50:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_network: Allow rx of IuUP in loopback mode with set rem IP addre...

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email ) Change subject: mgcp_network: Allow rx of IuUP in loopback mode with set rem IP address and unset rem port ...................................................................... Patch Set 2: (1 comment) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/c37e978b_9e777f73 PS2, Line 866: HACK: for IuUP, we want to reply with an IuUP Initialization ACK upon the first RTP : * messag > hmm! why is this stuff still here, we have proper IuUP support and everything about this legacy hack […] Neels I'm not sure how's that supposed to work without that hack. IIUC the steps are: HNBGW <- MSC: RAB-Ass-Req HNBGW -> MGW: CRCX (RAN side, remote IuUP IPaddr+port not known) HNBGW <- MGW: CRCX ACK (MGW local IuuP IPaddr+port is now known) HNB <- HNBGW: RAB-Ass-Req (MGW local IuuP IPaddr+port) HNB -> MGW: IuUP Init // THE CODE YOU REMOVED IS NEEDED HERE HNB <- MGW: IuUP Init ACK HNB -> HNBGW: RAB-Ass-Resp HNBGW -> MGW: MDCX (RAN side, remote IuUP IPaddr+port is now known) HNBGW <- MGW: MDCX ACK HNBGW -> MSC: RAB-Ass-Resp So IIUC IuUP Init happens before receiving RAB-ASs-resp, so MGW cannot know the remote IuUP IP addr + port when receiving the IuUP Init packet from HNB... -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idd833997abce46886e9664505b2776fa5dadc8db Gerrit-Change-Number: 35176 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:49:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_network: Improve err logging when rtp pkt from unexpected origin...

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email ) Change subject: mgcp_network: Improve err logging when rtp pkt from unexpected origin comes in ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/d77bbf72_fdd119b9 PS1, Line 8: > could you include some before and after log output? I'm not following you here. File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/44488f75_0fb01cf3 PS1, Line 873: osmo_sockaddr_to_str(addr), osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf)); > +1 for slashing LOGPC 👍 […] I used osmo_sockaddr_ntop on purpose since we are only interested about the wrong IP address there, not the port. https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/178e1eaf_465dec47 PS1, Line 885: osmo_sockaddr_to_str(addr), osmo_sockaddr_port(&conn->end.addr.u.sa), It's printing the port of *another* address. See the check between "got" and "expected" there. > (completely different question, should we even care where RTP is coming from) if you don't care about audio injection, or having customers plugged to other calls due to bugs, sure. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id9b60395df667ae9898c23cbc2afe56ac7e8b0e5 Gerrit-Change-Number: 35175 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:42:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp-cli: Transmit remote IP addr in CRCX if known and port=0

by pespin

Attention is currently required from: dexter, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email ) Change subject: mgcp-cli: Transmit remote IP addr in CRCX if known and port=0 ...................................................................... Patch Set 3: (6 comments) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/af2b6608_db3feb0d PS3, Line 1317: ip > missing msgb_free()? […] Ack to the missing msgb_free. https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/46e8821d_54b68d11 PS3, Line 1323: urn - > maybe we should just omit the address, same as unset flag _PRESENCE_AUDIO_IP? I'm not following you here. The flag is set by the caller and used here, it makes no sense to unset it in this code. https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/093ca3fd_392fe499 PS3, Line 1339: et > same as above, maybe just skip this when port == 0 I prefer the way it is now. The caller controls what it wants to send through the presence flags, and if the user wants to sent a port, it's clear that port 0 is wrong. https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/90f97406_0c117396 PS3, Line 1353: codecs > this conflicts with branch neels/fmtp […] Whichever gets first into master makes the other one rebase it, I don't really care and it's fine each way. In any case, I'm fixing customer direct problems here, so it makes no sense delaying this commit imho. https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/1c78306b_82a52e21 PS3, Line 1367: * > indent Ack https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/5f670cee_be93eb67 PS3, Line 1373: * > . Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I30165dbac5e484011d0acf46af36f105954a501d Gerrit-Change-Number: 35152 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:39:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_multiaddr_get_name_buf()

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35180?usp=email ) Change subject: socket: Introduce API osmo_sock_multiaddr_get_name_buf() ...................................................................... Patch Set 1: (5 comments) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/ec1feec8_ff7c2583 PS1, Line 1968: return -EBADF; > i understand, but for the snprintf() like function signature, if at all possible you should always r […] Ack https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/1411b96c_cca4890e PS1, Line 1993: v6 = !!s > assigning a value to is_v6 in an 'else' clause and using is_v6 below. […] I only care about checking if the address is ipv6 in the case where we only have 1 IP, because in that case I need to put "[]" around it to separate it from the port number. If there's more than 1, no need, because everything is already enclosed in "()". So by doing it here I avoid doing a lookup in a string unless it's strictly needed. https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/489652e3_5bf0d19e PS1, Line 2005: OSMO_STRBUF_PRINTF(sb, "<need-more-bufs!>"); > (could print this above instead of adding the need_more_bufs local var, just my opinion) […] I could write an entire novel explaining the error there, but have that token printed and looking at the code already quickly explains what's going on. I want to print it here because at least is provides as many addresses as it can fit. https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/ad4d2b6d_0d053a6e PS1, Line 2019: bool is_v6 = false; > (can this code dup be collapsed with the above, maybe with a static func?) It could, I'd need to pass the sb as a param and so on, and I'm not sure if the macros can use an sb pointer.... https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/4852c8d4_24954207 PS1, Line 2052: int osmo_sock_get_name_buf(char *str, size_t str_len, int fd) > my first thought is "yes, sounds good". […] I prefer keeping the multiaddr prefix instead of a "2", we already use it in several places. This way code knowing only to be handling single address protocols can keep using it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48950754ed6f61ee5ffa04a447fab8903f10acc0 Gerrit-Change-Number: 35180 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:33:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-bts[master]: Transmit invalid AMR speech blocks instead of dummy FACCH

by pespin

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email ) Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 Gerrit-Change-Number: 35132 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:17:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

by pespin

Attention is currently required from: arehbein, daniel, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: my opinion here seems to be matching neels thought afaict. I see no need to remove the union. Simply check the mode always. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec Gerrit-Change-Number: 35079 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits()

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email ) Change subject: soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I70f93b3655eb21c2323e451052c40cd305c016c8 Gerrit-Change-Number: 35171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:07:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-bts[master]: Transmit invalid AMR speech blocks instead of dummy FACCH

by falconia

Attention is currently required from: fixeria, jolly, pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email ) Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 Gerrit-Change-Number: 35132 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 15:01:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-upf[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616 --- M contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg M contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg M contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg M doc/examples/osmo-upf/osmo-upf-create-dev.cfg M doc/examples/osmo-upf/osmo-upf-mockup.cfg M doc/examples/osmo-upf/osmo-upf.cfg 6 files changed, 31 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/00/35200/1 diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg b/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg index a6d4635..ab4c4d4 100644 --- a/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg +++ b/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg @@ -1,4 +1,10 @@ log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all info local-addr 127.0.0.2 diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg b/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg index d619f54..6655223 100644 --- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg +++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice logging level set-all info logging level session debug diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg index 8b77417..b639e96 100644 --- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg +++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice logging level set-all info logging level session debug diff --git a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg index e69f49c..a4195b9 100644 --- a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg +++ b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice timer pfcp x24 5000 diff --git a/doc/examples/osmo-upf/osmo-upf-mockup.cfg b/doc/examples/osmo-upf/osmo-upf-mockup.cfg index 1150c34..b5d5c5b 100644 --- a/doc/examples/osmo-upf/osmo-upf-mockup.cfg +++ b/doc/examples/osmo-upf/osmo-upf-mockup.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice timer pfcp x24 5000 diff --git a/doc/examples/osmo-upf/osmo-upf.cfg b/doc/examples/osmo-upf/osmo-upf.cfg index 77b6871..3477daa 100644 --- a/doc/examples/osmo-upf/osmo-upf.cfg +++ b/doc/examples/osmo-upf/osmo-upf.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice timer pfcp x24 5000 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616 Gerrit-Change-Number: 35200 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-trx[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/35199?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: If9466e925a405d35deed2e81f25a0a1677de0f3c --- M doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg M doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 5 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/35199/1 diff --git a/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg b/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg index e3047c0..d66f09a 100644 --- a/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg +++ b/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty diff --git a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg index ae55efe..8989565 100644 --- a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg index ae55efe..8989565 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg index 1468e93..6af7844 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg index 9eeb395..87aed57 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9466e925a405d35deed2e81f25a0a1677de0f3c Gerrit-Change-Number: 35199 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-sysmon[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/35198?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: If737fb3aa92735a3f4280170370ec48c89134526 --- M doc/examples/osmo-sysmon.cfg 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/98/35198/1 diff --git a/doc/examples/osmo-sysmon.cfg b/doc/examples/osmo-sysmon.cfg index 22c27cb..4e6e633 100644 --- a/doc/examples/osmo-sysmon.cfg +++ b/doc/examples/osmo-sysmon.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + ctrl-client bsc 127.0.0.1 4249 get-variable msc.0.connection_status get-variable bts_connection_status -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/35198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: If737fb3aa92735a3f4280170370ec48c89134526 Gerrit-Change-Number: 35198 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-smlc[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/35197?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I24f454bd83f32504b9c135d1620b7d02167e8bc6 --- M doc/examples/osmo-smlc/osmo-smlc.cfg 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/97/35197/1 diff --git a/doc/examples/osmo-smlc/osmo-smlc.cfg b/doc/examples/osmo-smlc/osmo-smlc.cfg index 6585d47..74b90e0 100644 --- a/doc/examples/osmo-smlc/osmo-smlc.cfg +++ b/doc/examples/osmo-smlc/osmo-smlc.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + cells lac-ci 23 42 lat 12.34567 lon 34.56789 cgi 262 42 17 5 lat 12.34765 lon 34.56987 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/35197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I24f454bd83f32504b9c135d1620b7d02167e8bc6 Gerrit-Change-Number: 35197 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-sip-connector[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/35196?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I1b1ebca276184158d585815a62da3b91fa9c3081 --- M doc/examples/osmo-sip-connector.cfg 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/96/35196/1 diff --git a/doc/examples/osmo-sip-connector.cfg b/doc/examples/osmo-sip-connector.cfg index bf4967e..ed77956 100644 --- a/doc/examples/osmo-sip-connector.cfg +++ b/doc/examples/osmo-sip-connector.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + app mncc socket-path /tmp/msc_mncc -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/35196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I1b1ebca276184158d585815a62da3b91fa9c3081 Gerrit-Change-Number: 35196 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-pcu[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35195?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I0d0042aa37da887afa0e9a5060cfbacaec23ed0a --- M doc/examples/osmo-pcu.cfg M doc/examples/osmo-pcu.e1_ccu.cfg 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/95/35195/1 diff --git a/doc/examples/osmo-pcu.cfg b/doc/examples/osmo-pcu.cfg index 4a3842d..1459826 100644 --- a/doc/examples/osmo-pcu.cfg +++ b/doc/examples/osmo-pcu.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + pcu flow-control-interval 10 cs 2 diff --git a/doc/examples/osmo-pcu.e1_ccu.cfg b/doc/examples/osmo-pcu.e1_ccu.cfg index 01f9b09..359f1d9 100644 --- a/doc/examples/osmo-pcu.e1_ccu.cfg +++ b/doc/examples/osmo-pcu.e1_ccu.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + pcu flow-control-interval 10 cs 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0d0042aa37da887afa0e9a5060cfbacaec23ed0a Gerrit-Change-Number: 35195 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-pcap[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/35194?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I0754f45561a45557d0f9fb3218813a2c8e83559c --- M doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg M doc/examples/osmo-pcap-client/osmo-pcap-client.cfg M doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg M doc/examples/osmo-pcap-server/osmo-pcap-server.cfg 4 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/94/35194/1 diff --git a/doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg b/doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg index 73d1535..6249f2a 100644 --- a/doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg +++ b/doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg @@ -3,6 +3,14 @@ !! ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-pcap-client/osmo-pcap-client.cfg b/doc/examples/osmo-pcap-client/osmo-pcap-client.cfg index 829ae5d..7035099 100644 --- a/doc/examples/osmo-pcap-client/osmo-pcap-client.cfg +++ b/doc/examples/osmo-pcap-client/osmo-pcap-client.cfg @@ -3,6 +3,14 @@ !! ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg b/doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg index 1b89ba5..db055d4 100644 --- a/doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg +++ b/doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level all everything logging level pcap notice logging level client notice diff --git a/doc/examples/osmo-pcap-server/osmo-pcap-server.cfg b/doc/examples/osmo-pcap-server/osmo-pcap-server.cfg index e380113..abfae61 100644 --- a/doc/examples/osmo-pcap-server/osmo-pcap-server.cfg +++ b/doc/examples/osmo-pcap-server/osmo-pcap-server.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level all everything logging level pcap notice logging level client notice -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/35194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I0754f45561a45557d0f9fb3218813a2c8e83559c Gerrit-Change-Number: 35194 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-msc[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/35193?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: Ic710873f9203414b343b216097785cef36ca05a9 --- M doc/examples/osmo-msc/osmo-msc.cfg M doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg M doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg 3 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/93/35193/1 diff --git a/doc/examples/osmo-msc/osmo-msc.cfg b/doc/examples/osmo-msc/osmo-msc.cfg index b086237..aac27d2 100644 --- a/doc/examples/osmo-msc/osmo-msc.cfg +++ b/doc/examples/osmo-msc/osmo-msc.cfg @@ -1,6 +1,14 @@ ! ! OsmoMSC configuration saved from vty ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg b/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg index 176867a..5033598 100644 --- a/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg +++ b/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg @@ -1,6 +1,14 @@ ! ! OsmoMSC configuration saved from vty ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg b/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg index 66adfdd..22f8734 100644 --- a/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg +++ b/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg @@ -1,6 +1,14 @@ ! ! OsmoMSC configuration saved from vty ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic710873f9203414b343b216097785cef36ca05a9 Gerrit-Change-Number: 35193 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-mgw[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35192?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I82ee4ce3c961976526a792862061c237a372e31b --- M doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg M doc/examples/osmo-mgw/osmo-mgw.cfg 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/92/35192/1 diff --git a/doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg b/doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg index bd948b8..dcf3663 100644 --- a/doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg +++ b/doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg @@ -1,6 +1,14 @@ ! ! MGCP configuration example ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1_input e1_line 0 driver dahdi e1_line 0 port 0 diff --git a/doc/examples/osmo-mgw/osmo-mgw.cfg b/doc/examples/osmo-mgw/osmo-mgw.cfg index 320feae..8535efe 100644 --- a/doc/examples/osmo-mgw/osmo-mgw.cfg +++ b/doc/examples/osmo-mgw/osmo-mgw.cfg @@ -1,6 +1,14 @@ ! ! MGCP configuration example ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + mgcp bind ip 127.0.0.1 rtp port-range 4002 16000 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I82ee4ce3c961976526a792862061c237a372e31b Gerrit-Change-Number: 35192 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-hnodeb[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/35191?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I239229c0f23f70a75155ca8790b51a7c39acca21 --- M doc/examples/osmo-hnodeb/osmo-hnodeb.cfg 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/91/35191/1 diff --git a/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg b/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg index 89b4799..6c46bd2 100644 --- a/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg +++ b/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print category 1 logging print category-hex 0 - logging timestamp 1 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/35191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I239229c0f23f70a75155ca8790b51a7c39acca21 Gerrit-Change-Number: 35191 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35190?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I10bfc4150e10cac048f320641c040fa300f734c4 --- M doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg M doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg M doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg M doc/examples/osmo-hnbgw/osmo-hnbgw.cfg 4 files changed, 22 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/90/35190/1 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg index 3236afb..83e03b9 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice cs7 instance 0 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg index 8be4b1b..671d790 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg @@ -22,9 +22,9 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg index 087764c..7599427 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice hnbgw plmn 001 01 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg index a9edc77..996a3ae 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice hnbgw plmn 001 01 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I10bfc4150e10cac048f320641c040fa300f734c4 Gerrit-Change-Number: 35190 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-hlr[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/35189?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I4319b688286845d2ffbd944e51e9cc2e5159563c --- M doc/examples/osmo-hlr-dgsm.cfg M doc/examples/osmo-hlr.cfg 2 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/89/35189/1 diff --git a/doc/examples/osmo-hlr-dgsm.cfg b/doc/examples/osmo-hlr-dgsm.cfg index 2774c24..50abefb 100644 --- a/doc/examples/osmo-hlr-dgsm.cfg +++ b/doc/examples/osmo-hlr-dgsm.cfg @@ -1,4 +1,12 @@ # OsmoHLR example configuration for Distributed GSM (mslookup) +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + hlr gsup # For D-GSM roaming, osmo-hlr's GSUP must listen on a public IP: diff --git a/doc/examples/osmo-hlr.cfg b/doc/examples/osmo-hlr.cfg index dd5292e..e2a3163 100644 --- a/doc/examples/osmo-hlr.cfg +++ b/doc/examples/osmo-hlr.cfg @@ -4,11 +4,11 @@ log stderr logging filter all 1 logging color 1 - logging print category 1 logging print category-hex 0 - logging print level 1 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level main notice logging level db notice logging level auc notice -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/35189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4319b688286845d2ffbd944e51e9cc2e5159563c Gerrit-Change-Number: 35189 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[M] Change in osmo-sgsn[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35188?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I6b6aa5a5100cf0045dcba1b062acc9376d34b0ae --- M doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg M doc/examples/osmo-gtphub/osmo-gtphub.cfg M doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg M doc/examples/osmo-sgsn/osmo-sgsn.cfg M doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg 5 files changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/88/35188/1 diff --git a/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg b/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg index 3913d2c..d4dadf9 100644 --- a/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg +++ b/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg @@ -5,6 +5,14 @@ ! For the test, try to use most config commands. ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login diff --git a/doc/examples/osmo-gtphub/osmo-gtphub.cfg b/doc/examples/osmo-gtphub/osmo-gtphub.cfg index 652d97d..da9bba5 100644 --- a/doc/examples/osmo-gtphub/osmo-gtphub.cfg +++ b/doc/examples/osmo-gtphub/osmo-gtphub.cfg @@ -2,6 +2,14 @@ ! Osmocom gtphub configuration ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login diff --git a/doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg b/doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg index 7abe7b3..69000b4 100644 --- a/doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg +++ b/doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg @@ -2,6 +2,14 @@ ! Osmocom SGSN configuration ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-sgsn/osmo-sgsn.cfg b/doc/examples/osmo-sgsn/osmo-sgsn.cfg index 11413c1..0b5ef4b 100644 --- a/doc/examples/osmo-sgsn/osmo-sgsn.cfg +++ b/doc/examples/osmo-sgsn/osmo-sgsn.cfg @@ -2,6 +2,14 @@ ! Osmocom SGSN configuration ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg index 1cc4bde..a7ed9cf 100644 --- a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg +++ b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg @@ -2,6 +2,14 @@ ! Osmocom SGSN configuration ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/35188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6b6aa5a5100cf0045dcba1b062acc9376d34b0ae Gerrit-Change-Number: 35188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-gbproxy[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/35187?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I80708f7394d2d6f407523628a7101ec9428e1443 --- M doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg M doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg M doc/examples/osmo-gbproxy/osmo-gbproxy.cfg 3 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/87/35187/1 diff --git a/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg b/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg index e30b9f7..79b0c4b 100644 --- a/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg +++ b/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg @@ -5,7 +5,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level all debug logging level gprs debug logging level ns info diff --git a/doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg b/doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg index 7457ee8..3fa5e6d 100644 --- a/doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg +++ b/doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg @@ -2,6 +2,14 @@ ! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty !! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg b/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg index 15c53d2..91edbab 100644 --- a/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg +++ b/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg @@ -2,6 +2,14 @@ ! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty !! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/35187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I80708f7394d2d6f407523628a7101ec9428e1443 Gerrit-Change-Number: 35187 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-e1d[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I4a8cb558816534ac942bc38ff0b178849d610457 --- M doc/examples/osmo-e1d-octoi-client.cfg M doc/examples/osmo-e1d-octoi-server.cfg M doc/examples/osmo-e1d-vpair.cfg 3 files changed, 24 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/86/35186/1 diff --git a/doc/examples/osmo-e1d-octoi-client.cfg b/doc/examples/osmo-e1d-octoi-client.cfg index ddb981c..88a0e48 100644 --- a/doc/examples/osmo-e1d-octoi-client.cfg +++ b/doc/examples/osmo-e1d-octoi-client.cfg @@ -7,9 +7,9 @@ logging color 1 logging print category-hex 0 logging print category 1 - logging print thread-id 0 - logging timestamp 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level e1d info logging level linp info ! diff --git a/doc/examples/osmo-e1d-octoi-server.cfg b/doc/examples/osmo-e1d-octoi-server.cfg index ac5e2b7..32eb227 100644 --- a/doc/examples/osmo-e1d-octoi-server.cfg +++ b/doc/examples/osmo-e1d-octoi-server.cfg @@ -8,8 +8,9 @@ logging print category-hex 0 logging print category 1 logging print thread-id 0 - logging timestamp 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level e1d info logging level linp info ! diff --git a/doc/examples/osmo-e1d-vpair.cfg b/doc/examples/osmo-e1d-vpair.cfg index 04bdb72..265a5d0 100644 --- a/doc/examples/osmo-e1d-vpair.cfg +++ b/doc/examples/osmo-e1d-vpair.cfg @@ -1,2 +1,10 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1d virtual-e1-pair 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a8cb558816534ac942bc38ff0b178849d610457 Gerrit-Change-Number: 35186 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-cbc[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I9897bf964880f2e35a59812d319851eb6e06de68 --- M doc/examples/osmo-cbc/osmo-cbc.cfg 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/85/35185/1 diff --git a/doc/examples/osmo-cbc/osmo-cbc.cfg b/doc/examples/osmo-cbc/osmo-cbc.cfg index 9874a39..5310268 100644 --- a/doc/examples/osmo-cbc/osmo-cbc.cfg +++ b/doc/examples/osmo-cbc/osmo-cbc.cfg @@ -1,4 +1,10 @@ log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level main notice logging level smscb notice logging level cbsp notice -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9897bf964880f2e35a59812d319851eb6e06de68 Gerrit-Change-Number: 35185 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[M] Change in osmo-bts[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I08b297ea78e7cd60f28f0df79f2096f70c0692c6 --- M doc/examples/litecell15/lc15bts-mgr.cfg M doc/examples/litecell15/osmo-bts-lc15.cfg M doc/examples/oc2g/oc2gbts-mgr.cfg M doc/examples/oc2g/osmo-bts-oc2g.cfg M doc/examples/octphy/osmo-bts-octphy.cfg M doc/examples/octphy/osmo-bts-trx2dsp1.cfg M doc/examples/sysmo/osmo-bts-sysmo.cfg M doc/examples/sysmo/sysmobts-mgr.cfg M doc/examples/trx/osmo-bts-trx-calypso.cfg M doc/examples/trx/osmo-bts-trx.cfg M doc/examples/virtual/osmo-bts-virtual.cfg 11 files changed, 54 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/35184/1 diff --git a/doc/examples/litecell15/lc15bts-mgr.cfg b/doc/examples/litecell15/lc15bts-mgr.cfg index a92a3fd..850fb15 100644 --- a/doc/examples/litecell15/lc15bts-mgr.cfg +++ b/doc/examples/litecell15/lc15bts-mgr.cfg @@ -3,10 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 - logging print category 0 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git a/doc/examples/litecell15/osmo-bts-lc15.cfg b/doc/examples/litecell15/osmo-bts-lc15.cfg index 907d83a..16651eb 100644 --- a/doc/examples/litecell15/osmo-bts-lc15.cfg +++ b/doc/examples/litecell15/osmo-bts-lc15.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/oc2g/oc2gbts-mgr.cfg b/doc/examples/oc2g/oc2gbts-mgr.cfg index 8248f60..ce72e5d 100644 --- a/doc/examples/oc2g/oc2gbts-mgr.cfg +++ b/doc/examples/oc2g/oc2gbts-mgr.cfg @@ -3,10 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 - logging print category 0 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git a/doc/examples/oc2g/osmo-bts-oc2g.cfg b/doc/examples/oc2g/osmo-bts-oc2g.cfg index f985f3b..ddf69f4 100644 --- a/doc/examples/oc2g/osmo-bts-oc2g.cfg +++ b/doc/examples/oc2g/osmo-bts-oc2g.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/octphy/osmo-bts-octphy.cfg b/doc/examples/octphy/osmo-bts-octphy.cfg index d6d03b5..a3a0093 100644 --- a/doc/examples/octphy/osmo-bts-octphy.cfg +++ b/doc/examples/octphy/osmo-bts-octphy.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/octphy/osmo-bts-trx2dsp1.cfg b/doc/examples/octphy/osmo-bts-trx2dsp1.cfg index bf590f7..477bff8 100644 --- a/doc/examples/octphy/osmo-bts-trx2dsp1.cfg +++ b/doc/examples/octphy/osmo-bts-trx2dsp1.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/sysmo/osmo-bts-sysmo.cfg b/doc/examples/sysmo/osmo-bts-sysmo.cfg index 6ff043d..f44c718 100644 --- a/doc/examples/sysmo/osmo-bts-sysmo.cfg +++ b/doc/examples/sysmo/osmo-bts-sysmo.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/sysmo/sysmobts-mgr.cfg b/doc/examples/sysmo/sysmobts-mgr.cfg index f891ada..00be2fd 100644 --- a/doc/examples/sysmo/sysmobts-mgr.cfg +++ b/doc/examples/sysmo/sysmobts-mgr.cfg @@ -3,9 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git a/doc/examples/trx/osmo-bts-trx-calypso.cfg b/doc/examples/trx/osmo-bts-trx-calypso.cfg index d6cc43a..018744f 100644 --- a/doc/examples/trx/osmo-bts-trx-calypso.cfg +++ b/doc/examples/trx/osmo-bts-trx-calypso.cfg @@ -5,7 +5,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl notice logging level oml notice logging level rll notice diff --git a/doc/examples/trx/osmo-bts-trx.cfg b/doc/examples/trx/osmo-bts-trx.cfg index 81313e5..6b23952 100644 --- a/doc/examples/trx/osmo-bts-trx.cfg +++ b/doc/examples/trx/osmo-bts-trx.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl notice logging level oml notice logging level rll notice diff --git a/doc/examples/virtual/osmo-bts-virtual.cfg b/doc/examples/virtual/osmo-bts-virtual.cfg index 13bc0e5..4663f17 100644 --- a/doc/examples/virtual/osmo-bts-virtual.cfg +++ b/doc/examples/virtual/osmo-bts-virtual.cfg @@ -3,10 +3,12 @@ !! ! log stderr - logging filter all 1 - logging color 0 + logging color 1 + logging print category-hex 0 logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I08b297ea78e7cd60f28f0df79f2096f70c0692c6 Gerrit-Change-Number: 35184 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-bsc-nat[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I811f7ede8d8b5ae4036bfd9cb530b1100ba0fb07 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/83/35183/1 diff --git a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg index ef6b1ae..49daec9 100644 --- a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg +++ b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + cs7 instance 0 point-code 0.23.3 asp asp-clnt-OsmoBSCNAT-CN 2905 0 m3ua -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I811f7ede8d8b5ae4036bfd9cb530b1100ba0fb07 Gerrit-Change-Number: 35183 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: Use uniform log format for default config files

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35182?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I992ff466db768f625dd722d40829aa0301cc1705 --- M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg M doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg M doc/examples/osmo-bsc/osmo-bsc-4trx.cfg M doc/examples/osmo-bsc/osmo-bsc-minimal.cfg M doc/examples/osmo-bsc/osmo-bsc.cfg M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg M doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg 12 files changed, 84 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/35182/1 diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg index 7d676d6..22c70b9 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg index 38e7afb..79ebca9 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg @@ -10,6 +10,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg index 1f33577..4487ff0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg index 464b37f..7e87bab 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg index 844bf05..dd015c0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg index 82283c8..e61acc0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg b/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg index 0b0afa8..34ffa99 100644 --- a/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg +++ b/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg @@ -11,7 +11,9 @@ logging color 1 logging print category-hex 0 logging print category 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level llapd notice logging level nm debug e1_input diff --git a/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg b/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg index 786813a..03c3477 100644 --- a/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg @@ -1,4 +1,12 @@ ! osmo-bsc configuration example with 4 TRX +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1_input e1_line 0 driver ipa network diff --git a/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg b/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg index b4e6e4a..011b9d7 100644 --- a/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + network network country code 901 mobile network code 70 diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg b/doc/examples/osmo-bsc/osmo-bsc.cfg index 5c2cf34..32a8349 100644 --- a/doc/examples/osmo-bsc/osmo-bsc.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc.cfg @@ -1,6 +1,14 @@ ! osmo-bsc default configuration ! (assumes STP to run on 127.0.0.1 and uses default point codes) ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1_input e1_line 0 driver ipa network diff --git a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg index 8d334b2..f10221e 100644 --- a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg @@ -1,5 +1,13 @@ ! osmo-bsc configuration example for custom SCCP addresses ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1_input e1_line 0 driver ipa network diff --git a/doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg b/doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg index 8d75296..877ac6a 100644 --- a/doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg +++ b/doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg @@ -11,8 +11,9 @@ logging color 1 logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level llapd notice logging level linp notice logging level lmi notice -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I992ff466db768f625dd722d40829aa0301cc1705 Gerrit-Change-Number: 35182 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810

by jolly

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33532?usp=email ) Change subject: mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007 Gerrit-Change-Number: 33532 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 01 Dec 2023 10:09:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

by daniel

Attention is currently required from: arehbein, laforge, neels, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops ...................................................................... Patch Set 4: (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/1bcca390_cafaad48 PS3, Line 546: if (iofd->io_ops.read_cb) > ah ok, read_cb happens to be in the same place as recvfrom_cb, so only checking the one location wor […] This fix is only necessary after removing the union. I don't see how you could realize checking the exact member with the union in place. I can basically stick an ```c OSMO_ASSERT(&iofd->io_ops.read_cb == &iofd->io_ops.recvfrom_cb) ``` in here. Unless I'm missing something this is exactly the feature of the union, afterwards you can't know whether this memory location was set as read_cb or recvfrom_cb. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/813d11cc_3e337a84 PS4, Line 391: || (iofd->mode == OSMO_IO_FD_MODE_RECVFROM_SENDTO && iofd->io_ops.recvfrom_cb)); > this code should also work with the union present? It "works" in the sense that it even returns true if mode == *_READ_WRITE and .recvfrom_cb (or the other way around) is set since both function pointers are sharing the same memory location. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec Gerrit-Change-Number: 35079 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 10:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-bts[master]: Transmit invalid AMR speech blocks instead of dummy FACCH

by jolly

Attention is currently required from: falconia, fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email ) Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ...................................................................... Patch Set 6: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/2caa0774_46c1a43c PS6, Line 456: with > Grammar still not fixed here - you fixed the one in TCH/F, but not here. Grr.... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 Gerrit-Change-Number: 35132 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 10:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-bts[master]: Transmit invalid AMR speech blocks instead of dummy FACCH

by jolly

Attention is currently required from: fixeria, jolly, pespin. Hello Jenkins Builder, falconia, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ...................................................................... Transmit invalid AMR speech blocks instead of dummy FACCH Every BTS needs to have some graceful handling for the scenario where it is time to send out a speech frame on TCH DL, but there is no frame to be sent. One possible solution is to transmit dummy FACCH, but this option is unattractive for TCH/AHS where FACCH displaces two speech frames rather than one. A more elegant solution is to emit a speech frame that is bad, causing the MS receiver to declare a BFI condition to trigger substitution and muting procedure. A bad frame is generated by gsm0503_tch_{afs,ahs}_encode() by setting the payload length to 0. Depends: libosmocore.git I82ce2adf995a4b42d1f378c5819f88d773b9104a Related: OS#6049 Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 57 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/35132/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 Gerrit-Change-Number: 35132 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

5 months, 1 week

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

by neels

Attention is currently required from: arehbein, daniel, laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops ...................................................................... Patch Set 4: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/4be00890_58bf8718 PS3, Line 546: if (iofd->io_ops.read_cb) > i fail to see the problem though, can you explain? ah ok, read_cb happens to be in the same place as recvfrom_cb, so only checking the one location worked out, but semantics dictate that we should check exactly the member that is matching the current iofd->mode. Yet this fix seems orthogonal to removing the union? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec Gerrit-Change-Number: 35079 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 02:08:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

by neels

Attention is currently required from: arehbein, daniel, laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops ...................................................................... Patch Set 4: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/4642b068_2e53601d PS4, Line 11: from distinguishing between write_cb() and sendto_cb() etc. AFAIU, iofd->mode should distinguish which union members are in use, so it should be possible to handle things properly .. where exactly is the bug this is fixing? is the mode switched without NULLing the cb pointers or something in that way? File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/504ea742_ce7737fb PS3, Line 546: if (iofd->io_ops.read_cb) > The fact that this happened to work is even more reason to remove the union. i fail to see the problem though, can you explain? File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/2d9f5f19_5048d303 PS4, Line 391: || (iofd->mode == OSMO_IO_FD_MODE_RECVFROM_SENDTO && iofd->io_ops.recvfrom_cb)); this code should also work with the union present? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec Gerrit-Change-Number: 35079 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 02:04:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[L] Change in libosmocore[master]: soft_uart: implement modem status lines and flow control

by neels

Attention is currently required from: fixeria, jolly, laforge, osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email ) Change subject: soft_uart: implement modem status lines and flow control ...................................................................... Patch Set 3: (4 comments) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/1868fc74_0520d7cb PS3, Line 54: OSMO_SUART_STATUS_F_CTS = (1 << 5), /*!< Clear To Send */ (personally i prefer an enum storing just 0, 1, 2, 3, 4, 5, because it is easy to get from 5 to 1<<5, but it is hard to get from 0b0100000 to 5.) https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/4d979bcb_8280797d PS3, Line 61: OSMO_SUART_FLOW_CTRL_M_NONE, (apparently it's good practice to set the first item = 0 explicitly) https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/5624218e_614fba12 PS3, Line 100: gets wdym, "gets". it returns void? File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/c8ecb0f8_d64c2318 PS2, Line 398: if (active) /* assert the given line */ > Logic 1 is negative voltage on RS232 level and is the de-asserted (disabled) level on control lines. re: if assert and de-assert is terminology from the matching spec, then of course keep using those terms here. (could have one comment in the first occurence to explain the term usage maybe) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I26b93ce76f2f6b6fbf017f2684312007db3c6d48 Gerrit-Change-Number: 35172 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 01:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits()

by neels

Attention is currently required from: fixeria, laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email ) Change subject: soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits() ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: looks sane, though i don't understand in depth -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I70f93b3655eb21c2323e451052c40cd305c016c8 Gerrit-Change-Number: 35171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 01:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_network: Allow rx of IuUP in loopback mode with set rem IP addre...

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email ) Change subject: mgcp_network: Allow rx of IuUP in loopback mode with set rem IP address and unset rem port ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/41b926f6_5c5c1446 PS2, Line 7: mgcp_network: Allow rx of IuUP in loopback mode with set rem IP address and unset rem port (you're getting into a habit of too long summary lines) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/215343ec_a396b346 PS2, Line 866: HACK: for IuUP, we want to reply with an IuUP Initialization ACK upon the first RTP : * messag hmm! why is this stuff still here, we have proper IuUP support and everything about this legacy hack should be purged. let's rebase this onto https://gerrit.osmocom.org/c/osmo-mgw/+/35181 and only copy the hack-less part. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idd833997abce46886e9664505b2776fa5dadc8db Gerrit-Change-Number: 35176 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 00:58:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-mgw[master]: check_rtp_origin: drop special case for legacy IuUP hack

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35181?usp=email ) Change subject: check_rtp_origin: drop special case for legacy IuUP hack ...................................................................... check_rtp_origin: drop special case for legacy IuUP hack We have proper IuUP support and everything about this legacy hack should be purged. The purpose of this function is to validate that RTP is coming from the expected address and port. To allow that legacy IuUP hack, which is no longer needed, we punched a hole into this validation, by adding this special case for loopback mode (suddenly we don't care who or what sends RTP and bounce it back to anyone). So let's get rid of this hole that was only needed for very early 3G voice hacking. Related: Idd833997abce46886e9664505b2776fa5dadc8db Change-Id: I158dd046fdfcb10392cde3de8cc88dd095a05b40 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 28 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/81/35181/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 46d0cb4..23879b4 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -835,31 +835,14 @@ char ipbuf[INET6_ADDRSTRLEN]; if (osmo_sockaddr_is_any(&conn->end.addr) != 0) { - switch (conn->conn->mode) { - case MGCP_CONN_LOOPBACK: - /* HACK: for IuUP, we want to reply with an IuUP Initialization ACK upon the first RTP - * message received. We currently hackishly accomplish that by putting the endpoint in - * loopback mode and patching over the looped back RTP message to make it look like an - * ack. We don't know the femto cell's IP address and port until the RAB Assignment - * Response is received, but the nano3G expects an IuUP Initialization Ack before it even - * sends the RAB Assignment Response. Hence, if the remote address is 0.0.0.0 and the - * MGCP port is in loopback mode, allow looping back the packet to any source. */ - LOGPCONN(conn->conn, DRTP, LOGL_ERROR, - "In loopback mode and remote address not set:" - " allowing data from address: %s\n", - osmo_sockaddr_ntop(&addr->u.sa, ipbuf)); - return 0; - - default: - /* Receiving early media before the endpoint is configured. Instead of logging - * this as an error that occurs on every call, keep it more low profile to not - * confuse humans with expected errors. */ - LOGPCONN(conn->conn, DRTP, LOGL_INFO, - "Rx RTP from %s, but remote address not set:" - " dropping early media\n", - osmo_sockaddr_ntop(&addr->u.sa, ipbuf)); - return -1; - } + /* Receiving early media before the endpoint is configured. Instead of logging + * this as an error that occurs on every call, keep it more low profile to not + * confuse humans with expected errors. */ + LOGPCONN(conn->conn, DRTP, LOGL_INFO, + "Rx RTP from %s, but remote address not set:" + " dropping early media\n", + osmo_sockaddr_ntop(&addr->u.sa, ipbuf)); + return -1; } /* Note: Check if the inbound RTP data comes from the same host to -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I158dd046fdfcb10392cde3de8cc88dd095a05b40 Gerrit-Change-Number: 35181 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

5 months, 1 week

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_network: Improve err logging when rtp pkt from unexpected origin...

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email ) Change subject: mgcp_network: Improve err logging when rtp pkt from unexpected origin comes in ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/ed499b16_29e4fe50 PS1, Line 8: could you include some before and after log output? File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/3265754a_9577d428 PS1, Line 873: osmo_sockaddr_to_str(addr), osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf)); +1 for slashing LOGPC 👍 (we could use osmo_sockaddr_to_str_c(OTC_SELECT,..) or _buf(..) with static buffer for the second addr) https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/5115db42_559c8b3d PS1, Line 885: osmo_sockaddr_to_str(addr), osmo_sockaddr_port(&conn->end.addr.u.sa), doesn't osmo_sockaddr_to_str() already include the port? (completely different question, should we even care where RTP is coming from) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id9b60395df667ae9898c23cbc2afe56ac7e8b0e5 Gerrit-Change-Number: 35175 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 00:39:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp-cli: Transmit remote IP addr in CRCX if known and port=0

by neels

Attention is currently required from: dexter, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email ) Change subject: mgcp-cli: Transmit remote IP addr in CRCX if known and port=0 ...................................................................... Patch Set 3: Code-Review-1 (8 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/8b8940cf_ddbe4eb8 PS3, Line 7: cli (i'd prefer unabbreviated "client", vs. "cmdline interface") Patchset: PS3: marking -1 to clarify conflict with https://gerrit.osmocom.org/c/osmo-mgw/+/34899 File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/1a8a1131_f8a0af89 PS3, Line 1317: ip missing msgb_free()? also like below, maybe just omit addr instead https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/56e842d6_7a4a48db PS3, Line 1323: urn - maybe we should just omit the address, same as unset flag _PRESENCE_AUDIO_IP? https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/db76e38c_fb086adb PS3, Line 1339: et same as above, maybe just skip this when port == 0 https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/32bbb2d4_f01cb972 PS3, Line 1353: codecs this conflicts with branch neels/fmtp see https://gerrit.osmocom.org/c/osmo-mgw/+/34899 so after that patch we only use ptmap[], not codecs[]. In that patch, it's not yet clear how to re-add backwards compat; the patch removes codecs[], but instead codecs[] has to stay for compat, even though only ptmap[] is in use; maybe we can dynamically adopt codecs[] into ptmap[] ... so how do we resolve this conflict, rebase this onto neels/fmtp or vice versa? which patch has higher priority for users? either way, ultimately this code should s/codecs[i]/ptmap[i].codec/ https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/918b6913_2280908e PS3, Line 1367: * indent https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/62c28d66_3cc658f7 PS3, Line 1373: * . -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I30165dbac5e484011d0acf46af36f105954a501d Gerrit-Change-Number: 35152 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 00:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 1 week

1
0
0 0

2024

2023

2022

gerrit-log December 2023