December 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-mgw[master]: mgw: do not fail MGCP on codec mismatch
by neels 21 Dec '23

21 Dec '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email ) Change subject: mgw: do not fail MGCP on codec mismatch ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/35302/comment/1327b37f_24e71f52 PS1, Line 21: Still fail if one side has no codecs -- the only reason is that changing > I?m not following here. I don't understand why failing when the other side has no codecs set. only because that is what osmo-mgw is currently doing, and I don't want to change too many things at once. updating the commit log... -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3d1163fe622bdd7dc42a485f796072524ab39db9 Gerrit-Change-Number: 35302 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Dec 2023 00:25:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: Add LLC and HLC information to MNCC interface definiton
by neels 21 Dec '23

21 Dec '23

Attention is currently required from: fixeria, jolly, laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email ) Change subject: Add LLC and HLC information to MNCC interface definiton ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > We cannot add new fields to the MNCC protocol without bumping the protocol version. @vyanitskiy@sysmocom.de a vote of -2 is sticky and means "the idea of this patch is flawed and we will never merge this no matter what" ... I guess instead you mean to -1 until the version number is bumped along with this patch? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15f5afcf069ee6c1c4641108ceacc837bee311b5 Gerrit-Change-Number: 35392 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Dec 2023 00:04:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Fix tests reusing IMSI suffix
by pespin 20 Dec '23

20 Dec '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35395?usp=email ) Change subject: mme: Fix tests reusing IMSI suffix ...................................................................... mme: Fix tests reusing IMSI suffix Use value 0 to indicate that the test is not really using the generated imsi, to easily increment it for tests requiring it. Change-Id: Ia9d70c125b92352f50adfa80a6cb916bfc8acf99 --- M mme/MME_Tests.ttcn 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/35395/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 7266496..973c097 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -871,7 +871,7 @@ var charstring id := testcasename(); f_init_diameter(id); - f_init_s1ap(id, 4); + f_init_s1ap(id, 0); f_s1ap_setup(0); f_init_gtp(id); @@ -1112,7 +1112,7 @@ var charstring id := testcasename(); f_init_diameter(id); - f_init_s1ap(id, 4); + f_init_s1ap(id, 0); f_s1ap_setup(0); f_init_gtp(id); @@ -1126,7 +1126,7 @@ /* Successful RESET procedure from eNB to MME */ testcase TC_s1ap_reset() runs on MTC_CT { var charstring id := testcasename(); - f_init_s1ap(id, 3); + f_init_s1ap(id, 0); f_s1ap_setup(0); var template (value) S1AP_IEs.Cause reset_cause := {misc := om_intervention}; @@ -1187,7 +1187,7 @@ var charstring id := testcasename(); f_init_diameter(id); - f_init_s1ap(id, 4); + f_init_s1ap(id, 5); f_s1ap_setup(0); var ConnHdlrPars pars := f_init_pars(ue_idx := 0); @@ -1274,7 +1274,7 @@ var charstring id := testcasename(); f_init_diameter(id); - f_init_s1ap(id, 4); + f_init_s1ap(id, 6); f_init_gtpv2_s11(id); f_s1ap_setup(0); f_init_gtp(id); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia9d70c125b92352f50adfa80a6cb916bfc8acf99 Gerrit-Change-Number: 35395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Fix TEID values used in test
by pespin 20 Dec '23

20 Dec '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35394?usp=email ) Change subject: mme: Fix TEID values used in test ...................................................................... mme: Fix TEID values used in test Related: OS#6294 Change-Id: I5a32491a00eb6bad505e4bcf9a88017382073138 --- M library/GTP_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 19 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/35394/1 diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 839ed28..031d9b2 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -1036,10 +1036,10 @@ private_extension_gtpc := omit } } - template (value) Gtp1cUnitdata ts_GTPC_SGSNContextAck(GtpPeer peer, uint16_t seq, + template (value) Gtp1cUnitdata ts_GTPC_SGSNContextAck(GtpPeer peer, OCT4 teid, uint16_t seq, template (value) GTPC_PDUs SGSNContextAckPDU := ts_SGSNContextAckPDU(GTP_CAUSE_REQUEST_ACCEPTED)) := { peer := peer, - gtpc := ts_GTP1C_PDU(sgsnContextAcknowledge, '00000000'O, valueof(SGSNContextAckPDU), seq) + gtpc := ts_GTP1C_PDU(sgsnContextAcknowledge, teid, valueof(SGSNContextAckPDU), seq) } /* GTP-C RIM */ diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index f43bfbd..7266496 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -1232,6 +1232,8 @@ var OCT4 ptmsi; var OCT3 ptmsi_sig; var Gtp1cUnitdata gtpc_pdu; + var OCT4 new_sgsn_local_teid := '12345678'O; + var OCT4 old_mme_local_teid; f_init_handler(pars); f_gtp_register_imsi(g_pars.ue_pars.imsi); @@ -1241,16 +1243,17 @@ * convert it to P-TMSI and pass P-TMSI below */ guti2rai_ptmsi(g_pars.ue_pars.guti, rai, ptmsi, ptmsi_sig); - SGSNContextReqPDU := ts_SGSNContextReqPDU(rai, '00000000'O, f_inet_addr(mp_gn_local_ip), + SGSNContextReqPDU := ts_SGSNContextReqPDU(rai, new_sgsn_local_teid, f_inet_addr(mp_gn_local_ip), ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig)); GTP.send(ts_GTPC_SGSNContextReq(g_gn_iface_peer, 0, SGSNContextReqPDU)); timer T := 5.0; T.start; alt { - [] GTP.receive(tr_GTPC_SGSNContextResp(g_gn_iface_peer, '00000000'O, + [] GTP.receive(tr_GTPC_SGSNContextResp(g_gn_iface_peer, new_sgsn_local_teid, tr_SGSNContextRespPDU(GTP_CAUSE_REQUEST_ACCEPTED, g_pars.ue_pars.imsi))) -> value gtpc_pdu { + old_mme_local_teid := gtpc_pdu.gtpc.gtpc_pdu.sgsn_ContextResponse.teidControlPlane.teidControlPlane; setverdict(pass); } [] GTP.receive { @@ -1261,7 +1264,8 @@ } } - GTP.send(ts_GTPC_SGSNContextAck(g_gn_iface_peer, oct2int(gtpc_pdu.gtpc.opt_part.sequenceNumber), + GTP.send(ts_GTPC_SGSNContextAck(g_gn_iface_peer, old_mme_local_teid, + oct2int(gtpc_pdu.gtpc.opt_part.sequenceNumber), ts_SGSNContextAckPDU(GTP_CAUSE_REQUEST_ACCEPTED))); /* Give some time to process the SGSNContextACK: */ f_sleep(3.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a32491a00eb6bad505e4bcf9a88017382073138 Gerrit-Change-Number: 35394 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: Add LLC and HLC information to MNCC interface definiton
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email ) Change subject: Add LLC and HLC information to MNCC interface definiton ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: We cannot add new fields to the MNCC protocol without bumping the protocol version. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15f5afcf069ee6c1c4641108ceacc837bee311b5 Gerrit-Change-Number: 35392 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 16:54:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: Add LLC and HLC transcoding to MNCC transcoding functions
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email ) Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ...................................................................... Patch Set 2: (1 comment) File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/1284efa6_c3f4a299 PS2, Line 413: gsm48_encode_highl_compat The `encode`/`decode` in symbol names creates a false impression that these functions actually `encode`/`decode` from/to an abstract representation. We may need the actual encoding/decoding on the MS side (osmocom-bb). Maybe call it pack/unpack or wrap/unwrap to avoid confusion? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de Gerrit-Change-Number: 35391 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Dec 2023 16:53:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: extend documentation about transports
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35388?usp=email ) Change subject: extend documentation about transports ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I84d926b45c97477e77a7852bc8254ce9a7614a33 Gerrit-Change-Number: 35388 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:53:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: docs/shell: extend the introduction part; link to video presentation
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35387?usp=email ) Change subject: docs/shell: extend the introduction part; link to video presentation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77c30921f2b8c002c9dda244656c348c96b41f06 Gerrit-Change-Number: 35387 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:52:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: OML: Add Get Attributes for supported MOs for Channel Object Class
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email ) Change subject: OML: Add Get Attributes for supported MOs for Channel Object Class ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I56e067be9e5c17625c7da4e982b90927802f57b4 Gerrit-Change-Number: 35379 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:50:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email ) Change subject: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I49ab516c38a986520f1d3f6e26ddd20ee16688ac Gerrit-Change-Number: 35378 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:48:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log December 2023