November 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: docs: Fix docstring syntax to avoid warnings
by laforge 03 Nov '23

03 Nov '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34939?usp=email ) Change subject: docs: Fix docstring syntax to avoid warnings ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I170176910c4519005b9276dbe5854aaaecb58efb Gerrit-Change-Number: 34939 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 23:42:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: docs: shell: Re-order the command sections/classes
by laforge 03 Nov '23

03 Nov '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34938?usp=email ) Change subject: docs: shell: Re-order the command sections/classes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I11e66757f10cc28fda547244ae09d51dacd70824 Gerrit-Change-Number: 34938 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 23:42:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: Use argparser for verify_adm to support --help
by laforge 02 Nov '23

02 Nov '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34944?usp=email ) Change subject: pySim-shell: Use argparser for verify_adm to support --help ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/34944/comment/295f1204_cfedb8e4 PS1, Line 7: pySim-shell: Use arparser for verify_adm to support --help > argparser Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34944?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3321fae66a11efd00c53b66c7890fce84796e658 Gerrit-Change-Number: 34944 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:46:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: docs: shell: Clarify various different card support
by laforge 02 Nov '23

02 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34935?usp=email ) Change subject: docs: shell: Clarify various different card support ...................................................................... docs: shell: Clarify various different card support Change-Id: Ibf8e3538aa3c954df72c11ec0a2f885031b54b0e --- M docs/shell.rst 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/docs/shell.rst b/docs/shell.rst index de30ae7..c7e788a 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -1,7 +1,8 @@ pySim-shell =========== -pySim-shell is an interactive command line shell for all kind of interactions with SIM cards. +pySim-shell is an interactive command line shell for all kind of interactions with SIM cards, +including classic GSM SIM, GSM-R SIM, UICC, USIM, ISIM, HPSIM and recently even eUICC. The interactive shell provides command for -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibf8e3538aa3c954df72c11ec0a2f885031b54b0e Gerrit-Change-Number: 34935 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: docs: shell: By now we have encoders/decoders for most files
by laforge 02 Nov '23

02 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34936?usp=email ) Change subject: docs: shell: By now we have encoders/decoders for most files ...................................................................... docs: shell: By now we have encoders/decoders for most files Change-Id: Ia771f9969ae7eb0094d1768af3f7f54cc9d0d581 --- M docs/shell.rst 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/docs/shell.rst b/docs/shell.rst index c7e788a..2a16965 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -11,9 +11,9 @@ * CHV/PIN management (VERIFY, ENABLE, DISABLE, UNBLOCK) * decoding of SELECT response (file control parameters) * reading and writing of files and records in raw, hex-encoded binary format -* for some files where related support has been developed: +* for most files (where related file-specific encoder/decoder classes have been developed): - * decoded reading (display file data in JSON format) + * decoded reading (display file data represented in human and machine readable JSON format) * decoded writing (encode from JSON to binary format, then write) By means of using the python ``cmd2`` module, various useful features improve usability: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia771f9969ae7eb0094d1768af3f7f54cc9d0d581 Gerrit-Change-Number: 34936 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: docs: shell: link to cmd2 documentation
by laforge 02 Nov '23

02 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34937?usp=email ) Change subject: docs: shell: link to cmd2 documentation ...................................................................... docs: shell: link to cmd2 documentation Change-Id: I532cb33781f95fe847db7fae7a5264b5d9c416de --- M docs/shell.rst 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/docs/shell.rst b/docs/shell.rst index 2a16965..12c0493 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -50,7 +50,9 @@ cmd2 basics ----------- -FIXME +As pySim-shell is built upon ``cmd2``, some generic cmd2 commands/features are available. You may +want to check out the `cmd2 Builtin commands <https://cmd2.readthedocs.io/en/stable/features/builtin_commands.html>`_ +to learn about those. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I532cb33781f95fe847db7fae7a5264b5d9c416de Gerrit-Change-Number: 34937 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: docs: shell: link to cmd2 documentation
by laforge 02 Nov '23

02 Nov '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34937?usp=email ) Change subject: docs: shell: link to cmd2 documentation ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I532cb33781f95fe847db7fae7a5264b5d9c416de Gerrit-Change-Number: 34937 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:44:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: docs: shell: By now we have encoders/decoders for most files
by laforge 02 Nov '23

02 Nov '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34936?usp=email ) Change subject: docs: shell: By now we have encoders/decoders for most files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia771f9969ae7eb0094d1768af3f7f54cc9d0d581 Gerrit-Change-Number: 34936 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:44:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: docs: shell: Clarify various different card support
by laforge 02 Nov '23

02 Nov '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34935?usp=email ) Change subject: docs: shell: Clarify various different card support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibf8e3538aa3c954df72c11ec0a2f885031b54b0e Gerrit-Change-Number: 34935 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:44:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp
by laforge 02 Nov '23

02 Nov '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b Gerrit-Change-Number: 34900 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:43:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0