November 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: context_map_sccp: Fix assert hit due to missing ev handling
by laforge 02 Nov '23

02 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email ) Change subject: context_map_sccp: Fix assert hit due to missing ev handling ...................................................................... context_map_sccp: Fix assert hit due to missing ev handling This was being triggered recently by HNBGW_Tests.TC_ranap_cs_mo_disconnect in osmo-ttcn3-hacks.git. Change-Id: Idaad11eaa3c2e56de792f80bab1f1d8435ef9b68 --- M src/osmo-hnbgw/context_map_sccp.c 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 9b4837d..4a78337 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -452,6 +452,7 @@ handle_rx_sccp(fi, ranap_msg); return; + case MAP_SCCP_EV_RAN_LINK_LOST: case MAP_SCCP_EV_USER_ABORT: case MAP_SCCP_EV_CN_LINK_LOST: /* Stop waiting for RLSD, send RLSD now. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idaad11eaa3c2e56de792f80bab1f1d8435ef9b68 Gerrit-Change-Number: 34950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Fix assert hit due to missing ev handling
by laforge 02 Nov '23

02 Nov '23

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email ) Change subject: context_map_sccp: Fix assert hit due to missing ev handling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idaad11eaa3c2e56de792f80bab1f1d8435ef9b68 Gerrit-Change-Number: 34950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:42:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: repo-install-test: fix ca-certificates-java error
by laforge 02 Nov '23

02 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34954?usp=email ) Change subject: repo-install-test: fix ca-certificates-java error ...................................................................... repo-install-test: fix ca-certificates-java error The repo-install-test started to fail on debian 10 with the following error. Apparently this happens when installing ca-certificates-java after installing java. Add a workaround. Setting up ca-certificates-java (20190405) ... head: cannot open '/etc/ssl/certs/java/cacerts' for reading: No such file or directory Exception in thread "main" java.lang.InternalError: Error loading java.security file Change-Id: I00b9c97d9d85fb37ba33a48caa732cd50de99683 --- M scripts/repo-install-test/run-inside.sh 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index b45d76d..e08338f 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -185,8 +185,10 @@ case "$DISTRO" in debian10) - # Can't access https://osmocom.org otherwise + # libgnutls30: can't access https://osmocom.org otherwise + # ca-certificates-java: fails if installed after java apt-get install -y --no-install-recommends \ + ca-certificates-java \ libgnutls30 ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I00b9c97d9d85fb37ba33a48caa732cd50de99683 Gerrit-Change-Number: 34954 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: repo-install-test: ignore limesuite-images
by laforge 02 Nov '23

02 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34955?usp=email ) Change subject: repo-install-test: ignore limesuite-images ...................................................................... repo-install-test: ignore limesuite-images Don't attempt to install limesuite-images. It runs a post-install script that downloads files from an external server and fails currently, as there are no images for 23.10. While we have limesuite-images packages in our OBS repository, this is just a side-effect of building limesuite. What we are really interested in is liblimesuite for osmo-trx, as I understand. Add --no-install-recommends to the apt-get install line in install_repo_packages_debian, because the main limesuite package has limesuite-images in recommends and would pull it in otherwise. Change-Id: I237408c805977c831f352a57a301ea45753d1ac1 --- M scripts/repo-install-test/blacklist_debian10.txt M scripts/repo-install-test/blacklist_debian11.txt M scripts/repo-install-test/blacklist_debian12.txt M scripts/repo-install-test/run-inside.sh 4 files changed, 29 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/scripts/repo-install-test/blacklist_debian10.txt b/scripts/repo-install-test/blacklist_debian10.txt index 6570de6..93dac75 100644 --- a/scripts/repo-install-test/blacklist_debian10.txt +++ b/scripts/repo-install-test/blacklist_debian10.txt @@ -19,6 +19,10 @@ osmocom-nitb osmocom-nitb-dbg +# Not relevant for the test +limesuite-images +limesuite-images23.10 + # SoapySDR is not used anymore (see OS#3542) soapysdr-module-lms7 soapysdr0.6-module-lms7 diff --git a/scripts/repo-install-test/blacklist_debian11.txt b/scripts/repo-install-test/blacklist_debian11.txt index 53187dc..c962ffc 100644 --- a/scripts/repo-install-test/blacklist_debian11.txt +++ b/scripts/repo-install-test/blacklist_debian11.txt @@ -31,6 +31,8 @@ libulfius2.7-dbgsym libyder2.0-dbgsym limesuite-dbgsym +limesuite-images +limesuite-images23.10 soapysdr0.7-module-lms7-dbgsym # Depends on specific verions 0.5.4.38.0847 of rtl-sdr, which we won't install diff --git a/scripts/repo-install-test/blacklist_debian12.txt b/scripts/repo-install-test/blacklist_debian12.txt index b470d44..9b5f5e7 100644 --- a/scripts/repo-install-test/blacklist_debian12.txt +++ b/scripts/repo-install-test/blacklist_debian12.txt @@ -32,6 +32,8 @@ libulfius2.7-dbgsym libyder2.0-dbgsym limesuite-dbgsym +limesuite-images +limesuite-images23.10 soapysdr0.7-module-lms7 soapysdr0.7-module-lms7-dbgsym soapysdr-module-lms7 diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index e08338f..d7730ff 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -329,7 +329,7 @@ cat osmocom_packages_all.txt filter_packages_txt - apt install -y $(cat osmocom_packages.txt) + apt-get install -y --no-install-recommends $(cat osmocom_packages.txt) } install_repo_packages_centos() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I237408c805977c831f352a57a301ea45753d1ac1 Gerrit-Change-Number: 34955 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: repo-install-test: fix ca-certificates-java error
by laforge 02 Nov '23

02 Nov '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34954?usp=email ) Change subject: repo-install-test: fix ca-certificates-java error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I00b9c97d9d85fb37ba33a48caa732cd50de99683 Gerrit-Change-Number: 34954 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:42:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: repo-install-test: ignore limesuite-images
by laforge 02 Nov '23

02 Nov '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34955?usp=email ) Change subject: repo-install-test: ignore limesuite-images ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I237408c805977c831f352a57a301ea45753d1ac1 Gerrit-Change-Number: 34955 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:42:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: add mgcp_conn_rtp_type_names[]
by laforge 02 Nov '23

02 Nov '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34941?usp=email ) Change subject: add mgcp_conn_rtp_type_names[] ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If3d8bc68a3b26d3aa0ba7eedeab67b820889ed54 Gerrit-Change-Number: 34941 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:41:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns
by laforge 02 Nov '23

02 Nov '23

Attention is currently required from: dexter, keith, neels, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email ) Change subject: vty and log: also show local port for RTP conns ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132 Gerrit-Change-Number: 34150 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 21:41:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns
by pespin 02 Nov '23

02 Nov '23

Attention is currently required from: dexter, keith, neels, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email ) Change subject: vty and log: also show local port for RTP conns ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132 Gerrit-Change-Number: 34150 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 19:25:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: vty and log: also show local port for RTP conns
by keith 02 Nov '23

02 Nov '23

Attention is currently required from: dexter, neels, osmith, pespin. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email ) Change subject: vty and log: also show local port for RTP conns ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/3e112894_625f9a83 PS3, Line 363: if (!conn) { > unneeded {} Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132 Gerrit-Change-Number: 34150 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 18:47:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0