November 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31
by osmith 02 Nov '23

02 Nov '23

Attention is currently required from: laforge, neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34952?usp=email ) Change subject: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I98e1d4d649ea07b006a7d4c15f8d94a9b4b3de1d Gerrit-Change-Number: 34952 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 11:56:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31
by pespin 02 Nov '23

02 Nov '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34952?usp=email ) Change subject: ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31 ...................................................................... ttcn3-hnbgw: Use new module param mp_hnbgw_timer_x31 Depends: osmo-ttcn3-hacks.git I176ef96e193f2ca39077bcee3a2187768ddb45ce Change-Id: I98e1d4d649ea07b006a7d4c15f8d94a9b4b3de1d --- M ttcn3-hnbgw-test/HNBGW_Tests.cfg M ttcn3-hnbgw-test/osmo-hnbgw.cfg 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/52/34952/1 diff --git a/ttcn3-hnbgw-test/HNBGW_Tests.cfg b/ttcn3-hnbgw-test/HNBGW_Tests.cfg index a76d5fd..9a7e1b9 100644 --- a/ttcn3-hnbgw-test/HNBGW_Tests.cfg +++ b/ttcn3-hnbgw-test/HNBGW_Tests.cfg @@ -109,6 +109,8 @@ } }; HNBGW_Tests.mp_validate_talloc_asn1 := true; +# keep in sync with osmo-hnbgw.cfg "timer hnbgw x31": +HNBGW_Tests.mp_hnbgw_timer_x31 := 5; [MAIN_CONTROLLER] diff --git a/ttcn3-hnbgw-test/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/osmo-hnbgw.cfg index 377fad8..3361cb0 100644 --- a/ttcn3-hnbgw-test/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/osmo-hnbgw.cfg @@ -71,6 +71,7 @@ mgcp mgw local-ip 172.18.35.20 mgw remote-ip 172.18.35.203 + timer hnbgw x31 5 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I98e1d4d649ea07b006a7d4c15f8d94a9b4b3de1d Gerrit-Change-Number: 34952 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31
by pespin 02 Nov '23

02 Nov '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email ) Change subject: hnbgw: Introduce mp_hnbgw_timer_x31 ...................................................................... hnbgw: Introduce mp_hnbgw_timer_x31 The default value of the timer changed recently, and made some tests which were using some timer hardcoded values fail. Add this configurable option to adapt the test behavior to the osmo-hnbgw configuration. This way we can also set it to lower values in order to avoid waiting too much time. Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/osmo-hnbgw.cfg 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/34951/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 4afb8dd..505beab 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -194,6 +194,10 @@ charstring mp_pfcp_ip_remote := "127.0.0.2"; boolean mp_validate_talloc_asn1 := true; + + /* The X31 timer configured at osmo-hnbgw (seconds). This provided an idea on + * minimum time the test must wait to consider this timer triggered */ + integer mp_hnbgw_timer_x31 := 5; } function MSC_UnitdataCallback(RANAP_PDU ranap) runs on RAN_Emulation_CT return template RANAP_PDU { @@ -763,7 +767,7 @@ template RANAP_PDU exp_rx := omit) runs on ConnHdlr return RANAP_PDU { var RANAP_PDU rx - timer T := 10.0; + timer T := int2float(mp_hnbgw_timer_x31) + 1.0; if (istemplatekind(exp_rx, "omit")) { exp_rx := tx; diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg index 3ccc28d..edd8c21 100644 --- a/hnbgw/osmo-hnbgw.cfg +++ b/hnbgw/osmo-hnbgw.cfg @@ -49,6 +49,7 @@ local-ip 127.0.0.1 local-port 29169 hnbap-allow-tmsi 1 + timer hnbgw x31 5 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce Gerrit-Change-Number: 34951 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Fix assert hit due to missing ev handling
by osmith 02 Nov '23

02 Nov '23

Attention is currently required from: laforge, neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email ) Change subject: context_map_sccp: Fix assert hit due to missing ev handling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idaad11eaa3c2e56de792f80bab1f1d8435ef9b68 Gerrit-Change-Number: 34950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 11:17:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Fix assert hit due to missing ev handling
by pespin 02 Nov '23

02 Nov '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email ) Change subject: context_map_sccp: Fix assert hit due to missing ev handling ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This started happening because some tests were waiting for 10 seconds and now X31 is 15 seconds, so a different code path started being executed. I'll submit a patch fixing the timer timeout value lowering it back to 5 in the tests. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idaad11eaa3c2e56de792f80bab1f1d8435ef9b68 Gerrit-Change-Number: 34950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 11:15:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Fix assert hit due to missing ev handling
by pespin 02 Nov '23

02 Nov '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email ) Change subject: context_map_sccp: Fix assert hit due to missing ev handling ...................................................................... context_map_sccp: Fix assert hit due to missing ev handling This was being triggered recently by HNBGW_Tests.TC_ranap_cs_mo_disconnect in osmo-ttcn3-hacks.git. Change-Id: Idaad11eaa3c2e56de792f80bab1f1d8435ef9b68 --- M src/osmo-hnbgw/context_map_sccp.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/50/34950/1 diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 9b4837d..4a78337 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -452,6 +452,7 @@ handle_rx_sccp(fi, ranap_msg); return; + case MAP_SCCP_EV_RAN_LINK_LOST: case MAP_SCCP_EV_USER_ABORT: case MAP_SCCP_EV_CN_LINK_LOST: /* Stop waiting for RLSD, send RLSD now. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idaad11eaa3c2e56de792f80bab1f1d8435ef9b68 Gerrit-Change-Number: 34950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: filesystem: add flag to tell whether an ADF supports an FS or not
by dexter 02 Nov '23

02 Nov '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34902?usp=email ) Change subject: filesystem: add flag to tell whether an ADF supports an FS or not ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Unfortunately I could not find any hard evidence on this but I think you are right here. […] (btw: I noticed that the select response from ADF.ARA-M is just 9000, so it is really different. I think a real ADF should return a UICC-typical response with FCP) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifd0f7c34164685ea18d8a746394e55416fa0aa66 Gerrit-Change-Number: 34902 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 02 Nov 2023 10:36:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: filesystem: add flag to tell whether an ADF supports an FS or not
by dexter 02 Nov '23

02 Nov '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34902?usp=email ) Change subject: filesystem: add flag to tell whether an ADF supports an FS or not ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > strictly speaking, in terms of terminology an application with AID and no filesystem probably doesn' […] Unfortunately I could not find any hard evidence on this but I think you are right here. Probably applications which do not support a file system won't have an ADF. The only reason why one would want to have an ADF despite this is that an ADF would allow the selection of the application via a 2 byte FID. This probably also means that it is incorrect to have the ADF.ARA-M in the file system tree at all. However, it is a very handy extension to have such virtual ADFs. So what would speak against having the proposed has_fs flag that tells pySim that there is no FS behind this ADF? If we want to express this in the class model we could have a CardObj that is above CardFile and has the most basic methods and properties that are not file system related in particular. Then We could create a new type of CardADF that directly inherits from CardObj. We could call it "CardAPP". We would still make those appear in the file system tree but with a name that makes clear that it is a normal card applet without file system support. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifd0f7c34164685ea18d8a746394e55416fa0aa66 Gerrit-Change-Number: 34902 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 02 Nov 2023 10:25:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late
by osmith 02 Nov '23

02 Nov '23

Attention is currently required from: daniel, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4b53565f1fa19894ca24fa71e02ae7b1941411e Gerrit-Change-Number: 34923 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 10:14:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late
by pespin 02 Nov '23

02 Nov '23

Attention is currently required from: daniel, fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > Where this function is coming from? Neither I can find it in osmo-ttcn3-hacks. […] ACK that was the problem, the SCCP_Emulations was not in our library/ dirrectory. I changed the patch to have it working without needing to modify the dep. File library/SCCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923/comment/16cad347_f9f5… PS2, Line 137: function > why using a wrapper function? why not `template (value)`? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4b53565f1fa19894ca24fa71e02ae7b1941411e Gerrit-Change-Number: 34923 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Nov 2023 10:13:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0