November 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: osmo-bts-trx: eliminate ul_bursts_prev, use the primary buffer

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/35011?usp=email ) Change subject: osmo-bts-trx: eliminate ul_bursts_prev, use the primary buffer ...................................................................... osmo-bts-trx: eliminate ul_bursts_prev, use the primary buffer When adding support for Circuit Switched Data calls, we had to enlarge the burst buffer size to accommodate bits for a maximum of 24 bursts. Let's take advantage of this by utilizing the currently unused part of the Uplink burst buffer for storing bits of previously decoded blocks. This eliminates the need to allocate additional memory for SACCH. Change-Id: I15047cd1df4476054b36f05616e41f5297d9bfe5 Related: SYS#5114, OS#4794, OS#4795, OS#4796 --- M include/osmo-bts/scheduler.h M src/common/scheduler.c M src/osmo-bts-trx/sched_lchan_xcch.c 3 files changed, 24 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/35011/1 diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h index b9c7350..aea5595 100644 --- a/include/osmo-bts/scheduler.h +++ b/include/osmo-bts/scheduler.h @@ -92,7 +92,6 @@ enum trx_mod_type dl_mod_type; /* Downlink modulation type */ uint8_t dl_mask; /* mask of transmitted bursts */ sbit_t *ul_bursts; /* burst buffer for RX */ - sbit_t *ul_bursts_prev;/* previous burst buffer for RX (repeated SACCH) */ uint32_t ul_first_fn; /* fn of first burst */ uint32_t ul_mask; /* mask of received bursts */ diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 0e62b65..ef03932 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1084,11 +1084,8 @@ const size_t buf_size = 24 * GSM_NBITS_NB_GMSK_PAYLOAD; if (trx_chan_desc[chan].dl_fn != NULL) chan_state->dl_bursts = talloc_zero_size(l1ts, buf_size); - if (trx_chan_desc[chan].ul_fn != NULL) { + if (trx_chan_desc[chan].ul_fn != NULL) chan_state->ul_bursts = talloc_zero_size(l1ts, buf_size); - if (L1SAP_IS_LINK_SACCH(trx_chan_desc[chan].link_id)) - chan_state->ul_bursts_prev = talloc_zero_size(l1ts, buf_size); - } } else { chan_state->ho_rach_detect = 0; @@ -1100,7 +1097,6 @@ /* Release memory used by Rx/Tx burst buffers */ TALLOC_FREE(chan_state->dl_bursts); TALLOC_FREE(chan_state->ul_bursts); - TALLOC_FREE(chan_state->ul_bursts_prev); } chan_state->active = active; diff --git a/src/osmo-bts-trx/sched_lchan_xcch.c b/src/osmo-bts-trx/sched_lchan_xcch.c index a1a5e30..b6b5117 100644 --- a/src/osmo-bts-trx/sched_lchan_xcch.c +++ b/src/osmo-bts-trx/sched_lchan_xcch.c @@ -67,7 +67,9 @@ /* clear burst & store frame number of first burst */ if (bi->bid == 0) { - memset(bursts_p, 0, BPLEN * 4); + if (rep_sacch) /* Keep a copy to ease decoding in the next repetition pass */ + memcpy(BUFPOS(bursts_p, 4), BUFPOS(bursts_p, 0), BPLEN * 4); + memset(BUFPOS(bursts_p, 0), 0, BPLEN * 4); *mask = 0x0; *first_fn = bi->fn; } @@ -107,7 +109,7 @@ *mask = 0x0; /* decode */ - rc = gsm0503_xcch_decode(l2, bursts_p, &n_errors, &n_bits_total); + rc = gsm0503_xcch_decode(l2, BUFPOS(bursts_p, 0), &n_errors, &n_bits_total); if (rc) { LOGL1SB(DL1P, LOGL_NOTICE, l1ts, bi, BAD_DATA_MSG_FMT "\n", BAD_DATA_MSG_ARGS); @@ -118,8 +120,8 @@ * information from the previous SACCH block. See also: * 3GPP TS 44.006, section 11.2 */ if (rep_sacch) { - add_sbits(bursts_p, chan_state->ul_bursts_prev); - rc = gsm0503_xcch_decode(l2, bursts_p, &n_errors, &n_bits_total); + add_sbits(BUFPOS(bursts_p, 0), BUFPOS(bursts_p, 4)); + rc = gsm0503_xcch_decode(l2, BUFPOS(bursts_p, 0), &n_errors, &n_bits_total); if (rc) { LOGL1SB(DL1P, LOGL_NOTICE, l1ts, bi, "Combining current SACCH block with previous SACCH block also yields bad data (%u/%u)\n", @@ -136,10 +138,6 @@ ber10k = compute_ber10k(n_bits_total, n_errors); - /* Keep a copy to ease decoding in the next repetition pass */ - if (rep_sacch) - memcpy(chan_state->ul_bursts_prev, bursts_p, BPLEN * 4); - return _sched_compose_ph_data_ind(l1ts, *first_fn, bi->chan, &l2[0], l2_len, ber10k, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I15047cd1df4476054b36f05616e41f5297d9bfe5 Gerrit-Change-Number: 35011 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: add_sbits(): simplify, improve coding style

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/35009?usp=email ) Change subject: osmo-bts-trx: add_sbits(): simplify, improve coding style ...................................................................... osmo-bts-trx: add_sbits(): simplify, improve coding style Change-Id: I518a8ea268a9a6d48b04c291a03e5efbed5f571d --- M src/osmo-bts-trx/sched_lchan_xcch.c 1 file changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/09/35009/1 diff --git a/src/osmo-bts-trx/sched_lchan_xcch.c b/src/osmo-bts-trx/sched_lchan_xcch.c index ccf685f..b36f4e8 100644 --- a/src/osmo-bts-trx/sched_lchan_xcch.c +++ b/src/osmo-bts-trx/sched_lchan_xcch.c @@ -36,14 +36,10 @@ #include <sched_utils.h> /* Add two arrays of sbits */ -static void add_sbits(sbit_t * current, const sbit_t * previous) +static void add_sbits(sbit_t *current, const sbit_t *previous) { - unsigned int i; - for (i = 0; i < 464; i++) { - *current = (*current) / 2 + (*previous) / 2; - current++; - previous++; - } + for (unsigned int i = 0; i < 464; i++) + current[i] = current[i] / 2 + previous[i] / 2; } /*! \brief a single (SDCCH/SACCH) burst was received by the PHY, process it */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I518a8ea268a9a6d48b04c291a03e5efbed5f571d Gerrit-Change-Number: 35009 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[M] Change in osmo-bts[master]: osmo-bts-trx: tx_tch[fh]_fn(): fix sending idle CSD frames

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34992?usp=email ) Change subject: osmo-bts-trx: tx_tch[fh]_fn(): fix sending idle CSD frames ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0b25cfac41b6d8dcf3bfd9d46d51a9665f1b047a Gerrit-Change-Number: 34992 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Nov 2023 18:45:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in osmo-bts[master]: osmo-bts-trx: tx_tch[fh]_fn(): rework generation of dummy FACCH

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34991?usp=email ) Change subject: osmo-bts-trx: tx_tch[fh]_fn(): rework generation of dummy FACCH ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I67cb5c6f4d15149996e17c78a59d66db396da8ff Gerrit-Change-Number: 34991 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Nov 2023 18:45:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: tx_tch[fh]_fn(): use BUFPOS macro everywhere

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34990?usp=email ) Change subject: osmo-bts-trx: tx_tch[fh]_fn(): use BUFPOS macro everywhere ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34990?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16ce4c979c5b44fd67324eb2ed3da28a4b78221b Gerrit-Change-Number: 34990 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Nov 2023 18:44:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[XL] Change in ...osmo_dia2gsup[master]: WIP: diameter: add support for Cx (VoLTE)

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35006?usp=email ) Change subject: WIP: diameter: add support for Cx (VoLTE) ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: is it really still WIP? Then it should be marked as such in gerrit. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Icd623563c495fb6da4216bb6f74bc31873dc7d6e Gerrit-Change-Number: 35006 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 13 Nov 2023 18:35:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[XL] Change in ...osmo_dia2gsup[master]: WIP: diameter: add support for Cx (VoLTE)

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35006?usp=email ) Change subject: WIP: diameter: add support for Cx (VoLTE) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Icd623563c495fb6da4216bb6f74bc31873dc7d6e Gerrit-Change-Number: 35006 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 13 Nov 2023 18:35:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add config option diameter_connect_timer

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35002?usp=email ) Change subject: osmo_dia2gsup: add config option diameter_connect_timer ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I669a76022d866824e7b4e9f30dd7e51aa714ae7d Gerrit-Change-Number: 35002 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 13 Nov 2023 18:35:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: set Origin-State-Id

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35001?usp=email ) Change subject: osmo_dia2gsup: set Origin-State-Id ...................................................................... osmo_dia2gsup: set Origin-State-Id To allow the remote side to detect restarts. See RFC6733. Related: OS#6155 Change-Id: I3693bad6030d41db4e28bd5f343c5db912789344 --- M src/osmo_dia2gsup.erl 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index a4edd71..90f5ddc 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -31,6 +31,7 @@ -define(SERVICE(Name), [{'Origin-Host', application:get_env(osmo_dia2gsup, origin_host, "hss.localdomain")}, {'Origin-Realm', application:get_env(osmo_dia2gsup, origin_realm, "localdomain")}, {'Vendor-Id', application:get_env(osmo_dia2gsup, vendor_id, 0)}, + {'Origin-State-Id', diameter:origin_state_id()}, {'Product-Name', "osmo_dia2gsup"}, {'Auth-Application-Id', []}, {'Vendor-Specific-Application-Id', [?APPID_S6]}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3693bad6030d41db4e28bd5f343c5db912789344 Gerrit-Change-Number: 35001 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[M] Change in ...osmo_dia2gsup[master]: gsup: implement a (re-)connect the GSUP link if it fails

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... gsup: implement a (re-)connect the GSUP link if it fails Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d --- M src/gsup_client.erl M src/osmo_dia2gsup_sup.erl 2 files changed, 51 insertions(+), 30 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsup_client.erl b/src/gsup_client.erl index 047078b..967bf99 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -39,9 +39,13 @@ -include_lib("osmo_ss7/include/ipa.hrl"). -define(IPAC_PROTO_EXT_GSUP, {osmo, 5}). +-define(GSUP_TIMEOUT_MS, 5000). -record(gsupc_state, { - socket, + address, + port, + ccmoptions, + socket, ipa_pid }). @@ -54,43 +58,46 @@ %% our exported API %% ------------------------------------------------------------------ -start_link(ServerAddr, ServerPort, Options) -> - gen_server:start_link(?MODULE, [ServerAddr, ServerPort, Options], [{debug, [trace]}]). +start_link(ServerAddr, ServerPort, GsupName) -> + gen_server:start_link(?MODULE, [ServerAddr, ServerPort, GsupName], [{debug, [trace]}]). %% ------------------------------------------------------------------ %% gen_server Function Definitions %% ------------------------------------------------------------------ -init([Address, Port, Options]) -> +init([Address, Port, GsupName]) -> ipa_proto:init(), % register the GSUP codec with the IPA core; ignore result as we might be doing this multiple times ipa_proto:register_codec(?IPAC_PROTO_EXT_GSUP, fun gsup_protocol:encode/1, fun gsup_protocol:decode/1), - connect([Address, Port, Options]). - -connect([Address, Port, Options]) -> lager:info("Connecting to GSUP HLR on IP ~s port ~p~n", [Address, Port]), - CcmOptions = #ipa_ccm_options{ - serial_number="HSS-00-00-00-00-00-00", - unit_id="0/0/0", - mac_address="00:00:00:00:00:00", - location="00:00:00:00:00:00", - unit_type="00:00:00:00:00:00", - equipment_version="00:00:00:00:00:00", - sw_version="00:00:00:00:00:00", - unit_name="HSS-00-00-00-00-00-00" - }, - case ipa_proto:connect(Address, Port, Options) of + CcmOptions = #ipa_ccm_options{ + serial_number=GsupName, + unit_id="0/0/0", + mac_address="00:00:00:00:00:00", + location="00:00:00:00:00:00", + unit_type="00:00:00:00:00:00", + equipment_version="00:00:00:00:00:00", + sw_version="00:00:00:00:00:00", + unit_name=GsupName + }, + State = #gsupc_state{address = Address, port = Port, ccmoptions = CcmOptions, socket = [], ipa_pid = []}, + case connect(State) of + {ok, State2} -> {ok, State2}; + {error, _, State2} -> {ok, State2, ?GSUP_TIMEOUT_MS} + end. + +connect(State) -> + #gsupc_state{address = Address, port = Port, ccmoptions = Options} = State, + case ipa_proto:connect(Address, Port, []) of {ok, {Socket, IpaPid}} -> - ipa_proto:set_ccm_options(Socket, CcmOptions), + ipa_proto:set_ccm_options(Socket, Options), lager:info("connected!~n", []), true = ipa_proto:register_stream(Socket, ?IPAC_PROTO_EXT_GSUP, {process_id, self()}), ipa_proto:unblock(Socket), - {ok, #gsupc_state{socket=Socket, ipa_pid=IpaPid}}; - {error, Reason} -> - lager:error("Connecting to GSUP HLR on IP ~s port ~p failed: ~p~n", [Address, Port, Reason]), - lager:info("Reconnecting to GSUP HLR in 5s...~n", []), - timer:sleep(5000), - connect([Address, Port, Options]) + {ok, State#gsupc_state{socket=Socket, ipa_pid=IpaPid}}; + {error, Error} -> + lager:info("Failed to GSUP HLR on IP ~s port ~p ~p~n", [Address, Port, Error]), + {error, Error, State} end. % send a given GSUP message and synchronously wait for message type ExpRes or ExpErr @@ -102,10 +109,9 @@ receive {ipa, Socket, ?IPAC_PROTO_EXT_GSUP, GsupMsgRx = #{message_type := ExpRes, imsi := Imsi}} -> {reply, GsupMsgRx, State}; - {ipa, Socket, ?IPAC_PROTO_EXT_GSUP, GsupMsgRx = #{message_type := ExpErr, imsi := Imsi}} -> {reply, GsupMsgRx, State} - after 5000 -> + after ?GSUP_TIMEOUT_MS -> {reply, timeout, State} end. @@ -114,8 +120,14 @@ {noreply, S}. handle_info({ipa_closed, _}, S) -> - lager:error("GSUP connection has been closed, supervisor should reconnect us"), - {stop, ipa_closed, S}; + lager:error("GSUP connection has been closed, Reconnecting in 5sec."), + {noreply, S, ?GSUP_TIMEOUT_MS}; +handle_info(timeout, S) -> + case connect(S) of + {ok, State} -> {noreply, State}; + {error, _, State} -> {noreply, State, ?GSUP_TIMEOUT_MS} + end; + handle_info(Info, S) -> error_logger:error_report(["unknown handle_info", {module, ?MODULE}, {info, Info}, {state, S}]), {noreply, S}. diff --git a/src/osmo_dia2gsup_sup.erl b/src/osmo_dia2gsup_sup.erl index 17b5a14..03c780d 100644 --- a/src/osmo_dia2gsup_sup.erl +++ b/src/osmo_dia2gsup_sup.erl @@ -12,7 +12,7 @@ % GSUP side HlrIp = application:get_env(osmo_dia2gsup, hlr_ip, "127.0.0.1"), HlrPort = application:get_env(osmo_dia2gsup, hlr_port, 4222), - Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, []], [{debug, [trace]}]], + Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, "HSS-00-00-00-00-00-00"], [{debug, [trace]}]], GsupChild = {gsup_client, {gen_server, start_link, Args}, permanent, 2000, worker, [gsup_client]}, % DIAMETER side DiaServer = {osmo_dia2gsup,{osmo_dia2gsup,start_link,[]}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023