November 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: coding: gsm0503_tch_a[fh]s_encode(): make *codec const

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34996?usp=email ) Change subject: coding: gsm0503_tch_a[fh]s_encode(): make *codec const ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9e37a47c080cf57005e0205aa0d3cd25755a75f0 Gerrit-Change-Number: 34996 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 10:23:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: coding: gsm0503_tch_a[fh]s_encode(): improve cmr/ft checks

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34995?usp=email ) Change subject: coding: gsm0503_tch_a[fh]s_encode(): improve cmr/ft checks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If03d5b015ab1c8db56a4c67bdc8e36e260c06562 Gerrit-Change-Number: 34995 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 10:23:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: add osmo_dia2gsup

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34976?usp=email ) Change subject: tarballs: add osmo_dia2gsup ...................................................................... tarballs: add osmo_dia2gsup Change-Id: I9cbd3d3ce27a4b4c9c8e19b2876386d170d4f0a6 --- M scripts/common.sh M scripts/tarballs/publish-tarballs-for-tags.sh 2 files changed, 23 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/scripts/common.sh b/scripts/common.sh index ea106e2..1081859 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -142,6 +142,9 @@ osmo-isdntap) echo "$OSMO_GIT_URL_GITEA"/retronetworking/"$1" ;; + osmo_dia2gsup) + echo "$OSMO_GIT_URL_GERRIT"/erlang/"$1" + ;; *) echo "$OSMO_GIT_URL_GERRIT"/"$1" ;; diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index c185c21..4ef3b5f 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -42,6 +42,7 @@ osmo-sysmon osmo-trx osmo-uecups + osmo_dia2gsup osmocom-bb rtl-sdr simtrace2 @@ -240,6 +241,11 @@ cd /src/$project_path + # Erlang projects: download build depends + if [ -e contrib/generate_build_dep.sh ]; then + su build -c \"HOME=/build contrib/generate_build_dep.sh\" + fi + if /tarballs/prefer-configure.sh \"$repo\" \"$tag\"; then su build -c \"autoreconf -fi\" case \"$repo\" in @@ -255,6 +261,11 @@ else su build -c \"git archive -o $tarball_name $tag\" fi + + # Erlang projects: add build depends to release tarball + if [ -e build_dep.tar.gz ]; then + su build -c \"tar -rf $tarball_name build_dep.tar.gz\" + fi "; then echo "$LOG_PREFIX Building tarball failed!" exit 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9cbd3d3ce27a4b4c9c8e19b2876386d170d4f0a6 Gerrit-Change-Number: 34976 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: git archive: put files in directory

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34977?usp=email ) Change subject: tarballs: git archive: put files in directory ...................................................................... tarballs: git archive: put files in directory Make the releases created from the "git archive" code path more similar to the autotools releases, by having all files in a subdirectory with the project name and tag name instead of having them directly in the root of the tarball. $ tree osmo_dia2gsup-0.1.1 | head osmo_dia2gsup-0.1.1 ├── build_dep.tar.gz ├── contrib │ ├── generate_build_dep.sh │ ├── jenkins.sh │ └── systemd │ └── osmo_dia2gsup.service ├── debian │ ├── changelog │ ├── compat Change-Id: If37dcdc04278de0d4479cf72e0ca33c90b7deea8 --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 31 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 4ef3b5f..05d9f30 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -220,6 +220,7 @@ local project_path="$2" local tag="$3" local tarball_name="$(get_tarball_name "$project_path" "$tag")" + local prefix="$(echo "$tarball_name" | sed s/\.tar\.bz2//)" local uid_user="$(id -u)" echo "$LOG_PREFIX Building release tarball: $tarball_name" @@ -259,12 +260,14 @@ esac su build -c \"make dist-bzip2\" else - su build -c \"git archive -o $tarball_name $tag\" + su build -c \"git archive --prefix=$prefix/ -o $tarball_name $tag\" fi # Erlang projects: add build depends to release tarball if [ -e build_dep.tar.gz ]; then - su build -c \"tar -rf $tarball_name build_dep.tar.gz\" + su build -c \"mkdir $prefix\" + su build -c \"mv build_dep.tar.gz $prefix\" + su build -c \"tar -rf $tarball_name $prefix/build_dep.tar.gz\" fi "; then echo "$LOG_PREFIX Building tarball failed!" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If37dcdc04278de0d4479cf72e0ca33c90b7deea8 Gerrit-Change-Number: 34977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: git archive: make proper tar.bz2

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34978?usp=email ) Change subject: tarballs: git archive: make proper tar.bz2 ...................................................................... tarballs: git archive: make proper tar.bz2 Compress the tarball from "git archive" with bzip2 to turn it into a proper .tar.bz2. Previously the archive was named .tar.bz2, but it was just a regular tarball as git archive didn't guess the type from the filename (supposedly this works for .tar.gz and some others) and just defaulted to tar. Move the code that adds build_dep.tar.gz to the archive before the bzip2 call, because tar can't add files to the archive if it is compressed. Change-Id: I5830f9123150540a6467c19c64461d2fa1972a52 --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 27 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 05d9f30..46a2e17 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -260,14 +260,16 @@ esac su build -c \"make dist-bzip2\" else - su build -c \"git archive --prefix=$prefix/ -o $tarball_name $tag\" - fi + su build -c \"git archive --prefix=$prefix/ -o $prefix.tar $tag\" - # Erlang projects: add build depends to release tarball - if [ -e build_dep.tar.gz ]; then - su build -c \"mkdir $prefix\" - su build -c \"mv build_dep.tar.gz $prefix\" - su build -c \"tar -rf $tarball_name $prefix/build_dep.tar.gz\" + # Erlang projects: add build depends to release tarball + if [ -e build_dep.tar.gz ]; then + su build -c \"mkdir $prefix\" + su build -c \"mv build_dep.tar.gz $prefix\" + su build -c \"tar -rf $prefix.tar $prefix/build_dep.tar.gz\" + fi + + su build -c \"bzip2 -9 $prefix.tar\" fi "; then echo "$LOG_PREFIX Building tarball failed!" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5830f9123150540a6467c19c64461d2fa1972a52 Gerrit-Change-Number: 34978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: git archive: make proper tar.bz2

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34978?usp=email ) Change subject: tarballs: git archive: make proper tar.bz2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5830f9123150540a6467c19c64461d2fa1972a52 Gerrit-Change-Number: 34978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 10:09:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: git archive: put files in directory

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34977?usp=email ) Change subject: tarballs: git archive: put files in directory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If37dcdc04278de0d4479cf72e0ca33c90b7deea8 Gerrit-Change-Number: 34977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 10:09:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: add osmo_dia2gsup

by osmith

Attention is currently required from: daniel, dexter, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34976?usp=email ) Change subject: tarballs: add osmo_dia2gsup ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9cbd3d3ce27a4b4c9c8e19b2876386d170d4f0a6 Gerrit-Change-Number: 34976 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 10:09:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-bsc[master]: bsc: Make socket queue max. length configurable

by daniel

Attention is currently required from: arehbein, dexter, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email ) Change subject: bsc: Make socket queue max. length configurable ...................................................................... Patch Set 8: (2 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/ef46c6d0_758599ad PS8, Line 2499: size_t to = (net->pcu_sock_wqueue_len_max = atoi(argv[0])); > this new variable is really not needed and just makes everything more complex, specially with the pa […] Ack https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/450acc4e_c0e41486 PS8, Line 2503: LOGP(DPCU, LOGL_INFO, "Have dropped %zu messages due to shortened max. message queue size (from: %zu to %zu)\n", > it may be good to do vty_out with the same message here, to show the user of the VTY what happened a […] ACK -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b Gerrit-Change-Number: 33892 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 10:06:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in libosmocore[master]: gsmtap_util: Simplify sink

by daniel

Attention is currently required from: arehbein. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34881?usp=email ) Change subject: gsmtap_util: Simplify sink ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4025920d5f62d17133e9b5fe81cd34a88c4f20b5 Gerrit-Change-Number: 34881 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 10:03:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023