November 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: ts_31_102: correct name of EF_ePDGId

by fixeria

Attention is currently required from: iw0, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35024?usp=email ) Change subject: ts_31_102: correct name of EF_ePDGId ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2c27a7f325f75274e2110eb312b623cf9e7dab47 Gerrit-Change-Number: 35024 Gerrit-PatchSet: 2 Gerrit-Owner: iw0 <osmocom(a)heychris.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: iw0 <osmocom(a)heychris.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Nov 2023 13:34:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in docker-playground[master]: Use 2023q1 osmo-ttcn3-hacks branch for 2023q1 SUTs

by fixeria

Attention is currently required from: daniel, dexter, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35013?usp=email ) Change subject: Use 2023q1 osmo-ttcn3-hacks branch for 2023q1 SUTs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35013?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id82425aca4a8ff87feb8a130d31712bc62fa27ed Gerrit-Change-Number: 35013 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 13:32:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in pysim[master]: ts_31_102: correct name of EF_ePDGId

by iw0

iw0 has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/pysim/+/35024?usp=email ) Change subject: ts_31_102: correct name of EF_ePDGId ...................................................................... ts_31_102: correct name of EF_ePDGId In 31.102 v17.10, file 6ff3 is called "EF_ePDGId". Adjust the spelling to match. Change-Id: I2c27a7f325f75274e2110eb312b623cf9e7dab47 --- M pySim/ts_31_102.py 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/35024/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2c27a7f325f75274e2110eb312b623cf9e7dab47 Gerrit-Change-Number: 35024 Gerrit-PatchSet: 2 Gerrit-Owner: iw0 <osmocom(a)heychris.eu> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 7 months

1
0
0 0

[S] Change in pysim[master]: ts_31_102: correct name of EF_ePDGId In 31.102 v17.10, file 6ff3 is c...

by iw0

iw0 has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35024?usp=email ) Change subject: ts_31_102: correct name of EF_ePDGId In 31.102 v17.10, file 6ff3 is called "EF_ePDGId". Adjust the spelling to match. ...................................................................... ts_31_102: correct name of EF_ePDGId In 31.102 v17.10, file 6ff3 is called "EF_ePDGId". Adjust the spelling to match. Change-Id: I2c27a7f325f75274e2110eb312b623cf9e7dab47 --- M pySim/ts_31_102.py 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/35024/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 738f107..0fcf883 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -880,7 +880,7 @@ 'IPv4': HexAdapter(GreedyBytes), 'IPv6': HexAdapter(GreedyBytes)})) - def __init__(self, fid='6ff3', sfid=None, name='EF.eDPDGId', desc='Home ePDG Identifier', **kwargs): + def __init__(self, fid='6ff3', sfid=None, name='EF.ePDGId', desc='Home ePDG Identifier', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, **kwargs) self._tlv = EF_ePDGId.ePDGId -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2c27a7f325f75274e2110eb312b623cf9e7dab47 Gerrit-Change-Number: 35024 Gerrit-PatchSet: 1 Gerrit-Owner: iw0 <osmocom(a)heychris.eu> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in docker-playground[master]: Use 2023q1 osmo-ttcn3-hacks branch for 2023q1 SUTs

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35013?usp=email ) Change subject: Use 2023q1 osmo-ttcn3-hacks branch for 2023q1 SUTs ...................................................................... Use 2023q1 osmo-ttcn3-hacks branch for 2023q1 SUTs Fix the TTCN3-centos-pcu-test-2023q1 jenkins job where currently most tests are failing. This is because 2023q1 is using an older PCUIF version that is no longer supported by osmo-ttcn3-hacks.git. As discussed, use a 2023q1 branch of osmo-ttcn3-hacks where the support was not removed yet. Fixes: SYS#6638 Change-Id: Id82425aca4a8ff87feb8a130d31712bc62fa27ed --- M jenkins-common.sh 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/13/35013/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 4e476f6..65c4942 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -122,6 +122,28 @@ set -x } +# Get the osmo-ttcn3-hacks branch to use, based on the IMAGE_SUFFIX we are +# testing. This allows e.g. running 2023q1 SUTs against the 2023q1 branch of +# osmo-ttcn3-hacks.git (SYS#6638). The OSMO_TTCN3_BRANCH env var can be used to +# override it in any case. +# $1: image name (e.g. ttcn3-pcu-test) +# $IMAGE_SUFFIX: e.g. 2023q1-centos8 +docker_osmo_ttcn3_branch() { + if [ -n "$OSMO_TTCN3_BRANCH" ]; then + echo "$OSMO_TTCN3_BRANCH" + return + fi + + case "$IMAGE_SUFFIX" in + 20*q*) + echo "$IMAGE_SUFFIX" | cut -d- -f 1 + ;; + *) + echo "master" + ;; + esac +} + # Make sure required images are available and build them if necessary. # $*: image names (e.g. "debian-bullseye-build", "osmo-mgw-master", "osmo-mgw-master-centos8") # The images are automatically built from the Dockerfile of the subdir of @@ -184,6 +206,7 @@ UPSTREAM_DISTRO="$upstream_distro_arg" \ DISTRO="$distro_arg" \ IMAGE="$REPO_USER/$i" \ + OSMO_TTCN3_BRANCH="$(docker_osmo_ttcn3_branch)" \ || exit 1 fi -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35013?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id82425aca4a8ff87feb8a130d31712bc62fa27ed Gerrit-Change-Number: 35013 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: add_sbits(): simplify, improve coding style

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35009?usp=email ) Change subject: osmo-bts-trx: add_sbits(): simplify, improve coding style ...................................................................... osmo-bts-trx: add_sbits(): simplify, improve coding style Change-Id: I518a8ea268a9a6d48b04c291a03e5efbed5f571d --- M src/osmo-bts-trx/sched_lchan_xcch.c 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_xcch.c b/src/osmo-bts-trx/sched_lchan_xcch.c index ccf685f..b36f4e8 100644 --- a/src/osmo-bts-trx/sched_lchan_xcch.c +++ b/src/osmo-bts-trx/sched_lchan_xcch.c @@ -36,14 +36,10 @@ #include <sched_utils.h> /* Add two arrays of sbits */ -static void add_sbits(sbit_t * current, const sbit_t * previous) +static void add_sbits(sbit_t *current, const sbit_t *previous) { - unsigned int i; - for (i = 0; i < 464; i++) { - *current = (*current) / 2 + (*previous) / 2; - current++; - previous++; - } + for (unsigned int i = 0; i < 464; i++) + current[i] = current[i] / 2 + previous[i] / 2; } /*! \brief a single (SDCCH/SACCH) burst was received by the PHY, process it */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I518a8ea268a9a6d48b04c291a03e5efbed5f571d Gerrit-Change-Number: 35009 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: use BPLEN macro instead of magic numbers

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35010?usp=email ) Change subject: osmo-bts-trx: use BPLEN macro instead of magic numbers ...................................................................... osmo-bts-trx: use BPLEN macro instead of magic numbers Change-Id: I7d89b2e50c7eeb54b734c4959eeeb1c63a51a315 --- M src/osmo-bts-trx/sched_lchan_xcch.c 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_xcch.c b/src/osmo-bts-trx/sched_lchan_xcch.c index b36f4e8..a1a5e30 100644 --- a/src/osmo-bts-trx/sched_lchan_xcch.c +++ b/src/osmo-bts-trx/sched_lchan_xcch.c @@ -38,7 +38,7 @@ /* Add two arrays of sbits */ static void add_sbits(sbit_t *current, const sbit_t *previous) { - for (unsigned int i = 0; i < 464; i++) + for (unsigned int i = 0; i < BPLEN * 4; i++) current[i] = current[i] / 2 + previous[i] / 2; } @@ -67,7 +67,7 @@ /* clear burst & store frame number of first burst */ if (bi->bid == 0) { - memset(bursts_p, 0, 464); + memset(bursts_p, 0, BPLEN * 4); *mask = 0x0; *first_fn = bi->fn; } @@ -138,7 +138,7 @@ /* Keep a copy to ease decoding in the next repetition pass */ if (rep_sacch) - memcpy(chan_state->ul_bursts_prev, bursts_p, 464); + memcpy(chan_state->ul_bursts_prev, bursts_p, BPLEN * 4); return _sched_compose_ph_data_ind(l1ts, *first_fn, bi->chan, &l2[0], l2_len, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7d89b2e50c7eeb54b734c4959eeeb1c63a51a315 Gerrit-Change-Number: 35010 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: use BPLEN macro instead of magic numbers

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35010?usp=email ) Change subject: osmo-bts-trx: use BPLEN macro instead of magic numbers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7d89b2e50c7eeb54b734c4959eeeb1c63a51a315 Gerrit-Change-Number: 35010 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Nov 2023 12:22:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: add_sbits(): simplify, improve coding style

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35009?usp=email ) Change subject: osmo-bts-trx: add_sbits(): simplify, improve coding style ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I518a8ea268a9a6d48b04c291a03e5efbed5f571d Gerrit-Change-Number: 35009 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Nov 2023 12:22:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: run TC_second_rab_assignment on nightly

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35012?usp=email ) Change subject: hnbgw: run TC_second_rab_assignment on nightly ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id09b1a22dbd391c19ecfe34af990ec1ef3bb5089 Gerrit-Change-Number: 35012 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Nov 2023 12:21:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023