October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: pcu_l1_if: signal BTS model via PCUIF
by laforge 19 Oct '23

19 Oct '23

Attention is currently required from: dexter, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 4: (1 comment) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34647/comment/38196b77_3113ee7e PS4, Line 806: { PCU_IF_BTS_MODEL_TRX, "osmo-trx" }, > Or rather "trx" if you follow the logic above. I'd vote for osmo-bts-trx -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 34647 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 07:35:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support
by laforge 19 Oct '23

19 Oct '23

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email ) Change subject: ASCI: Add System Information 10 support ...................................................................... Patch Set 5: (1 comment) File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/d2efdc06_bf70f3fa PS2, Line 1428: unsigned int save_cur_bit; : struct gsm_subscriber_connection *c; > You could still have them variables defined separately from code within a for-loop, but it's not rea […] variables should always be declared with the smallest possible scope. So if they are only used within the for-loop, they should be declared on top of the for-loop. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 Gerrit-Change-Number: 34626 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 07:34:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmo-netif[master]: stream_test: Fix memleaks
by laforge 19 Oct '23

19 Oct '23

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34793?usp=email ) Change subject: stream_test: Fix memleaks ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica25fcd71e8bf8946def3ea7ce320354ea6edb3a Gerrit-Change-Number: 34793 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 07:31:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-netif[master]: stream_test: Improve mem mgmt, fix connection mgmt
by laforge 19 Oct '23

19 Oct '23

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34799?usp=email ) Change subject: stream_test: Improve mem mgmt, fix connection mgmt ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9ef02ed113bc049ae430b93d0eb69641e2ee809b Gerrit-Change-Number: 34799 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 07:31:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: ansible: jenkins: debian: remove qemu package
by osmith 19 Oct '23

19 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34786?usp=email ) Change subject: ansible: jenkins: debian: remove qemu package ...................................................................... ansible: jenkins: debian: remove qemu package This is a dummy package that isn't available anymore in debian 12. https://packages.debian.org/buster/qemu says: > This package can safely be removed. We install qemu-user-static and qemu-system-arm, which contain qemu binaries. Related: OS#6186 Change-Id: I4d5bd376b1e370d9636b9a2e9e710f5f20b9ae98 --- M ansible/roles/osmocom-jenkins-slave/tasks/debian.yml 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml index 0c762e9..ead03d7 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml @@ -5,7 +5,6 @@ name: - htop - virt-manager - - qemu - qemu-user-static - qemu-system-arm - proot -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d5bd376b1e370d9636b9a2e9e710f5f20b9ae98 Gerrit-Change-Number: 34786 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: ansible: hosts: add build4-deb12build-ansible
by osmith 19 Oct '23

19 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34785?usp=email ) Change subject: ansible: hosts: add build4-deb12build-ansible ...................................................................... ansible: hosts: add build4-deb12build-ansible Related: OS#6186 Change-Id: Ia4ce2ab074941dda6b7c820673108d19d4136664 --- M ansible/hosts M ansible/util/known_hosts A ansible/vars/Debian-12.yml 3 files changed, 16 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/hosts b/ansible/hosts index e027a31..6a1783e 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -5,11 +5,13 @@ [coverity_slaves] build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 +build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 [jenkins_slaves] build2-deb10build-ansible ansible_host=2a01:4f8:10b:2ad9::1:10 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" +build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" host2-deb11build-ansible ansible_host=2a01:4f8:120:8470::1:4 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" rpi4-raspbian11build-ansible-1 ansible_host=10.9.25.50 docker_max_image_space="20 GB" rpi4-raspbian11build-ansible-2 ansible_host=10.9.25.60 docker_max_image_space="20 GB" @@ -25,3 +27,4 @@ # Need to have kvm inside lxc, see OS#5365 [qemu] build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 +build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 diff --git a/ansible/util/known_hosts b/ansible/util/known_hosts index 8c93b5d..05b30c8 100644 --- a/ansible/util/known_hosts +++ b/ansible/util/known_hosts @@ -5,3 +5,4 @@ 10.9.25.50 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIPowg8lZeIGJ6LCLA8U4eSHnnPX90FaVgInDuRi5U9Zq 10.9.25.60 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOAK6SQXmifMamE1VHL/1GmPkk6KhplzT20jSOwb8PyZ 10.9.25.70 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAILioWTUt6CyZTceSKqy09mtlNUif+ETKTF6whnWuIROx +2a01:4f8:121:200a::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIGafw2VdeZo4YNvbu8VEBjDrsCFL+ZSbHtvhspNIQ9PR diff --git a/ansible/vars/Debian-12.yml b/ansible/vars/Debian-12.yml new file mode 100644 index 0000000..4db6ac1 --- /dev/null +++ b/ansible/vars/Debian-12.yml @@ -0,0 +1,2 @@ +--- +obs_distro: Debian_12 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4ce2ab074941dda6b7c820673108d19d4136664 Gerrit-Change-Number: 34785 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: ansible: jenkins: use default-jre-headless
by osmith 19 Oct '23

19 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34787?usp=email ) Change subject: ansible: jenkins: use default-jre-headless ...................................................................... ansible: jenkins: use default-jre-headless Use default-jre-headless instead of giving the openjdk version, so we don't need to adjust it to whatever the current version in debian is. The default-jre-headless package is at least available since debian 10: https://packages.debian.org/search?suite=buster&arch=any&searchon=names&key… Related: OS#6186 Change-Id: I6c5c74ff3d75dca2f89765d95c4b4c6d67ace703 --- M ansible/roles/osmocom-jenkins-slave/tasks/debian.yml 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml index ead03d7..3743043 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml @@ -49,7 +49,7 @@ - name: install java for buster and later apt: name: - - openjdk-11-jre-headless + - default-jre-headless cache_valid_time: 3600 update_cache: yes install_recommends: no -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6c5c74ff3d75dca2f89765d95c4b4c6d67ace703 Gerrit-Change-Number: 34787 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: ansible: jenkins: debian: add more packages
by osmith 19 Oct '23

19 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34796?usp=email ) Change subject: ansible: jenkins: debian: add more packages ...................................................................... ansible: jenkins: debian: add more packages Add python3-setuptools, as it is needed to run the update-osmo-python-on-slaves jenkins job. Add bc, as it is needed in docker-playground.git's network_create() in jenkins-common.sh. Related: OS#6186 Change-Id: I1ff0711b7b29ba4dc78f51f257b986d7a0994a96 --- M ansible/roles/osmocom-jenkins-slave/tasks/debian.yml 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml index 102d0b8..62beb8e 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml @@ -3,10 +3,12 @@ - name: install jenkins utilities apt: name: + - bc - debootstrap - fakeroot - htop - proot + - python3-setuptools - qemu-system-arm - qemu-user-static - virt-manager -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1ff0711b7b29ba4dc78f51f257b986d7a0994a96 Gerrit-Change-Number: 34796 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: ansible: jenkins: debian: sort packages
by osmith 19 Oct '23

19 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34795?usp=email ) Change subject: ansible: jenkins: debian: sort packages ...................................................................... ansible: jenkins: debian: sort packages Related: OS#6186 Change-Id: If4ce784821cc40a2e795afafa452c99bf0588253 --- M ansible/roles/osmocom-jenkins-slave/tasks/debian.yml 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml index 3743043..102d0b8 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml @@ -3,13 +3,13 @@ - name: install jenkins utilities apt: name: - - htop - - virt-manager - - qemu-user-static - - qemu-system-arm - - proot - debootstrap - fakeroot + - htop + - proot + - qemu-system-arm + - qemu-user-static + - virt-manager cache_valid_time: 3600 update_cache: yes install_recommends: no -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If4ce784821cc40a2e795afafa452c99bf0588253 Gerrit-Change-Number: 34795 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/update-osmo-*: add build4-deb12build-ansible
by osmith 19 Oct '23

19 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34794?usp=email ) Change subject: jobs/update-osmo-*: add build4-deb12build-ansible ...................................................................... jobs/update-osmo-*: add build4-deb12build-ansible Related: OS#6186 Change-Id: I1f732718df87ed3b850332dbf1a7f6b2f854f280 --- M jobs/update-osmo-ci-on-slaves.yml M jobs/update-osmo-python-on-slaves.yml 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index e9f80b1..2b1d81f 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -9,6 +9,7 @@ - build2-deb10build-ansible - build2-deb11build-ansible - build3-deb11build-ansible + - build4-deb12build-ansible - gtp0-deb10fr - host2-deb11build-ansible - rpi4-raspbian11build-ansible-1 diff --git a/jobs/update-osmo-python-on-slaves.yml b/jobs/update-osmo-python-on-slaves.yml index 8147b4f..0842fba 100644 --- a/jobs/update-osmo-python-on-slaves.yml +++ b/jobs/update-osmo-python-on-slaves.yml @@ -9,6 +9,7 @@ - build2-deb10build-ansible - build2-deb11build-ansible - build3-deb11build-ansible + - build4-deb12build-ansible - host2-deb11build-ansible - rpi4-raspbian11build-ansible-1 - rpi4-raspbian11build-ansible-2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1f732718df87ed3b850332dbf1a7f6b2f854f280 Gerrit-Change-Number: 34794 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0