dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34687?usp=email )
Change subject: transport: show full traceback on failed reader init
......................................................................
transport: show full traceback on failed reader init
When the reader initialization failes with an exception we may have a
major hardware problem and it may not be enough to print only the
exception message. Also in some rare cases an exception message may not
be available. To make it easier to debug problems lets print the full
traceback like we already do it in pySim-shell.py.
Related: OS#6210
Change-Id: I46e913a516dbc13f7610512484f515ab25d3fbae
---
M pySim/transport/__init__.py
1 file changed, 22 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/87/34687/1
diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py
index 79f82c2..6bce674 100644
--- a/pySim/transport/__init__.py
+++ b/pySim/transport/__init__.py
@@ -5,6 +5,7 @@
import abc
import argparse
+import traceback
from typing import Optional, Tuple
from construct import Construct
@@ -293,6 +294,7 @@
Init card reader driver
"""
sl = None # type : :Optional[LinkBase]
+
try:
if opts.pcsc_dev is not None:
print("Using PC/SC reader number %u" % opts.pcsc_dev)
@@ -314,9 +316,8 @@
baudrate=opts.baudrate, **kwargs)
return sl
except Exception as e:
- if str(e):
- print("Card reader initialization failed with exception:\n" + str(e))
- else:
- print(
- "Card reader initialization failed with an exception of type:\n" + str(type(e)))
+ print("Card reader initialization failed with an exception:")
+ print("---------------------8<---------------------")
+ traceback.print_exc()
+ print("---------------------8<---------------------")
return None
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34687?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I46e913a516dbc13f7610512484f515ab25d3fbae
Gerrit-Change-Number: 34687
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34686?usp=email )
Change subject: transport: print reader device/number on init
......................................................................
transport: print reader device/number on init
When we initialize the reader, we currently tell only which type of
interface we are using, but we do not print the reader number or the
device path.
Related: OS#6210
Change-Id: I5c08995fcd55bd9bb173adc2acd9722e438a164b
---
M pySim/transport/__init__.py
1 file changed, 18 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/34686/1
diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py
index c8079f6..79f82c2 100644
--- a/pySim/transport/__init__.py
+++ b/pySim/transport/__init__.py
@@ -295,20 +295,20 @@
sl = None # type : :Optional[LinkBase]
try:
if opts.pcsc_dev is not None:
- print("Using PC/SC reader interface")
+ print("Using PC/SC reader number %u" % opts.pcsc_dev)
from pySim.transport.pcsc import PcscSimLink
sl = PcscSimLink(opts.pcsc_dev, **kwargs)
elif opts.osmocon_sock is not None:
- print("Using Calypso-based (OsmocomBB) reader interface")
+ print("Using Calypso-based (OsmocomBB) reader at socket %s" % opts.osmocon_sock)
from pySim.transport.calypso import CalypsoSimLink
sl = CalypsoSimLink(sock_path=opts.osmocon_sock, **kwargs)
elif opts.modem_dev is not None:
- print("Using modem for Generic SIM Access (3GPP TS 27.007)")
+ print("Using modem for Generic SIM Access (3GPP TS 27.007) at port %s" % opts.modem_dev)
from pySim.transport.modem_atcmd import ModemATCommandLink
sl = ModemATCommandLink(
device=opts.modem_dev, baudrate=opts.modem_baud, **kwargs)
else: # Serial reader is default
- print("Using serial reader interface")
+ print("Using serial reader interface at port %s" % opts.device)
from pySim.transport.serial import SerialSimLink
sl = SerialSimLink(device=opts.device,
baudrate=opts.baudrate, **kwargs)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34686?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5c08995fcd55bd9bb173adc2acd9722e438a164b
Gerrit-Change-Number: 34686
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34683?usp=email )
Change subject: Do not prefix UI header to System Information Type 10
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34683?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: osmith/1.7.1
Gerrit-Change-Id: Ifede42bfd84ea5914b559a20ae68f594d2ee1a5c
Gerrit-Change-Number: 34683
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 09 Oct 2023 08:27:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34682?usp=email )
Change subject: ASCI: Ignore LAPD frames from MS, while the uplink is not active
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34682?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: osmith/1.7.1
Gerrit-Change-Id: I5075115123055b2997481f56ddf473430a1dc9e3
Gerrit-Change-Number: 34682
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 09 Oct 2023 08:27:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment