October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: firmware/layer1: emit TRAFFIC.ind even if B_BFI is set
by laforge 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34756?usp=email ) Change subject: firmware/layer1: emit TRAFFIC.ind even if B_BFI is set ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I559793a3506089b1c1758ee7022cceb7753afb30 Gerrit-Change-Number: 34756 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 07:53:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: firmware/layer1: fill-in DL info for L1CTL TRAFFIC.ind
by laforge 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34755?usp=email ) Change subject: firmware/layer1: fill-in DL info for L1CTL TRAFFIC.ind ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1c9727b183214f3d1a4f9a48489479f8435a4c5a Gerrit-Change-Number: 34755 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 07:53:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: firmware/layer1: fix l1s_tch_resp(): use the right A_DD header
by laforge 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34754?usp=email ) Change subject: firmware/layer1: fix l1s_tch_resp(): use the right A_DD header ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34754?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idd48438e47ac3ef1172621e77688d094cdcdbf34 Gerrit-Change-Number: 34754 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 07:52:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: firmware/layer1: clean up l1s_tch_resp()
by laforge 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34753?usp=email ) Change subject: firmware/layer1: clean up l1s_tch_resp() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34753?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie4faf386f54720888e73171bee26f93dfa0562d5 Gerrit-Change-Number: 34753 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 07:51:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: firmware/layer1: cosmetic: labels should not be indented
by laforge 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34763?usp=email ) Change subject: firmware/layer1: cosmetic: labels should not be indented ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie32501df19cc2eedd1042c9917583d7386a665bc Gerrit-Change-Number: 34763 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 07:51:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: firmware/layer1: clean up l1s_tch_cmd(): reduce nesting
by laforge 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34752?usp=email ) Change subject: firmware/layer1: clean up l1s_tch_cmd(): reduce nesting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If4f0bb37cb3e12e09078027461cd5040524e43b2 Gerrit-Change-Number: 34752 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 07:50:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: firmware/layer1: mute UL/DL vocodec if it's not needed
by laforge 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34751?usp=email ) Change subject: firmware/layer1: mute UL/DL vocodec if it's not needed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34751?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I390db1889f079dea8112794c3e039a9136b897df Gerrit-Change-Number: 34751 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 07:50:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: firmware/layer1: clean up l1s_tch_resp()
by fixeria 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34753?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: firmware/layer1: clean up l1s_tch_resp() ...................................................................... firmware/layer1: clean up l1s_tch_resp() * Reset both A_DD_0 and A_DD_1 headers, like in the case of FACCH. * Reduce nesting, fix minor coding style issues. * Add a FIXME for proper B_BFI checking. Change-Id: Ie4faf386f54720888e73171bee26f93dfa0562d5 Related: OS#4396 --- M src/target/firmware/layer1/prim_tch.c 1 file changed, 44 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/53/34753/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34753?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie4faf386f54720888e73171bee26f93dfa0562d5 Gerrit-Change-Number: 34753 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: firmware/layer1: cosmetic: labels should not be indented
by fixeria 16 Oct '23

16 Oct '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34763?usp=email ) Change subject: firmware/layer1: cosmetic: labels should not be indented ...................................................................... firmware/layer1: cosmetic: labels should not be indented Change-Id: Ie32501df19cc2eedd1042c9917583d7386a665bc Related: OS#4396 --- M src/target/firmware/layer1/prim_tch.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/63/34763/1 diff --git a/src/target/firmware/layer1/prim_tch.c b/src/target/firmware/layer1/prim_tch.c index 7d5c1f4..0c8745d 100644 --- a/src/target/firmware/layer1/prim_tch.c +++ b/src/target/firmware/layer1/prim_tch.c @@ -269,7 +269,7 @@ /* Give message to up layer */ l1_queue_for_l2(msg); - skip_rx_facch: +skip_rx_facch: /* Reset A_FD header (needed by DSP) */ /* B_FIRE1 =1, B_FIRE0 =0 , BLUD =0 */ dsp_api.ndb->a_fd[0] = (1<<B_FIRE1); @@ -327,7 +327,7 @@ l1_queue_for_l2(msg); } - skip_rx_traffic: +skip_rx_traffic: /* Reset traffic buffer header in NDB (needed by DSP) */ traffic_buf[0] = 0; traffic_buf[2] = 0xffff; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie32501df19cc2eedd1042c9917583d7386a665bc Gerrit-Change-Number: 34763 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: mobile: mncc_recv_internal(): make struct gsm_mncc ptr const
by fixeria 16 Oct '23

16 Oct '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34758?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: mobile: mncc_recv_internal(): make struct gsm_mncc ptr const ...................................................................... mobile: mncc_recv_internal(): make struct gsm_mncc ptr const Change-Id: I0a5522b7df112bfaefc684c872a618c1e9118e61 --- M src/host/layer23/src/mobile/mnccms.c 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/34758/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0a5522b7df112bfaefc684c872a618c1e9118e61 Gerrit-Change-Number: 34758 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0