January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

by keith

Attention is currently required from: keith, lynxis lazus. keith has uploaded a new patch set (#9) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause ...................................................................... Add vty `reject-cause` to set the reject cause Allow to set the reject cause when an IMSI is unknown to the HLR. Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or CAUSE_ROAMING_NOTALLOWED (11). Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a --- M include/osmocom/hlr/hlr.h M include/osmocom/hlr/hlr_vty.h M src/hlr.c M src/hlr_vty.c M src/lu_fsm.c M src/proxy.c M tests/test_nodes.vty 7 files changed, 98 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

by keith

Attention is currently required from: keith, lynxis lazus. keith has uploaded a new patch set (#8) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause ...................................................................... Add vty `reject-cause` to set the reject cause Allow to set the reject cause when an IMSI is unknown to the HLR. Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or CAUSE_ROAMING_NOTALLOWED (11). Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a --- M include/osmocom/hlr/hlr.h M include/osmocom/hlr/hlr_vty.h M src/hlr.c M src/hlr_vty.c M tests/test_nodes.vty 5 files changed, 87 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-trx[master]: ms: update submodule to currently known working version

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30967 ) Change subject: ms: update submodule to currently known working version ...................................................................... ms: update submodule to currently known working version Change-Id: I690f508d1f0cee0b623196dd4574c3ee456f07fa --- M osmocom-bb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/67/30967/1 diff --git a/osmocom-bb b/osmocom-bb index 040bf41..c209242 160000 --- a/osmocom-bb +++ b/osmocom-bb @@ -1 +1 @@ -Subproject commit 040bf4102892ddba1a4574d85b31653131c5ede4 +Subproject commit c209242d196a9c30401c383104f5063d4dbde4cd -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I690f508d1f0cee0b623196dd4574c3ee456f07fa Gerrit-Change-Number: 30967 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-trx[master]: ms: adjust float<->integral type conversion

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30966 ) Change subject: ms: adjust float<->integral type conversion ...................................................................... ms: adjust float<->integral type conversion Given integral type A and non integral type B and depending on rounding mode, optimization, compiler, and phase of the moon A(A)*B != A(A*B) so split the two cases. While at it, also make the template automagically work for complex types instead of requiring manual casts, the general idea here is to allow inlining and vectorization by treating all args as plain arrays, which is fine. This works as expected with -tune=native, x64 implies sse2, and we do not target any neon-less arm versions either. Clang only array length hints can improve this even more. Change-Id: I93f077f967daf2ed382d12cc20a54846b3688634 --- M Transceiver52M/Complex.h M Transceiver52M/ms/ms.cpp M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_burst_test.cpp M Transceiver52M/ms/ms_rx_lower.cpp M Transceiver52M/ms/ms_upper.cpp 6 files changed, 46 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/66/30966/1 diff --git a/Transceiver52M/Complex.h b/Transceiver52M/Complex.h index 6e72346..597a26f 100644 --- a/Transceiver52M/Complex.h +++ b/Transceiver52M/Complex.h @@ -29,7 +29,7 @@ template<class Real> class Complex { public: - + typedef Real value_type; Real r, i; /**@name constructors */ diff --git a/Transceiver52M/ms/ms.cpp b/Transceiver52M/ms/ms.cpp index ddcfc3e..6f63a73 100644 --- a/Transceiver52M/ms/ms.cpp +++ b/Transceiver52M/ms/ms.cpp @@ -62,7 +62,7 @@ // float -> int16 blade_sample_type burst_buf[burst->size()]; - convert_and_scale<int16_t, float>(burst_buf, burst->begin(), burst->size() * 2, 1); + convert_and_scale(burst_buf, burst->begin(), burst->size() * 2, 1); while (1) { GSM::Time target; @@ -126,7 +126,7 @@ t->submit_burst_ts(buf2, burst->size() + pad, send_ts - pad); #ifdef DBGXX signalVector test(burst->size() + pad); - convert_and_scale<float, int16_t>(test.begin(), buf2, burst->size() * 2 + pad, 1.f / float(scale)); + convert_and_scale(test.begin(), buf2, burst->size() * 2 + pad, 1.f / float(scale)); estim_burst_params ebp; auto det = detectAnyBurst(test, 0, 4, 4, CorrType::RACH, 40, &ebp); if (det > 0) diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h index 5425283..f79a560 100644 --- a/Transceiver52M/ms/ms.h +++ b/Transceiver52M/ms/ms.h @@ -38,6 +38,7 @@ #error wat? no device.. #endif +#include "Complex.h" #include "GSMCommon.h" #include "itrq.h" @@ -53,15 +54,44 @@ start2[i] = t2; } } -template <typename DST_T, typename SRC_T, typename ST> -void convert_and_scale(void *dst, void *src, unsigned int src_len, ST scale) + +namespace cvt_internal +{ +template <typename SRC_T, typename ST> +void convert_and_scale_i(float *dst, const SRC_T *src, unsigned int src_len, ST scale) { for (unsigned int i = 0; i < src_len; i++) - reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; + dst[i] = static_cast<float>(src[i]) * scale; } -template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) +template <typename DST_T, typename ST> +void convert_and_scale_i(DST_T *dst, const float *src, unsigned int src_len, ST scale) { - return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); + for (unsigned int i = 0; i < src_len; i++) + dst[i] = static_cast<DST_T>(src[i] * scale); +} +template <typename ST> void convert_and_scale_i(float *dst, const float *src, unsigned int src_len, ST scale) +{ + for (unsigned int i = 0; i < src_len; i++) + dst[i] = src[i] * scale; +} + +template <typename T> struct is_complex : std::false_type { + using baset = T; +}; +template <typename T> struct is_complex<std::complex<T>> : std::true_type { + using baset = typename std::complex<T>::value_type; +}; +template <typename T> struct is_complex<Complex<T>> : std::true_type { + using baset = typename Complex<T>::value_type; +}; +} // namespace cvt_internal + +template <typename DST_T, typename SRC_T, typename ST> +void convert_and_scale(DST_T *dst, const SRC_T *src, unsigned int src_len, ST scale) +{ + using vd = typename cvt_internal::is_complex<DST_T>::baset; + using vs = typename cvt_internal::is_complex<SRC_T>::baset; + return cvt_internal::convert_and_scale_i((vd *)dst, (vs *)src, src_len, scale); } struct one_burst { diff --git a/Transceiver52M/ms/ms_rx_burst_test.cpp b/Transceiver52M/ms/ms_rx_burst_test.cpp index 7018301..c3ba4ee 100644 --- a/Transceiver52M/ms/ms_rx_burst_test.cpp +++ b/Transceiver52M/ms/ms_rx_burst_test.cpp @@ -90,7 +90,7 @@ if (is_sch) { char outbin[148]; - convert_and_scale_default<float, int16_t>(burst.begin(), e.burst, ONE_TS_BURST_LEN * 2); + convert_and_scale(burst.begin(), e.burst, ONE_TS_BURST_LEN * 2, SAMPLE_SCALE_FACTOR); std::stringstream dbgout; #if 0 { @@ -109,8 +109,7 @@ } #endif { - convert_and_scale<float, float>(burst.begin(), burst.begin(), ONE_TS_BURST_LEN * 2, - 1.f / float(scale)); + convert_and_scale(burst.begin(), burst.begin(), ONE_TS_BURST_LEN * 2, 1.f / float(scale)); std::complex<float> channel_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; auto ss = reinterpret_cast<std::complex<float> *>(burst.begin()); @@ -133,7 +132,7 @@ return; } #if 1 - convert_and_scale<float, int16_t>(burst.begin(), e.burst, ONE_TS_BURST_LEN * 2, 1.f / float(scale)); + convert_and_scale(burst.begin(), e.burst, ONE_TS_BURST_LEN * 2, 1.f / float(scale)); // std::cerr << "@" << tsc << " " << e.gsmts.FN() << ":" << e.gsmts.TN() << " " << ebp.toa << " " // << std::endl; diff --git a/Transceiver52M/ms/ms_rx_lower.cpp b/Transceiver52M/ms/ms_rx_lower.cpp index bec1691..e39d72d 100644 --- a/Transceiver52M/ms/ms_rx_lower.cpp +++ b/Transceiver52M/ms/ms_rx_lower.cpp @@ -180,13 +180,11 @@ memset((void *)&sch_acq_buffer[0], 0, sizeof(sch_acq_buffer)); if (is_first_sch_acq) { float max_corr = 0; - convert_and_scale<float, int16_t>(which_out_buffer, which_in_buffer, buf_len * 2, - 1.f / float(rxFullScale)); + convert_and_scale(which_out_buffer, which_in_buffer, buf_len * 2, 1.f / float(rxFullScale)); start = get_sch_buffer_chan_imp_resp(ss, &channel_imp_resp[0], buf_len, &max_corr); detect_burst(&ss[start], &channel_imp_resp[0], 0, sch_demod_bits); } else { - convert_and_scale<float, int16_t>(which_out_buffer, which_in_buffer, buf_len * 2, - 1.f / float(rxFullScale)); + convert_and_scale(which_out_buffer, which_in_buffer, buf_len * 2, 1.f / float(rxFullScale)); start = get_sch_chan_imp_resp(ss, &channel_imp_resp[0]); start = start < 39 ? start : 39; start = start > -39 ? start : -39; diff --git a/Transceiver52M/ms/ms_upper.cpp b/Transceiver52M/ms/ms_upper.cpp index 2f3bdc6..63f5926 100644 --- a/Transceiver52M/ms/ms_upper.cpp +++ b/Transceiver52M/ms/ms_upper.cpp @@ -191,7 +191,7 @@ return true; } - convert_and_scale<float, int16_t>(ss, e.burst, ONE_TS_BURST_LEN * 2, 1.f / float(rxFullScale)); + convert_and_scale(ss, e.burst, ONE_TS_BURST_LEN * 2, 1.f / float(rxFullScale)); pow = energyDetect(sv, 20 * 4 /*sps*/); if (pow < -1) { @@ -292,10 +292,10 @@ // float -> int16 blade_sample_type burst_buf[txburst->size()]; - convert_and_scale<int16_t, float>(burst_buf, txburst->begin(), txburst->size() * 2, 1); + convert_and_scale(burst_buf, txburst->begin(), txburst->size() * 2, 1); #ifdef TXDEBUG auto check = signalVector(txburst->size(), 40); - convert_and_scale<float, int16_t, 1>(check.begin(), burst_buf, txburst->size() * 2); + convert_and_scale(check.begin(), burst_buf, txburst->size() * 2, 1); estim_burst_params ebp; auto d = detectAnyBurst(check, 2, 4, 4, CorrType::RACH, 40, &ebp); if (d) @@ -462,7 +462,6 @@ { auto tall_trxcon_ctx = talloc_init("trxcon context"); signal(SIGPIPE, sighandler); - fesetround(FE_TOWARDZERO); trxcon::msgb_talloc_ctx_init(tall_trxcon_ctx, 0); trxc_log_init(tall_trxcon_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I93f077f967daf2ed382d12cc20a54846b3688634 Gerrit-Change-Number: 30966 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

by keith

Attention is currently required from: lynxis lazus. keith has uploaded a new patch set (#7) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause ...................................................................... Add vty `reject-cause` to set the reject cause Allow to set the reject cause when an IMSI is unknown to the HLR. Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or CAUSE_ROAMING_NOTALLOWED (11). Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a --- M include/osmocom/hlr/hlr.h M src/hlr.c M src/hlr_vty.c M tests/test_nodes.vty 4 files changed, 75 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Fix wrong prim op passed in osmo_gprs_sndcp_prim_alloc_sn_xid_...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30951 ) Change subject: sndcp: Fix wrong prim op passed in osmo_gprs_sndcp_prim_alloc_sn_xid_rsp() ...................................................................... sndcp: Fix wrong prim op passed in osmo_gprs_sndcp_prim_alloc_sn_xid_rsp() Change-Id: I0644bf481c06a2cfc1d9f57995eefedf36e8b839 --- M src/sndcp/sndcp_prim.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/sndcp/sndcp_prim.c b/src/sndcp/sndcp_prim.c index 7dd9d43..09c37b7 100644 --- a/src/sndcp/sndcp_prim.c +++ b/src/sndcp/sndcp_prim.c @@ -210,7 +210,7 @@ struct osmo_gprs_sndcp_prim *osmo_gprs_sndcp_prim_alloc_sn_xid_rsp(uint32_t tlli, uint8_t sapi, uint8_t nsapi) { struct osmo_gprs_sndcp_prim *sndcp_prim; - sndcp_prim = sndcp_prim_sn_alloc(OSMO_GPRS_SNDCP_SN_XID, PRIM_OP_REQUEST, 0); + sndcp_prim = sndcp_prim_sn_alloc(OSMO_GPRS_SNDCP_SN_XID, PRIM_OP_RESPONSE, 0); sndcp_prim->sn.tlli = tlli; sndcp_prim->sn.sapi = sapi; sndcp_prim->sn.xid_rsp.nsapi = nsapi; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0644bf481c06a2cfc1d9f57995eefedf36e8b839 Gerrit-Change-Number: 30951 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Add missing header dependencies to several files

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30959 to look at the new patch set (#2). Change subject: layer23: Add missing header dependencies to several files ...................................................................... layer23: Add missing header dependencies to several files Change-Id: I9819b12d1c24f6ee197daa887452b09418d689e8 --- M src/host/layer23/include/osmocom/bb/common/l1ctl.h M src/host/layer23/include/osmocom/bb/common/l1l2_interface.h M src/host/layer23/include/osmocom/bb/common/sim.h M src/host/layer23/include/osmocom/bb/misc/log.h M src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h M src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h M src/host/layer23/include/osmocom/bb/mobile/mncc.h M src/host/layer23/include/osmocom/bb/mobile/settings.h M src/host/layer23/src/common/gps.c M src/host/layer23/src/common/l1ctl_lapdm_glue.c M src/host/layer23/src/common/l1l2_interface.c M src/host/layer23/src/common/sap_fsm.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/app_echo_test.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm322.c M src/host/layer23/src/mobile/gsm414.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/mnccms.c M src/host/layer23/src/mobile/settings.c M src/host/layer23/src/mobile/subscriber.c M src/host/layer23/src/mobile/voice.c 24 files changed, 48 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/30959/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9819b12d1c24f6ee197daa887452b09418d689e8 Gerrit-Change-Number: 30959 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Add inital VTY support for l23_apps

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 to look at the new patch set (#3). Change subject: layer23: Add inital VTY support for l23_apps ...................................................................... layer23: Add inital VTY support for l23_apps Initial VTY "boilerplate" code for modem app is already added in this commit as a showcase what's needed by an app to have the VTY config file read and VTY interface initialized. Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a --- M src/host/layer23/include/osmocom/bb/common/l23_app.h M src/host/layer23/src/common/main.c M src/host/layer23/src/misc/Makefile.am M src/host/layer23/src/modem/app_modem.c 4 files changed, 78 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/50/30950/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a Gerrit-Change-Number: 30950 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: misc/log.h: Fix missing pragma once

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30957 to look at the new patch set (#2). Change subject: layer23: misc/log.h: Fix missing pragma once ...................................................................... layer23: misc/log.h: Fix missing pragma once Change-Id: Ie57357224ba5ed2bf691e2912ede7ee19012b6dd --- M src/host/layer23/include/osmocom/bb/misc/log.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/30957/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie57357224ba5ed2bf691e2912ede7ee19012b6dd Gerrit-Change-Number: 30957 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: fix -Wmaybe-uninitialized in modem_rx_imm_ass()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30964 ) Change subject: modem: fix -Wmaybe-uninitialized in modem_rx_imm_ass() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I773b13e3c7b7546a6cdd7d0b729cca8687b0a131 Gerrit-Change-Number: 30964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jan 2023 18:15:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023