lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

January 2023

  • 1 participants
  • 2205 discussions
Change in osmo-bsc[master]: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH
by dexter 31 Jan '23

31 Jan '23
Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31112 ) Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31112/comment/618d7692_bd109dc4 PS1, Line 13: actively manage the channel than. In the case of Ericsson we have to > "the channel than" I don't understand this part. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:51:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-bsc[master]: pcu_sock: inform when no PDCH is available at all
by dexter 31 Jan '23

31 Jan '23
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31111 to look at the new patch set (#2). Change subject: pcu_sock: inform when no PDCH is available at all ...................................................................... pcu_sock: inform when no PDCH is available at all In case no PDCH is currently available (resources exhausted, or simply a bug that prevents TS to be recognized as usable for PDCH) display an informative message to inform the user about this. Change-Id: Ie3e5409cd798f6027404c0ff95297af850e516c4 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/31111/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3e5409cd798f6027404c0ff95297af850e516c4 Gerrit-Change-Number: 31111 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
Change in libosmocore[master]: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF
by osmith 31 Jan '23

31 Jan '23
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31094 ) Change subject: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'd normally always add a backwards compatibility #define in case some unknown application might hav […] I've added one in this patch: #define GSM0808_DATA_FULL_RPREF GSM0808_DATA_FULL_PREF -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25f46bf3893bb68203414300587756cf2fdb04f7 Gerrit-Change-Number: 31094 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment
1 0
0 0
Change in osmocom-bb[master]: Get rid of openbsc leftover references
by laforge 31 Jan '23

31 Jan '23
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31116 ) Change subject: Get rid of openbsc leftover references ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0b4f536b16f3693ef16de8505036943c3a30b1df Gerrit-Change-Number: 31116 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:49:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in libosmocore[master]: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF
by laforge 31 Jan '23

31 Jan '23
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31094 ) Change subject: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'd normally always add a backwards compatibility #define in case some unknown application might have used the name with typo. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25f46bf3893bb68203414300587756cf2fdb04f7 Gerrit-Change-Number: 31094 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:48:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
Change in libosmocore[master]: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF
by osmith 31 Jan '23

31 Jan '23
osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31094 ) Change subject: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF ...................................................................... gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF Change-Id: I25f46bf3893bb68203414300587756cf2fdb04f7 --- M include/osmocom/gsm/protocol/gsm_08_08.h 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h index c7cf1d8..96ac6af 100644 --- a/include/osmocom/gsm/protocol/gsm_08_08.h +++ b/include/osmocom/gsm/protocol/gsm_08_08.h @@ -446,10 +446,11 @@ }; /* GSM 08.08 3.2.2.11 Channel Type */ +#define GSM0808_DATA_FULL_RPREF GSM0808_DATA_FULL_PREF enum gsm0808_chan_rate_type_data { GSM0808_DATA_FULL_BM = 0x8, GSM0808_DATA_HALF_LM = 0x9, - GSM0808_DATA_FULL_RPREF = 0xa, + GSM0808_DATA_FULL_PREF = 0xa, GSM0808_DATA_HALF_PREF = 0xb, GSM0808_DATA_FULL_PREF_NO_CHANGE = 0x1a, GSM0808_DATA_HALF_PREF_NO_CHANGE = 0x1b, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25f46bf3893bb68203414300587756cf2fdb04f7 Gerrit-Change-Number: 31094 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmocom-bb[master]: layer23: Support configuring GSMTAP through VTY in l23 apps.
by fixeria 31 Jan '23

31 Jan '23
Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 ) Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/f90af13e_f22ce9ad PS3, Line 23: gsmtap-sapi pdtch : gsmtap-sapi ptcch Question: if I have 'gsmtap-sapi pdtch' in my config file, does this enable all GPRS categories? Similarly, if I do 'no gsmtap-sapi pdtch' and then 'gsmtap-category gprs dl-ctrl', will I see only the dl-ctrl messages or nothing? Oh, there is also 'pacch'... Here is another proposal, hopefully making all my questions above void: gsmtap ... gsmtap-sapi tch/f gsmtap-sapi tch/h gsmtap-sapi pdch (enable-all|disable-all) gsmtap-sapi pdch (dl-dummy|dl-ctrl|...) This way it looks more logical to me, and somehow consistent. P.S. there is no SAPI in GSMTAP. P.P.S. This probably comes from osmo-bts-sysmo, where the L1 prims have SAPI field. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839 Gerrit-Change-Number: 31108 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:37:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
Change in osmocom-bb[master]: layer23: Support configuring GSMTAP through VTY in l23 apps.
by pespin 31 Jan '23

31 Jan '23
Attention is currently required from: jolly, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 ) Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/221d65ad_3074e131 PS2, Line 13: gsmtap > Ok, let's see what the others think about the command style/consistency. Ack File src/host/layer23/include/osmocom/bb/common/l23_app.h: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/17421f82_f6d394f5 PS3, Line 20: l23_gsmtap_category > Maybe l23_gsmtap_gprs_category? Or have GPRS prefix in all enum entries? Ack File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/e6ff6ea6_4de2c66a PS3, Line 138: gsmtap_sapi_names > There exists gsmtap_gsm_channel_names[] in libosmocore. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839 Gerrit-Change-Number: 31108 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:36:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in libosmocore[master]: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF
by fixeria 31 Jan '23

31 Jan '23
Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31094 ) Change subject: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25f46bf3893bb68203414300587756cf2fdb04f7 Gerrit-Change-Number: 31094 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:25:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmocom-bb[master]: layer23: Support configuring GSMTAP through VTY in l23 apps.
by fixeria 31 Jan '23

31 Jan '23
Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 ) Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/e4590ff6_c3d752c9 PS2, Line 13: gsmtap > I'm not mixing them here, I'm establishing 2 layers of granularity. […] Ok, let's see what the others think about the command style/consistency. File src/host/layer23/include/osmocom/bb/common/l23_app.h: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/b7db2693_38af60c8 PS3, Line 20: l23_gsmtap_category Maybe l23_gsmtap_gprs_category? Or have GPRS prefix in all enum entries? File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/924827a2_3b38d154 PS3, Line 138: gsmtap_sapi_names There exists gsmtap_gsm_channel_names[] in libosmocore.git, maybe use it? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839 Gerrit-Change-Number: 31108 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:24:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 8
  • 9
  • 10
  • 11
  • 12
  • 13
  • 14
  • ...
  • 221
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.