Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29236 )
Change subject: contrib/jenkins.sh: execute this script with -x and -e
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/pysim/+/29236/comment/536b3f2f_ebc2c6cf
PS2, Line 9: set -e
is now redundant, can be removed
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/29236
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833
Gerrit-Change-Number: 29236
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 07:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria, dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29239 )
Change subject: contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
nice, it was just fixed upstream. so once they make a new release we should be able to revert this
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/29239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie29be6ec6631ff2b3d8cd6b2dd9ac0ed8f505e4f
Gerrit-Change-Number: 29239
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 07:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29256 )
Change subject: osmux: Drop long time deprecated APIs
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/f555f043_22e1ac2f
PS2, Line 10: been
> We'll require a major bump anyway since the whole API will be improved/extended/changed (see for ins […]
I don't have a strong opinion here. On the one hand, I agree that keeping deprecated API forever might introduce additional effort of maintaining it. On the other hand, we cannot be sure that 3-rd party (even worse if abandoned) projects are not using these APIs.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853
Gerrit-Change-Number: 29256
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Sep 2022 19:32:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29269 )
Change subject: Move AMR defintions out of OSMUX_Types to its own file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29269
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0edfbb7359516ba77180afab18c3e1ffb2d0c927
Gerrit-Change-Number: 29269
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Sep 2022 18:18:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29268 )
Change subject: BSC: Implement RSL_IE_MultirateCfg and use it in BSC_Tests
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29268/comment/dd37c986_c1f1…
PS1, Line 4604: 2004
You're introducing a regression here: unlike above, it's not '2804'O. I think you need to do pars.expect_mr_conf_ie.multirate_cfg.icmi := false to match what the comment states.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0a5ddce570c0fd70f096d897b0b609d20b552ff7
Gerrit-Change-Number: 29268
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Sep 2022 18:17:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment