September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: Clarify RTP AMR header offset in TCH enc/dec

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29274 ) Change subject: Clarify RTP AMR header offset in TCH enc/dec ...................................................................... Clarify RTP AMR header offset in TCH enc/dec The struct amr_hdr is present in libosmo-netif, which was not yet an osmo-bts dependency. While it may seem gross to depend on it only for this, the truth is that it already feels weird it's not used more in osmo-bts, so having it already include will hopefully allow cleaning up more code in osmo-bts in the future. Furthermore, Osmux support being added soon to osmo-bts will require libosmo-netif anyway, so it's a good step to add it already in here. Change-Id: I607fdf6d627242e010fba35be1b9b0ffde820d08 --- M configure.ac M contrib/jenkins_bts_trx.sh M contrib/jenkins_lc15.sh M contrib/jenkins_oc2g.sh M contrib/jenkins_oct.sh M contrib/jenkins_oct_and_bts_trx.sh M contrib/jenkins_sysmobts.sh M contrib/osmo-bts.spec.in M debian/control M src/common/Makefile.am M src/osmo-bts-lc15/Makefile.am M src/osmo-bts-oc2g/Makefile.am M src/osmo-bts-octphy/Makefile.am M src/osmo-bts-omldummy/Makefile.am M src/osmo-bts-sysmo/Makefile.am M src/osmo-bts-trx/Makefile.am M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c M src/osmo-bts-virtual/Makefile.am M tests/agch/Makefile.am M tests/cipher/Makefile.am M tests/handover/Makefile.am M tests/meas/Makefile.am M tests/misc/Makefile.am M tests/paging/Makefile.am M tests/power/Makefile.am M tests/sysmobts/Makefile.am M tests/tx_power/Makefile.am 28 files changed, 62 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/74/29274/1 diff --git a/configure.ac b/configure.ac index 4dbdd94..aee5600 100644 --- a/configure.ac +++ b/configure.ac @@ -77,6 +77,7 @@ PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.3.0) PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.3.0) +PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.2.0) AC_MSG_CHECKING([whether to enable support for sysmobts calibration tool]) AC_ARG_ENABLE(sysmobts-calib, diff --git a/contrib/jenkins_bts_trx.sh b/contrib/jenkins_bts_trx.sh index cb041a5..a98a633 100755 --- a/contrib/jenkins_bts_trx.sh +++ b/contrib/jenkins_bts_trx.sh @@ -10,6 +10,7 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_lc15.sh b/contrib/jenkins_lc15.sh index c7d62c9..4454f65 100755 --- a/contrib/jenkins_lc15.sh +++ b/contrib/jenkins_lc15.sh @@ -10,6 +10,7 @@ export LD_LIBRARY_PATH="$inst/lib" osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" osmo-layer1-headers.sh lc15 "$FIRMWARE_VERSION" diff --git a/contrib/jenkins_oc2g.sh b/contrib/jenkins_oc2g.sh index b8badce..af2f8a0 100755 --- a/contrib/jenkins_oc2g.sh +++ b/contrib/jenkins_oc2g.sh @@ -10,6 +10,7 @@ export LD_LIBRARY_PATH="$inst/lib" osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" osmo-layer1-headers.sh oc2g "$FIRMWARE_VERSION" diff --git a/contrib/jenkins_oct.sh b/contrib/jenkins_oct.sh index bd57dd1..0984e20 100755 --- a/contrib/jenkins_oct.sh +++ b/contrib/jenkins_oct.sh @@ -10,6 +10,7 @@ export LD_LIBRARY_PATH="$inst/lib" osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" osmo-layer1-headers.sh oct "$FIRMWARE_VERSION" diff --git a/contrib/jenkins_oct_and_bts_trx.sh b/contrib/jenkins_oct_and_bts_trx.sh index ead2f56..3f4efae 100755 --- a/contrib/jenkins_oct_and_bts_trx.sh +++ b/contrib/jenkins_oct_and_bts_trx.sh @@ -10,6 +10,7 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_sysmobts.sh b/contrib/jenkins_sysmobts.sh index 6376e92..2e5ab8d 100755 --- a/contrib/jenkins_sysmobts.sh +++ b/contrib/jenkins_sysmobts.sh @@ -10,6 +10,7 @@ export LD_LIBRARY_PATH="$inst/lib" osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" osmo-layer1-headers.sh sysmo "$FIRMWARE_VERSION" diff --git a/contrib/osmo-bts.spec.in b/contrib/osmo-bts.spec.in index fe03050..2e48d2f 100644 --- a/contrib/osmo-bts.spec.in +++ b/contrib/osmo-bts.spec.in @@ -35,6 +35,7 @@ BuildRequires: pkgconfig(libosmovty) >= 1.7.0 BuildRequires: pkgconfig(libosmoabis) >= 1.3.0 BuildRequires: pkgconfig(libosmotrau) >= 1.3.0 +BuildRequires: pkgconfig(libosmo-netif) >= 1.2.0 ### FIXME: DependencyHACK to include osmocom/gprs/protocol/gsm_04_60.h BuildRequires: pkgconfig(libosmogb) %{?systemd_requires} diff --git a/debian/control b/debian/control index ed23e75..13000a1 100644 --- a/debian/control +++ b/debian/control @@ -9,6 +9,7 @@ pkg-config, libosmocore-dev (>= 1.7.0), libosmo-abis-dev (>= 1.3.0), + libosmo-netif-dev (>= 1.2.0), libgps-dev, txt2man, osmo-gsm-manuals-dev (>= 1.3.0) diff --git a/src/common/Makefile.am b/src/common/Makefile.am index 35df73e..2f529a4 100644 --- a/src/common/Makefile.am +++ b/src/common/Makefile.am @@ -9,12 +9,14 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ $(LIBOSMOCODEC_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOTRAU_LIBS) \ $(LIBOSMOCODEC_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) if ENABLE_LC15BTS diff --git a/src/osmo-bts-lc15/Makefile.am b/src/osmo-bts-lc15/Makefile.am index a4a105a..58284e9 100644 --- a/src/osmo-bts-lc15/Makefile.am +++ b/src/osmo-bts-lc15/Makefile.am @@ -11,6 +11,7 @@ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(LIBSYSTEMD_CFLAGS) \ $(NULL) @@ -23,6 +24,7 @@ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) AM_CFLAGS += -DENABLE_LC15BTS diff --git a/src/osmo-bts-oc2g/Makefile.am b/src/osmo-bts-oc2g/Makefile.am index 6e6078d..0da40b9 100644 --- a/src/osmo-bts-oc2g/Makefile.am +++ b/src/osmo-bts-oc2g/Makefile.am @@ -11,6 +11,7 @@ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(LIBSYSTEMD_CFLAGS) \ $(ORTP_CFLAGS) \ @@ -24,6 +25,7 @@ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_CFLAGS) \ $(ORTP_LIBS) \ $(NULL) diff --git a/src/osmo-bts-octphy/Makefile.am b/src/osmo-bts-octphy/Makefile.am index fa0a63d..fb3f669 100644 --- a/src/osmo-bts-octphy/Makefile.am +++ b/src/osmo-bts-octphy/Makefile.am @@ -9,6 +9,7 @@ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(NULL) COMMON_LDADD = \ @@ -19,6 +20,7 @@ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) EXTRA_DIST = l1_if.h l1_oml.h l1_utils.h octphy_hw_api.h octpkt.h diff --git a/src/osmo-bts-omldummy/Makefile.am b/src/osmo-bts-omldummy/Makefile.am index 6800883..81da29b 100644 --- a/src/osmo-bts-omldummy/Makefile.am +++ b/src/osmo-bts-omldummy/Makefile.am @@ -6,6 +6,7 @@ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(NULL) @@ -18,6 +19,7 @@ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ -ldl \ $(NULL) diff --git a/src/osmo-bts-sysmo/Makefile.am b/src/osmo-bts-sysmo/Makefile.am index 0641433..12dea3b 100644 --- a/src/osmo-bts-sysmo/Makefile.am +++ b/src/osmo-bts-sysmo/Makefile.am @@ -8,6 +8,7 @@ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(NULL) @@ -19,6 +20,7 @@ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) EXTRA_DIST = \ diff --git a/src/osmo-bts-trx/Makefile.am b/src/osmo-bts-trx/Makefile.am index 845c9e7..63c00fe 100644 --- a/src/osmo-bts-trx/Makefile.am +++ b/src/osmo-bts-trx/Makefile.am @@ -14,6 +14,7 @@ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(NULL) LDADD = \ @@ -25,6 +26,7 @@ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ -ldl \ $(NULL) diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 65f397d..9e0308b 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -35,6 +35,8 @@ #include <osmocom/coding/gsm0503_coding.h> #include <osmocom/coding/gsm0503_amr_dtx.h> +#include <osmocom/netif/amr.h> + #include <osmo-bts/bts.h> #include <osmo-bts/l1sap.h> #include <osmo-bts/logging.h> @@ -155,11 +157,13 @@ if (chan_state->amr_last_dtx == AFS_ONSET) lchan_set_marker(false, lchan); - /* we store tch_data + 2 header bytes, the amr variable set to - * 2 will allow us to skip the first 2 bytes in case we did - * receive an FACCH frame instead of a voice frame (we do not - * know this before we actually decode the frame) */ - amr = 2; + /* Store AMR payload in tch-data with an offset od 2 bytes, so + that we can easily prepend/fill the RTP AMR header (struct + amr_hdr) with osmo_amr_rtp_enc() later on. The amr variable + is used far below to account for the decoded offset in case + we receive an FACCH frame instead of a voice frame (we + do not know this before we actually decode the frame) */ + amr = sizeof(struct amr_hdr); rc = gsm0503_tch_afs_decode_dtx(tch_data + amr, *bursts_p, amr_is_cmr, chan_state->codec, chan_state->codecs, &chan_state->ul_ft, &chan_state->ul_cmr, &n_errors, &n_bits_total, &chan_state->amr_last_dtx); @@ -302,7 +306,7 @@ "not sending BFI\n", rc); return -EINVAL; } - memset(tch_data + 2, 0, rc - 2); + memset(tch_data + sizeof(struct amr_hdr), 0, rc - sizeof(struct amr_hdr)); break; default: LOGL1SB(DL1P, LOGL_ERROR, l1ts, bi, @@ -509,8 +513,8 @@ /* the first FN 4,13,21 defines that CMI is included in frame, * the first FN 0,8,17 defines that CMR is included in frame. */ - gsm0503_tch_afs_encode(*bursts_p, msg->l2h + 2, - msgb_l2len(msg) - 2, !dl_amr_fn_is_cmi(br->fn), + gsm0503_tch_afs_encode(*bursts_p, msg->l2h + sizeof(struct amr_hdr), + msgb_l2len(msg) - sizeof(struct amr_hdr), !dl_amr_fn_is_cmi(br->fn), chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index a5f6747..17073e0 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -35,6 +35,8 @@ #include <osmocom/coding/gsm0503_coding.h> #include <osmocom/coding/gsm0503_amr_dtx.h> +#include <osmocom/netif/amr.h> + #include <osmo-bts/bts.h> #include <osmo-bts/l1sap.h> #include <osmo-bts/logging.h> @@ -196,7 +198,7 @@ fn_is_cmi = sched_tchh_ul_amr_cmi_map[bi->fn % 26]; /* See comment in function rx_tchf_fn() */ - amr = 2; + amr = sizeof(struct amr_hdr); rc = gsm0503_tch_ahs_decode_dtx(tch_data + amr, *bursts_p, !sched_tchh_ul_facch_map[bi->fn % 26], !fn_is_cmi, chan_state->codec, @@ -336,7 +338,7 @@ "not sending BFI\n", rc); return -EINVAL; } - memset(tch_data + 2, 0, rc - 2); + memset(tch_data + sizeof(struct amr_hdr), 0, rc - sizeof(struct amr_hdr)); break; default: LOGL1SB(DL1P, LOGL_ERROR, l1ts, bi, @@ -436,8 +438,8 @@ /* the first FN 4,13,21 or 5,14,22 defines that CMI is included * in frame, the first FN 0,8,17 or 1,9,18 defines that CMR is * included in frame. */ - gsm0503_tch_ahs_encode(*bursts_p, msg->l2h + 2, - msgb_l2len(msg) - 2, !dl_amr_fn_is_cmi(br->fn), + gsm0503_tch_ahs_encode(*bursts_p, msg->l2h + sizeof(struct amr_hdr), + msgb_l2len(msg) - sizeof(struct amr_hdr), !dl_amr_fn_is_cmi(br->fn), chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); diff --git a/src/osmo-bts-virtual/Makefile.am b/src/osmo-bts-virtual/Makefile.am index 2b3d825..2ae53b4 100644 --- a/src/osmo-bts-virtual/Makefile.am +++ b/src/osmo-bts-virtual/Makefile.am @@ -6,6 +6,7 @@ $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(NULL) @@ -18,6 +19,7 @@ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ -ldl \ $(NULL) diff --git a/tests/agch/Makefile.am b/tests/agch/Makefile.am index 2bb4144..f77341a 100644 --- a/tests/agch/Makefile.am +++ b/tests/agch/Makefile.am @@ -7,6 +7,7 @@ $(LIBOSMOCODEC_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -15,6 +16,7 @@ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) check_PROGRAMS = agch_test diff --git a/tests/cipher/Makefile.am b/tests/cipher/Makefile.am index 0650d3d..13bface 100644 --- a/tests/cipher/Makefile.am +++ b/tests/cipher/Makefile.am @@ -7,6 +7,7 @@ $(LIBOSMOCODEC_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -15,6 +16,7 @@ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) check_PROGRAMS = cipher_test diff --git a/tests/handover/Makefile.am b/tests/handover/Makefile.am index f850a6f..beebaed 100644 --- a/tests/handover/Makefile.am +++ b/tests/handover/Makefile.am @@ -6,6 +6,7 @@ $(LIBOSMOCODEC_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -13,6 +14,7 @@ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) check_PROGRAMS = handover_test diff --git a/tests/meas/Makefile.am b/tests/meas/Makefile.am index e75481f..0af192f 100644 --- a/tests/meas/Makefile.am +++ b/tests/meas/Makefile.am @@ -6,6 +6,7 @@ $(LIBOSMOCODEC_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -13,6 +14,7 @@ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOTRAU_LIBS) \ $(LIBOSMOABIS_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) check_PROGRAMS = meas_test diff --git a/tests/misc/Makefile.am b/tests/misc/Makefile.am index f3cc734..fd6ebf3 100644 --- a/tests/misc/Makefile.am +++ b/tests/misc/Makefile.am @@ -6,6 +6,7 @@ $(LIBOSMOCODEC_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -13,7 +14,9 @@ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) + check_PROGRAMS = misc_test EXTRA_DIST = misc_test.ok diff --git a/tests/paging/Makefile.am b/tests/paging/Makefile.am index d5b090c..0c01e39 100644 --- a/tests/paging/Makefile.am +++ b/tests/paging/Makefile.am @@ -7,6 +7,7 @@ $(LIBOSMOCODEC_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -15,6 +16,7 @@ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) check_PROGRAMS = paging_test diff --git a/tests/power/Makefile.am b/tests/power/Makefile.am index 149d691..7b9ae27 100644 --- a/tests/power/Makefile.am +++ b/tests/power/Makefile.am @@ -6,6 +6,7 @@ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -13,6 +14,7 @@ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) check_PROGRAMS = ms_power_loop_test bs_power_loop_test diff --git a/tests/sysmobts/Makefile.am b/tests/sysmobts/Makefile.am index 59d68fa..2796136 100644 --- a/tests/sysmobts/Makefile.am +++ b/tests/sysmobts/Makefile.am @@ -12,6 +12,7 @@ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -20,6 +21,7 @@ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) check_PROGRAMS = sysmobts_test diff --git a/tests/tx_power/Makefile.am b/tests/tx_power/Makefile.am index f59f0c0..ae57a40 100644 --- a/tests/tx_power/Makefile.am +++ b/tests/tx_power/Makefile.am @@ -6,6 +6,7 @@ $(LIBOSMOCODEC_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMONETIF_CFAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ @@ -13,6 +14,7 @@ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMONETIF_LIBS) \ $(NULL) check_PROGRAMS = tx_power_test EXTRA_DIST = tx_power_test.ok tx_power_test.err -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I607fdf6d627242e010fba35be1b9b0ffde820d08 Gerrit-Change-Number: 29274 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Initial support for forwarding AMR

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 ) Change subject: trxcon: Initial support for forwarding AMR ...................................................................... Patch Set 3: (1 comment) File src/host/trxcon/src/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/9573d52f_5f0968fa PS3, Line 56: ul_amr_fn_is_cmi > osmo-bts code uses also 2 different things for some reason I guess? AFAIR, it's only used in unit tests. I intentionally kept it while adding the lookup table, in order to avoid changing too many things in one patch. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331 Gerrit-Change-Number: 29264 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 18:23:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Initial support for forwarding AMR

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 ) Change subject: trxcon: Initial support for forwarding AMR ...................................................................... Patch Set 3: (1 comment) File src/host/trxcon/src/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/0dd1a8ce_80d4f7e4 PS3, Line 56: ul_amr_fn_is_cmi > This function can be replaced with sched_tchf_ul_amr_cmi_map[] from patchset 2. osmo-bts code uses also 2 different things for some reason I guess? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331 Gerrit-Change-Number: 29264 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:59:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Initial support for forwarding AMR

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 ) Change subject: trxcon: Initial support for forwarding AMR ...................................................................... Patch Set 3: (3 comments) File src/host/trxcon/src/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/69326fb0_b3b366c2 PS3, Line 47: sched_tchf_dl_amr_cmi_map Cool! Would you submit a patch to osmo-bts.git adding this table there? https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/b2f119a8_5972d30c PS3, Line 48: [11] = 1, /* TCH/F: a=4 / h=11 */ Please fix the alignment, I find the old variant a bit easier to read. https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/15131430_ca972957 PS3, Line 56: ul_amr_fn_is_cmi This function can be replaced with sched_tchf_ul_amr_cmi_map[] from patchset 2. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331 Gerrit-Change-Number: 29264 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:57:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Drop long time deprecated APIs

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29256 ) Change subject: osmux: Drop long time deprecated APIs ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I plan to merge this tomorrow if nobody is against it & providing a good reason to avoid it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853 Gerrit-Change-Number: 29256 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:52:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Initial support for forwarding AMR

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 ) Change subject: trxcon: Initial support for forwarding AMR ...................................................................... Patch Set 3: -Code-Review (1 comment) Patchset: PS3: With this new version of the patch I fixed several stuff which allows also passing BTS_Tests.TC_speech_rtp_tchf with AMR enabled. I submitted a patch to enable it. tch/h support is still missing, I'll write & submit a follow up patch adding support for it soon. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331 Gerrit-Change-Number: 29264 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:46:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Initial support for forwarding AMR

by pespin

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264 to look at the new patch set (#3). Change subject: trxcon: Initial support for forwarding AMR ...................................................................... trxcon: Initial support for forwarding AMR This allows TTCN3 L1CTL module (used in BTS_Tests) to transmit and receive AMR payloads towards osmo-bts-trx. Related: SYS#5987 Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331 --- M include/l1ctl_proto.h M src/host/layer23/src/common/l1ctl.c M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/include/osmocom/bb/l1sched/logging.h M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/trxcon_fsm.c M src/host/virt_phy/src/l1ctl_sap.c M src/target/firmware/layer1/l23_api.c 10 files changed, 219 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/29264/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331 Gerrit-Change-Number: 29264 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Osmux_Emulation: Add DATA port

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29273 ) Change subject: Osmux_Emulation: Add DATA port ...................................................................... Osmux_Emulation: Add DATA port Similar to what's already present in RTPEM_Emulation, this allows tests to retrieve the Osmux messages received. Related: OS#5987 Change-Id: Id9aa3a0a02ef5a5e39b4df8a1c165f35255829ab --- M library/OSMUX_Emulation.ttcn 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/29273/1 diff --git a/library/OSMUX_Emulation.ttcn b/library/OSMUX_Emulation.ttcn index 10338d2..c6999de 100644 --- a/library/OSMUX_Emulation.ttcn +++ b/library/OSMUX_Emulation.ttcn @@ -67,6 +67,8 @@ /* user-facing port for controlling the binding */ port OsmuxEM_CTRL_PT CTRL; + /* user-facing port for sniffing Osmux frames */ + port OsmuxEM_DATA_PT DATA; /* configurable by user, should be fixed */ var OsmuxemConfig g_cfg := c_OsmuxemDefaultCfg; @@ -190,6 +192,10 @@ OsmuxEM_stats_get, OsmuxEM_register_rxhandle, OsmuxEM_register_txhandle; } with { extension "internal" }; +type port OsmuxEM_DATA_PT message { + inout OSMUX_PDU; +} with { extension "internal" }; + function f_osmuxem_bind(OsmuxEM_CTRL_PT pt, in HostName local_host, inout PortNumber local_port) { pt.call(OsmuxEM_bind:{local_host, local_port}) { [] pt.getreply(OsmuxEM_bind:{local_host, ?}) -> param (local_port) {}; @@ -556,6 +562,9 @@ if (ispresent(g_cfg.rx_fixed_payload) and rx_osmux.msg.osmux_amr.data != payload_truncated) { g_stat.num_pkts_rx_err_payload := g_stat.num_pkts_rx_err_payload + 1; } + if (DATA.checkstate("Connected")) { + DATA.send(rx_osmux.msg); + } } /* process received Osmux Dummy if receiver enabled */ [g_rx_enabled] OSMUX.receive(tr_osmux_dummy) -> value rx_osmux { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9aa3a0a02ef5a5e39b4df8a1c165f35255829ab Gerrit-Change-Number: 29273 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: Test AMR in TC_speech_rtp_tch{h,f}()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29272 ) Change subject: bts: Test AMR in TC_speech_rtp_tch{h,f}() ...................................................................... bts: Test AMR in TC_speech_rtp_tch{h,f}() Related: SYS#5987 Requires: osmocom-bb.git Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 (trxcon) Change-Id: I8cf7792a00b0a858f6a02bf5cb0d283484b820eb --- M bts/BTS_Tests.ttcn M bts/gen_links.sh 2 files changed, 56 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/29272/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 646e5bf..ea53212 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -47,6 +47,8 @@ import from RSL_Emulation all; import from RTP_Emulation all; +import from AMR_Types all; + import from IPL4asp_Types all; import from TRXC_Types all; import from TRXC_CodecPort all; @@ -2542,6 +2544,28 @@ g_first_meas_res := true; } +private function get_start_amr_ft() runs on ConnHdlr return integer { + var integer start_nth; + if (g_pars.mr_conf.icmi) { + start_nth := 0; /* FIXME: implement 3GPP TS 45.009 3.4.3 */ + } else { + start_nth := g_pars.mr_conf.start_mode; + } + + var integer n := 0; + for (var integer i:= 7; i >= 0; i := i - 1) { + if (g_pars.mr_conf.amr_codec_modes[i] == '1'B) { + if (n == start_nth) { + return 7 - i; + } + n := n + 1; + } + } + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("mr_conf is wrong! ", g_pars.mr_conf)); + return 0; +} + /* Initialize and start the RTP emulation component for a ConnHdlr */ friend function f_rtpem_activate(inout octetstring payload, RtpemConfig cfg := c_RtpemDefaultCfg, @@ -2566,7 +2590,27 @@ { payload_len := 15; hdr := '00'O; } case (tr_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM2)) /* TCH/EFS */ { payload_len := 31; hdr := 'C0'O; } - case else { /* FIXME: also handle TCH/AFS and TCH/AHS */ + case (tr_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM3)) /* TCH/AFS */ + { + var integer amr_ft := get_start_amr_ft(); + payload_len := f_amrft_payload_len(amr_ft) + 2; + hdr := bit2oct(int2bit(amr_ft, 4) & /*CMR: */ + '00000'B & /* padding */ + int2bit(amr_ft, 4) & /* FT */ + '1'B & /* q */ + '00'B); /* padding */ + } + case (tr_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM3)) /* TCH/AHS */ + { + var integer amr_ft := get_start_amr_ft(); + payload_len := f_amrft_payload_len(amr_ft) + 2; + hdr := bit2oct(int2bit(amr_ft, 4) & /*CMR: */ + '00000'B & /* padding */ + int2bit(amr_ft, 4) & /* FT */ + '1'B & /* q */ + '00'B); /* padding */ + } + case else { setverdict(fail, "Unhandled RSL channel mode := ", g_pars.chan_mode); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } @@ -8147,7 +8191,11 @@ vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); vc_conn.done; - /* TODO: also test V3 (AMR codec) */ + /* TS1, TCH/F, V3 (AMR codec) */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), ts_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM3))); + pars.mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } @@ -8162,7 +8210,11 @@ vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); vc_conn.done; - /* TODO: also test V3 (AMR codec) */ + /* TS1, TCH/H0, V3 (AMR codec) */ + pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM3))); + pars.mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } diff --git a/bts/gen_links.sh b/bts/gen_links.sh index c8c2b98..b7ba2cc 100755 --- a/bts/gen_links.sh +++ b/bts/gen_links.sh @@ -44,6 +44,7 @@ FILES+="L3_Templates.ttcn L3_Common.ttcn " FILES+="Native_Functions.ttcn Native_FunctionDefs.cc " FILES+="TRXC_Types.ttcn TRXC_CodecPort.ttcn TRXC_CodecPort_CtrlFunct.ttcn TRXC_CodecPort_CtrlFunctDef.cc " +FILES+="AMR_Types.ttcn " FILES+="RTP_CodecPort.ttcn RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_Emulation.ttcn IuUP_EncDec.cc " FILES+="RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc " FILES+="PCUIF_Types.ttcn PCUIF_CodecPort.ttcn " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8cf7792a00b0a858f6a02bf5cb0d283484b820eb Gerrit-Change-Number: 29272 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: Implement RSL_IE_MultirateCfg and use it in BSC_Tests

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29268 to look at the new patch set (#3). Change subject: BSC: Implement RSL_IE_MultirateCfg and use it in BSC_Tests ...................................................................... BSC: Implement RSL_IE_MultirateCfg and use it in BSC_Tests Change-Id: I0a5ddce570c0fd70f096d897b0b609d20b552ff7 --- M bsc/BSC_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 35 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/29268/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a5ddce570c0fd70f096d897b0b609d20b552ff7 Gerrit-Change-Number: 29268 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022