August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: tests/rlcmac: remove unused #includes

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28951 ) Change subject: tests/rlcmac: remove unused #includes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib3315f61eb90704b1216094a80e9f379f4150d33 Gerrit-Change-Number: 28951 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 22:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-trx[master]: threshold_timer_update_intv(): call osmo_timer_del() unconditionally

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/28956 ) Change subject: threshold_timer_update_intv(): call osmo_timer_del() unconditionally ...................................................................... threshold_timer_update_intv(): call osmo_timer_del() unconditionally osmo_timer_del() does check if a timer is active internally. Change-Id: Icaf6f31a3235a3fb6993fa2bb35190150e35c2c2 --- M CommonLibs/trx_rate_ctr.cpp 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/56/28956/1 diff --git a/CommonLibs/trx_rate_ctr.cpp b/CommonLibs/trx_rate_ctr.cpp index a7467c1..3806268 100644 --- a/CommonLibs/trx_rate_ctr.cpp +++ b/CommonLibs/trx_rate_ctr.cpp @@ -312,8 +312,7 @@ return; if (llist_empty(&threshold_list)) { - if (osmo_timer_pending(&threshold_timer)) - osmo_timer_del(&threshold_timer); + osmo_timer_del(&threshold_timer); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icaf6f31a3235a3fb6993fa2bb35190150e35c2c2 Gerrit-Change-Number: 28956 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-pcu[master]: tests/rlcmac: cosmetic: fix coding style in arrays

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28954 ) Change subject: tests/rlcmac: cosmetic: fix coding style in arrays ...................................................................... tests/rlcmac: cosmetic: fix coding style in arrays Change-Id: I65a5313704f692c411714006def143cfdb7cc04a --- M tests/rlcmac/RLCMACTest.cpp 1 file changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/28954/1 diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index 9908a81..f2b0447 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -42,17 +42,17 @@ bitvec_unhex(resultVector, DUMMY_VEC); std::string testData[] = { - "4e082500e3f1a81d080820800b2b2b2b2b2b2b2b2b2b2b", // Packet Downlink Assignment - "48282407a6a07422720100032b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Assignment - "47240c00400000000000000079eb2ac9402b2b2b2b2b2b", // Packet Uplink Ack Nack - "47283c367513ba333004242b2b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Assignment - "400820001a3904df0680efb3300b2b2b2b2b2b2b2b2b2b", // Packet Downlink Assignment (EGPRS) - "40284f0000001009810c826f4406809dcecb2b2b2b2b2b", // Packet Uplink Assignment (EGPRS) - "4024030f2f0000000087b0042b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Ack Nack (EGPRS) - "4913e00850884013a8048b2b2b2b2b2b2b2b2b2b2b2b2b", // Polling Request (malformed) - "412430007fffffffffffffffefd19c7ba12b2b2b2b2b2b", // Packet Uplink Ack Nack? - "41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // System Info 13? - "40883c1493120000000012002b2b2b2b2b2b2b2b2b2b2b", // Pkt Paging Request (OS#4838) + "4e082500e3f1a81d080820800b2b2b2b2b2b2b2b2b2b2b", // Packet Downlink Assignment + "48282407a6a07422720100032b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Assignment + "47240c00400000000000000079eb2ac9402b2b2b2b2b2b", // Packet Uplink Ack Nack + "47283c367513ba333004242b2b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Assignment + "400820001a3904df0680efb3300b2b2b2b2b2b2b2b2b2b", // Packet Downlink Assignment (EGPRS) + "40284f0000001009810c826f4406809dcecb2b2b2b2b2b", // Packet Uplink Assignment (EGPRS) + "4024030f2f0000000087b0042b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Ack Nack (EGPRS) + "4913e00850884013a8048b2b2b2b2b2b2b2b2b2b2b2b2b", // Polling Request (malformed) + "412430007fffffffffffffffefd19c7ba12b2b2b2b2b2b", // Packet Uplink Ack Nack? + "41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // System Info 13? + "40883c1493120000000012002b2b2b2b2b2b2b2b2b2b2b", // Pkt Paging Request (OS#4838) }; int testDataSize = sizeof(testData)/sizeof(testData[0]); @@ -95,18 +95,18 @@ bitvec_unhex(resultVector, DUMMY_VEC); std::string testData[] = { - "400e1e61d11d2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Dummy Control Block - "400b8020000000000000002480e0032b2b2b2b2b2b2b2b", // Packet Downlink Ack/Nack - "4016713dc094270ca2ae57ef909006aa0fc0001f80222b", // Packet Resource Request - "401673c87f24af2632b25964200600000091000b780080", // Packet Resource Request (from keith) - "40200ffc0021ec010b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // EPDAN - "400a9020000000000000003010012a0800132b2b2b2b2b", // Packet Downlink Ack/Nack ? + "400e1e61d11d2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Dummy Control Block + "400b8020000000000000002480e0032b2b2b2b2b2b2b2b", // Packet Downlink Ack/Nack + "4016713dc094270ca2ae57ef909006aa0fc0001f80222b", // Packet Resource Request + "401673c87f24af2632b25964200600000091000b780080", // Packet Resource Request (from keith) + "40200ffc0021ec010b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // EPDAN + "400a9020000000000000003010012a0800132b2b2b2b2b", // Packet Downlink Ack/Nack ? - /* Packet Resource Request (see OS#4955, mistakes in 3GPP TS 44.060) */ - "4117ea1b903eaeb2686564b2330820078000102b2b2b2b", - "40167e49f7f8ef2632b2596620060000806d00541c0080", - "4017787174d92eba686564b2ccc30800a000040b2b2b2b", - "4017e5b2cd5a2eca68655e44aec84880139300412b2b2b", + /* Packet Resource Request (see OS#4955, mistakes in 3GPP TS 44.060) */ + "4117ea1b903eaeb2686564b2330820078000102b2b2b2b", + "40167e49f7f8ef2632b2596620060000806d00541c0080", + "4017787174d92eba686564b2ccc30800a000040b2b2b2b", + "4017e5b2cd5a2eca68655e44aec84880139300412b2b2b", }; int testDataSize = sizeof(testData)/sizeof(testData[0]); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I65a5313704f692c411714006def143cfdb7cc04a Gerrit-Change-Number: 28954 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-pcu[master]: tests/rlcmac: use ARRAY_SIZE macro

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28955 ) Change subject: tests/rlcmac: use ARRAY_SIZE macro ...................................................................... tests/rlcmac: use ARRAY_SIZE macro Change-Id: I6e9d95ef007e984d25403eb64f8aeab02e3fa8e7 --- M tests/rlcmac/RLCMACTest.cpp 1 file changed, 2 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/28955/1 diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index f2b0447..9ba7831 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -55,10 +55,8 @@ "40883c1493120000000012002b2b2b2b2b2b2b2b2b2b2b", // Pkt Paging Request (OS#4838) }; - int testDataSize = sizeof(testData)/sizeof(testData[0]); - cout << " DOWNLINK " << endl; - for (int i = 0; i < testDataSize; i++) + for (unsigned int i = 0; i < ARRAY_SIZE(testData); i++) { cout << "vector1 = " << testData[i] << endl; bitvec *vector = bitvec_alloc(23, test_ctx); @@ -109,11 +107,8 @@ "4017e5b2cd5a2eca68655e44aec84880139300412b2b2b", }; - int testDataSize = sizeof(testData)/sizeof(testData[0]); - - cout << " UPLINK " << endl; - for (int i = 0; i < testDataSize; i++) + for (unsigned int i = 0; i < ARRAY_SIZE(testData); i++) { cout << "vector1 = " << testData[i] << endl; bitvec *vector = bitvec_alloc(23, test_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6e9d95ef007e984d25403eb64f8aeab02e3fa8e7 Gerrit-Change-Number: 28955 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-pcu[master]: tests/rlcmac: remove unused #includes

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28951 ) Change subject: tests/rlcmac: remove unused #includes ...................................................................... tests/rlcmac: remove unused #includes Change-Id: Ib3315f61eb90704b1216094a80e9f379f4150d33 --- M tests/rlcmac/RLCMACTest.cpp 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/28951/1 diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index 30476c5..7b98d18 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -15,21 +15,14 @@ -//#include <BitVector.h> #include <iostream> -#include <cstdlib> #include <cstring> -#include <assert.h> #include "gprs_rlcmac.h" #include "decoding.h" extern "C" { -#include "pcu_vty.h" -#include <osmocom/vty/telnet_interface.h> -#include <osmocom/vty/logging.h> #include <osmocom/core/utils.h> #include <osmocom/core/msgb.h> -#include <osmocom/core/application.h> #include "csn1.h" #include "gsm_rlcmac.h" -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib3315f61eb90704b1216094a80e9f379f4150d33 Gerrit-Change-Number: 28951 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-pcu[master]: tests/rlcmac: remove unused printSizeofRLCMAC()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28952 ) Change subject: tests/rlcmac: remove unused printSizeofRLCMAC() ...................................................................... tests/rlcmac: remove unused printSizeofRLCMAC() Change-Id: I4858d1cb0c4ffb0a152b1d975e30d50efa6296a7 --- M tests/rlcmac/RLCMACTest.cpp 1 file changed, 0 insertions(+), 49 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/52/28952/1 diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index 7b98d18..b1241f6 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -33,54 +33,6 @@ void *tall_pcu_ctx; -void printSizeofRLCMAC() -{ - printf("*** %s ***\n", __func__); - cout << "sizeof RlcMacUplink_t " << sizeof(RlcMacUplink_t) << endl; - cout << "sizeof Packet_Cell_Change_Failure_t " << sizeof(Packet_Cell_Change_Failure_t) << endl; - cout << "sizeof Packet_Control_Acknowledgement_t " << sizeof(Packet_Control_Acknowledgement_t) << endl; - cout << "sizeof Packet_Downlink_Ack_Nack_t " << sizeof(Packet_Downlink_Ack_Nack_t) << endl; - cout << "sizeof EGPRS_PD_AckNack_t " << sizeof(EGPRS_PD_AckNack_t) << endl; - cout << "sizeof Packet_Uplink_Dummy_Control_Block_t " << sizeof(Packet_Uplink_Dummy_Control_Block_t) << endl; - cout << "sizeof Packet_Measurement_Report_t " << sizeof(Packet_Measurement_Report_t) << endl; - cout << "sizeof Packet_Resource_Request_t " << sizeof(Packet_Resource_Request_t) << endl; - cout << "sizeof Packet_Mobile_TBF_Status_t " << sizeof(Packet_Mobile_TBF_Status_t) << endl; - cout << "sizeof Packet_PSI_Status_t " << sizeof(Packet_PSI_Status_t) << endl; - cout << "sizeof Packet_Enh_Measurement_Report_t " << sizeof(Packet_Enh_Measurement_Report_t) << endl; - cout << "sizeof Packet_Cell_Change_Notification_t " << sizeof(Packet_Cell_Change_Notification_t) << endl; - cout << "sizeof Packet_SI_Status_t " << sizeof(Packet_SI_Status_t) << endl; - cout << "sizeof Additional_MS_Rad_Access_Cap_t " << sizeof(Additional_MS_Rad_Access_Cap_t) << endl; - cout << "sizeof Packet_Pause_t " << sizeof(Packet_Pause_t) << endl; - - cout << "sizeof RlcMacDownlink_t " << sizeof(RlcMacDownlink_t) << endl; - cout << "sizeof Packet_Access_Reject_t " << sizeof(Packet_Access_Reject_t) << endl; - cout << "sizeof Packet_Cell_Change_Order_t " << sizeof(Packet_Cell_Change_Order_t) << endl; - cout << "sizeof Packet_Downlink_Assignment_t " << sizeof(Packet_Downlink_Assignment_t) << endl; - cout << "sizeof Packet_Neighbour_Cell_Data_t " << sizeof(Packet_Neighbour_Cell_Data_t) << endl; - cout << "sizeof Packet_Serving_Cell_Data_t " << sizeof(Packet_Serving_Cell_Data_t) << endl; - cout << "sizeof Packet_Paging_Request_t " << sizeof(Packet_Paging_Request_t) << endl; - cout << "sizeof Packet_PDCH_Release_t " << sizeof(Packet_PDCH_Release_t) << endl; - cout << "sizeof Packet_Polling_Request_t " << sizeof(Packet_Polling_Request_t) << endl; - cout << "sizeof Packet_Power_Control_Timing_Advance_t " << sizeof(Packet_Power_Control_Timing_Advance_t) << endl; - cout << "sizeof Packet_PRACH_Parameters_t " << sizeof(Packet_PRACH_Parameters_t) << endl; - cout << "sizeof Packet_Queueing_Notification_t " << sizeof(Packet_Queueing_Notification_t) << endl; - cout << "sizeof Packet_Timeslot_Reconfigure_t " << sizeof(Packet_Timeslot_Reconfigure_t) << endl; - cout << "sizeof Packet_TBF_Release_t " << sizeof(Packet_TBF_Release_t) << endl; - cout << "sizeof Packet_Uplink_Ack_Nack_t " << sizeof(Packet_Uplink_Ack_Nack_t) << endl; - cout << "sizeof Packet_Uplink_Assignment_t " << sizeof(Packet_Uplink_Assignment_t) << endl; - cout << "sizeof Packet_Cell_Change_Continue_t " << sizeof(Packet_Cell_Change_Continue_t) << endl; - cout << "sizeof Packet_Handover_Command_t " << sizeof(Packet_Handover_Command_t) << endl; - cout << "sizeof Packet_PhysicalInformation_t " << sizeof(Packet_PhysicalInformation_t) << endl; - cout << "sizeof Packet_Downlink_Dummy_Control_Block_t " << sizeof(Packet_Downlink_Dummy_Control_Block_t) << endl; - cout << "sizeof PSI1_t " << sizeof(PSI1_t) << endl; - cout << "sizeof PSI2_t " << sizeof(PSI2_t) << endl; - cout << "sizeof PSI3_t " << sizeof(PSI3_t) << endl; - cout << "sizeof PSI3_BIS_t " << sizeof(PSI3_BIS_t) << endl; - cout << "sizeof PSI4_t " << sizeof(PSI4_t) << endl; - cout << "sizeof PSI13_t " << sizeof(PSI13_t) << endl; - cout << "sizeof PSI5_t " << sizeof(PSI5_t) << endl; -} - void testRlcMacDownlink(void *test_ctx) { printf("*** %s ***\n", __func__); @@ -872,7 +824,6 @@ log_set_print_level(osmo_stderr_target, 1); log_set_use_color(osmo_stderr_target, 0); - //printSizeofRLCMAC(); testRlcMacDownlink(ctx); testRlcMacUplink(ctx); testCsnLeftAlignedVarBmpBounds(ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4858d1cb0c4ffb0a152b1d975e30d50efa6296a7 Gerrit-Change-Number: 28952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-pcu[master]: tests/rlcmac: make all test functions static

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28953 ) Change subject: tests/rlcmac: make all test functions static ...................................................................... tests/rlcmac: make all test functions static Change-Id: Ia7f1615edf1cac630631c14ccaeebab758aa4f72 --- M tests/rlcmac/RLCMACTest.cpp 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/53/28953/1 diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index b1241f6..9908a81 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -33,7 +33,7 @@ void *tall_pcu_ctx; -void testRlcMacDownlink(void *test_ctx) +static void testRlcMacDownlink(void *test_ctx) { printf("*** %s ***\n", __func__); @@ -86,7 +86,7 @@ } -void testRlcMacUplink(void *test_ctx) +static void testRlcMacUplink(void *test_ctx) { printf("*** %s ***\n", __func__); @@ -140,7 +140,7 @@ bitvec_free(resultVector); } -void testCsnLeftAlignedVarBmpBounds(void *test_ctx) +static void testCsnLeftAlignedVarBmpBounds(void *test_ctx) { printf("*** %s ***\n", __func__); @@ -168,7 +168,7 @@ int encode_gsm_ra_cap(struct bitvec *vector, MS_Radio_Access_capability_t * data); } -void testRAcap(void *test_ctx) +static void testRAcap(void *test_ctx) { printf("*** %s ***\n", __func__); MS_Radio_Access_capability_t data; @@ -237,7 +237,7 @@ printf("decode_gsm_ra_cap() returns %d\n", rc); } -void testMalformedRAcap(void *test_ctx) +static void testMalformedRAcap(void *test_ctx) { printf("*** %s ***\n", __func__); MS_Radio_Access_capability_t data; @@ -280,7 +280,7 @@ } /* Reproduce crash from ticket OS#4463 */ -void testRAcap2(void *test_ctx) +static void testRAcap2(void *test_ctx) { printf("*** %s ***\n", __func__); MS_Radio_Access_capability_t data; @@ -421,7 +421,7 @@ } /* RAcap larger than 23 bytes */ -void testRAcap3(void *test_ctx) +static void testRAcap3(void *test_ctx) { printf("*** %s ***\n", __func__); MS_Radio_Access_capability_t data; @@ -618,7 +618,7 @@ } /* RAcap larger than 23 bytes */ -void testRAcap4(void *test_ctx) +static void testRAcap4(void *test_ctx) { printf("*** %s ***\n", __func__); MS_Radio_Access_capability_t data; @@ -759,7 +759,7 @@ bitvec_free(bv_dec); } -void testEGPRSPktChReq(void *test_ctx) +static void testEGPRSPktChReq(void *test_ctx) { EGPRS_PacketChannelRequest_t req; int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia7f1615edf1cac630631c14ccaeebab758aa4f72 Gerrit-Change-Number: 28953 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_create_nack_mme

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 ) Change subject: cbc: Introduce test TC_create_nack_mme ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File cbc/CBC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945/comment/3ff10f51_926a… PS1, Line 726: write_repl_unknown_TAIs > unused? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36 Gerrit-Change-Number: 28945 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 20:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_create_nack_mme

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 to look at the new patch set (#2). Change subject: cbc: Introduce test TC_create_nack_mme ...................................................................... cbc: Introduce test TC_create_nack_mme Related: OS#4945 Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36 --- M cbc/CBC_Tests.ttcn M cbc/MME_ConnectionHandler.ttcn 2 files changed, 23 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/28945/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36 Gerrit-Change-Number: 28945 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: remove unneded template local var

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28942 ) Change subject: cbc: remove unneded template local var ...................................................................... cbc: remove unneded template local var Change-Id: I31f751f5c61de545d038d9e63e01188c3ae5f161 --- M cbc/CBC_Tests.ttcn 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 83cf07d..437ba0b 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -345,13 +345,9 @@ } private function f_bsc_create_and_delete() runs on BSC_ConnHdlr { - var template (omit) BSSMAP_FIELD_CellIdentificationList cell_list_success := omit; - if (ispresent(g_pars.cell_list_success)) { - cell_list_success := g_pars.cell_list_success; - } - f_cbsp_handle_write(g_pars.exp_cbs_msg, 0, cell_list_success); + f_cbsp_handle_write(g_pars.exp_cbs_msg, 0, g_pars.cell_list_success); f_cbsp_handle_kill(0, g_pars.exp_cbs_msg.msg_id, g_pars.exp_cbs_msg.ser_nr, - exp_list:=cell_list_success, tx_list:=cell_list_success, + exp_list:=g_pars.cell_list_success, tx_list:=g_pars.cell_list_success, tx_fail_list:=omit, tx_compl_list:=omit, channel_ind:=g_pars.exp_cbs_msg.channel_ind); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I31f751f5c61de545d038d9e63e01188c3ae5f161 Gerrit-Change-Number: 28942 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022