lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

August 2022

  • 3 participants
  • 2402 discussions
Change in osmo-msc[master]: contrib/jenkins.sh: do not override parallel make for libsmpp34
by osmith 29 Aug '22

29 Aug '22
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29222 ) Change subject: contrib/jenkins.sh: do not override parallel make for libsmpp34 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 08:57:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic
by osmith 29 Aug '22

29 Aug '22
Attention is currently required from: neels, laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 ) Change subject: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 Gerrit-Change-Number: 29202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 08:56:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-msc[master]: contrib/jenkins.sh: do not override parallel make for libsmpp34
by fixeria 28 Aug '22

28 Aug '22
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/29222 ) Change subject: contrib/jenkins.sh: do not override parallel make for libsmpp34 ...................................................................... contrib/jenkins.sh: do not override parallel make for libsmpp34 Parallel build has been fixed [1] and re-enabled [2] back in 2018. Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Related: [1] I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12 libsmpp34.git Related: [2] Id41fbcb5a96093eb6c3dc00bcacbd379111ada70 libsmpp34.git --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/29222/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fb858d7..e1bbad4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -35,7 +35,7 @@ osmo-build-dep.sh libosmo-abis osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp -PARALLEL_MAKE="" osmo-build-dep.sh libsmpp34 +osmo-build-dep.sh libsmpp34 osmo-build-dep.sh osmo-mgw osmo-build-dep.sh osmo-hlr -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-smlc[master]: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL...
by fixeria 28 Aug '22

28 Aug '22
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29221 ) Change subject: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/21/29221/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 939a514..62e6516 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -58,12 +58,12 @@ || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" \ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ - $MAKE distcheck \ + $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi -$MAKE maintainer-clean +$MAKE $PARALLEL_MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 Gerrit-Change-Number: 29221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-cbc[master]: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE
by fixeria 28 Aug '22

28 Aug '22
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29220 ) Change subject: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/20/29220/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 0848bea..f3331af 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -51,7 +51,7 @@ ./configure --enable-sanitize --enable-werror --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ - $MAKE distcheck \ + $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh $MAKE $PARALLEL_MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 Gerrit-Change-Number: 29220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE
by fixeria 28 Aug '22

28 Aug '22
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: actually build with $PARALLEL_MAKE Executing $MAKE without $PARALLEL_MAKE builds the project with -j1. Executing $MAKE with $PARALLEL_MAKE after that makes no sense, because everything is already compiled and there is nothing to do. Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 --- M contrib/jenkins.sh 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/19/29219/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 3b4e639..7a75e25 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -7,7 +7,6 @@ autoreconf --install --force ./configure --enable-sanitize --enable-werror -$MAKE $MAKE $PARALLEL_MAKE $MAKE distcheck || cat-testlogs.sh $MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-cbc[master]: contrib/jenkins.sh: also execute maintainer-clean target
by fixeria 28 Aug '22

28 Aug '22
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29218 ) Change subject: contrib/jenkins.sh: also execute maintainer-clean target ...................................................................... contrib/jenkins.sh: also execute maintainer-clean target Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/18/29218/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 104ba2a..0848bea 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -53,6 +53,7 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE $PARALLEL_MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c Gerrit-Change-Number: 29218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-hnbgw[master]: debian,RPM: package with PFCP support
by neels 27 Aug '22

27 Aug '22
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 ) Change subject: debian,RPM: package with PFCP support ...................................................................... debian,RPM: package with PFCP support - depend on libosmo-pfcp - configure --enable-pfcp Related: SYS#5895 Change-Id: I54dfe600d45541fecbb4c05bf75f147934c230f0 --- M contrib/osmo-hnbgw.spec.in M debian/control M debian/rules 3 files changed, 5 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/osmo-hnbgw.spec.in b/contrib/osmo-hnbgw.spec.in index a4379fa..75b1e51 100644 --- a/contrib/osmo-hnbgw.spec.in +++ b/contrib/osmo-hnbgw.spec.in @@ -45,6 +45,7 @@ BuildRequires: pkgconfig(libosmo-hnbap) >= 1.3.0 BuildRequires: pkgconfig(libosmo-ranap) >= 1.3.0 BuildRequires: pkgconfig(libosmo-rua) >= 1.3.0 +BuildRequires: pkgconfig(libosmo-pfcp) >= 0.1.0 BuildRequires: pkgconfig(talloc) BuildRequires: pkgconfig(libasn1c) >= 0.9.30 %{?systemd_requires} @@ -60,7 +61,8 @@ autoreconf -fi %configure \ --docdir=%{_docdir}/%{name} \ - --with-systemdsystemunitdir=%{_unitdir} + --with-systemdsystemunitdir=%{_unitdir} \ + --enable-pfcp make %{?_smp_mflags} %install diff --git a/debian/control b/debian/control index 3fe8035..0aed0f4 100644 --- a/debian/control +++ b/debian/control @@ -21,6 +21,7 @@ libosmo-hnbap-dev (>= 1.3.0), libosmo-ranap-dev (>= 1.3.0), libosmo-rua-dev (>= 1.3.0), + libosmo-pfcp-dev (>= 0.1.0), osmo-gsm-manuals-dev (>= 1.3.0) Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/osmo-hnbgw diff --git a/debian/rules b/debian/rules index bce8ed6..f341a84 100755 --- a/debian/rules +++ b/debian/rules @@ -46,6 +46,7 @@ # debmake generated override targets CONFIGURE_FLAGS += --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals +CONFIGURE_FLAGS += --enable-pfcp override_dh_auto_configure: dh_auto_configure -- $(CONFIGURE_FLAGS) # -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I54dfe600d45541fecbb4c05bf75f147934c230f0 Gerrit-Change-Number: 29002 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-hnbgw[master]: debian,RPM: package with PFCP support
by neels 27 Aug '22

27 Aug '22
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 ) Change subject: debian,RPM: package with PFCP support ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: libosmo-pfcp shows as succeeded in obs for nightly and latest; it is disabled on CentOS7, but so is osmo-hnbgw. my "home" build on obs worked, so this should succeed now... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I54dfe600d45541fecbb4c05bf75f147934c230f0 Gerrit-Change-Number: 29002 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 27 Aug 2022 16:02:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
Change in osmo-bts[master]: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY
by fixeria 27 Aug '22

27 Aug '22
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29217 ) Change subject: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY ...................................................................... osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY The PRIM_INFO_MODIFY is sent on receipt of the RSL MODE MODIFY message, which may optionally contain new ciphering parameters. Before this patch, osmo-bts-trx would ignore the new parameters and continue using the old ciphering key/algorithm. * Modify l1if_set_ciphering() to allow updating ciphering params. * Call l1if_set_ciphering() when handling PRIM_INFO_MODIFY. This problem was uncovered by BTS_Tests.TC_rsl_modify_encr, which has been failing ever since it was introduced [1]. This patch makes it pass. Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Related: [1] I4cbea499bb6a331d314e6573548a4540945208b5 osmo-ttcn3-hacks.git Related: OS#3750 --- M src/osmo-bts-trx/l1_if.c 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/29217/1 diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 92180b5..8c364c3 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -326,8 +326,8 @@ /* enable ciphering */ static int l1if_set_ciphering(struct gsm_lchan *lchan, uint8_t chan_nr, int downlink) { - /* ciphering already enabled in both directions */ - if (lchan->ciph_state == LCHAN_CIPH_RXTX_CONF) + /* ignore the request when the channel is not active */ + if (lchan->state != LCHAN_S_ACTIVE) return -EINVAL; if (!downlink) { @@ -463,6 +463,13 @@ lchan->tch.amr_mr.mode[3].mode, amr_get_initial_mode(lchan), 0); + /* update ciphering params */ + l1if_set_ciphering(lchan, chan_nr, 0); + l1if_set_ciphering(lchan, chan_nr, 1); + if (lchan->encr.alg_id) + lchan->ciph_state = LCHAN_CIPH_RXTX_CONF; + else + lchan->ciph_state = LCHAN_CIPH_NONE; break; } /* here, type == PRIM_INFO_DEACTIVATE */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Gerrit-Change-Number: 29217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 15
  • 16
  • 17
  • 18
  • 19
  • 20
  • 21
  • ...
  • 241
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.