Attention is currently required from: wbokslag.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28926 )
Change subject: when traffic dump directory is specified, now prints error message and exits instead of crashing when traffic file cannot be written
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I273e07aefd9faea13662f6699a6f3b074c8efe88
Gerrit-Change-Number: 28926
Gerrit-PatchSet: 4
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Comment-Date: Tue, 09 Aug 2022 15:40:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: daniel.
wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28926 )
Change subject: when traffic dump directory is specified, now prints error message and exits instead of crashing when traffic file cannot be written
......................................................................
Patch Set 4:
(1 comment)
File src/lower_mac/tetra_lower_mac.c:
https://gerrit.osmocom.org/c/osmo-tetra/+/28926/comment/e95722f0_2813fb14
PS3, Line 200: fprintf(stderr, "could not open dump file %s for writing\n", fname);
> You could use perror or a strerror variant to include the reason it failed.
Good idea, pushed a revised version that prints the error message through strerror
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I273e07aefd9faea13662f6699a6f3b074c8efe88
Gerrit-Change-Number: 28926
Gerrit-PatchSet: 4
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Aug 2022 15:31:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: wbokslag.
Hello Jenkins Builder, laforge, daniel,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-tetra/+/28926
to look at the new patch set (#4).
Change subject: when traffic dump directory is specified, now prints error message and exits instead of crashing when traffic file cannot be written
......................................................................
when traffic dump directory is specified, now prints error message and exits instead of crashing when traffic file cannot be written
Change-Id: I273e07aefd9faea13662f6699a6f3b074c8efe88
---
M src/lower_mac/tetra_lower_mac.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/26/28926/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I273e07aefd9faea13662f6699a6f3b074c8efe88
Gerrit-Change-Number: 28926
Gerrit-PatchSet: 4
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-MessageType: newpatchset
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Tumbleweed/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hnbgw
Last lines of build log:
[ 18s] checking for LIBOSMOGSM... yes
[ 18s] checking for LIBOSMONETIF... yes
[ 18s] checking for LIBOSMOSIGTRAN... yes
[ 18s] checking for LIBOSMORUA... yes
[ 18s] checking for LIBOSMORANAP... yes
[ 18s] checking for LIBOSMOHNBAP... yes
[ 18s] checking for LIBOSMOMGCPCLIENT... yes
[ 18s] checking for LIBOSMOGTLV... no
[ 18s] configure: error: Package requirements (libosmo-gtlv >= 0.1.0) were not met:
[ 18s]
[ 18s] Package 'libosmo-gtlv', required by 'virtual:world', not found
[ 18s]
[ 18s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 18s] installed software in a non-standard prefix.
[ 18s]
[ 18s] Alternatively, you may set the environment variables LIBOSMOGTLV_CFLAGS
[ 18s] and LIBOSMOGTLV_LIBS to avoid the need to call pkg-config.
[ 18s] See the pkg-config man page for more details.
[ 18s] error: Bad exit status from /var/tmp/rpm-tmp.PIrOLU (%build)
[ 18s]
[ 18s] RPM build errors:
[ 18s] Bad exit status from /var/tmp/rpm-tmp.PIrOLU (%build)
[ 18s] ### VM INTERACTION START ###
[ 18s] [ 14.526952][ T1] sysrq: Power Off
[ 18s] [ 14.528709][ T18] reboot: Power down
[ 18s] ### VM INTERACTION END ###
[ 18s]
[ 18s] goat03 failed "build osmo-hnbgw.spec" at Tue Aug 9 13:27:10 UTC 2022.
[ 18s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Tumbleweed/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hnbgw
Last lines of build log:
[ 26s] checking for LIBOSMOGSM... yes
[ 26s] checking for LIBOSMONETIF... yes
[ 26s] checking for LIBOSMOSIGTRAN... yes
[ 26s] checking for LIBOSMORUA... yes
[ 26s] checking for LIBOSMORANAP... yes
[ 26s] checking for LIBOSMOHNBAP... yes
[ 26s] checking for LIBOSMOMGCPCLIENT... yes
[ 27s] checking for LIBOSMOGTLV... no
[ 27s] configure: error: Package requirements (libosmo-gtlv >= 0.1.0) were not met:
[ 27s]
[ 27s] Package 'libosmo-gtlv', required by 'virtual:world', not found
[ 27s]
[ 27s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 27s] installed software in a non-standard prefix.
[ 27s]
[ 27s] Alternatively, you may set the environment variables LIBOSMOGTLV_CFLAGS
[ 27s] and LIBOSMOGTLV_LIBS to avoid the need to call pkg-config.
[ 27s] See the pkg-config man page for more details.
[ 27s] error: Bad exit status from /var/tmp/rpm-tmp.iWly62 (%build)
[ 27s]
[ 27s] RPM build errors:
[ 27s] Bad exit status from /var/tmp/rpm-tmp.iWly62 (%build)
[ 27s] ### VM INTERACTION START ###
[ 27s] [ 22.395588][ T1] sysrq: Power Off
[ 27s] [ 22.402733][ T18] reboot: Power down
[ 27s] ### VM INTERACTION END ###
[ 27s]
[ 27s] sheep83 failed "build osmo-hnbgw.spec" at Tue Aug 9 12:54:25 UTC 2022.
[ 27s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Attention is currently required from: rauf.gyulaliev(a)fairwaves.co, ipse, pespin, lynxis lazus.
lynxis lazus has uploaded a new patch set (#5) to the change originally created by rauf.gyulaliev(a)fairwaves.co. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 )
Change subject: Initial XTRX support
......................................................................
Initial XTRX support
Add dummy functions for
RxGain/TxGain/getPowerAttenuation/PowerAttenuation/TxPower
Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
---
M Transceiver52M/Makefile.am
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/xtrx/Makefile.am
A Transceiver52M/device/xtrx/XTRXDevice.cpp
A Transceiver52M/device/xtrx/XTRXDevice.h
M configure.ac
M contrib/systemd/Makefile.am
A contrib/systemd/osmo-trx-xtrx.service
M debian/control
A debian/osmo-trx-xtrx.install
M doc/examples/Makefile.am
A doc/examples/osmo-trx-xtrx/osmo-trx-xtrx.cfg
12 files changed, 757 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/15685/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: rauf.gyulaliev(a)fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris(a)gmail.com>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: rauf.gyulaliev(a)fairwaves.co
Gerrit-Attention: ipse <Alexander.Chemeris(a)gmail.com>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset