July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28518 ) Change subject: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized ...................................................................... lchan_select: fix 'chan_alloc_reverse' may be used uninitialized GCC 12.1.0 emits -Wmaybe-uninitialized when building with '-O2'. In function 'populate_ts_list', inlined from 'lchan_avail_by_type' at src/osmo-bsc/lchan_select.c:356:2: src/osmo-bsc/lchan_select.c:248:12: warning: 'chan_alloc_reverse' may be used uninitialized [-Wmaybe-uninitialized] 248 | if (chan_alloc_reverse) { | ^ src/osmo-bsc/lchan_select.c: In function 'lchan_avail_by_type': src/osmo-bsc/lchan_select.c:326:14: note: 'chan_alloc_reverse' was declared here 326 | bool chan_alloc_reverse; | ^~~~~~~~~~~~~~~~~~ This could only happen if in 'enum lchan_select_reason' we had items that are not handled in lchan_avail_by_type(), but this is not the case. Make GCC happy by initializing chan_alloc_reverse to false. Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 --- M src/osmo-bsc/lchan_select.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c index ebc7ede..0ccdb6a 100644 --- a/src/osmo-bsc/lchan_select.c +++ b/src/osmo-bsc/lchan_select.c @@ -323,7 +323,7 @@ enum gsm_phys_chan_config first, first_cbch, second, second_cbch; struct lchan_select_ts_list ts_list; bool sort_by_trx_power = false; - bool chan_alloc_reverse; + bool chan_alloc_reverse = false; if (log) { LOG_BTS(bts, DRLL, LOGL_DEBUG, "lchan_avail_by_type(type=%s, reason=%s)\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 Gerrit-Change-Number: 28518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc/Makefile.am: fix undefined reference to symbol pow()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28519 ) Change subject: osmo-bsc/Makefile.am: fix undefined reference to symbol pow() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 Gerrit-Change-Number: 28519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:25:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc[master]: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28518 ) Change subject: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 Gerrit-Change-Number: 28518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:25:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc/Makefile.am: fix undefined reference to symbol pow()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28519 ) Change subject: osmo-bsc/Makefile.am: fix undefined reference to symbol pow() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 Gerrit-Change-Number: 28519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 16:25:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc/Makefile.am: fix undefined reference to symbol pow()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28519 ) Change subject: osmo-bsc/Makefile.am: fix undefined reference to symbol pow() ...................................................................... osmo-bsc/Makefile.am: fix undefined reference to symbol pow() When trying to build osmo-bsc using clang 14, I am getting this error: make[3]: Entering directory 'src/osmo-bsc' CCLD osmo-bsc /usr/bin/ld: ./.libs/libbsc.a(handover_decision_2.o): undefined reference to symbol 'pow@@GLIBC_2.29' /usr/bin/ld: /usr/lib/libm.so.6: error adding symbols: DSO missing from command line clang-14: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [Makefile:656: osmo-bsc] Error 1 We need to link with the math library to resolve this. Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 --- M src/osmo-bsc/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/28519/1 diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index 557178e..f075580 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -122,6 +122,7 @@ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(LIBOSMOMGCPCLIENT_LIBS) \ + -lm \ $(NULL) bin_PROGRAMS = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 Gerrit-Change-Number: 28519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-bsc[master]: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28518 ) Change subject: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 Gerrit-Change-Number: 28518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 14:28:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc[master]: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28518 ) Change subject: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized ...................................................................... lchan_select: fix 'chan_alloc_reverse' may be used uninitialized GCC 12.1.0 emits -Wmaybe-uninitialized when building with '-O2'. In function 'populate_ts_list', inlined from 'lchan_avail_by_type' at src/osmo-bsc/lchan_select.c:356:2: src/osmo-bsc/lchan_select.c:248:12: warning: 'chan_alloc_reverse' may be used uninitialized [-Wmaybe-uninitialized] 248 | if (chan_alloc_reverse) { | ^ src/osmo-bsc/lchan_select.c: In function 'lchan_avail_by_type': src/osmo-bsc/lchan_select.c:326:14: note: 'chan_alloc_reverse' was declared here 326 | bool chan_alloc_reverse; | ^~~~~~~~~~~~~~~~~~ This could only happen if in 'enum lchan_select_reason' we had items that are not handled in lchan_avail_by_type(), but this is not the case. Make GCC happy by initializing chan_alloc_reverse to false. Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 --- M src/osmo-bsc/lchan_select.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/28518/1 diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c index ebc7ede..0ccdb6a 100644 --- a/src/osmo-bsc/lchan_select.c +++ b/src/osmo-bsc/lchan_select.c @@ -323,7 +323,7 @@ enum gsm_phys_chan_config first, first_cbch, second, second_cbch; struct lchan_select_ts_list ts_list; bool sort_by_trx_power = false; - bool chan_alloc_reverse; + bool chan_alloc_reverse = false; if (log) { LOG_BTS(bts, DRLL, LOGL_DEBUG, "lchan_avail_by_type(type=%s, reason=%s)\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 Gerrit-Change-Number: 28518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28517 ) Change subject: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() ...................................................................... gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() Jumping to label 'error' before allocating memory and storing an address to pointer 'rim_cont_buf' would result in passing garbage to talloc_free(). Found with clang 14. Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b --- M src/gb/gprs_bssgp_rim.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c index 63b303e..71f7ea8 100644 --- a/src/gb/gprs_bssgp_rim.c +++ b/src/gb/gprs_bssgp_rim.c @@ -1064,7 +1064,6 @@ struct msgb *msg = bssgp_msgb_alloc(); struct bssgp_normal_hdr *bgph; uint8_t rim_ri_buf[BSSGP_RIM_ROUTING_INFO_MAXLEN]; - uint8_t *rim_cont_buf; int rc; if (!msg) @@ -1105,7 +1104,7 @@ /* Put RIM container */ if (pdu->decoded_present) { - rim_cont_buf = talloc_zero_size(msg, msg->data_len); + uint8_t *rim_cont_buf = talloc_zero_size(msg, msg->data_len); if (!rim_cont_buf) goto error; @@ -1130,8 +1129,10 @@ /* The API user must set the iei properly! */ OSMO_ASSERT(false); } - if (rc < 0) + if (rc < 0) { + talloc_free(rim_cont_buf); goto error; + } msgb_tvlv_put(msg, pdu->rim_cont_iei, rc, rim_cont_buf); talloc_free(rim_cont_buf); @@ -1143,7 +1144,6 @@ return msg; error: - talloc_free(rim_cont_buf); msgb_free(msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b Gerrit-Change-Number: 28517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28517 ) Change subject: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b Gerrit-Change-Number: 28517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 13:56:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28517 ) Change subject: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() ...................................................................... gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() Jumping to label 'error' before allocating memory and storing an address to pointer 'rim_cont_buf' would result in passing garbage to talloc_free(). Found with clang 14. Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b --- M src/gb/gprs_bssgp_rim.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/28517/1 diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c index 63b303e..71f7ea8 100644 --- a/src/gb/gprs_bssgp_rim.c +++ b/src/gb/gprs_bssgp_rim.c @@ -1064,7 +1064,6 @@ struct msgb *msg = bssgp_msgb_alloc(); struct bssgp_normal_hdr *bgph; uint8_t rim_ri_buf[BSSGP_RIM_ROUTING_INFO_MAXLEN]; - uint8_t *rim_cont_buf; int rc; if (!msg) @@ -1105,7 +1104,7 @@ /* Put RIM container */ if (pdu->decoded_present) { - rim_cont_buf = talloc_zero_size(msg, msg->data_len); + uint8_t *rim_cont_buf = talloc_zero_size(msg, msg->data_len); if (!rim_cont_buf) goto error; @@ -1130,8 +1129,10 @@ /* The API user must set the iei properly! */ OSMO_ASSERT(false); } - if (rc < 0) + if (rc < 0) { + talloc_free(rim_cont_buf); goto error; + } msgb_tvlv_put(msg, pdu->rim_cont_iei, rc, rim_cont_buf); talloc_free(rim_cont_buf); @@ -1143,7 +1144,6 @@ return msg; error: - talloc_free(rim_cont_buf); msgb_free(msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b Gerrit-Change-Number: 28517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022