July 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... rtp: Delay rtph ptr assign after validating length Make coverity happy, since this seems to spread as a tainted error further below. Related: Coverity CID#273000 Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d --- M src/rtp.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/rtp.c b/src/rtp.c index 5718c5f..5c06c42 100644 --- a/src/rtp.c +++ b/src/rtp.c @@ -89,13 +89,14 @@ struct rtp_hdr *osmo_rtp_get_hdr(struct msgb *msg) { - struct rtp_hdr *rtph = (struct rtp_hdr *)msg->data; + struct rtp_hdr *rtph; if (msg->len < sizeof(struct rtp_hdr)) { DEBUGPC(DLMUX, "received RTP frame too short (len = %d)\n", msg->len); return NULL; } + rtph = (struct rtp_hdr *)msg->data; if (rtph->version != RTP_VERSION) { DEBUGPC(DLMUX, "received RTP version %d not supported.\n", rtph->version); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by laforge

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Jul 2022 12:27:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by laforge

Attention is currently required from: pespin, fixeria. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Removed Code-Review-1 by fixeria <vyanitskiy(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 11 months

1
0
0 0

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/28479/comment/1baeb40d_896b8b4a PS1, Line 9: Make coverity happy > It still makes more sense to do it this way from procedural/logical point of view, so I don't see wh […] Agreed with Pau. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Jul 2022 11:44:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Move header files to include/osmocom/cbc/ dir

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28516 ) Change subject: Move header files to include/osmocom/cbc/ dir ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > would be interesting to state why (I guess for consistency with our other projects?) […] Yes, consistency with all other projects. Furthermore, we'll have more headers soon (include/osmocom/sbcap) so it made everything more aligned. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 Gerrit-Change-Number: 28516 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 Jul 2022 08:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28515 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... fixup: coverity: compile tests, but not execute them In change 82265bc46df2f5c54be71274330e43664cf6c7fc [1] I attempted to fix aaeab8c976a478309477e4200c1aef51407f6152 [2], however both pushd and popd commands are not available in plain shell. Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Fixes: [1] I92b648cd1e80399561067eae99426faed1ff1e25 Fixes: [2] Idf0714a59356633021be21acc47f9471d059b7fe --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index ba5f13a..11b7e5c 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -52,9 +52,7 @@ # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. files="$(git -C $proj grep -l check_PROGRAMS)" if [ -n "$files" ]; then - pushd $proj - sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files - popd + (cd $proj && sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files) fi done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Gerrit-Change-Number: 28515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28515 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > you could also simply have switched to bash? That would indeed make scripting a bit more comfortable. But most of the existing scripts seem to be using '/bin/sh', so I don't want to introduce inconsistency. I can tolerate the limits of '/bin/sh' given the low amount of my occasional contributions to osmo-ci :) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Gerrit-Change-Number: 28515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28515 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: you could also simply have switched to bash? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Gerrit-Change-Number: 28515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Move header files to include/osmocom/cbc/ dir

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28516 ) Change subject: Move header files to include/osmocom/cbc/ dir ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: would be interesting to state why (I guess for consistency with our other projects?) I personally think they should actually all be in src and only public (library) headers should be in include/osmocom/* :P -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 Gerrit-Change-Number: 28516 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc/Makefile.am: fix undefined reference to symbol pow()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28519 ) Change subject: osmo-bsc/Makefile.am: fix undefined reference to symbol pow() ...................................................................... osmo-bsc/Makefile.am: fix undefined reference to symbol pow() When trying to build osmo-bsc using clang 14, I am getting this error: make[3]: Entering directory 'src/osmo-bsc' CCLD osmo-bsc /usr/bin/ld: ./.libs/libbsc.a(handover_decision_2.o): undefined reference to symbol 'pow@@GLIBC_2.29' /usr/bin/ld: /usr/lib/libm.so.6: error adding symbols: DSO missing from command line clang-14: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [Makefile:656: osmo-bsc] Error 1 We need to link with the math library to resolve this. Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 --- M src/osmo-bsc/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index 557178e..f075580 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -122,6 +122,7 @@ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(LIBOSMOMGCPCLIENT_LIBS) \ + -lm \ $(NULL) bin_PROGRAMS = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 Gerrit-Change-Number: 28519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022