osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28522 )
Change subject: release-tarball-build-dist/Makefile: update
......................................................................
release-tarball-build-dist/Makefile: update
Adjust the Makefile as well after the docker container has been migrated
to debian 11 in Ib6039724a7200abce5252f95407047296b72cd51.
Change-Id: Ibebca7be7daccd17bbf1b382108d87eb5a93ecf1
---
M release-tarball-build-dist/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/28522/1
diff --git a/release-tarball-build-dist/Makefile b/release-tarball-build-dist/Makefile
index 10f0e20..736769d 100644
--- a/release-tarball-build-dist/Makefile
+++ b/release-tarball-build-dist/Makefile
@@ -1,3 +1,3 @@
-UPSTREAM_DISTRO=debian:stretch
-DISTRO=debian-stretch
+UPSTREAM_DISTRO=debian:bullseye
+DISTRO=debian-bullseye
include ../make/Makefile
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28522
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ibebca7be7daccd17bbf1b382108d87eb5a93ecf1
Gerrit-Change-Number: 28522
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28520 )
Change subject: stream: assert params are not NULL in send/recv functions
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Makes sense to me, but wouldn't the functions crash anyway when one of the parameters in questions is NULL?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28520
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie9e67396973128aba87b584be1a36e2a94dd0998
Gerrit-Change-Number: 28520
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 09:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, dexter.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 )
Change subject: MGCP_Test: fix TC_dlcx_wildcarded
......................................................................
Patch Set 1:
(1 comment)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494/comment/b4528d2c_63b9…
PS1, Line 1121: /* Query a the statsd once to ensure that intermediate results are pulled from the
> I don't know that exactly, but I remember we had the exact same problem (at another place) some time […]
I agree with Pau that the second call shouldn't be necessary. I would have expected a race condition, but there was already a sleep there.
Then, I think the stats reported are the maximum number during that reporting interval (it was changed some time ago). That would explain why you're seeing this behaviour. In that case I would rather call f_statsd_reset after the mgcp_transceive_mgw to clear the values.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3
Gerrit-Change-Number: 28494
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 09:47:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495 )
Change subject: MGCP_Test: add testcase TC_e1_dlcx_wildcarded
......................................................................
Patch Set 2:
(1 comment)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495/comment/5643a9df_41fe…
PS2, Line 2454: /* Query a the statsd once to ensure that intermediate results are pulled from the
> See my comment on previous patch.
(see my response in the previous patch)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6cfbd24982d1e72206f8237b2eaea52cdaebf9dc
Gerrit-Change-Number: 28495
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Jul 2022 15:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, daniel.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 )
Change subject: MGCP_Test: fix TC_dlcx_wildcarded
......................................................................
Patch Set 1:
(1 comment)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494/comment/47a0a9ac_4802…
PS1, Line 1121: /* Query a the statsd once to ensure that intermediate results are pulled from the
> Are you sure what you say is correct? IIRC there are no intermediate results at all, statsd are only […]
I don't know that exactly, but I remember we had the exact same problem (at another place) some time ago and the fix was also the same. Maybe Daniel knows more about this.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3
Gerrit-Change-Number: 28494
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Jul 2022 15:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment