Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28520 )
Change subject: stream: assert params are not NULL in send/recv functions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Makes sense to me, but wouldn't the functions crash anyway when one of the parameters in questions i […]
Yes, crashing is fine since it should not happen and if it happens it means the caller has some several problem, hence it's good to catch it early during develop time.
That's what I encountered while extending osmo-cbc, with the problem that the crash happened when accessing the null pointer so it was no obvious at all when the sigsegv was occuring. If instead of that, an assert is hit, then it's immediatelly obvios when looking at the program's output.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28520
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie9e67396973128aba87b584be1a36e2a94dd0998
Gerrit-Change-Number: 28520
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 11:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/28527
to look at the new patch set (#2).
Change subject: jobs/registry-update-base-images: drop old images
......................................................................
jobs/registry-update-base-images: drop old images
No need to mirror these images if we don't use them anymore.
Remove debian 8 and 9, and ubuntu zesty. The latter is the codename for
ubuntu 17.04, which is a non-LTS and was unsupported since 2018-01-13.
Related: OS#5601
Change-Id: If1c198038b0fd5faf0763172447962969448940e
---
M jobs/registry-update-base-images.yml
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/27/28527/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: If1c198038b0fd5faf0763172447962969448940e
Gerrit-Change-Number: 28527
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset