July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: scripts/osmocom-latest-packages.sh: build osmo-python-tests

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28533 ) Change subject: scripts/osmocom-latest-packages.sh: build osmo-python-tests ...................................................................... scripts/osmocom-latest-packages.sh: build osmo-python-tests Build the source package too, don't just checkout the sources. Related: OS#5604 Change-Id: I5b7c6b6849edbca44f45041a6e506f10933b5d43 --- M scripts/osmocom-latest-packages.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/33/28533/1 diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index a94c412..3efc101 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -223,6 +223,7 @@ build osmo-mgw build osmo-msc build osmo-bsc + build osmo-python-tests build simtrace2 build libosmo-dsp build osmo-sysmon -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5b7c6b6849edbca44f45041a6e506f10933b5d43 Gerrit-Change-Number: 28533 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in pysim[master]: sim-rest-server: Set Content-Type: application/json on response

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28531 ) Change subject: sim-rest-server: Set Content-Type: application/json on response ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib80a650f3e8d3e3ee6295db6de0981dfc23d3feb Gerrit-Change-Number: 28531 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 06 Jul 2022 14:41:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Improve error handling when forwarding ECBE msg to CBSP

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28532 ) Change subject: Improve error handling when forwarding ECBE msg to CBSP ...................................................................... Improve error handling when forwarding ECBE msg to CBSP Change-Id: Ie411409b3af8f7dd6913b522ea9ed3b58736dc9f --- M src/message_handling.c M src/smscb_peer_fsm.c 2 files changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/32/28532/1 diff --git a/src/message_handling.c b/src/message_handling.c index a8c8368..41b854a 100644 --- a/src/message_handling.c +++ b/src/message_handling.c @@ -132,9 +132,16 @@ switch (peer->proto) { case CBC_PEER_PROTO_CBSP: /* skip peers without any current CBSP connection */ - if (!peer->client.cbsp) - return 0; - cbsp = cbcmsg_to_cbsp(peer, cbcmsg); + if (!peer->client.cbsp) { + LOGP(DCBSP, LOGL_NOTICE, "[%s] Tx CBSP: not connected\n", + peer->name); + return -ENOTCONN; + } + if (!(cbsp = cbcmsg_to_cbsp(peer, cbcmsg))) { + LOGP(DCBSP, LOGL_ERROR, "[%s] Tx CBSP: msg gen failed\n", + peer->name); + return -EINVAL; + } cbsp_cbc_client_tx(peer->client.cbsp, cbsp); break; default: diff --git a/src/smscb_peer_fsm.c b/src/smscb_peer_fsm.c index 510c198..cc91e39 100644 --- a/src/smscb_peer_fsm.c +++ b/src/smscb_peer_fsm.c @@ -279,13 +279,17 @@ static void smscb_p_fsm_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct cbc_message_peer *mp = (struct cbc_message_peer *) fi->priv; + int rc; switch (event) { case SMSCB_E_CREATE: /* send it to peer */ - peer_new_cbc_message(mp->peer, mp->cbcmsg); - /* wait for peers' response */ - osmo_fsm_inst_state_chg(fi, SMSCB_S_WAIT_WRITE_ACK, 10, T_WAIT_WRITE_ACK); + rc = peer_new_cbc_message(mp->peer, mp->cbcmsg); + if (rc == 0) { + /* wait for peers' response */ + osmo_fsm_inst_state_chg(fi, SMSCB_S_WAIT_WRITE_ACK, 10, + T_WAIT_WRITE_ACK); + } break; default: OSMO_ASSERT(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ie411409b3af8f7dd6913b522ea9ed3b58736dc9f Gerrit-Change-Number: 28532 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in pysim[master]: sim-rest-server: Set Content-Type: application/json on response

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/28531 ) Change subject: sim-rest-server: Set Content-Type: application/json on response ...................................................................... sim-rest-server: Set Content-Type: application/json on response Change-Id: Ib80a650f3e8d3e3ee6295db6de0981dfc23d3feb --- M contrib/sim-rest-server.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/31/28531/1 diff --git a/contrib/sim-rest-server.py b/contrib/sim-rest-server.py index fb73ef8..a31aeed 100755 --- a/contrib/sim-rest-server.py +++ b/contrib/sim-rest-server.py @@ -50,6 +50,8 @@ return tp, scc, card +def set_headers(request): + request.setHeader('Content-Type', 'application/json') @route('/sim-auth-api/v1/slot/<int:slot>') def auth(request, slot): @@ -86,6 +88,7 @@ tp.disconnect() + set_headers(request) return json.dumps(res, indent=4) @route('/sim-info-api/v1/slot/<int:slot>') @@ -117,6 +120,7 @@ tp.disconnect() + set_headers(request) return json.dumps(res, indent=4) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib80a650f3e8d3e3ee6295db6de0981dfc23d3feb Gerrit-Change-Number: 28531 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmocom-latest-packages: add osmo-python-tests

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28530 ) Change subject: scripts/osmocom-latest-packages: add osmo-python-tests ...................................................................... scripts/osmocom-latest-packages: add osmo-python-tests Add it in the same place as in osmocom-nightly-packages.sh. Closes: OS#5604 Change-Id: I187c73f8dff6800abaaeb6126ace13142a8ae20d --- M scripts/osmocom-latest-packages.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index 18f9420..a94c412 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -183,6 +183,7 @@ checkout osmo-mgw checkout osmo-msc checkout osmo-bsc + checkout python/osmo-python-tests checkout simtrace2 checkout libosmo-dsp checkout osmo-sysmon -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I187c73f8dff6800abaaeb6126ace13142a8ae20d Gerrit-Change-Number: 28530 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmocom-latest-packages: add osmo-python-tests

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28530 ) Change subject: scripts/osmocom-latest-packages: add osmo-python-tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I187c73f8dff6800abaaeb6126ace13142a8ae20d Gerrit-Change-Number: 28530 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Jul 2022 14:24:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmo-netif[master]: stream: assert params are not NULL in send/recv functions

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28520 ) Change subject: stream: assert params are not NULL in send/recv functions ...................................................................... stream: assert params are not NULL in send/recv functions Change-Id: Ie9e67396973128aba87b584be1a36e2a94dd0998 --- M src/stream.c 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/stream.c b/src/stream.c index 4379212..e6b731c 100644 --- a/src/stream.c +++ b/src/stream.c @@ -870,6 +870,8 @@ * \param[in] msg Message buffer to enqueue in transmit queue */ void osmo_stream_cli_send(struct osmo_stream_cli *cli, struct msgb *msg) { + OSMO_ASSERT(cli); + OSMO_ASSERT(msg); msgb_enqueue(&cli->tx_queue, msg); osmo_fd_write_enable(&cli->ofd); } @@ -881,6 +883,8 @@ int osmo_stream_cli_recv(struct osmo_stream_cli *cli, struct msgb *msg) { int ret; + OSMO_ASSERT(cli); + OSMO_ASSERT(msg); ret = recv(cli->ofd.fd, msg->data, msg->data_len, 0); if (ret < 0) { @@ -1448,6 +1452,8 @@ * \param[in] msg Message buffer to enqueue in transmit queue */ void osmo_stream_srv_send(struct osmo_stream_srv *conn, struct msgb *msg) { + OSMO_ASSERT(conn); + OSMO_ASSERT(msg); if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) { LOGP(DLINP, LOGL_DEBUG, "Connection is being flushed and closed; ignoring new outgoing message\n"); return; @@ -1515,9 +1521,8 @@ int osmo_stream_srv_recv(struct osmo_stream_srv *conn, struct msgb *msg) { int ret; - - if (!msg) - return -EINVAL; + OSMO_ASSERT(conn); + OSMO_ASSERT(msg); switch (conn->srv->sk_domain) { case AF_UNIX: -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie9e67396973128aba87b584be1a36e2a94dd0998 Gerrit-Change-Number: 28520 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in libosmo-netif[master]: stream: assert params are not NULL in send/recv functions

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28520 ) Change subject: stream: assert params are not NULL in send/recv functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie9e67396973128aba87b584be1a36e2a94dd0998 Gerrit-Change-Number: 28520 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Jul 2022 14:23:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: jobs/registry-update-base-images: drop old images

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28527 ) Change subject: jobs/registry-update-base-images: drop old images ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If1c198038b0fd5faf0763172447962969448940e Gerrit-Change-Number: 28527 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Jul 2022 14:21:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: ci-docker-rebuild: drop debian-stretch-jenkins

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28526 ) Change subject: ci-docker-rebuild: drop debian-stretch-jenkins ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I572ff9624fba25d7d96af79d1229b614be1c11ba Gerrit-Change-Number: 28526 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Jul 2022 14:21:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022