Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407 )
Change subject: cbc: Introduce f_shutdown_helper() and call it in every test
......................................................................
Patch Set 2:
(1 comment)
File cbc/CBC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407/comment/db30fa97_36a4…
PS1, Line 135: private function f_shutdown_helper() runs on test_CT {
I think you could avoid adding a new function here by using Misc_Helpers.f_shutdown(), which basically does the same. BSC_Tests has its own f_shutdown_helper() because it also checks some talloc stuff...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I95e6f8a5a5c35d35662950e1105bdb17d2ca00de
Gerrit-Change-Number: 28407
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Jun 2022 10:57:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406
to look at the new patch set (#2).
Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
......................................................................
bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
This should avoid some sporadic failure sptted during tear down.
Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe
---
M bsc/BSC_Tests.ttcn
M bsc/BSC_Tests_CBSP.ttcn
2 files changed, 34 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/28406/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe
Gerrit-Change-Number: 28406
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 )
Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
......................................................................
Patch Set 1:
(1 comment)
File bsc/BSC_Tests_CBSP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/40c4103d_4373…
PS1, Line 15: friend module BSC_Tests;
By saying that BSC_Tests is a friend module, you basically allow BSC_Tests to import 'friendly' stuff from BSC_Tests_CBSP. However, I see no friend definitions in this module at all, so I don't think this is needed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe
Gerrit-Change-Number: 28406
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Jun 2022 10:54:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: iedemam.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/28405 )
Change subject: typo: SAC needs 16bit range, not 8bit as copied from RAC entry
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/28405
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I756fbab449151d912cde48f1da01d3b645b7627c
Gerrit-Change-Number: 28405
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 09:47:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment