June 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: osmo-gsm-tester: use debian's soapysdr-module-lms7

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28455 ) Change subject: osmo-gsm-tester: use debian's soapysdr-module-lms7 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie2408258eda407d9db6c2f0f5fbe475861756778 Gerrit-Change-Number: 28455 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 08:57:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-*: change mail recipients

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28458 ) Change subject: jobs/update-osmo-*: change mail recipients ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28458 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I95c22215dbe09d06d9458a980d15370440f67fd6 Gerrit-Change-Number: 28458 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 08:57:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: osmo-ci-docker-rebuild: don't always build osmo-gsm-tester

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28457 ) Change subject: osmo-ci-docker-rebuild: don't always build osmo-gsm-tester ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9191d6d54d516ce75f3f576f34463dcaad22c85a Gerrit-Change-Number: 28457 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 08:57:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: ansible/gsm-tester: use debian's soapysdr-module-lms7

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28456 ) Change subject: ansible/gsm-tester: use debian's soapysdr-module-lms7 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I957dc42df640e513554f54e597a12df05e0fd740 Gerrit-Change-Number: 28456 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 08:56:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-*: change mail recipients

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28458 ) Change subject: jobs/update-osmo-*: change mail recipients ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28458 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I95c22215dbe09d06d9458a980d15370440f67fd6 Gerrit-Change-Number: 28458 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 08:52:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: osmo-ci-docker-rebuild: don't always build osmo-gsm-tester

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28457 ) Change subject: osmo-ci-docker-rebuild: don't always build osmo-gsm-tester ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9191d6d54d516ce75f3f576f34463dcaad22c85a Gerrit-Change-Number: 28457 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 08:51:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: ansible/gsm-tester: use debian's soapysdr-module-lms7

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28456 ) Change subject: ansible/gsm-tester: use debian's soapysdr-module-lms7 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I957dc42df640e513554f54e597a12df05e0fd740 Gerrit-Change-Number: 28456 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 08:51:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in docker-playground[master]: osmo-gsm-tester: use debian's soapysdr-module-lms7

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28455 ) Change subject: osmo-gsm-tester: use debian's soapysdr-module-lms7 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie2408258eda407d9db6c2f0f5fbe475861756778 Gerrit-Change-Number: 28455 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 08:51:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: fix f_exp_rsl_etws(): add some guard time

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28445 ) Change subject: BSC_Tests_CBSP: fix f_exp_rsl_etws(): add some guard time ...................................................................... BSC_Tests_CBSP: fix f_exp_rsl_etws(): add some guard time Recently I noticed sporadic CBSP test case failures on Jenkins: Timeout waiting for RSL_OSMO_ETWS_CMD (disable) BSC_Tests_CBSP.ttcn:1209 BSC_Tests_CBSP control part BSC_Tests_CBSP.ttcn:1056 TC_cbsp_emerg_write_bts_cgi_cchan_disable The related timeout is set to 5.0 seconds in f_exp_rsl_etws(), what matches the Warning Period IE sent in CBSP WRITE-REPLACE message. Adding a debug log printing T.read on receipt of RSL_OSMO_ETWS_CMD reveals that we're cutting it too close: the message arrives just a few milliseconds before the timeout expires. f_exp_rsl_etws(): T := 4.999196s, remaining 0.000804s f_exp_rsl_etws(): T := 4.998683s, remaining 0.001317s f_exp_rsl_etws(): T := 4.999344s, remaining 0.000656s Let's increase the timeout value (+0.5s) to avoid sporadic failures. Change-Id: Ia40a268f9780ffbcfa2bb962d7c1ac25d16193de --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index cba8268..1373002 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -992,7 +992,7 @@ private function f_exp_rsl_etws(integer rsl_idx := 0, boolean enabled) runs on cbsp_test_CT { var template (present) octetstring tr_apdu; - timer T := 5.0; + timer T := 5.0 + 0.5; /* +0.5s guard */ if (enabled) { tr_apdu := f_gen_etws_pn(g_cbsp_ser_no, g_cbsp_msg_id); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia40a268f9780ffbcfa2bb962d7c1ac25d16193de Gerrit-Change-Number: 28445 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: cosmetic: move T.start closer to the alt statement

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28444 ) Change subject: BSC_Tests_CBSP: cosmetic: move T.start closer to the alt statement ...................................................................... BSC_Tests_CBSP: cosmetic: move T.start closer to the alt statement Change-Id: Ib84fadad77b908f0bb71d6fdefda2513ee510ce1 --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index 359a985..cba8268 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -993,7 +993,6 @@ private function f_exp_rsl_etws(integer rsl_idx := 0, boolean enabled) runs on cbsp_test_CT { var template (present) octetstring tr_apdu; timer T := 5.0; - T.start; if (enabled) { tr_apdu := f_gen_etws_pn(g_cbsp_ser_no, g_cbsp_msg_id); @@ -1001,6 +1000,7 @@ tr_apdu := ''O; } + T.start; alt { [] IPA_RSL[rsl_idx][0].receive(tr_ASP_RSL_UD(tr_RSL_OSMO_ETWS_CMD(t_RslChanNr_PCH_AGCH(0), tr_apdu))) { setverdict(pass); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib84fadad77b908f0bb71d6fdefda2513ee510ce1 Gerrit-Change-Number: 28444 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022