pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28047 )
Change subject: paging: start/stop credit_timer based on C0 running
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
TTCN3 tests seem to be fine running for a while and I also tested with a manual setup starting/stopping the BTS, everything looked fine so far.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b5b1a98115b4e9d821eb3330fc5b970a0e78a44
Gerrit-Change-Number: 28047
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 09 May 2022 18:08:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28047 )
Change subject: paging: start/stop credit_timer based on C0 running
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b5b1a98115b4e9d821eb3330fc5b970a0e78a44
Gerrit-Change-Number: 28047
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 May 2022 18:07:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28046 )
Change subject: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,bbtransc
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I206d4c7863a77fbab6a600126742a6a6b8fc3614
Gerrit-Change-Number: 28046
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 09 May 2022 18:07:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/28077
to look at the new patch set (#2).
Change subject: TbfTest: Reset MS timeout to 0 in test_tbf_dl_llc_loss()
......................................................................
TbfTest: Reset MS timeout to 0 in test_tbf_dl_llc_loss()
The timeout is set to a high value to avoid freeing the MS during main
loop iteration. Let's set it back to 0 to have a common free path in
test infrastructure.
Change-Id: I6dc4765163fde1a46574b49f3185aea65391e0d0
---
M tests/tbf/TbfTest.cpp
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/28077/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6dc4765163fde1a46574b49f3185aea65391e0d0
Gerrit-Change-Number: 28077
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-pcu/+/28078 )
Change subject: gprs_ms_stoage: Release all MS in ms_storage cleanup()
......................................................................
gprs_ms_stoage: Release all MS in ms_storage cleanup()
This makes sure all MS and TBF objects under a bts are freed when its
underlaying storage is freed (cleanup() is called).
Related: OS#5555
Change-Id: Idf3ad8b70c97313dec38a49d48cf36d6c9b404c7
---
M src/gprs_ms_storage.cpp
M tests/tbf/TbfTest.err
2 files changed, 139 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/28078/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Idf3ad8b70c97313dec38a49d48cf36d6c9b404c7
Gerrit-Change-Number: 28078
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/28078 )
Change subject: gprs_ms_stoage: Release all MS in ms_storage cleanup()
......................................................................
gprs_ms_stoage: Release all MS in ms_storage cleanup()
This makes sure all MS and TBF objects under a bts are freed when its
underlaying storage is freed (cleanup() is called).
Change-Id: Idf3ad8b70c97313dec38a49d48cf36d6c9b404c7
---
M src/gprs_ms_storage.cpp
M tests/tbf/TbfTest.err
2 files changed, 139 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/28078/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Idf3ad8b70c97313dec38a49d48cf36d6c9b404c7
Gerrit-Change-Number: 28078
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28077 )
Change subject: TbfTest: Reset MS timeout to 0 in test_tbf_dl_llc_loss()
......................................................................
TbfTest: Reset MS timeout to 0 in test_tbf_dl_llc_loss()
The timeout is set to a high value to avoid freeing the MS during main
loop iteration. Let's set it back to 0 to have a common free path in
test infrastructure.
Change-Id: I6dc4765163fde1a46574b49f3185aea65391e0d0
---
M tests/tbf/TbfTest.cpp
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/28077/1
diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp
index 585496a..eb85f60 100644
--- a/tests/tbf/TbfTest.cpp
+++ b/tests/tbf/TbfTest.cpp
@@ -622,6 +622,8 @@
fprintf(stderr, "=== end %s ===\n", __func__);
+ /* Restore MS release timeout to 0 to make sure it is freed immediatelly: */
+ ms_set_timeout(ms, 0);
TALLOC_FREE(the_pcu);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6dc4765163fde1a46574b49f3185aea65391e0d0
Gerrit-Change-Number: 28077
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange