Attention is currently required from: laforge, keith.
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28136 )
Change subject: smpp: Parse and use SMPP-provided validity period
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28136
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iad9f2697f045ed3bc0eb74c3a9730861f82e6c48
Gerrit-Change-Number: 28136
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-MessageType: deleteVote
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131 )
Change subject: stp: Fix sporadic failure in TC_ipa_to_m3ua_ni
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
other possible cause: we still have some messages in transit while we execute the f_vty_config, either on the wire between IUT and TITAN, or inside TITAN itself. Then some code before the f_vty_config() doesn't consume all the messages it generates?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ef08447d2e36b6948d3db4ec9d1459beebc9384
Gerrit-Change-Number: 28131
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 May 2022 05:15:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131 )
Change subject: stp: Fix sporadic failure in TC_ipa_to_m3ua_ni
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
I somehow doubt the theory. f_vty_config2() is implemented using f_vty_transceive_ret() which first sends the command and then executes f_vty_wait_for_prompt(), i.e. we wait after the IUT (stp in this case) has returned a prompt after executing the command.
Sice there is no multi-threading in the STP, this must be sufficient.
So either f_vty_wait_for_prompt() is broken and doesn't dod what we expect it to do, or the bug is something else than you suspect.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ef08447d2e36b6948d3db4ec9d1459beebc9384
Gerrit-Change-Number: 28131
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 May 2022 05:13:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment