May 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: pySim-shell: catch exceptions from walk() while exporting

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28162 ) Change subject: pySim-shell: catch exceptions from walk() while exporting ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3edc250ef2a84550c5b821a72e207e4d685790a5 Gerrit-Change-Number: 28162 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 May 2022 19:52:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in pysim[master]: pySim-shell: add export option to add CREATE FILE APDUs

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28161 ) Change subject: pySim-shell: add export option to add CREATE FILE APDUs ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/28161/comment/ff774aab_d60554c4 PS3, Line 556: self._cmd.poutput("apdu 00E00000%02x%s" % (int(len(self._cmd.rs.selected_file_fcp_hex)/2), str(self._cmd.rs.selected_file_fcp_hex))) I would have preferred if we actually generate the 'create file' command here. That would be readable with its arguments. But I understand that you don' have the decoded FCP here and a "raw" statement is more convenient (and less error-prone) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If529b86062f7c678c9c75f46ce9ca116cea8b47b Gerrit-Change-Number: 28161 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 May 2022 19:52:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in pysim[master]: pySim-shell: extend walk() so that we can also have action of ADF or DF

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28160 ) Change subject: pySim-shell: extend walk() so that we can also have action of ADF or DF ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iabcd78552a14a2d3f8f31273dda7731e1f640cdb Gerrit-Change-Number: 28160 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 May 2022 19:50:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in pysim[master]: pySim-shell: more generic export options

by laforge

Attention is currently required from: pespin, Christian Amsüss, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28159 ) Change subject: pySim-shell: more generic export options ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think the more pythonic way would be **kwargs instead of passing a custom dict? But then, I'm not a native Python speaker. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie860eec918e7cdb01651642f4bc2474c9fb1924f Gerrit-Change-Number: 28159 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 May 2022 19:50:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ci[master]: ansible/jenkins/osmocom_build_deps: drop py2 pkgs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28151 ) Change subject: ansible/jenkins/osmocom_build_deps: drop py2 pkgs ...................................................................... ansible/jenkins/osmocom_build_deps: drop py2 pkgs Drop python2 packages. It's deprecated, packages don't exist in debian 11 and our jenkins nodes don't need it anymore. Related: OS#5453 Change-Id: Id2da7adab83f240e7e0b45c018f91c9e639fc80d --- M ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml index 5cf0677..1cfb715 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml @@ -29,7 +29,6 @@ - mscgen - osc - pkgconf - - python-minimal - python-setuptools - python3 - python3-setuptools @@ -37,7 +36,6 @@ - texinfo # by gsm-manuals - python3-nwdiag - - python-pychart - inkscape # by gapk - libasound-dev -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id2da7adab83f240e7e0b45c018f91c9e639fc80d Gerrit-Change-Number: 28151 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci: gtp0-deb{10 => 11}build32

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28152 ) Change subject: jobs/update-osmo-ci: gtp0-deb{10 => 11}build32 ...................................................................... jobs/update-osmo-ci: gtp0-deb{10 => 11}build32 Related: OS#5453 Change-Id: I4b10550f4274995e70bf32f013bffecc1039d8a0 --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 1a0c79c..c99bf5b 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -14,7 +14,7 @@ - rpi4-raspbian11build-ansible-2 - rpi4-raspbian11build-ansible-3 - gtp0-deb9build - - gtp0-deb10build32 + - gtp0-deb11build32 - gtp0-deb10fr - osmo-gsm-tester-prod - osmo-gsm-tester-rnd -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4b10550f4274995e70bf32f013bffecc1039d8a0 Gerrit-Change-Number: 28152 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ci[master]: ansible/hosts: add gtp0-deb11build-i586

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28149 ) Change subject: ansible/hosts: add gtp0-deb11build-i586 ...................................................................... ansible/hosts: add gtp0-deb11build-i586 Related: OS#5453 Change-Id: I107dfb543090989c8b7c746be381aa19f0afa366 --- M ansible/hosts 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/hosts b/ansible/hosts index f9ed7a2..180e9c7 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -14,6 +14,7 @@ host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3 osmocom_jenkins_slave_fstrim=True gtp0-deb9build ansible_host=10.34.2.102 osmocom_jenkins_slave_fstrim=True gtp0-deb10build ansible_host=10.34.2.101 osmocom_jenkins_slave_fstrim=True +gtp0-deb11build-i586 ansible_host=10.34.2.104 osmocom_jenkins_slave_fstrim=True rpi4-raspbian11build-ansible-1 ansible_host=10.9.25.50 rpi4-raspbian11build-ansible-2 ansible_host=10.9.25.60 rpi4-raspbian11build-ansible-3 ansible_host=10.9.25.70 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I107dfb543090989c8b7c746be381aa19f0afa366 Gerrit-Change-Number: 28149 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ci[master]: ansible/jenkins/osmocom_build_deps: drop dh-systemd

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28150 ) Change subject: ansible/jenkins/osmocom_build_deps: drop dh-systemd ...................................................................... ansible/jenkins/osmocom_build_deps: drop dh-systemd This package is no longer available in debian 11. Even in debian 9 the description says: "This package is for transitional purposes and can be removed safely." Related: OS#5453 Change-Id: I6f72de4d7fb0aab4b153dfc0affbc6f11d20ee4c --- M ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml index e2b5a98..5cf0677 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml @@ -13,7 +13,6 @@ - debhelper - devscripts - dh-autoreconf - - dh-systemd - doxygen - flex - g++ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6f72de4d7fb0aab4b153dfc0affbc6f11d20ee4c Gerrit-Change-Number: 28150 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ci[master]: docker: Fix vfs storage cleanup task

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28145 ) Change subject: docker: Fix vfs storage cleanup task ...................................................................... docker: Fix vfs storage cleanup task The 'grep' logic of Change-Id I58f3f4a26ad6fa4698d87475cefb6ab21e66b15a seems to be inverted. if "overlay2" is found (grep successful) the exit code of grep is '0'. Change-Id: I334b0c71ef626ffd2c84097e902a5164faa3fa8b Related: OS#5827 --- M ansible/roles/docker/tasks/main.yml A ansible/vars/Debian-11.yml 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/ansible/roles/docker/tasks/main.yml b/ansible/roles/docker/tasks/main.yml index 7c7fe85..e6e6d9f 100644 --- a/ansible/roles/docker/tasks/main.yml +++ b/ansible/roles/docker/tasks/main.yml @@ -54,7 +54,7 @@ # daemon.json configures overlay2 storage driver, clean up vfs leftovers - name: cleanup vfs storage dir - shell: "docker info | grep -q 'Storage Driver: overlay2' && rm -rf /var/lib/docker/vfs" + shell: "docker info | grep -q 'Storage Driver: overlay2' || rm -rf /var/lib/docker/vfs" # After docker is set up, add docuum to clean old docker images # x86_64 only, as the raspberries need to be upgraded before they can use recent docker images (OS#5453) diff --git a/ansible/vars/Debian-11.yml b/ansible/vars/Debian-11.yml new file mode 100644 index 0000000..8361e15 --- /dev/null +++ b/ansible/vars/Debian-11.yml @@ -0,0 +1,2 @@ +--- +obs_distro: Debian_11 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I334b0c71ef626ffd2c84097e902a5164faa3fa8b Gerrit-Change-Number: 28145 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci: gtp0-deb{10 => 11}build32

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28152 ) Change subject: jobs/update-osmo-ci: gtp0-deb{10 => 11}build32 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4b10550f4274995e70bf32f013bffecc1039d8a0 Gerrit-Change-Number: 28152 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 May 2022 19:46:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022