May 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: debian-bullseye-build: add libmnl-dev

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28021 ) Change subject: debian-bullseye-build: add libmnl-dev ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4cd05ef2c164dfb765ee365ab38b8dfd4f955ac6 Gerrit-Change-Number: 28021 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 May 2022 09:09:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-remsim[master]: server: Detect duplicate client/bankd connection; drop new ones

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28027 ) Change subject: server: Detect duplicate client/bankd connection; drop new ones ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm not talking about rogue actors, but about an accidential misconfiguration. […] Another reason to drop the new one is to avoid neverending ping-pong between two clients. If they both re-connect and you always use the new one, you will have a different client connected to the reader/slot every few seconds. If the old one prevails, then at least one client owns the card until it releases it (or times out), at which point they both have a chance of grabbing it, and whoever wins will then remain owning that slot/card. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I00387dbc19d689415470e2f08df08a47a78b81c0 Gerrit-Change-Number: 28027 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 May 2022 08:48:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmo-abis[master]: stats: add site_id scope to ipa-rsl tcp stat names

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28024 ) Change subject: stats: add site_id scope to ipa-rsl tcp stat names ...................................................................... stats: add site_id scope to ipa-rsl tcp stat names Multiple IPA units can have the same bts_id but scoping by their site_ids will make them unique. This also clarifies the "bts" number being communicated. It is not the bts configuration index in osmo-bsc.cfg, it is the bts id specified in the vty line: bts X ipa unit-id SITE BTS Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 --- M src/input/ipaccess.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 8dc1008..9659b36 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -296,7 +296,7 @@ struct e1inp_ts *ts; struct osmo_fd *newbfd; struct e1inp_line *new_line; - char tcp_stat_name[32]; + char tcp_stat_name[64]; sign_link = line->ops->sign_link_up(&unit_data, line, @@ -343,8 +343,8 @@ "could not register FD\n"); goto err; } - snprintf(tcp_stat_name, sizeof(tcp_stat_name), "bts.%u.ipa-rsl.%u", - unit_data.bts_id, unit_data.trx_id); + snprintf(tcp_stat_name, sizeof(tcp_stat_name), "site.%u.bts.%u.ipa-rsl.%u", + unit_data.site_id, unit_data.bts_id, unit_data.trx_id); osmo_stats_tcp_osmo_fd_register(newbfd, tcp_stat_name); e1i_ts = ipaccess_line_ts(newbfd, new_line); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmo-abis[master]: stats: add site_id scope to ipa-rsl tcp stat names

by pespin

Attention is currently required from: iedemam. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28024 ) Change subject: stats: add site_id scope to ipa-rsl tcp stat names ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 03 May 2022 18:23:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmo-abis[master]: stats: add site_id scope to ipa-rsl tcp stat names

by iedemam

Attention is currently required from: pespin. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28024 ) Change subject: stats: add site_id scope to ipa-rsl tcp stat names ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Thanks for the peek. Size adjusted. File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/28024/comment/97a27cfc_b7b608bf PS1, Line 299: char tcp_stat_name[32]; > 32 may be too small here, I'd better use 64 now. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 May 2022 17:28:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmo-abis[master]: stats: add site_id scope to ipa-rsl tcp stat names

by iedemam

Attention is currently required from: iedemam. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/28024 to look at the new patch set (#2). Change subject: stats: add site_id scope to ipa-rsl tcp stat names ...................................................................... stats: add site_id scope to ipa-rsl tcp stat names Multiple IPA units can have the same bts_id but scoping by their site_ids will make them unique. This also clarifies the "bts" number being communicated. It is not the bts configuration index in osmo-bsc.cfg, it is the bts id specified in the vty line: bts X ipa unit-id SITE BTS Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 --- M src/input/ipaccess.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/24/28024/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b44319fb4bc6a812800001c58dfe1a664645b43 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-remsim[master]: server: Detect duplicate client/bankd connection; drop new ones

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28027 ) Change subject: server: Detect duplicate client/bankd connection; drop new ones ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > even it allows DDoS i would like to drop the old connection. […] I'm not talking about rogue actors, but about an accidential misconfiguration. That's why I think it is more safe to keep the current client. If we are talking about some kind of network outage, or operating system reboot of the client and old client == new client, then the old connection will time out (we do have application level keep-alives for that). The new client will meanwhile keep trying to re-connect and once the old connection is gone, the new connection will succeed. Overall I think this is the safer and less risky approach. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I00387dbc19d689415470e2f08df08a47a78b81c0 Gerrit-Change-Number: 28027 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 May 2022 16:58:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Use larger MSISDN number

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28029 ) Change subject: ggsn: Use larger MSISDN number ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: In theory the 2 byte msisdn is fine according to 3GPP TS 29.002 "ISDN-AddressString", since it can range 1..9 bytes. However wireshark shows errors because it tries to decode it and fails because it is indeed a weird number with 2 digits only (first byte basically states it's an international number, and 2nd byte has the 2 digits). Let's use a more "normal" msisdn length. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8a1eeb48efdddaa4f5466cdbe72545523ce31cb8 Gerrit-Change-Number: 28029 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 03 May 2022 16:39:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Use larger MSISDN number

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28029 ) Change subject: ggsn: Use larger MSISDN number ...................................................................... ggsn: Use larger MSISDN number Change-Id: I8a1eeb48efdddaa4f5466cdbe72545523ce31cb8 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/28029/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 7418638..b67645d 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -2194,7 +2194,7 @@ g_gy_validity_time := 3; /* Grant access for 3 seconds, needs to be re-validated afterwards */ f_init(); - var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn))); + var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234567890'O, c_ApnInternet, valueof(t_EuaIPv4Dyn))); ctx.pco_req := valueof(ts_PCO_IPv4_DNS_CONT); f_pdp_ctx_act(ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8a1eeb48efdddaa4f5466cdbe72545523ce31cb8 Gerrit-Change-Number: 28029 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Send MSISDN in GTPv2C CreateSessionRequest

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28030 ) Change subject: pgw: Send MSISDN in GTPv2C CreateSessionRequest ...................................................................... pgw: Send MSISDN in GTPv2C CreateSessionRequest Change-Id: I71bcad944f40aa78357f2d11f54d139103ca3e24 --- M pgw/PGW_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/28030/1 diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 1a02c4d..44bf6f9 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -421,7 +421,7 @@ fteid_u_ie := ts_GTP2C_FTEID(FTEID_IF_S5S8_SGW_GTPU, g_teid, 2, f_inet_addr(mp_local_hostname_u), omit); var template (value) PDU_GTPCv2 g2c := - ts_GTP2C_CreateSessionReq(imsi := g_pars.imsi, msisdn := omit, rat_type := 6, + ts_GTP2C_CreateSessionReq(imsi := g_pars.imsi, msisdn := oct2hex('1234567890'O), rat_type := 6, sender_fteid := fteid_c_ie, apn := f_enc_dns_hostname(g_pars.apn), pdn_type := g_pars.pdn_type, teid_list := { fteid_u_ie }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I71bcad944f40aa78357f2d11f54d139103ca3e24 Gerrit-Change-Number: 28030 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022