Attention is currently required from: lynxis lazus.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 )
Change subject: docs: add a simple example to use configuration file
......................................................................
Patch Set 1:
(1 comment)
File README.md:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647/comment/cb2b191b_…
PS1, Line 33: $ rebar3 shell --config ./examples/sys.config
Isn'tn this the same as above but with config? why not merging both sections?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I013f03779508bc3ee5bb378c357a5c94b40b74a0
Gerrit-Change-Number: 27647
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 05 Apr 2022 10:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27642 )
Change subject: tests/llc: Add test_llc_meta_pdu_life_expire
......................................................................
Patch Set 1:
(1 comment)
File tests/llc/LlcTest.ok:
https://gerrit.osmocom.org/c/osmo-pcu/+/27642/comment/c7a603e2_33c6b388
PS1, Line 6: === end test_llc_meta_pdu_life_expire ===
> Not related to this patch, but I wonder why the test output is split across stdout + stderr instead […]
IMHO: usually stdout should be always the same if the test succeed. while stderr can contains more detailed logs. but the detailed logs might contain dynamic parts (e.g. pointer). so they can't be used as part of the test output and should not be the same.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27642
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7ba6be32778e2c2b22723db10fa66655812c8452
Gerrit-Change-Number: 27642
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Apr 2022 09:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment