April 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: ttcn-pgw-test: Improve osmo-uecups cfg file

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27748 ) Change subject: ttcn-pgw-test: Improve osmo-uecups cfg file ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File ttcn3-pgw-test/osmo-uecups-daemon.cfg: https://gerrit.osmocom.org/c/docker-playground/+/27748/comment/c6c5ab00_5e8… PS1, Line 3: logging print extended-timestamp 1 > What's the point of re-ordering stuff here? This makes it harder to read the patch. […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I36bb04a388ab65aaa03a82c159a1b258886ec0d0 Gerrit-Change-Number: 27748 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 12:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn-pgw-test: Improve osmo-uecups cfg file

by pespin

Attention is currently required from: osmith, pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/27748 to look at the new patch set (#2). Change subject: ttcn-pgw-test: Improve osmo-uecups cfg file ...................................................................... ttcn-pgw-test: Improve osmo-uecups cfg file Bind to specific container IP address. Use more uniform logging config settings as most of the other osmocom processes. Change-Id: I36bb04a388ab65aaa03a82c159a1b258886ec0d0 --- M ttcn3-pgw-test/osmo-uecups-daemon.cfg 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/48/27748/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I36bb04a388ab65aaa03a82c159a1b258886ec0d0 Gerrit-Change-Number: 27748 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27749 ) Change subject: ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS ...................................................................... ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS Change-Id: I5a7ace64cefead2c05437ea75ba29ecc969d426e --- M ttcn3-ggsn-test/ogs/freediameter.conf M ttcn3-ggsn-test/ogs/open5gs-smf.yaml 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/ttcn3-ggsn-test/ogs/freediameter.conf b/ttcn3-ggsn-test/ogs/freediameter.conf index a770a0f..60693cd 100644 --- a/ttcn3-ggsn-test/ogs/freediameter.conf +++ b/ttcn3-ggsn-test/ogs/freediameter.conf @@ -262,6 +262,7 @@ #ConnectPeer = "aaa.wide.ad.jp"; #ConnectPeer = "old.diameter.serv" { TcTimer = 60; TLS_old_method; No_SCTP; Port=3868; } ; ConnectPeer = "pcrf.localdomain" { ConnectTo = "172.18.3.202"; Port = 3868; No_TLS; TcTimer = 2; }; +ConnectPeer = "ocs.localdomain" { ConnectTo = "172.18.3.202"; Port = 3869; No_TLS; TcTimer = 2; }; ############################################################## diff --git a/ttcn3-ggsn-test/ogs/open5gs-smf.yaml b/ttcn3-ggsn-test/ogs/open5gs-smf.yaml index 0751ab5..3ee3b04 100644 --- a/ttcn3-ggsn-test/ogs/open5gs-smf.yaml +++ b/ttcn3-ggsn-test/ogs/open5gs-smf.yaml @@ -358,6 +358,8 @@ - fd02:db8:3::222 - 2001:4860:4860::8844 mtu: 1400 + ctf: + enabled: auto freeDiameter: /data/freediameter.conf # -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5a7ace64cefead2c05437ea75ba29ecc969d426e Gerrit-Change-Number: 27749 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27749 ) Change subject: ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5a7ace64cefead2c05437ea75ba29ecc969d426e Gerrit-Change-Number: 27749 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 11:36:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn-pgw-test: Improve osmo-uecups cfg file

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27748 ) Change subject: ttcn-pgw-test: Improve osmo-uecups cfg file ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File ttcn3-pgw-test/osmo-uecups-daemon.cfg: https://gerrit.osmocom.org/c/docker-playground/+/27748/comment/65ab8150_0f3… PS1, Line 3: logging print extended-timestamp 1 What's the point of re-ordering stuff here? This makes it harder to read the patch. I see you're changing the 'color' 0->1 and 'set-all' debug->info. Please modify the existing lines without re-ordering them, thanks! -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I36bb04a388ab65aaa03a82c159a1b258886ec0d0 Gerrit-Change-Number: 27748 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 11:35:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS

by daniel

Attention is currently required from: osmith, pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27749 ) Change subject: ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5a7ace64cefead2c05437ea75ba29ecc969d426e Gerrit-Change-Number: 27749 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 11:34:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-uecups[master]: Move several objects outside of main.c

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/27747 ) Change subject: Move several objects outside of main.c ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/27747 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I4613361dc40518edd94f2d4128ba412337690736 Gerrit-Change-Number: 27747 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 11:32:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-uecups[master]: Add optarg support

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/27746 ) Change subject: Add optarg support ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: We should finally have some common argparse API in libosmocore to avoid code duplication... -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/27746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I88c95c27d20f1da8dc2ce967197b58c876b42c59 Gerrit-Change-Number: 27746 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Apr 2022 11:31:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27749 ) Change subject: ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS ...................................................................... ttcn-ggsn: Configure open5gs-smfd to connect to TTCN3 OCS Change-Id: I5a7ace64cefead2c05437ea75ba29ecc969d426e --- M ttcn3-ggsn-test/ogs/freediameter.conf M ttcn3-ggsn-test/ogs/open5gs-smf.yaml 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/49/27749/1 diff --git a/ttcn3-ggsn-test/ogs/freediameter.conf b/ttcn3-ggsn-test/ogs/freediameter.conf index a770a0f..60693cd 100644 --- a/ttcn3-ggsn-test/ogs/freediameter.conf +++ b/ttcn3-ggsn-test/ogs/freediameter.conf @@ -262,6 +262,7 @@ #ConnectPeer = "aaa.wide.ad.jp"; #ConnectPeer = "old.diameter.serv" { TcTimer = 60; TLS_old_method; No_SCTP; Port=3868; } ; ConnectPeer = "pcrf.localdomain" { ConnectTo = "172.18.3.202"; Port = 3868; No_TLS; TcTimer = 2; }; +ConnectPeer = "ocs.localdomain" { ConnectTo = "172.18.3.202"; Port = 3869; No_TLS; TcTimer = 2; }; ############################################################## diff --git a/ttcn3-ggsn-test/ogs/open5gs-smf.yaml b/ttcn3-ggsn-test/ogs/open5gs-smf.yaml index 0751ab5..3ee3b04 100644 --- a/ttcn3-ggsn-test/ogs/open5gs-smf.yaml +++ b/ttcn3-ggsn-test/ogs/open5gs-smf.yaml @@ -358,6 +358,8 @@ - fd02:db8:3::222 - 2001:4860:4860::8844 mtu: 1400 + ctf: + enabled: auto freeDiameter: /data/freediameter.conf # -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5a7ace64cefead2c05437ea75ba29ecc969d426e Gerrit-Change-Number: 27749 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn-pgw-test: Improve osmo-uecups cfg file

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27748 ) Change subject: ttcn-pgw-test: Improve osmo-uecups cfg file ...................................................................... ttcn-pgw-test: Improve osmo-uecups cfg file Bind to specific container IP address. Use more uniform logging config settings as most of the other osmocom processes. Change-Id: I36bb04a388ab65aaa03a82c159a1b258886ec0d0 --- M ttcn3-pgw-test/osmo-uecups-daemon.cfg 1 file changed, 9 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/48/27748/1 diff --git a/ttcn3-pgw-test/osmo-uecups-daemon.cfg b/ttcn3-pgw-test/osmo-uecups-daemon.cfg index e268277..77a46fa 100644 --- a/ttcn3-pgw-test/osmo-uecups-daemon.cfg +++ b/ttcn3-pgw-test/osmo-uecups-daemon.cfg @@ -1,16 +1,15 @@ +log gsmtap 172.18.18.202 + logging level set-all debug + logging filter all 1 log stderr logging filter all 1 - logging print extended-timestamp 1 - logging print file basename last - logging print category-hex 0 + logging color 1 logging print category 1 - logging print level 1 + logging print category-hex 0 logging timestamp 1 - logging color 0 -! - logging level set-all debug - logging level linp info + logging print extended-timestamp 1 + logging level set-all info line vty - bind 0.0.0.0 + bind 172.18.18.20 uecups - local-ip 0.0.0.0 + local-ip 172.18.18.20 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I36bb04a388ab65aaa03a82c159a1b258886ec0d0 Gerrit-Change-Number: 27748 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022