Hello Jenkins Builder, daniel,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/23184
to look at the new patch set (#2).
Change subject: gprs_ns2: add vty `nse <0-65535> restart sns`
......................................................................
gprs_ns2: add vty `nse <0-65535> restart sns`
Allow to restart SNS procedure and initiate a SNS-SIZE procedure with Reset.
SGSN side SNS restart will stop answer on ALIVE and is sending NS STATUS
invalid protocol state.
BSS side SNS restart will send a SNS Size procedure to reset the state.
Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
---
M src/gb/gprs_ns2_vty.c
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/23184/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d
Gerrit-Change-Number: 23184
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569 )
Change subject: hlr: add imsi unknown cause test case
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
It would break all hlr latest test cases. Do we have a configuration which allows us to detect latest or master?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a
Gerrit-Change-Number: 27569
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 24 Mar 2022 22:35:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16808
to look at the new patch set (#5).
Change subject: Add vty `imsi unknown cause` to set the reject cause
......................................................................
Add vty `imsi unknown cause` to set the reject cause
Allow to set the reject cause when an IMSI is unknown to the HLR.
Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or
CAUSE_ROAMING_NOTALLOWED (11).
Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M doc/examples/osmo-hlr.cfg
M include/osmocom/hlr/hlr.h
M src/hlr.c
M src/hlr_vty.c
M tests/test_nodes.vty
5 files changed, 43 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )
Change subject: Add vty `imsi unknown cause` to set the reject cause
......................................................................
Patch Set 4:
(6 comments)
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/c241c228_2fe3afff
PS2, Line 345: CAUSE
> How about: […]
Done
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/348b11ef_113e1e30
PS4, Line 49: "roaming-not-allowed" },
> No need to break the line.
Ack
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/97ff33e6_eb8177ea
PS4, Line 88: imsi_cause_code
> Why not just g_hlr->imsi_unknown_cause != GMM_CAUSE_IMSI_UNKNOWN (it's the default).
ok. That's the correct way to do with vty? Not writing out default values so we can change default later?
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/26f1e06e_c91bebd0
PS4, Line 356: imsi unknown cause
> You have to add help string for every singe word of the command. […]
Ack
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/9bd32036_89363c77
PS4, Line 357: GSUP cause
> This is actually GSM 04.08 GMM cause if I understand correctly.
Yes and not. We use GMM cause for this, even the request comes over CS and retranslate them back into MM cause. Should I use GSUP cause or should I say GSM 04.08 GMM?
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/0bd0aecf_3efc07ab
PS4, Line 365: Cannot find cause value to %s%s
> This shall not happen because VTY would not accept any other values than 'imsi-unknown' and 'roaming […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Mar 2022 21:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, laforge.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 )
Change subject: RFC: lint: annotate lines in gerrit
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/e7d3a471_109657ef
PS1, Line 13: The jenkins nodes needs to access the gerrit via ssh
> > I would expect one can createa gerrit user that has permission only to provide review and thereby […]
We could execute this script from the review job, save the json in the workspace and execute the upload in a second job.
How should we continue here?
Patchset:
PS1:
@osmith: how should we continue here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49
Gerrit-Change-Number: 26393
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 24 Mar 2022 21:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment
Attention is currently required from: iedemam, fixeria, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )
Change subject: stats: new trackers for lchan life duration
......................................................................
Patch Set 18:
(11 comments)
Patchset:
PS18:
looks like we will merge this soon. Let's sort out these remaining issues:
* milliseconds vs tenth seconds, various places marked (1):
The time_cc updates the rate_ctr every tenth of a second now, which is nice, thumbs up.
However, the naming and doc still suggest that the rate_ctrs are counting milliseconds.
* reporting on vty the average activity duration, see the place marked (2)
* reporting on vty how long a single active lchan has been active, marked (3)
* minor style
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/bd885a57_1fdc10fe
PS18, Line 61: BTS_CTR_CHAN_SDCCH_ACTIVE_MILLISECONDS_TOTAL,
(1)
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/e33c5ad2_cfe40ef9
PS18, Line 890: /* Interval timing to capture duration per activation and cummulative active time */
"cumulative"
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/13a6d2ba_5633c0e8
PS18, Line 891: struct osmo_time_cc active_ms;
(1)
I think it was named active_ms due to my code review ... maybe just 'active' or 'active_cc' is better after all? sorry about that.
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/038dc187_5ac51d5a
PS18, Line 1038: "Cumulative number of milliseconds of SDCCH channel activity" },
(1)
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/33b5979b_43ba30bf
PS18, Line 576: VTY_NEWLINE);
(3)
Before, I gave code review to remove the osmo_time_cc_reset(), saying it was not necessary. Which is true, when thinking in terms of rate counters and stats; the normal / intended way to use osmo_time_cc is to always just carry on. I realize there is a "but" that I didn't see before: of course without a reset the total_sum accumulates across all activations of an lchan, and we cannot use it to report how long ago the currently active lchan has been activated. Sorry for not seeing that before.
ways to resolve: one of
a) drop this vty output and the gsm_lchan_active_duration_ms() function. Then it is fine to not do osmo_time_cc_reset().
b) use a separate simple timestamp to count a single lchan's active time, orthogonal to the osmo_time_cc that does the "magic" rate_ctr stuff.
c) re-add the osmo_time_cc_reset() with a comment indicating
"/* This reset allows showing on vty how long ago a single active lchan was activated. This reset does not affect rate_ctr statistics. */".
The osmo_time_cc still works fine when it is reset at a time when the flag is false.
I think either way it would be nicer to first do this patch about rate_ctr and averages only, and add the "activated x seconds ago" in a separate patch -- it is a separate feature. We can then discuss there whether that x should also be exposed to statistics somehow.
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/f2439f5e_3166fad9
PS18, Line 3844: vty_out(vty, "%s", VTY_NEWLINE);
(2)
the usefulness of this output is disputable because it averages over the entire lifetime of the cell. so if we have a month of normal operation followed by an hour of short-lived lchans, the avg lifespan reported here does not reflect reality in a useful way.
We can instead (or in addition to above output?) use the rate in the last interval instead: in rate_ctr->intv, we keep values for the last second, minute, hour and day. For example:
const struct rate_ctr *active_time_tch = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_TCH_ACTIVE_TENTH_SECONDS);
const struct rate_ctr *activations_tch = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_ACT_TCH);
vty_out(vty, "avg active duration in the last hour: TCH: %s",
/* active_time_tch counts tenths of seconds, so *100 gives an avg in ms */
osmo_int_to_float_str_c(OTC_SELECT,
100 * active_time_tch->intv[RATE_CTR_INTV_HOUR].rate
/ activations_tch->[RATE_CTR_INTV_HOUR].rate, 3));
Same can be done per minute, per day, and per each lchan type, as you see fit...
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/6a9972bf_12de536a
PS18, Line 208: struct rate_ctr *rate_ctr;
osmocom style requires that this local variable be defined at the start of the scope, at line 203 above
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/67698bca_fdd73598
PS18, Line 224: if (lchan->active_ms.cfg.rate_ctr) {
(could just set the flag no matter if rate_ctr is set or not.)
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/d3012b5b_7d4dbfe5
PS18, Line 546: .active_ms = lchan->active_ms
please add a trailing comma. it allows future patches to add a single line, less merge-conflict prone
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/5c2f549f_fb724a13
PS18, Line 556: if (lchan->active_ms.cfg.rate_ctr) {
(could just set the flag no matter if rate_ctr is set or not.)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 18
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Mar 2022 17:20:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27521 )
Change subject: clean-up pkg-config files: Make use of "Requires" as documented
......................................................................
Patch Set 2:
(1 comment)
File libosmogb.pc.in:
https://gerrit.osmocom.org/c/libosmocore/+/27521/comment/eabae010_9ca8f9d8
PS1, Line 9: Requires: libosmocore, libosmovty
> Done
libosmocore requiring talloc is totally orthogonal to having talloc listed here. libosmogb using talloc directly means it should show up here. IIRC in pkgconfig there's the concept of "internally using" some dep vs really exporting its linking flags to users of the lib.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27521
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2ab1fe8e4bbfc120b471d6c9f2312a89dbc7d42b
Gerrit-Change-Number: 27521
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Mar 2022 15:25:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: iedemam, neels, fixeria, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )
Change subject: stats: new trackers for lchan life duration
......................................................................
Patch Set 18:
(1 comment)
Patchset:
PS15:
> that patch is now merged, FYI
@neels as you did a lot of the review / discussions here, I was hoping that you'd follow up "now" that iedemam has updated the path 7 days ago? Thanks!
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 18
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Mar 2022 15:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: nickvsnetworking.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27014 )
Change subject: Doc Update - Build process for DAHDI on Debian 11
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
hi nick, would you mind incorporating the requested feedback so we can get this merged? thanks!
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27014
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I0679bd14702b7b3d05c3346ce10358f45fef0301
Gerrit-Change-Number: 27014
Gerrit-PatchSet: 1
Gerrit-Owner: nickvsnetworking <nick(a)nickvsnetworking.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: nickvsnetworking <nick(a)nickvsnetworking.com>
Gerrit-Comment-Date: Thu, 24 Mar 2022 14:59:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment