March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ggsn[master]: pco.h: Fix typo in reference to spec

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27568 ) Change subject: pco.h: Fix typo in reference to spec ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic428892161123b62d25a7619128ef7325bf85500 Gerrit-Change-Number: 27568 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Mar 2022 14:46:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: pco.h: Fix typo in reference to spec

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27568 ) Change subject: pco.h: Fix typo in reference to spec ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic428892161123b62d25a7619128ef7325bf85500 Gerrit-Change-Number: 27568 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Mar 2022 14:14:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: pco.h: Fix typo in reference to spec

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27568 ) Change subject: pco.h: Fix typo in reference to spec ...................................................................... pco.h: Fix typo in reference to spec Change-Id: Ic428892161123b62d25a7619128ef7325bf85500 --- M ggsn/pco.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/68/27568/1 diff --git a/ggsn/pco.h b/ggsn/pco.h index 7ebe05a..4d999ef 100644 --- a/ggsn/pco.h +++ b/ggsn/pco.h @@ -4,7 +4,7 @@ #include "../gtp/pdp.h" -/* 3GPP TS 24.008 10.6.5.3 */ +/* 3GPP TS 24.008 10.5.6.3 */ enum pco_protocols { PCO_P_LCP = 0xC021, PCO_P_PAP = 0xC023, -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic428892161123b62d25a7619128ef7325bf85500 Gerrit-Change-Number: 27568 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/BSSMAP_Templates: add missing LCS {Priority,QoS} IEs

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27567 ) Change subject: library/BSSMAP_Templates: add missing LCS {Priority,QoS} IEs ...................................................................... library/BSSMAP_Templates: add missing LCS {Priority,QoS} IEs According to 3GPP TS 48.008, section 3.2.1.71, the LCS QoS IE shall be present if location of the target MS is requested and is optional otherwise. Since [1], osmo-bsc started to check presence of this IE, so let's add it to ts_BSSMAP_Perform_Location_Request. Taking a chance, let's also add LCS Priority IE. Change-Id: If2bd6e636d3ee695abab9ed40417dc53ec68fd12 Related: [1] osmo-bsc.git Ifeb359b0468845da0b4fed9e2e4b79256067fa81 Related: SYS#5891 --- M library/BSSMAP_Templates.ttcn 1 file changed, 32 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 07c7c8d..376cea6 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -1881,10 +1881,39 @@ category := category } +template (value) BSSMAP_IE_LCSPriority +ts_BSSMAP_IE_LCSPriority(template (value) OCT1 priority := '00'O) := { + elementIdentifier := '43'O, + lengthIndicator := 0, /* overwritten */ + priority := priority +} + +template (value) BSSMAP_IE_LCSQOS +ts_BSSMAP_IE_LCSQOS(template (value) BIT1 vCI := '0'B, + template (value) BIT1 vEL := '0'B, + template (value) BIT1 hAI := '1'B, + template (value) BIT7 hAV := '0010010'B, + template (value) BIT1 vAI := '0'B, + template (value) BIT7 vAV := '0000000'B) := { + elementIdentifier := '3E'O, + lengthIndicator := 0, /* overwritten */ + vCI := vCI, /* Vertical Coordinate Indicator: VC requested ('1'B) or not ('0'B) */ + vEL := vEL, /* report velocity if available (1) or not(0) */ + spare_1_6 := '000000'B, + horizontalAccuracy := hAV, /* Accuracy Horizontal (HA) */ + hAI := hAI, /* Horizontal Accuracy Indicator HA is specified (1) or not (0) */ + verticalAccuracy := vAV, /* Accuracy Vertical (VA) */ + vAI := vAI, /* Vertical Accuracy Indicator VA is specified (1) or not (0) */ + spare_2_6 := '000000'B, + rTC := '00'B /* Response Time is not specified */ +} + template (value) PDU_BSSAP ts_BSSMAP_Perform_Location_Request(template (omit) BSSMAP_IE_IMSI imsi, template (omit) BSSMAP_IE_CellIdentifier cellIdentifier := omit, - template (omit) BSSMAP_IE_LCSClientType clientType := ts_BSSMAP_IE_LCSClientType) + template (omit) BSSMAP_IE_LCSClientType clientType := ts_BSSMAP_IE_LCSClientType, + template (omit) BSSMAP_IE_LCSPriority priority := ts_BSSMAP_IE_LCSPriority, + template (omit) BSSMAP_IE_LCSQOS qos := ts_BSSMAP_IE_LCSQOS) modifies ts_BSSAP_BSSMAP := { pdu := { bssmap := { @@ -1895,8 +1924,8 @@ classmarkInformationType3 := omit, lCS_ClientType := clientType, chosenChannel := omit, - lCS_Priority := omit, - lCS_QOS := omit, + lCS_Priority := priority, + lCS_QOS := qos, gPS_AssistanceData := omit, aPDU := omit, iMSI := imsi, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2bd6e636d3ee695abab9ed40417dc53ec68fd12 Gerrit-Change-Number: 27567 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/BSSAP_LE_Types: fix wrong IEI in record BSSMAP_LE_IE_LcsClien...

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27565 ) Change subject: library/BSSAP_LE_Types: fix wrong IEI in record BSSMAP_LE_IE_LcsClientType ...................................................................... library/BSSAP_LE_Types: fix wrong IEI in record BSSMAP_LE_IE_LcsClientType Change-Id: Ifae1efa1717a5dbc7ecd4b5ba83e3866ff803390 Related: SYS#5891 --- M library/BSSAP_LE_Types.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/library/BSSAP_LE_Types.ttcn b/library/BSSAP_LE_Types.ttcn index ddff90a..e007180 100644 --- a/library/BSSAP_LE_Types.ttcn +++ b/library/BSSAP_LE_Types.ttcn @@ -288,7 +288,7 @@ uint8_t len, BSSMAP_LE_ClientType cltype } with { - variant "PRESENCE(iei = BSSMAP_LE_IEI_CAUSE)" + variant "PRESENCE(iei = BSSMAP_LE_IEI_LCS_CLIENT_TYPE)" variant (len) "LENGTHTO(cltype)" } type enumerated BSSMAP_LE_ClientType { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifae1efa1717a5dbc7ecd4b5ba83e3866ff803390 Gerrit-Change-Number: 27565 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/BSSMAP_Templates: add missing LCS Client Type IE

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566 ) Change subject: library/BSSMAP_Templates: add missing LCS Client Type IE ...................................................................... library/BSSMAP_Templates: add missing LCS Client Type IE According to 3GPP TS 48.008, section 3.2.1.71, the LCS Client Type IE shall be present if the location type indicates a request for a location estimate and is optional otherwise. Since [1], osmo-bsc started to check presence of this IE, so let's make sure that it's present in ts_BSSMAP_Perform_Location_Request by default. Change-Id: I5c8d6962e957d587dc4b65d08bf56bd4ef2f0d6e Related: [1] osmo-bsc.git Id3262e67c3dc25cb93fbd52a40689c5529ca2d41 Related: SYS#5891 --- M library/BSSMAP_Templates.ttcn 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 57422cc..07c7c8d 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -1872,9 +1872,19 @@ positioningMethod := omit } -template (value) PDU_BSSAP ts_BSSMAP_Perform_Location_Request(template (omit) BSSMAP_IE_IMSI imsi, - template (omit) BSSMAP_IE_CellIdentifier cellIdentifier := omit - ) +template (value) BSSMAP_IE_LCSClientType +ts_BSSMAP_IE_LCSClientType(template (value) BIT4 category := '0010'B, + template (value) BIT4 subtype := '0000'B) := { + elementIdentifier := '48'O, + lengthIndicator := 0, /* overwritten */ + subtype := subtype, + category := category +} + +template (value) PDU_BSSAP +ts_BSSMAP_Perform_Location_Request(template (omit) BSSMAP_IE_IMSI imsi, + template (omit) BSSMAP_IE_CellIdentifier cellIdentifier := omit, + template (omit) BSSMAP_IE_LCSClientType clientType := ts_BSSMAP_IE_LCSClientType) modifies ts_BSSAP_BSSMAP := { pdu := { bssmap := { @@ -1883,7 +1893,7 @@ locationType := ts_BSSMAP_IE_LocationType, cellIdentifier := cellIdentifier, classmarkInformationType3 := omit, - lCS_ClientType := omit, + lCS_ClientType := clientType, chosenChannel := omit, lCS_Priority := omit, lCS_QOS := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c8d6962e957d587dc4b65d08bf56bd4ef2f0d6e Gerrit-Change-Number: 27566 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/BSSMAP_Templates: add missing LCS Client Type IE

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566 ) Change subject: library/BSSMAP_Templates: add missing LCS Client Type IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c8d6962e957d587dc4b65d08bf56bd4ef2f0d6e Gerrit-Change-Number: 27566 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Mar 2022 16:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/BSSMAP_Templates: add missing LCS {Priority,QoS} IEs

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27567 ) Change subject: library/BSSMAP_Templates: add missing LCS {Priority,QoS} IEs ...................................................................... Patch Set 1: (1 comment) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27567/comment/54842a15_e0c1… PS1, Line 1908: rTC := '00'B /* Response Time is not specified */ > so many magic numbers... […] Same here, BSSMAP_IE_LCSQOS comes from Ericsson's protocol modules (see my comment to I5c8d6962e957d587dc4b65d08bf56bd4ef2f0d6e). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2bd6e636d3ee695abab9ed40417dc53ec68fd12 Gerrit-Change-Number: 27567 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Mar 2022 15:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/BSSMAP_Templates: add missing LCS Client Type IE

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566 ) Change subject: library/BSSMAP_Templates: add missing LCS Client Type IE ...................................................................... Patch Set 1: (1 comment) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566/comment/e1c1b0c9_9e5f… PS1, Line 1877: template (value) BIT4 subtype := '0000'B) := { > would it make sense to define enums for these? Indeed it would make sense. The problem is that BSSMAP_IE_LCSClientType comes from Ericsson's protocol modules (external deps), and somehow they prefer using BITs and OCTs over the enumerated types. So not in this case, unfortunately :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c8d6962e957d587dc4b65d08bf56bd4ef2f0d6e Gerrit-Change-Number: 27566 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Mar 2022 15:34:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27221 ) Change subject: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h ...................................................................... Patch Set 7: (1 comment) Patchset: PS1: > python script parsing from the spec .docx file. See open5gs. […] you'd think they could officially publish these numbers and strings in an easily parseable way... -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I568b821e89007ed52eeefcdbcb6edd8052a8b5be Gerrit-Change-Number: 27221 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Mar 2022 15:34:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022