Change in osmo-hlr[master]: Add vty `imsi unknown cause` to set the reject cause
Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `imsi unknown cause` to set the reject cause ...................................................................... Patch Set 4: (6 comments) File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/c241c228_2fe3afff PS2, Line 345: CAUSE
How about: […] Done
File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/348b11ef_113e1e30 PS4, Line 49: "roaming-not-allowed" },
No need to break the line. Ack
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/97ff33e6_eb8177ea PS4, Line 88: imsi_cause_code
Why not just g_hlr->imsi_unknown_cause != GMM_CAUSE_IMSI_UNKNOWN (it's the default). ok. That's the correct way to do with vty? Not writing out default values so we can change default later?
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/26f1e06e_c91bebd0 PS4, Line 356: imsi unknown cause
You have to add help string for every singe word of the command. […] Ack
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/9bd32036_89363c77 PS4, Line 357: GSUP cause
This is actually GSM 04.08 GMM cause if I understand correctly. Yes and not. We use GMM cause for this, even the request comes over CS and retranslate them back into MM cause. Should I use GSUP cause or should I say GSM 04.08 GMM?
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/0bd0aecf_3efc07ab PS4, Line 365: Cannot find cause value to %s%s
This shall not happen because VTY would not accept any other values than 'imsi-unknown' and 'roaming […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 24 Mar 2022 21:53:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
lynxis lazus