Attention is currently required from: fixeria.

View Change

6 comments:

• File src/hlr_vty.c:

  • Patch Set #2, Line 345: CAUSE

    How about: […]

    Done

• File src/hlr_vty.c:

  • Patch Set #4, Line 49: "roaming-not-allowed" },

    No need to break the line.

    Ack

  • Patch Set #4, Line 88: imsi_cause_code

    Why not just g_hlr->imsi_unknown_cause != GMM_CAUSE_IMSI_UNKNOWN (it's the default).

    ok. That's the correct way to do with vty? Not writing out default values so we can change default later?

  • Patch Set #4, Line 356: imsi unknown cause

    You have to add help string for every singe word of the command. […]

    Ack

  • Patch Set #4, Line 357: GSUP cause

    This is actually GSM 04.08 GMM cause if I understand correctly.

    Yes and not. We use GMM cause for this, even the request comes over CS and retranslate them back into MM cause. Should I use GSUP cause or should I say GSM 04.08 GMM?

  • Patch Set #4, Line 365: Cannot find cause value to %s%s

    This shall not happen because VTY would not accept any other values than 'imsi-unknown' and 'roaming […]

    Done

To view, visit change 16808. To unsubscribe, or for help writing mail filters, visit settings.