March 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: usb: Match device by VID/PID without path/addr if it is unique

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27398 to look at the new patch set (#2). Change subject: usb: Match device by VID/PID without path/addr if it is unique ...................................................................... usb: Match device by VID/PID without path/addr if it is unique If there's only a single device with matching VID/PID attached, we don't need to insist that either the path or the address of the device matches. Those are only needed to disambiguate multiple devices with identical VID/PID. Change-Id: I2ef245a56dfcf22758a0216b86d2a5c602ee5588 --- M src/usb/osmo_libusb.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/27398/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ef245a56dfcf22758a0216b86d2a5c602ee5588 Gerrit-Change-Number: 27398 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: host: Don't pass -1 (converted to 255) as address

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/27397 to look at the new patch set (#2). Change subject: host: Don't pass -1 (converted to 255) as address ...................................................................... host: Don't pass -1 (converted to 255) as address We initialize a local variable to -1, and if the user specifies no address from the command line, we use this in the interface match struct, which uses a uint8_t. This means 255 ends up in there, and as a result no usb interface ever matches unless the user explicitly specifies the -A command line argument. With this patch any absent -A argument will result in ifm.addr == 0, which means "don't match on address", and which is what we want here. Change-Id: Iffb5fa406ddef00c7c15570ffca2c109b98d7a2d --- M host/src/simtrace2-cardem-pcsc.c M host/src/simtrace2-tool.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/97/27397/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Iffb5fa406ddef00c7c15570ffca2c109b98d7a2d Gerrit-Change-Number: 27397 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: usb: Match device by VID/PID without path/addr if it is unique

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27398 ) Change subject: usb: Match device by VID/PID without path/addr if it is unique ...................................................................... usb: Match device by VID/PID without path/addr if it is unique If there's only a single device with matching VID/PID attached, we don't need to insist that either the path or the address of the device matches. Those are only needed to disambiguate multiple devices with identical VID/PID. Change-Id: I2ef245a56dfcf22758a0216b86d2a5c602ee5588 --- M src/usb/osmo_libusb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/27398/1 diff --git a/src/usb/osmo_libusb.c b/src/usb/osmo_libusb.c index c5ea507..c8b9348 100644 --- a/src/usb/osmo_libusb.c +++ b/src/usb/osmo_libusb.c @@ -536,7 +536,7 @@ addr = libusb_get_device_address(*dev); path = osmo_libusb_dev_get_path_buf(pathbuf, sizeof(pathbuf), *dev); - if ((ifm->addr && addr == ifm->addr) || + if ((ifm->addr && addr == ifm->addr) || !list[1] /* only one device */ || (strlen(ifm->path) && !strcmp(path, ifm->path))) { rc = libusb_open(*dev, &usb_devh); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ef245a56dfcf22758a0216b86d2a5c602ee5588 Gerrit-Change-Number: 27398 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: host: Don't pass -1 (converted to 255) as address

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/27397 ) Change subject: host: Don't pass -1 (converted to 255) as address ...................................................................... host: Don't pass -1 (converted to 255) as address We initialize a local variable to -1, and if the user specifies no address from the command line, we use this in the interface match struct, which uses a uint8_t. This means 255 ends up in there, and as a result no usb interface ever matches unless the user explicitly specifies the -A command line argument. With this patch any absent -A argument will result in ifm.addr == 0, which means "don't match on address", and which is what we want here. Change-Id: Iffb5fa406ddef00c7c15570ffca2c109b98d7a2d --- M host/src/simtrace2-cardem-pcsc.c M host/src/simtrace2-tool.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/97/27397/1 diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 0eaf2c3..36fa579 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -529,7 +529,8 @@ altsetting = atoi(optarg); break; case 'A': - addr = atoi(optarg); + if (addr > 0 && addr < 256) + addr = atoi(optarg); break; case 'H': path = optarg; diff --git a/host/src/simtrace2-tool.c b/host/src/simtrace2-tool.c index b0fac6c..bfdc979 100644 --- a/host/src/simtrace2-tool.c +++ b/host/src/simtrace2-tool.c @@ -275,7 +275,8 @@ altsetting = atoi(optarg); break; case 'A': - addr = atoi(optarg); + if (addr > 0 && addr < 256) + addr = atoi(optarg); break; case 'H': path = optarg; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Iffb5fa406ddef00c7c15570ffca2c109b98d7a2d Gerrit-Change-Number: 27397 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy_peer: Add rate counters when forwarding packets fail

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27396 ) Change subject: gbproxy_peer: Add rate counters when forwarding packets fail ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I7fa972ba843993dac84241c04d66d5b7e2a0b40f Gerrit-Change-Number: 27396 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:33:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy_peer: Use designated initializers for bvc_ctr_description

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27395 ) Change subject: gbproxy_peer: Use designated initializers for bvc_ctr_description ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: If571e5d5b653291f34df516b801f35225dd4f7c9 Gerrit-Change-Number: 27395 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:32:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration

by iedemam

iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: Hi all, This latest patchset is nothing more than to move the conversation forward. I narrowed things down to a single line change I can make which resolves the handover unit test failures (but breaks my feature). I have no idea why it fixes *make check* as I'm having difficulty even looking at what is going on in those tests because they never complete, just hang and bomb. Maybe this change triggers a thought with someone more experienced with the lchan lifecycle or osmo_time_cc API. I'm definitely abusing it in some way. I'll keep at it. Just posting this update in case. Thanks, -Michael -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 13 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy_peer: Add rate counters when forwarding packets fail

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27396 ) Change subject: gbproxy_peer: Add rate counters when forwarding packets fail ...................................................................... gbproxy_peer: Add rate counters when forwarding packets fail Change-Id: I7fa972ba843993dac84241c04d66d5b7e2a0b40f --- M include/osmocom/gbproxy/gb_proxy.h M src/gb_proxy.c M src/gb_proxy_peer.c 3 files changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/96/27396/1 diff --git a/include/osmocom/gbproxy/gb_proxy.h b/include/osmocom/gbproxy/gb_proxy.h index 0657df7..00309e1 100644 --- a/include/osmocom/gbproxy/gb_proxy.h +++ b/include/osmocom/gbproxy/gb_proxy.h @@ -50,6 +50,8 @@ GBPROX_PEER_CTR_DROPPED, GBPROX_PEER_CTR_INV_NSEI, GBPROX_PEER_CTR_TX_ERR, + GBPROX_PEER_CTR_FWD_FROM_SGSN_ERR, + GBPROX_PEER_CTR_FWD_FROM_BSS_ERR, GBPROX_PEER_CTR_LAST, }; diff --git a/src/gb_proxy.c b/src/gb_proxy.c index c2b958a..298e132 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -532,6 +532,9 @@ } } + if (rc < 0) + rate_ctr_inc(rate_ctr_group_get_ctr(bss_bvc->ctrg, GBPROX_PEER_CTR_FWD_FROM_BSS_ERR)); + return 0; } @@ -606,8 +609,12 @@ default: break; } - return gbprox_relay2peer(msg, bss_bvc, bss_bvc->bvci); + rc = gbprox_relay2peer(msg, bss_bvc, bss_bvc->bvci); + if (rc < 0) + rate_ctr_inc(rate_ctr_group_get_ctr(bss_bvc->ctrg, GBPROX_PEER_CTR_FWD_FROM_SGSN_ERR)); + + return rc; } /*********************************************************************** diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c index 74bde3a..1e300ad 100644 --- a/src/gb_proxy_peer.c +++ b/src/gb_proxy_peer.c @@ -39,11 +39,13 @@ extern void *tall_sgsn_ctx; static const struct rate_ctr_desc bvc_ctr_description[] = { - [GBPROX_PEER_CTR_BLOCKED] = { "blocked", "BVC Block " }, - [GBPROX_PEER_CTR_UNBLOCKED] = { "unblocked", "BVC Unblock " }, - [GBPROX_PEER_CTR_DROPPED] = { "dropped", "BVC blocked, dropped packet " }, - [GBPROX_PEER_CTR_INV_NSEI] = { "inv-nsei", "NSEI mismatch " }, - [GBPROX_PEER_CTR_TX_ERR] = { "tx-err", "NS Transmission error " }, + [GBPROX_PEER_CTR_BLOCKED] = { "blocked", "BVC Block " }, + [GBPROX_PEER_CTR_UNBLOCKED] = { "unblocked", "BVC Unblock " }, + [GBPROX_PEER_CTR_DROPPED] = { "dropped", "BVC blocked, dropped packet " }, + [GBPROX_PEER_CTR_INV_NSEI] = { "inv-nsei", "NSEI mismatch " }, + [GBPROX_PEER_CTR_TX_ERR] = { "tx-err", "NS Transmission error " }, + [GBPROX_PEER_CTR_FWD_FROM_SGSN_ERR] = { "fwd-sgsn-err", "Forwarding data from SGSN failed" }, + [GBPROX_PEER_CTR_FWD_FROM_BSS_ERR] = { "fwd-bss-err", "Forwarding data from BSS failed " }, }; osmo_static_assert(ARRAY_SIZE(bvc_ctr_description) == GBPROX_PEER_CTR_LAST, everything_described); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I7fa972ba843993dac84241c04d66d5b7e2a0b40f Gerrit-Change-Number: 27396 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy_peer: Use designated initializers for bvc_ctr_description

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27395 ) Change subject: gbproxy_peer: Use designated initializers for bvc_ctr_description ...................................................................... gbproxy_peer: Use designated initializers for bvc_ctr_description Change-Id: If571e5d5b653291f34df516b801f35225dd4f7c9 --- M src/gb_proxy_peer.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/95/27395/1 diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c index 0070155..74bde3a 100644 --- a/src/gb_proxy_peer.c +++ b/src/gb_proxy_peer.c @@ -39,11 +39,11 @@ extern void *tall_sgsn_ctx; static const struct rate_ctr_desc bvc_ctr_description[] = { - { "blocked", "BVC Block " }, - { "unblocked", "BVC Unblock " }, - { "dropped", "BVC blocked, dropped packet " }, - { "inv-nsei", "NSEI mismatch " }, - { "tx-err", "NS Transmission error " }, + [GBPROX_PEER_CTR_BLOCKED] = { "blocked", "BVC Block " }, + [GBPROX_PEER_CTR_UNBLOCKED] = { "unblocked", "BVC Unblock " }, + [GBPROX_PEER_CTR_DROPPED] = { "dropped", "BVC blocked, dropped packet " }, + [GBPROX_PEER_CTR_INV_NSEI] = { "inv-nsei", "NSEI mismatch " }, + [GBPROX_PEER_CTR_TX_ERR] = { "tx-err", "NS Transmission error " }, }; osmo_static_assert(ARRAY_SIZE(bvc_ctr_description) == GBPROX_PEER_CTR_LAST, everything_described); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: If571e5d5b653291f34df516b801f35225dd4f7c9 Gerrit-Change-Number: 27395 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: treewide: rename rpi4-raspbian10 to rpi4-raspbian11

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27393 ) Change subject: treewide: rename rpi4-raspbian10 to rpi4-raspbian11 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0b2e08b11d83243e81b2bb4412ffcc9bc59821ff Gerrit-Change-Number: 27393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 14:45:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022