March 2022 - gerrit-log - lists.osmocom.org

Change in simtrace2[master]: simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/27389 ) Change subject: simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR ...................................................................... simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR Sometimes I get LIBUSB_TRANSFER_ERROR particularly when the USB bus is very busy. We shouldn't terminate the program, but simply resubmit it. That's what we have multiple transfers for... Change-Id: I77d7bc636c21171fcff7e70e87c0109cbaee9b51 --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/89/27389/1 diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index df4397a..c86f06a 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -278,6 +278,9 @@ /* hand the message up the stack */ process_usb_msg(ci, xfer->buffer, xfer->actual_length); break; + case LIBUSB_TRANSFER_ERROR: + LOGCI(ci, LOGL_FATAL, "USB IN transfer error, trying resubmit\n"); + break; case LIBUSB_TRANSFER_NO_DEVICE: LOGCI(ci, LOGL_FATAL, "USB device disappeared\n"); exit(1); @@ -329,6 +332,9 @@ case LIBUSB_TRANSFER_COMPLETED: process_usb_msg_irq(ci, xfer->buffer, xfer->actual_length); break; + case LIBUSB_TRANSFER_ERROR: + LOGCI(ci, LOGL_FATAL, "USB INT transfer error, trying resubmit\n"); + break; case LIBUSB_TRANSFER_NO_DEVICE: LOGCI(ci, LOGL_FATAL, "USB device disappeared\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77d7bc636c21171fcff7e70e87c0109cbaee9b51 Gerrit-Change-Number: 27389 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: simtrace: Enable VCC detection via ADC (voltage dependent)

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/27387 ) Change subject: simtrace: Enable VCC detection via ADC (voltage dependent) ...................................................................... simtrace: Enable VCC detection via ADC (voltage dependent) SIMtrace should reject any card activation at 1.8V as it is a 3[.3]V device without level shifters. For this, we must include the ADC in determining the VCC voltage. Change-Id: Ic76f06037590ff1c0dae818d5eb2c2019dd75f2d FIXME: reporting uses raw ADC voltage, not the voltage before divider --- M firmware/libboard/simtrace/include/board.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/87/27387/1 diff --git a/firmware/libboard/simtrace/include/board.h b/firmware/libboard/simtrace/include/board.h index 7cb30b0..d6905ea 100644 --- a/firmware/libboard/simtrace/include/board.h +++ b/firmware/libboard/simtrace/include/board.h @@ -155,3 +155,7 @@ #endif /* SIMtrace board supports man-in-the-middle mode */ //#define HAVE_MITM + +#define DETECT_VCC_BY_ADC +#define VCC_UV_THRESH_1V8 (1500000/2) /* 10k/10k resistive divider halves voltage */ +#define VCC_UV_THRESH_3V (2500000/2) /* 10k/10k resistive divider halves voltage */ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ic76f06037590ff1c0dae818d5eb2c2019dd75f2d Gerrit-Change-Number: 27387 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: simtrace2-cardem-pcsc: Fix copy+paste error in log message

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/27388 ) Change subject: simtrace2-cardem-pcsc: Fix copy+paste error in log message ...................................................................... simtrace2-cardem-pcsc: Fix copy+paste error in log message Change-Id: I98e4356900a22f69d0ff262cb112194b1e11d4af --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/88/27388/1 diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index c684868..df4397a 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -334,7 +334,7 @@ exit(1); break; default: - LOGCI(ci, LOGL_FATAL, "USB IN transfer failed, status=%u\n", xfer->status); + LOGCI(ci, LOGL_FATAL, "USB INT transfer failed, status=%u\n", xfer->status); exit(1); break; } -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I98e4356900a22f69d0ff262cb112194b1e11d4af Gerrit-Change-Number: 27388 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: system_information: use is_ipaccess_bts() helper

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27385 ) Change subject: system_information: use is_ipaccess_bts() helper ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id14f39f50a6d7644f81b21c0b89e10f44901348b Gerrit-Change-Number: 27385 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 11:51:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: system_information: fix DCS/PCS band indicator in generate_si6()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27386 ) Change subject: system_information: fix DCS/PCS band indicator in generate_si6() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: unit test would be great. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iaa8377919a144e7f3799b76249f579c8f3874145 Gerrit-Change-Number: 27386 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 11:51:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: system_information: fix DCS/PCS band indicator in generate_si6()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27386 ) Change subject: system_information: fix DCS/PCS band indicator in generate_si6() ...................................................................... system_information: fix DCS/PCS band indicator in generate_si6() Change-Id: Iaa8377919a144e7f3799b76249f579c8f3874145 --- M src/osmo-bsc/system_information.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/86/27386/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index bedba3a..27c60a0 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1190,7 +1190,7 @@ gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, false); /* SI6 Rest Octets: 10.5.2.35a: PCH / NCH info, VBS/VGCS options */ - si6_ro_info.band_indicator_1900 = is_dcs_net(bts); + si6_ro_info.band_indicator_1900 = !is_dcs_net(bts); rc = osmo_gsm48_rest_octets_si6_encode(si6->rest_octets, &si6_ro_info); return l2_plen + rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iaa8377919a144e7f3799b76249f579c8f3874145 Gerrit-Change-Number: 27386 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: system_information: use is_ipaccess_bts() helper

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27385 ) Change subject: system_information: use is_ipaccess_bts() helper ...................................................................... system_information: use is_ipaccess_bts() helper Change-Id: Id14f39f50a6d7644f81b21c0b89e10f44901348b --- M src/osmo-bsc/system_information.c 1 file changed, 4 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/27385/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index dfde5a2..bedba3a 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1066,14 +1066,9 @@ memset(output, GSM_MACBLOCK_PADDING, GSM_MACBLOCK_LEN); /* ip.access nanoBTS needs l2_plen!! */ - switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS: - case GSM_BTS_TYPE_OSMOBTS: + if (is_ipaccess_bts(bts)) { *output++ = GSM48_LEN2PLEN(l2_plen); l2_plen++; - break; - default: - break; } si5 = (struct gsm48_system_information_type_5 *) output; @@ -1102,14 +1097,9 @@ memset(output, GSM_MACBLOCK_PADDING, GSM_MACBLOCK_LEN); /* ip.access nanoBTS needs l2_plen!! */ - switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS: - case GSM_BTS_TYPE_OSMOBTS: + if (is_ipaccess_bts(bts)) { *output++ = GSM48_LEN2PLEN(l2_plen); l2_plen++; - break; - default: - break; } si5b = (struct gsm48_system_information_type_5bis *) output; @@ -1146,14 +1136,9 @@ memset(output, GSM_MACBLOCK_PADDING, GSM_MACBLOCK_LEN); /* ip.access nanoBTS needs l2_plen!! */ - switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS: - case GSM_BTS_TYPE_OSMOBTS: + if (is_ipaccess_bts(bts)) { *output++ = GSM48_LEN2PLEN(l2_plen); l2_plen++; - break; - default: - break; } si5t = (struct gsm48_system_information_type_5ter *) output; @@ -1186,14 +1171,9 @@ memset(&si6_ro_info, 0, sizeof(si6_ro_info)); /* ip.access nanoBTS needs l2_plen!! */ - switch (bts->type) { - case GSM_BTS_TYPE_NANOBTS: - case GSM_BTS_TYPE_OSMOBTS: + if (is_ipaccess_bts(bts)) { *output++ = GSM48_LEN2PLEN(l2_plen); l2_plen++; - break; - default: - break; } si6 = (struct gsm48_system_information_type_6 *) output; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id14f39f50a6d7644f81b21c0b89e10f44901348b Gerrit-Change-Number: 27385 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MGCP_Test: ensure PT translation works when converting AMR bwe/oa

by pespin

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27384 ) Change subject: MGCP_Test: ensure PT translation works when converting AMR bwe/oa ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id734b6954098130bba02f8cdf1b06e0080c3e915 Gerrit-Change-Number: 27384 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 10:38:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[2021q4]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27383 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2021q4 Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27383 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 10:36:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[2021q4]: tests/gsm0408: add testing coverage for generate_cell_chan_list()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27382 ) Change subject: tests/gsm0408: add testing coverage for generate_cell_chan_list() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2021q4 Gerrit-Change-Id: Ied0519c70501f105673a9b36657101063d275058 Gerrit-Change-Number: 27382 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 10:36:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022