March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-gbproxy[master]: gbproxy: Only route to an SGSN if the BVC is not blocked

by daniel

Attention is currently required from: laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 ) Change subject: gbproxy: Only route to an SGSN if the BVC is not blocked ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > maybe some kind of counetr or whatever else might help noticing such events? I added rate counters in I7fa972ba843993dac84241c04d66d5b7e2a0b40f. They count failures to forward messages from BSS and SGSN respectively. -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 Gerrit-Change-Number: 27322 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 17:02:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: usb: Match device by VID/PID without path/addr if it is unique

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27398 ) Change subject: usb: Match device by VID/PID without path/addr if it is unique ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > This looks a bit dangerous. […] the current problem is that you always have to specify either the address or the path for all the simtrace tools. That's annoying as the address and path changes every time you plug the device itno some other socket of your computer. For all those users that only have a single simtrace connected, it is inconvenient having to specify those parameters all the time. Even with this patch the application must explicitly request this behavior by not providing a path (strlen == 0) and by not providing an address (0). So any application that specifies either a path or an address will not have the automatic selection. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ef245a56dfcf22758a0216b86d2a5c602ee5588 Gerrit-Change-Number: 27398 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 17:01:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/27389 ) Change subject: simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR ...................................................................... simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR Sometimes I get LIBUSB_TRANSFER_ERROR particularly when the USB bus is very busy. We shouldn't terminate the program, but simply resubmit it. That's what we have multiple transfers for... Change-Id: I77d7bc636c21171fcff7e70e87c0109cbaee9b51 --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 031e1f0..b7d41bd 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -278,6 +278,9 @@ /* hand the message up the stack */ process_usb_msg(ci, xfer->buffer, xfer->actual_length); break; + case LIBUSB_TRANSFER_ERROR: + LOGCI(ci, LOGL_FATAL, "USB IN transfer error, trying resubmit\n"); + break; case LIBUSB_TRANSFER_NO_DEVICE: LOGCI(ci, LOGL_FATAL, "USB device disappeared\n"); exit(1); @@ -329,6 +332,9 @@ case LIBUSB_TRANSFER_COMPLETED: process_usb_msg_irq(ci, xfer->buffer, xfer->actual_length); break; + case LIBUSB_TRANSFER_ERROR: + LOGCI(ci, LOGL_FATAL, "USB INT transfer error, trying resubmit\n"); + break; case LIBUSB_TRANSFER_NO_DEVICE: LOGCI(ci, LOGL_FATAL, "USB device disappeared\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77d7bc636c21171fcff7e70e87c0109cbaee9b51 Gerrit-Change-Number: 27389 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: host: Don't pass -1 (converted to 255) as address

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/27397 ) Change subject: host: Don't pass -1 (converted to 255) as address ...................................................................... host: Don't pass -1 (converted to 255) as address We initialize a local variable to -1, and if the user specifies no address from the command line, we use this in the interface match struct, which uses a uint8_t. This means 255 ends up in there, and as a result no usb interface ever matches unless the user explicitly specifies the -A command line argument. With this patch any absent -A argument will result in ifm.addr == 0, which means "don't match on address", and which is what we want here. Change-Id: Iffb5fa406ddef00c7c15570ffca2c109b98d7a2d --- M host/src/simtrace2-cardem-pcsc.c M host/src/simtrace2-tool.c 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 0eaf2c3..dabe693 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -587,7 +587,8 @@ ifm->configuration = config_id; ifm->interface = if_num; ifm->altsetting = altsetting; - ifm->addr = addr; + if (addr > 0 && addr < 256) + ifm->addr = addr; if (path) osmo_strlcpy(ifm->path, path, sizeof(ifm->path)); transp->udp_fd = -1; diff --git a/host/src/simtrace2-tool.c b/host/src/simtrace2-tool.c index b0fac6c..fdf0d56 100644 --- a/host/src/simtrace2-tool.c +++ b/host/src/simtrace2-tool.c @@ -309,7 +309,8 @@ ifm->configuration = config_id; ifm->interface = if_num; ifm->altsetting = altsetting; - ifm->addr = addr; + if (addr > 0 && addr < 256) + ifm->addr = addr; if (path) osmo_strlcpy(ifm->path, path, sizeof(ifm->path)); transp->usb_devh = osmo_libusb_open_claim_interface(NULL, NULL, ifm); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Iffb5fa406ddef00c7c15570ffca2c109b98d7a2d Gerrit-Change-Number: 27397 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: simtrace2-cardem-pcsc: Fix copy+paste error in log message

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/27388 ) Change subject: simtrace2-cardem-pcsc: Fix copy+paste error in log message ...................................................................... simtrace2-cardem-pcsc: Fix copy+paste error in log message Change-Id: I98e4356900a22f69d0ff262cb112194b1e11d4af --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index dabe693..031e1f0 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -334,7 +334,7 @@ exit(1); break; default: - LOGCI(ci, LOGL_FATAL, "USB IN transfer failed, status=%u\n", xfer->status); + LOGCI(ci, LOGL_FATAL, "USB INT transfer failed, status=%u\n", xfer->status); exit(1); break; } -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I98e4356900a22f69d0ff262cb112194b1e11d4af Gerrit-Change-Number: 27388 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/27389 ) Change subject: simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77d7bc636c21171fcff7e70e87c0109cbaee9b51 Gerrit-Change-Number: 27389 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:58:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: host: Don't pass -1 (converted to 255) as address

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/27397 ) Change subject: host: Don't pass -1 (converted to 255) as address ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Iffb5fa406ddef00c7c15570ffca2c109b98d7a2d Gerrit-Change-Number: 27397 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:58:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: simtrace2-cardem-pcsc: Fix copy+paste error in log message

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/27388 ) Change subject: simtrace2-cardem-pcsc: Fix copy+paste error in log message ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I98e4356900a22f69d0ff262cb112194b1e11d4af Gerrit-Change-Number: 27388 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:58:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in simtrace2[master]: contrib/simtrace.lua: Add Flag bits + Data to COL_INFO

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26985 ) Change subject: contrib/simtrace.lua: Add Flag bits + Data to COL_INFO ...................................................................... Patch Set 5: (1 comment) File contrib/simtrace.lua: https://gerrit.osmocom.org/c/simtrace2/+/26985/comment/c961dc9c_d272aaa5 PS1, Line 93: if is_pbrx().value == 1 then > I see no difference, between previous and current patchset. the syntax you provided simply doesn't work here: "unexpected symbol near if" -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I0aa3d68172022907fbe8371aaca6538df0649dfe Gerrit-Change-Number: 26985 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:57:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: usb: Match device by VID/PID without path/addr if it is unique

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27398 ) Change subject: usb: Match device by VID/PID without path/addr if it is unique ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This looks a bit dangerous. Because then the behavior of your program with the same config changes based on the amount of devices you have connected on your system. Not sure it's a good idea? If only the VID/PID is needed in that case I'd expect that to come from config explicitly (the user only specifies that one, and leave the path empty strlen()=0. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ef245a56dfcf22758a0216b86d2a5c602ee5588 Gerrit-Change-Number: 27398 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 16:50:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022