Attention is currently required from: msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30663 )
Change subject: ctrl: take both address and port from vty config
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30663
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ieca05004255c40287e6427560c2636b39529cf07
Gerrit-Change-Number: 30663
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 19:57:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30666 )
Change subject: ctrl: take both address and port from vty config
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30666
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id053bc02e0a6359e52a0f5e110128d3bb87ed151
Gerrit-Change-Number: 30666
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 19:56:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30671 )
Change subject: ctrl: take both address and port from vty config
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30671
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Id7d1425e603cc62a62a63d1057291861f02782ba
Gerrit-Change-Number: 30671
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 19:55:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, fixeria, pespin.
Hello Jenkins Builder, laforge, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/30416
to look at the new patch set (#28).
Change subject: ms-trx support
......................................................................
ms-trx support
This is basically a trxcon that includes a transceiver, and can just
be used with existing and future apps supporting the trxcon interface,
i.e. mobile or ccch_scan.
Supports bladerf and uhd.
Currently using hardcoded sched/prios aimed at a setup with working,
reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3,
not 2, not any other version)
Additionally builds test tools used for development: osmo-trx-syncthing*
see https://osmocom.org/projects/baseband/wiki/MS-side_GPRS for the
project description and details
Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
---
M .gitignore
M .gitmodules
M Makefile.am
M Transceiver52M/Makefile.am
M Transceiver52M/grgsm_vitac/grgsm_vitac.cpp
M Transceiver52M/grgsm_vitac/grgsm_vitac.h
A Transceiver52M/ms/bladerf_specific.h
A Transceiver52M/ms/itrq.h
A Transceiver52M/ms/l1ctl_server.c
A Transceiver52M/ms/l1ctl_server_cb.cpp
A Transceiver52M/ms/logging.c
A Transceiver52M/ms/ms.cpp
A Transceiver52M/ms/ms.h
A Transceiver52M/ms/ms_rx_burst.h
A Transceiver52M/ms/ms_rx_burst_test.cpp
A Transceiver52M/ms/ms_rx_lower.cpp
A Transceiver52M/ms/ms_upper.cpp
A Transceiver52M/ms/ms_upper.h
A Transceiver52M/ms/sch.c
A Transceiver52M/ms/sch.h
A Transceiver52M/ms/uhd_specific.h
M configure.ac
M contrib/jenkins.sh
M osmocom-bb
24 files changed, 3,534 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/28
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 28
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: daniel.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30690 )
Change subject: Rename TC_tx_power_start_ramp_down_bcch
......................................................................
Patch Set 3:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30690/comment/fabdd89c_574e…
PS3, Line 8869: TC_tx_power_start_ramp_down_bcch
When renaming testcases, don't forget to update the expected-results.xml.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30690
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I463679d9678b95b7d3a5ace711c6ce17b3b24689
Gerrit-Change-Number: 30690
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 19:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, fixeria, pespin.
Hello Jenkins Builder, laforge, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/30416
to look at the new patch set (#27).
Change subject: ms-trx support
......................................................................
ms-trx support
This is basically a trxcon that includes a transceiver, and can just
be used with existing and future apps supporting the trxcon interface,
i.e. mobile or ccch_scan.
Supports bladerf and uhd.
Currently using hardcoded sched/prios aimed at a setup with working,
reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3,
not 2, not any other version)
Additionally builds test tools used for development: osmo-trx-syncthing*
see https://osmocom.org/projects/baseband/wiki/MS-side_GPRS for the
project description and details
Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
---
M .gitignore
M .gitmodules
M Makefile.am
M Transceiver52M/Makefile.am
M Transceiver52M/grgsm_vitac/grgsm_vitac.cpp
M Transceiver52M/grgsm_vitac/grgsm_vitac.h
A Transceiver52M/ms/bladerf_specific.h
A Transceiver52M/ms/itrq.h
A Transceiver52M/ms/l1ctl_server.c
A Transceiver52M/ms/l1ctl_server_cb.cpp
A Transceiver52M/ms/logging.c
A Transceiver52M/ms/ms.cpp
A Transceiver52M/ms/ms.h
A Transceiver52M/ms/ms_rx_burst.h
A Transceiver52M/ms/ms_rx_burst_test.cpp
A Transceiver52M/ms/ms_rx_lower.cpp
A Transceiver52M/ms/ms_upper.cpp
A Transceiver52M/ms/ms_upper.h
A Transceiver52M/ms/sch.c
A Transceiver52M/ms/sch.h
A Transceiver52M/ms/uhd_specific.h
M configure.ac
M contrib/jenkins.sh
M osmocom-bb
24 files changed, 3,535 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/27
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 27
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30757 )
Change subject: Introduce utils/osmo-amr-inspect program
......................................................................
Patch Set 3:
(2 comments)
File utils/osmo-amr-inspect.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2191):
https://gerrit.osmocom.org/c/libosmo-netif/+/30757/comment/da5a8ea4_db47ee8f
PS3, Line 51: do { \
suspect code indent for conditional statements (8, 8)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2191):
https://gerrit.osmocom.org/c/libosmo-netif/+/30757/comment/4c3366f9_bce7bd85
PS3, Line 56: } while(0)
space required before the open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30757
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Iffa6cc2e5391b77e3097d4c3b8d3f5211427dbe2
Gerrit-Change-Number: 30757
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 19:40:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30757
to look at the new patch set (#3).
Change subject: Introduce utils/osmo-amr-inspect program
......................................................................
Introduce utils/osmo-amr-inspect program
This program allows inspecting a list of AMR PDUs in hexstring format
present in a text file.
This allows easily finding out the properties of the PDU as well as
finding potential errors on the data.
It also allows forcing decode in different formats (octet-aligned,
bandwidth-efficient) in order to detect which may be the correct one.
Related: SYS#6161
Change-Id: Iffa6cc2e5391b77e3097d4c3b8d3f5211427dbe2
---
M Makefile.am
M configure.ac
M contrib/libosmo-netif.spec.in
A utils/Makefile.am
A utils/osmo-amr-inspect.c
5 files changed, 315 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/57/30757/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30757
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Iffa6cc2e5391b77e3097d4c3b8d3f5211427dbe2
Gerrit-Change-Number: 30757
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith, laforge, daniel.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30689 )
Change subject: shutdown_fsm: Add power_ramp_force() to jump straight to the tgt power
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File include/osmo-bts/tx_power.h:
https://gerrit.osmocom.org/c/osmo-bts/+/30689/comment/447aacf4_e38e50b9
PS2, Line 83: force
Maybe '_skip' is a better fit here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30689
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ida1d7bbf094958b9142af306dbf84206729a609e
Gerrit-Change-Number: 30689
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 19:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30757 )
Change subject: Introduce utils/osmo-amr-inspect program
......................................................................
Patch Set 2:
(1 comment)
File utils/osmo-amr-inspect.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/30757/comment/8e7c51a6_3ed80f13
PS2, Line 2: Utility program for ARFCN / frequency calculations
FIXME
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30757
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Iffa6cc2e5391b77e3097d4c3b8d3f5211427dbe2
Gerrit-Change-Number: 30757
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 19:25:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment