gerrit-log December 2022

gerrit-log@lists.osmocom.org

1 participants
1979 discussions

Change in osmo-ci[master]: ansible: coverity: update version to 22.06

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30417 ) Change subject: ansible: coverity: update version to 22.06 ...................................................................... ansible: coverity: update version to 22.06 Coverity doesn't make the old version available for download and will probably deprecate the previous version at some point. I'm about to install it on new hosts, so upgrade to the latest version while at it. Related: OS#5793 Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4 --- M ansible/roles/install-coverity/defaults/main.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/30417/1 diff --git a/ansible/roles/install-coverity/defaults/main.yml b/ansible/roles/install-coverity/defaults/main.yml index d7a8082..4a74887 100644 --- a/ansible/roles/install-coverity/defaults/main.yml +++ b/ansible/roles/install-coverity/defaults/main.yml @@ -1,4 +1,4 @@ --- -coverity_version: 2021.12.1 +coverity_version: 2022.06 coverity_installer_file: "cov-analysis-linux64-{{ coverity_version }}.tar.gz" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4 Gerrit-Change-Number: 30417 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

Change in osmo-ci[master]: ansible/coverity: extract into subdirectory

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30418 ) Change subject: ansible/coverity: extract into subdirectory ...................................................................... ansible/coverity: extract into subdirectory The tarball provided by coverity doesn't have the same version in the name as in the directory inside the tarball. Tarball: cov-analysis-linux64-2022.06.tar.gz Directory: cov-analysis-linux64-2022.6.0 Work around this by extracting it into a subdirectory and using glob to match the directory name. Related: OS#5793 Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b --- M ansible/roles/install-coverity/tasks/main.yml 1 file changed, 7 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/18/30418/1 diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml index 5baf6f3..4047fb8 100644 --- a/ansible/roles/install-coverity/tasks/main.yml +++ b/ansible/roles/install-coverity/tasks/main.yml @@ -13,9 +13,9 @@ ignore_errors: yes tags: [coverity] -- name: create /opt/coverity +- name: create /opt/coverity/{{ coverity_version }}/ file: - path: /opt/coverity/ + path: /opt/coverity/{{ coverity_version }}/ state: directory when: coverity_copy.failed == False tags: [coverity] @@ -23,16 +23,15 @@ - name: unpack coverity unarchive: src: "/tmp/{{ coverity_installer_file }}" - dest: /opt/coverity/ + dest: /opt/coverity/{{ coverity_version }} remote_src: yes when: coverity_copy.failed == False tags: [coverity] -- name: create link /opt/coverity/last - file: - src: /opt/coverity/cov-analysis-linux64-{{ coverity_version }} - dest: /opt/coverity/current - state: link +- name: create link /opt/coverity/current + shell: ln -sf /opt/coverity/{{ coverity_version }}/* /opt/coverity/current + args: + warn: false when: coverity_copy.failed == False tags: [coverity] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b Gerrit-Change-Number: 30418 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

Change in osmo-trx[master]: rename noisevector class -> avgvector

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 ) Change subject: rename noisevector class -> avgvector ...................................................................... Patch Set 1: Verified+1 Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:05:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: ignore vscode dirs

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 ) Change subject: ignore vscode dirs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c Gerrit-Change-Number: 30410 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:04:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

Change in libosmo-pfcp[master]: bitmask to string: shorten

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30408 ) Change subject: bitmask to string: shorten ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I38426d6381e96d4a683e46eba1bdd29c73d3f027 Gerrit-Change-Number: 30408 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:03:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

Change in libosmo-pfcp[master]: fix coding of Network Instance IE

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406 ) Change subject: fix coding of Network Instance IE ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/a6083bac_3c46af10 PS1, Line 13: These qualify for moving to libosmocore utils > BTW, libosmocore already offers some APN conversion API: https://cgit.osmocom. […] SO IIUC the code that neels proposes here is not needed since the same is already implemented in libosmocore? File src/libosmo-pfcp/pfcp_ies_custom.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/e1f9af35_922dc52e PS1, Line 86: static int strncpy_buf(char *buf, size_t buflen, const char *src, size_t len) len is "srclen"? -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I9d67464ef0f92b0512cfd6e48d203f8828a82a19 Gerrit-Change-Number: 30406 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:01:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

Change in libosmo-pfcp[master]: pfcp coding errmsgs: drop extra newlines

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30405 ) Change subject: pfcp coding errmsgs: drop extra newlines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4eea1efc9bd67676b6202e50d41974b2717a2511 Gerrit-Change-Number: 30405 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:57:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

Change in libosmo-pfcp[master]: add osmo_pfcp_ie_outer_header_creation_to_str_*()

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30403 ) Change subject: add osmo_pfcp_ie_outer_header_creation_to_str_*() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4ad1570485c8081b82284e4e6b4de4d7eed414b0 Gerrit-Change-Number: 30403 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:57:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: ms-trx support

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 3: (408 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba8b0baa_cc5224e6 PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ea5a549_5e132e96 PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1171cda_c5a690a8 PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a227c8ce_9c3eb6c4 PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d1390a7_2fd4c30b PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e01b625a_c1744783 PS3, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1feed99_d573da8b PS3, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c994dd2f_ac76abde PS3, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b37c0ad_3f397823 PS3, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29fcfe2c_12eb8da6 PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2f9048eb_2485c549 PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54d4576e_51378b22 PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4bd5af4_6aaad064 PS3, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5feefac5_a07a24a5 PS3, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/990925f3_d997a82c PS3, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16d85c35_d6839e2b PS3, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55f935b3_8f1f7261 PS3, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/691bf1e1_ca297b28 PS3, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca1f471a_0123b27d PS3, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daf3b8ac_0cf13f09 PS3, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d3326e0_dd27a2f7 PS3, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5f6c7d9_c4fccb2b PS3, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec0b9219_6bb24672 PS3, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd886d35_8e006dd9 PS3, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a1491bb_0ddfe138 PS3, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/981325ad_a475ddbc PS3, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c68e9996_8b126a4b PS3, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bb7e3f3_6ce98626 PS3, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75029840_7841d8d9 PS3, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4879256_cc0d47b5 PS3, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0a917ac_0f5bbe43 PS3, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ebb64aba_7ad26910 PS3, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d0b57cd_c409917d PS3, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b0f881f_b7366e7e PS3, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6931c674_bf35d054 PS3, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d36167f7_d4262f3f PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f81910fd_db9b9691 PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02d8b1ef_cdef212e PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1041f7e_03662dc3 PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ded46a75_4e8244fe PS3, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b36b03b3_c26a3a3f PS3, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ad0f057_c673f117 PS3, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f79c4051_50e75fd4 PS3, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39abcdb8_5fded511 PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad0e3eb6_7cb9145e PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c64d23d_e773b03f PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9674b9e7_bd870d1d PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d544a74a_86f6e043 PS3, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0eb47131_06b66f43 PS3, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc9b7289_513d9183 PS3, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f73c6c4_67b3edc3 PS3, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a2c8415_cdd50fe3 PS3, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4034d376_285b9bbd PS3, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6ee28aa_e4d2c9d3 PS3, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7a0061f_02a27a43 PS3, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0cfba239_a4207e81 PS3, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/657a6cfd_75bb5b36 PS3, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0260057_077b235f PS3, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1beaf79_33ccdf24 PS3, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f051ce8_cc48d68c PS3, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29329646_6c8d99c0 PS3, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86ca7775_6812e59c PS3, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc345c1a_cce44b35 PS3, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f47cc868_1895eeb1 PS3, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3214031c_d7efc070 PS3, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc44a38c_7fabb7f1 PS3, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddeb7121_f16328df PS3, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b82b7796_04223e41 PS3, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec08b7ae_debe9d0c PS3, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bab2c6d_7f3e1e93 PS3, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42a65e8a_6abb3023 PS3, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24ebeb49_30800d27 PS3, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff697468_d3417e60 PS3, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e846e1e4_4c6f3a24 PS3, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/119dc541_2c0ed57e PS3, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d354ab4_24deabf0 PS3, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/117fb990_e2f8e338 PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49590da0_ff770364 PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0445a94c_e5911f13 PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25362f18_6346e42c PS3, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27e770bd_aa56f365 PS3, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42ba2f14_c63b9c44 PS3, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e51145d_f8f36aa1 PS3, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3610503_042fc96e PS3, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a6ef1a8_f4fa6aae PS3, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/821fa3e5_3b06513a PS3, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a15c78ac_1c0a22ca PS3, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/390992bc_1f130e0f PS3, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5be12e54_60191e4a PS3, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/923b289f_132d9225 PS3, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba084ab9_3bf5a1c6 PS3, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8566624f_7d22d454 PS3, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b292305_a4471848 PS3, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/287a7c2d_8fbb49da PS3, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18bd6c62_8512d5e0 PS3, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4bf690c_0668cd2c PS3, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40f4c20f_8f1f005b PS3, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2eb06af3_1f75154c PS3, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1249c3b9_4f577da2 PS3, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/640852e3_61ca29bd PS3, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0019793b_c364da36 PS3, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6d0805d_f1234cbe PS3, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37866471_03c18272 PS3, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe00b8cc_ff49cc04 PS3, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec06a734_9896ef53 PS3, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aef59f4e_da266579 PS3, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11132b87_e1b03d57 PS3, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d4eb73e_728c0516 PS3, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ad52825_01ef6467 PS3, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0dc16bbd_ec80111f PS3, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba3e7025_d6cdd5ca PS3, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbbb7d6b_bff63695 PS3, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcb52d46_3c5b391b PS3, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/ipc_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/914548e4_6cfec982 PS3, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4e1cd58_686b327c PS3, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7edcf6e3_57ca4c37 PS3, Line 45: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ffceee11_6b59f90d PS3, Line 45: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66196f55_533c4cb3 PS3, Line 49: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd96e752_f398f0f2 PS3, Line 49: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bbc627c_eb69c788 PS3, Line 53: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3e506ed_0a4b3d3b PS3, Line 58: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb0b01f3_4a4c1507 PS3, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55a1f448_6cd64b3e PS3, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c04aeb8d_b86bb002 PS3, Line 71: template <typename T> struct ipc_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af9b8f93_8d0147be PS3, Line 71: template <typename T> struct ipc_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26a9e62a_a7034855 PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2e0f29c_c4582754 PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a136e69_cc4b306a PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/deab6179_bdb67879 PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f02102b9_be01c97b PS3, Line 92: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da14af62_34ee9566 PS3, Line 99: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14cbe96b_3188668e PS3, Line 106: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/41519892_cd3937c1 PS3, Line 111: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f2beeed_86859d26 PS3, Line 119: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/becf3c31_1654ff46 PS3, Line 127: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4f9fd20_a08996bf PS3, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4428091_102e6d57 PS3, Line 137: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8f2d068_e240070a PS3, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f99df907_8d85636f PS3, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3222a247_3c7ae87a PS3, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c59289ee_50d68ac7 PS3, Line 166: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/839b7491_a930c174 PS3, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31343549_a46ac0a1 PS3, Line 177: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd0e1b8c_f7bd9940 PS3, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/140e10c9_0648d5b2 PS3, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f921479a_3380381b PS3, Line 193: void signal_start() Bad function definition - void signal_start() should probably be void signal_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/231f3f5c_07d6310b PS3, Line 193: void signal_start() open brace '{' following function definitions go on the next line File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c82aec61_39991c07 PS3, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c2bb9a2_d975b158 PS3, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e74b49c_246238c0 PS3, Line 52: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c944dff1_d38376db PS3, Line 53: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60d3bb97_2eda81dc PS3, Line 54: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f3c8a6c_49cdfe42 PS3, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/150cabb2_814ac186 PS3, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87ab023b_049880b1 PS3, Line 65: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5da13b7c_26e856d5 PS3, Line 65: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ad57fe6_b9b2bf96 PS3, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78db5da9_355c999b PS3, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d31a1b3d_40323c31 PS3, Line 67: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd0492ef_5ff6b31b PS3, Line 73: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e86920b_e633b0f8 PS3, Line 73: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf73cf7b_258b5d71 PS3, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76ff7026_072913b1 PS3, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d283347_cf89dcb4 PS3, Line 75: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11d83567_bc6dd09c PS3, Line 81: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4108089_44011c20 PS3, Line 81: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cd34243_60a3917b PS3, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50a73c19_97eb9038 PS3, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec33dd04_9c39d3ff PS3, Line 83: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c996c184_ae7f06b4 PS3, Line 87: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b41cf42_be3ae62b PS3, Line 87: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87e9395d_c3b97e37 PS3, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a979ef5_5fd5f50f PS3, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d087f75_3e2b035c PS3, Line 89: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5447f3b_c40efb11 PS3, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/909805c3_cb26d06d PS3, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74f817d1_965b9057 PS3, Line 99: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/69d429f5_aef5217a PS3, Line 100: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ededf509_8ad31777 PS3, Line 111: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/291b5beb_f3ce3c4e PS3, Line 111: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7325abb_14a22683 PS3, Line 116: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3a1dcc9_962c42e2 PS3, Line 116: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/12b28d8c_4e8238ee PS3, Line 121: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99b1025f_2ad1e918 PS3, Line 121: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e97e714a_073182e0 PS3, Line 126: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05d71af1_0f79790b PS3, Line 126: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c0c25c1_5716bb37 PS3, Line 131: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd03e987_e49774e9 PS3, Line 131: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72424a9e_31ec39fd PS3, Line 135: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/872613ad_69e513c8 PS3, Line 135: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cc4aaf2_1d95ff34 PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bde04339_af3c4eae PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95ee10a7_7f669cc1 PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1e068dbf_9f4f59df PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c0b58272_93487ec3 PS3, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f115708_44edfe3c PS3, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0b1e36a_d7234f23 PS3, Line 144: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ca3d48f_52ccd40b PS3, Line 144: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/befa5b65_10b9e525 PS3, Line 144: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d53fa5fb_5ae9c976 PS3, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e17028e_5093dd33 PS3, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b144b74_b26dcd8c PS3, Line 145: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cbe724ea_51cb83c5 PS3, Line 149: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/88740775_d51ad6f3 PS3, Line 150: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/122ee559_75d81dc3 PS3, Line 150: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf8199de_635cc276 PS3, Line 152: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d750a72a_e552cb37 PS3, Line 163: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d4403e7_44baed4e PS3, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b1eeda1c_9766fcc4 PS3, Line 176: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d497c6e_04e82351 PS3, Line 183: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d3a33b7_d038e2d9 PS3, Line 195: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/016e3712_a9710798 PS3, Line 202: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bb90ecc_3d5ee3cb PS3, Line 202: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e62776c7_99781c02 PS3, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91490d62_ca30fa0a PS3, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3729b56a_cda98f39 PS3, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/630dc86d_23edd8d6 PS3, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/901693b1_ed64a3a1 PS3, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59c30d55_22caf92b PS3, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d0076a18_57aa73d3 PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a5f23dae_187a71de PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3b74d98_0b7de752 PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/logging.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/292183b6_e8f5f6ad PS3, Line 83: .enabled = 0, trailing whitespace File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/def84da7_5f05856e PS3, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/974f1c41_d35cc072 PS3, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f59ab076_431b6db1 PS3, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35ead75f_37b48e3b PS3, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f70a63c3_5c396af4 PS3, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1ef85f0_ebcda613 PS3, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/881a1726_0a2d9da3 PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ccdd3bcd_642b4295 PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bed1ad5_af09eb8f PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8e6dd14c_27cd1583 PS3, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/522d36dd_c053b192 PS3, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5378f472_67925f82 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ca8ce5a_58a5e74e PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a148bfa6_02c2b616 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea11c0ca_92ba2446 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b2d6da55_95291b70 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ee1edf5_346bc3ad PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/203596a9_442c5ed1 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd25bb29_378ff782 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78f02691_f82ed62c PS3, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fbca279d_e7f89242 PS3, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/becc925c_5a0c8ba6 PS3, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c88d7811_dd9ef5dc PS3, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b91cf46_5ad22f46 PS3, Line 75: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddc2b7bf_61038c45 PS3, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03b32806_ddc649f4 PS3, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bfb83da9_60bc59f7 PS3, Line 87: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f49cebff_7cb2fc14 PS3, Line 89: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ae44a51_3d3d520e PS3, Line 90: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef0d20c2_8e1f2044 PS3, Line 92: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a1a031d2_e6e3dde4 PS3, Line 92: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98104e1c_59eab598 PS3, Line 104: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92d58ab7_d385fbd8 PS3, Line 106: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e56a1a3_f1cd1eba PS3, Line 108: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b4aaa0b_ac8daee6 PS3, Line 113: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9fd2791f_a0138377 PS3, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7ef1500_9f3403a3 PS3, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/479a4e99_77e14e32 PS3, Line 115: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/415a31af_399b900b PS3, Line 119: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b29dbcbc_37d4f1f9 PS3, Line 119: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a9b6cba7_cb624fbd PS3, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eee747c1_88976980 PS3, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/73363a15_79b99341 PS3, Line 121: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6019d3cd_11daceec PS3, Line 125: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35a1a464_83151c80 PS3, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71d1029a_de5380f3 PS3, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a84c970_01dc5e05 PS3, Line 127: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0b9b8900_ab1a2a75 PS3, Line 132: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c331074_6f3ecf89 PS3, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fba5ebc_35ed12c9 PS3, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/751517b4_e093f141 PS3, Line 134: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/413dc058_14c3beae PS3, Line 142: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/100a0551_6d50d4b9 PS3, Line 142: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df41448a_193b2d68 PS3, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/be070ad4_c1ecb94d PS3, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61f41ecf_c11a9d17 PS3, Line 144: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e2635164_bde694bd PS3, Line 148: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31cee22a_797e5ae5 PS3, Line 148: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8936b739_40ece684 PS3, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba220657_76f5dde9 PS3, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37ca4dd4_7c46c952 PS3, Line 150: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0173f6f8_c6d1f491 PS3, Line 153: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c98ae15b_8b16b147 PS3, Line 153: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e963e5dc_f60732e2 PS3, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a4e12f8_598a047c PS3, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f0f83fc_285cb21d PS3, Line 155: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/757d5cfb_f6e29b94 PS3, Line 158: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6faf43fa_90157638 PS3, Line 158: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/220b2e39_292584d5 PS3, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4dd9f888_7282f6c1 PS3, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68b93fbf_ec0f1a24 PS3, Line 160: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6763e05_0932e1c0 PS3, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28c5d133_674e839c PS3, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78c518fd_63734e76 PS3, Line 176: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1957d217_f0afc88c PS3, Line 177: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83e7ffc5_027f9875 PS3, Line 178: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee9850b8_f7ba7d51 PS3, Line 178: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/880df032_6e41dbb1 PS3, Line 189: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/503e01bb_4de997be PS3, Line 189: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f047c94b_30cf9ae1 PS3, Line 189: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce18034b_82b910b6 PS3, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9da56b4_7cc36a77 PS3, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbb3661d_64439466 PS3, Line 190: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8189c25_9a7de424 PS3, Line 197: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98f0fcc5_ec3c0fdf PS3, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9767233_824d76f2 PS3, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50b3cb49_2fe63ddb PS3, Line 198: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/057d4741_38cd68a6 PS3, Line 201: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6fa91560_d5392a55 PS3, Line 207: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c31b0de_6d6cdee6 PS3, Line 208: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34c1c93c_72d737ab PS3, Line 209: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80c2182a_00cf7053 PS3, Line 211: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/819f9785_68de1ebb PS3, Line 212: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a4c4c7f_a02d11bb PS3, Line 225: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a0729f2_13db89e0 PS3, Line 226: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/835e6a73_7a248542 PS3, Line 229: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66a6ab17_23a8770f PS3, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4af43cd_7d4f91c2 PS3, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/adab125f_be6623f8 PS3, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32e33cdb_cfccdb54 PS3, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f140d94_984a9526 PS3, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3740eb6_24ce1e63 PS3, Line 44: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb2822ee_9538b166 PS3, Line 45: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d477f08f_64ac9533 PS3, Line 46: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b3b2180_4e57e97d PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76ab6e59_15abdc8c PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f808a82_9c774059 PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21d4ef33_2b28d9ae PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34d1d772_ade734de PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9fb048a_568f398d PS3, Line 50: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b208705b_6d8d8dc5 PS3, Line 52: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f67c2fd_bcae3013 PS3, Line 53: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28faa287_c4bb8ef2 PS3, Line 54: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8b9766e_e2536a58 PS3, Line 56: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21b7825c_88b2206f PS3, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4cf00c0_373b7d93 PS3, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/668f8388_fb4863d8 PS3, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ea69fe2_12e201d4 PS3, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f86444f4_f3f92a2e PS3, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1cb901d8_451f40da PS3, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b9622ad_cfd6f7f0 PS3, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96c5b166_22212a38 PS3, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbd5e655_538499fb PS3, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e61359f3_209372ee PS3, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fec44201_f9c122ba PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b76eab7f_f9434c11 PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ff3e00c_d85118c0 PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c98a68c6_05f3ece8 PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/052a04cc_a7cde47f PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d38a68dc_b2ee1b0e PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35976b64_6d39afcd PS3, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/88b0cf87_62584e99 PS3, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bcb6f7f5_6b24c3a6 PS3, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c52a074_943ac956 PS3, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b6dfc13_75069efd PS3, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/318d8ee7_5a74b8ca PS3, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7c70d1e4_dce6868c PS3, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d03a74a_9fccc848 PS3, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c57063f9_79333734 PS3, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19a67292_7243580b PS3, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f1695fc_000bb28c PS3, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8a27374_40c31769 PS3, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f7486b23_42b54dbe PS3, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f66f54a1_e47caa1e PS3, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36edfbd0_996103fa PS3, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60d5f432_b6706ee7 PS3, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff8ba3a9_87a4d4e4 PS3, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06f46b9b_f5c791c4 PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76f956cb_4536441d PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/847fff0d_ddab50e9 PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71310bcc_3b397a9e PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26bb493f_919cafc9 PS3, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58d07258_13d09f46 PS3, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40901927_d80296a6 PS3, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31a4d114_f4da6b00 PS3, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3e18785_6bab3abd PS3, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0adc7b29_8921f047 PS3, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19be2193_a29cc58d PS3, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e53d965_7515a6d3 PS3, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55dc7dce_0048da9f PS3, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/249bc39a_8c59dc3d PS3, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b6a97b95_fe46214b PS3, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86cde646_62b5aaef PS3, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72dc2a0d_d005d898 PS3, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9deb4645_4b368ac8 PS3, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c97274e_a9933aa4 PS3, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d1edce7_07c3abcc PS3, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7916fb56_3f968e8b PS3, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d796734_289225cc PS3, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bd6a3e4_4ec7755f PS3, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e52c55be_c3a46247 PS3, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7222a21d_a1f0578c PS3, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/398ab124_d6b5fed7 PS3, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6a27e87_aa3eb4c3 PS3, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b68f1cfe_698ba958 PS3, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7066c193_84905e34 PS3, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d56dca20_6c37339d PS3, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71fafa62_5d1064bc PS3, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cfc7dbd_76814509 PS3, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df19065b_07710025 PS3, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/399f02af_cc39508d PS3, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3ccccf9_9d527358 PS3, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d71ce1b_4cfd38d4 PS3, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3eb52d04_53904dcd PS3, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6b75c43_b3568ea6 PS3, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: vita demod by piotr krysik, modified

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 ) Change subject: vita demod by piotr krysik, modified ...................................................................... Patch Set 2: (946 comments) File Transceiver52M/grgsm_vitac/constants.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/322593ec_5d0b0394 PS2, Line 1: #pragma once DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a308c129_5d92b397 PS2, Line 2: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bbc8cd5_23ec81e2 PS2, Line 3: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/575a4d11_5efb79c2 PS2, Line 4: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a8219c7d_b5f75f17 PS2, Line 5: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed6cf8f1_702d41be PS2, Line 6: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86d77e8d_e34430ea PS2, Line 7: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d87d35f0_52a3e43e PS2, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58a14e4d_2fb1fb62 PS2, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8843a62_5be6c06b PS2, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b26ed69_aaca3b79 PS2, Line 11: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45108c59_f367bb37 PS2, Line 12: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b2071c1_4ebb6428 PS2, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ab066d9_f4906bca PS2, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b5ddcfc2_a2595bca PS2, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/def879b2_99e419a4 PS2, Line 16: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e40cce53_52832359 PS2, Line 17: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ddfa9e2c_86a8a83b PS2, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78209566_d5c61897 PS2, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/081c94b9_825c722e PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/720dcaa6_acb9f0aa PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99640bc0_5f6a7ce8 PS2, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0486f24_49687faf PS2, Line 22: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1f57d1b_f42a543a PS2, Line 23: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/638129c5_5771f2ee PS2, Line 24: #include <complex> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d7d6e8c_a2e35649 PS2, Line 25: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af5dfd65_e784f012 PS2, Line 26: #define gr_complex std::complex<float> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2080a61_001edee8 PS2, Line 26: #define gr_complex std::complex<float> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f43562eb_fe15cb31 PS2, Line 26: #define gr_complex std::complex<float> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f338741_3324c942 PS2, Line 27: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0f17738_ae4cec7a PS2, Line 28: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/def350ee_9f58fb4f PS2, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f77ec7b6_c57ef9f9 PS2, Line 30: #define GSM_SYMBOL_PERIOD (1.0/GSM_SYMBOL_RATE) //seconds per symbol trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/997e7902_5e4382d1 PS2, Line 31: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c060efeb_a80d07fa PS2, Line 32: //Burst timing trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/012113f5_7368a011 PS2, Line 33: #define TAIL_BITS 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a17334b_03db13bc PS2, Line 34: #define GUARD_BITS 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6cc4fcc7_ff6d0089 PS2, Line 35: #define GUARD_FRACTIONAL 0.25 //fractional part of guard period trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbf75f4c_06f67817 PS2, Line 36: #define GUARD_PERIOD GUARD_BITS + GUARD_FRACTIONAL DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b13d0b7a_438da698 PS2, Line 37: #define DATA_BITS 57 //size of 1 data block in normal burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40c0a781_58af3954 PS2, Line 38: #define STEALING_BIT 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1dcd4e95_049efd35 PS2, Line 39: #define N_TRAIN_BITS 26 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9c7ed3a_0cc4305e PS2, Line 40: #define N_SYNC_BITS 64 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3986ffe_6fa59174 PS2, Line 41: #define USEFUL_BITS 142 //(2*(DATA_BITS+STEALING_BIT) + N_TRAIN_BITS ) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bfbfaba_b284e4a0 PS2, Line 42: #define FCCH_BITS USEFUL_BITS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0242fe0d_64af96dd PS2, Line 43: #define BURST_SIZE (USEFUL_BITS+2*TAIL_BITS) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf50e4bc_611d164f PS2, Line 44: #define ACCESS_BURST_SIZE 88 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e67b47ac_47799c75 PS2, Line 45: #define PROCESSED_CHUNK BURST_SIZE+2*GUARD_PERIOD DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64652455_042f0478 PS2, Line 46: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4aabdd2f_e761d50e PS2, Line 47: #define SCH_DATA_LEN 39 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6f58f98b_97de7a24 PS2, Line 48: #define TS_BITS (TAIL_BITS+USEFUL_BITS+TAIL_BITS+GUARD_BITS) //a full TS (156 bits) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acdd1930_c3f17d6b PS2, Line 49: #define TS_PER_FRAME 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6757fb6b_7f13a20f PS2, Line 50: #define FRAME_BITS (TS_PER_FRAME * TS_BITS + 2) // 156.25 * 8 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0684b360_d8ffc025 PS2, Line 51: #define FCCH_POS TAIL_BITS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d4626d2_43144fa8 PS2, Line 52: #define SYNC_POS (TAIL_BITS + 39) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c2b505d_8123f694 PS2, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2a046dd_d2fcf6c9 PS2, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f44a9b8c_48595216 PS2, Line 54: //aren't used for channel impulse response estimation trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d21ae8f6_6fdaad3f PS2, Line 55: #define TRAIN_BEGINNING 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21048e80_cb3ca857 PS2, Line 56: #define SAFETY_MARGIN 6 // trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e743e96d_67226310 PS2, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9ddb925_a4694223 PS2, Line 58: #define FCCH_HITS_NEEDED (USEFUL_BITS - 4) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84eb07b8_aac18bd0 PS2, Line 59: #define FCCH_MAX_MISSES 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed999ca5_bde67488 PS2, Line 60: #define FCCH_MAX_FREQ_OFFSET 100 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f409e1b_0cc38011 PS2, Line 61: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a674add_6a227c65 PS2, Line 62: #define CHAN_IMP_RESP_LENGTH 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d8df6e2_91fd05f5 PS2, Line 63: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/065c16b7_432ec99b PS2, Line 64: #define MAX_SCH_ERRORS 10 //maximum number of subsequent sch errors after which gsm receiver goes to find_next_fcch state trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a98bb8db_bd6e8188 PS2, Line 65: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3479e1b_e57fc750 PS2, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ba0f07a_38147b64 PS2, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fddbfb4_d5677f1e PS2, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ded9505_33bff5cf PS2, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7c09303_5e985860 PS2, Line 68: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51e1ca82_3a633586 PS2, Line 69: static const unsigned char SYNC_BITS[] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db6f3c49_776a543a PS2, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66083918_35310a18 PS2, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f85e5d76_7ffb21bb PS2, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5027d61_172e1b0c PS2, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1207d769_85250e8f PS2, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4843d77_74c593f6 PS2, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/491fcd8c_e760c342 PS2, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83958ae3_eb62a06d PS2, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acdedb7c_08f3ab05 PS2, Line 74: }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c50a83c_95019385 PS2, Line 75: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a61c84b_b6955b63 PS2, Line 76: const unsigned FCCH_FRAMES[] = { 0, 10, 20, 30, 40 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d757e3b_5fca85b1 PS2, Line 77: const unsigned SCH_FRAMES[] = { 1, 11, 21, 31, 41 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eaa5e4e_be9ffe06 PS2, Line 78: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f0792d4_abb06f68 PS2, Line 79: const unsigned BCCH_FRAMES[] = { 2, 3, 4, 5 }; //!!the receiver shouldn't care about logical trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98568501_dc605f91 PS2, Line 80: //!!channels so this will be removed from this header trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfe9f6ac_61f614b4 PS2, Line 81: const unsigned TEST_CCH_FRAMES[] = { 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39, 42, 43, 44, 45, 46, 47, 48, 49 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fde6a217_fce85ffc PS2, Line 82: const unsigned TRAFFIC_CHANNEL_F[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b872eb17_54c73021 PS2, Line 83: const unsigned TEST51[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a61794e_10b370d7 PS2, Line 84: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d28a829b_b181d1b6 PS2, Line 85: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f39b3d0_157e844f PS2, Line 86: #define TSC0 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/345558f5_e890908c PS2, Line 87: #define TSC1 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84533531_73bbf8c9 PS2, Line 88: #define TSC2 2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9d1e2e3_72f45131 PS2, Line 89: #define TSC3 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68a1a8bc_53e46ec5 PS2, Line 90: #define TSC4 4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6bda7e94_3cd2bfe6 PS2, Line 91: #define TSC5 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb0910a8_b0a6984b PS2, Line 92: #define TSC6 6 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43cf1280_fdd48d40 PS2, Line 93: #define TSC7 7 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8b27f3c1_1f838c50 PS2, Line 94: #define TS_DUMMY 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dca0803_ef5e08e4 PS2, Line 95: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c99e8823_f5296ee9 PS2, Line 96: #define TRAIN_SEQ_NUM 9 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4ea35f8_b72c70bc PS2, Line 97: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bba21af2_f652a489 PS2, Line 98: #define TIMESLOT0 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2730cb0e_467786bf PS2, Line 99: #define TIMESLOT1 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c04f94a5_c8c980cc PS2, Line 100: #define TIMESLOT2 2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1930b07b_f60330b4 PS2, Line 101: #define TIMESLOT3 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b9c342a_39146955 PS2, Line 102: #define TIMESLOT4 4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f488c498_72d203d6 PS2, Line 103: #define TIMESLOT5 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3cd1b5cb_44817048 PS2, Line 104: #define TIMESLOT6 6 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c05aca46_0678b6bd PS2, Line 105: #define TIMESLOT7 7 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef42da19_3d38ec57 PS2, Line 106: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c909a8bf_753c7692 PS2, Line 107: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38115b5d_bfadc3b9 PS2, Line 108: static const unsigned char train_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ed1589a_706654da PS2, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b760cb72_a3453b3a PS2, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a6b65e2_612332ba PS2, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b6115b0_adcf6db6 PS2, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ee4ba3b_287880d5 PS2, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c5fa31_7378eeee PS2, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ecdb68e_e9808715 PS2, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf97ec50_892513b2 PS2, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e222dbd2_ed4895e3 PS2, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8eed6c35_0a973f20 PS2, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d0948cd_b292c96b PS2, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8943596_66a67bdc PS2, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94845f1f_b935eb0b PS2, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/956b6c02_139b65a0 PS2, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f6bfeb6_077bedb2 PS2, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63c5991e_c4717c1f PS2, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce099397_ca168d4c PS2, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d754b58d_5bfefe5e PS2, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dbf0bb64_f9756a49 PS2, Line 118: }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/961d8fc1_a73ad667 PS2, Line 119: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/873a1dba_d200f2a2 PS2, Line 120: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95422e91_3f19ddd9 PS2, Line 121: //Dummy burst 0xFB 76 0A 4E 09 10 1F 1C 5C 5C 57 4A 33 39 E9 F1 2F A8 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff27cc91_1461eb64 PS2, Line 122: static const unsigned char dummy_burst[] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36ae0da7_3f045cec PS2, Line 123: 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/879b5961_388aa647 PS2, Line 123: 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c00797d_95358a0b PS2, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d5a8a80_fd90a2c6 PS2, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd1075f4_5cff83c7 PS2, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2a4b97c_9e43187c PS2, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/50171c05_6dfab3d7 PS2, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c228bba_d8c3de76 PS2, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e8565c2_b02b997e PS2, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1abfca62_583e30bb PS2, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f442f03_51370aaa PS2, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f03dc313_a5abec04 PS2, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/878402f0_fc229acf PS2, Line 129: 0, 1, 1, 1, 1, 1, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64455f0d_f8d255f9 PS2, Line 129: 0, 1, 1, 1, 1, 1, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54a92586_a70991bc PS2, Line 130: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac60ebf2_8f0b8a95 PS2, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4ca4dc4_2a760388 PS2, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f295ce7e_53f42c77 PS2, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acea8625_ff46834b PS2, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ce66951_c77ad155 PS2, Line 133: 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17b97556_dae5b8b5 PS2, Line 133: 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7ce2887_f6a34c03 PS2, Line 134: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/799ae95a_d92052f2 PS2, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7682f2b2_eda845b8 PS2, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49fb59e3_1cc11dce PS2, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cddcbfc_8aead84c PS2, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e24ac8c_41919b0a PS2, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/027f2b3b_efe46ebd PS2, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/55446c74_26cbfe0a PS2, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5636d416_fdad2bff PS2, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb9e599d_ec4dd38d PS2, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6b34e81a_71d2d737 PS2, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e2c3034_b8fe905a PS2, Line 140: 1, 1, 1, 0, 1, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9751a887_aa28f31e PS2, Line 140: 1, 1, 1, 0, 1, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e253f4ea_84091e9f PS2, Line 141: 0, 0, 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1af75d5a_19901f7e PS2, Line 141: 0, 0, 0 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eb5c486_afd1501c PS2, Line 142: }; DOS line endings File Transceiver52M/grgsm_vitac/grgsm_vitac.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be88dbee_64f02d2d PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/24e43cf2_ceb3fcd4 PS2, Line 38: void initvita(); Bad function definition - void initvita() should probably be void initvita(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/418b240d_0665c00e PS2, Line 59: std::string fpath; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26d0baa1_ad7a73aa PS2, Line 60: std::vector<gr_complex> data; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/55eda7ce_8bcea424 PS2, Line 60: std::vector<gr_complex> data; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/545882a2_b11ee329 PS2, Line 60: std::vector<gr_complex> data; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89d43193_db4a7a35 PS2, Line 62: }; adding a line without newline at end of file File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/414f972c_a09c45fc PS2, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35c52c00_7eb24dcb PS2, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52605bb0_66d592d2 PS2, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/024e5e3c_9984d0b3 PS2, Line 4: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/690d3124_521ebc68 PS2, Line 5: * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild <ewild(a)sysmocom.de> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/448b2dff_a2469425 PS2, Line 6: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e67d61e_3ef20283 PS2, Line 7: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1863108_ac01961e PS2, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6009c345_ba1cca39 PS2, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59fee2ad_c52e463b PS2, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b017a4dd_13384a75 PS2, Line 11: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c6c9cc4_089e20b3 PS2, Line 12: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2823ea35_d4863a9a PS2, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3adebc32_17d57a7f PS2, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a36bef9b_20f8aaad PS2, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df4c37f7_63b9c233 PS2, Line 16: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0191f2f1_854f4f01 PS2, Line 17: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29821671_858398d8 PS2, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23df2001_9ee74458 PS2, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01c8ff98_7486a545 PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc442523_c67eb68c PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bc83e8c_102f3113 PS2, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7cfd5f38_626a9014 PS2, Line 22: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef908324_5f149f2c PS2, Line 23: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9411010_a055c52f PS2, Line 24: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3f1d051_4578f7b6 PS2, Line 25: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/821f0200_12e5b643 PS2, Line 26: #ifdef HAVE_CONFIG_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0ff4242_172d6d79 PS2, Line 27: #include "config.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58560035_cc5e3d59 PS2, Line 28: #endif DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/150bf6a2_104c50c4 PS2, Line 29: #include <complex> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ddd3d058_262ce3cd PS2, Line 30: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9af6c70a_66a569f0 PS2, Line 31: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/524c8f78_2e99b604 PS2, Line 32: #include <algorithm> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/002a5d06_9d22588b PS2, Line 33: #include <string.h> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5074fa8_54240036 PS2, Line 34: #include <iostream> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e77d6a78_98777dea PS2, Line 35: #include <numeric> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26596589_f455f118 PS2, Line 36: #include <vector> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/603cd00b_04f2600f PS2, Line 37: #include <fstream> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec5624c5_57d407c3 PS2, Line 38: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f180c0c4_e484c429 PS2, Line 39: #include "viterbi_detector.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1074c4e_d0fd73cc PS2, Line 40: #include "grgsm_vitac.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9a53d9c_3c7b3a2f PS2, Line 41: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d3ac5e4_5a7cf572 PS2, Line 42: //signalVector mChanResp; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2624d918_ad6cfe8c PS2, Line 43: gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a99b3e2_0ef376af PS2, Line 44: gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0af2c1ef_589c0d40 PS2, Line 45: const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b442146a_1ff228f6 PS2, Line 46: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/baf47aca_0e69b0fb PS2, Line 47: void initvita() { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/355ebfb4_f65f0257 PS2, Line 48: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69e9c682_ca1f2bde PS2, Line 49: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/413d2a0d_93253d16 PS2, Line 50: * Prepare SCH sequence bits trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/976d7fed_726c2eb3 PS2, Line 51: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa1cb3f2_643051e3 PS2, Line 52: * (TS_BITS + 2 * GUARD_PERIOD) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd789410_9397358f PS2, Line 53: * Burst and two guard periods trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f892b19_4955a7f6 PS2, Line 54: * (one guard period is an arbitrary overlap) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb65aa6b_caf69314 PS2, Line 55: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/256893d4_a92653d1 PS2, Line 56: gmsk_mapper(SYNC_BITS, N_SYNC_BITS, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab9e38e4_7c321b41 PS2, Line 57: d_sch_training_seq, gr_complex(0.0, -1.0)); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8521238_c8815857 PS2, Line 58: for (auto &i : d_sch_training_seq) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75af89cb_33263745 PS2, Line 59: i = conj(i); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2ed7679_97d843b0 PS2, Line 60: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2443ef48_8d388084 PS2, Line 61: /* Prepare bits of training sequences */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bd068aa_b790207f PS2, Line 62: for (int i = 0; i < TRAIN_SEQ_NUM; i++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d1b1606_26c6851e PS2, Line 63: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3843da2c_0dfb91eb PS2, Line 64: * If first bit of the sequence is 0 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6feeb70_7f4c46d5 PS2, Line 65: * => first symbol is 1, else -1 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c4dfff3_dd4e7af7 PS2, Line 66: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f24bf315_4a8c876e PS2, Line 67: gr_complex startpoint = train_seq[i][0] == 0 ? DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8725c3d_b6e7ff6e PS2, Line 68: gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95a78ea6_511f33d9 PS2, Line 69: gmsk_mapper(train_seq[i], N_TRAIN_BITS, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfbf9397_0a24484f PS2, Line 70: d_norm_training_seq[i], startpoint); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/250c4b29_aa6aaedc PS2, Line 71: for (auto &i : d_norm_training_seq[i]) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82677a06_557513ac PS2, Line 72: i = conj(i); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f7f7895_9b55f42f PS2, Line 73: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/051415d7_20610004 PS2, Line 74: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfe559c6_8789bc37 PS2, Line 75: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3bde1af7_2da0d626 PS2, Line 76: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79e752a8_fd185227 PS2, Line 77: MULTI_VER_TARGET_ATTR DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dd673a8a_6e8bf004 PS2, Line 78: void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d313d663_7219c926 PS2, Line 79: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1f3f745_b65bfb33 PS2, Line 80: std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40eada7b_3cc31d4f PS2, Line 81: unsigned int stop_states[2] = { 4, 12 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9af80762_f7b50378 PS2, Line 82: gr_complex filtered_burst[BURST_SIZE]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea20e96e_5c23e504 PS2, Line 83: gr_complex rhh[CHAN_IMP_RESP_LENGTH]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a42490ef_6a54791c PS2, Line 84: float output[BURST_SIZE]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d00ca77_4b00458b PS2, Line 85: int start_state = 3; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/260bff6e_b7a71c43 PS2, Line 86: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/958667ef_6d52aad5 PS2, Line 87: // if(burst_start < 0 ||burst_start > 10) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4b1d67f_8eeb3797 PS2, Line 88: // fprintf(stderr, "bo %d\n", burst_start); trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af752f1f_acece406 PS2, Line 89: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca7f6bc7_319fff9b PS2, Line 90: // burst_start = burst_start >= 0 ? burst_start : 0; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/182e3718_ea84b2f2 PS2, Line 91: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1b8d13ac_c133f0eb PS2, Line 92: autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca998df2_6e4343a8 PS2, Line 93: for (int ii = 0; ii < d_chan_imp_length; ii++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26839e07_66b04ae6 PS2, Line 94: rhh[ii] = conj(rhh_temp[ii * d_OSR]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64381507_7114b0f2 PS2, Line 95: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ea77aa8_d00623a6 PS2, Line 96: mafi(&input[burst_start], BURST_SIZE, chan_imp_resp, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0b5cf0f_c7928e45 PS2, Line 97: d_chan_imp_length * d_OSR, filtered_burst); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26a426db_552cba2f PS2, Line 98: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/268a3909_4dc38c6c PS2, Line 99: viterbi_detector(filtered_burst, BURST_SIZE, rhh, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7801c01c_952472e2 PS2, Line 100: start_state, stop_states, 2, output); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc385f87_ceb446c9 PS2, Line 101: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71453e24_91275d61 PS2, Line 102: for (int i = 0; i < BURST_SIZE; i++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d146dcb0_55579480 PS2, Line 103: output_binary[i] = output[i] * -127; // pre flip bits! trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72b27196_f21d45e3 PS2, Line 104: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49ab04fd_3031e28f PS2, Line 105: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63b7bfcd_00817f71 PS2, Line 106: void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/885b8fdc_b64c28a1 PS2, Line 107: gmsk_mapper(const unsigned char* input, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e62acb2_df4037ae PS2, Line 108: int nitems, gr_complex* gmsk_output, gr_complex start_point) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87b4d812_d65bfb3c PS2, Line 109: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1db0f482_994b3620 PS2, Line 110: gr_complex j = gr_complex(0.0, 1.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19e16a5f_59ecc68f PS2, Line 111: gmsk_output[0] = start_point; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db65bd6e_2a82e56c PS2, Line 112: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3a02c32a_49b1a089 PS2, Line 113: int previous_symbol = 2 * input[0] - 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de45d096_9312d0ea PS2, Line 114: int current_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/96b60472_1ec5fb14 PS2, Line 115: int encoded_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dba13ecb_43e29d3e PS2, Line 116: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c042a34_a916a471 PS2, Line 117: for (int i = 1; i < nitems; i++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf27d404_1df990fb PS2, Line 118: /* Change bits representation to NRZ */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df12c1d2_bb46a65e PS2, Line 119: current_symbol = 2 * input[i] - 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d74045a3_89aaa076 PS2, Line 120: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfb833ff_a5b6b263 PS2, Line 121: /* Differentially encode */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/282efc69_f3744197 PS2, Line 122: encoded_symbol = current_symbol * previous_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bae50c10_7eeee2ae PS2, Line 123: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d12e015_a6f89e7e PS2, Line 124: /* And do GMSK mapping */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e186f540_0473c6e4 PS2, Line 125: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf9cf2f1_a5c4226a PS2, Line 126: * gmsk_output[i - 1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67833d78_e4e7d82f PS2, Line 127: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c1180c1_9d222749 PS2, Line 128: previous_symbol = current_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e779bf88_b73bf030 PS2, Line 129: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b24387b0_47fedb76 PS2, Line 130: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/496b92b8_7704d56e PS2, Line 131: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57d652d2_b72d3a83 PS2, Line 132: gr_complex DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed8cf6ea_6c9c0d6c PS2, Line 133: correlate_sequence(const gr_complex* sequence, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53e5699a_ce1b60ac PS2, Line 134: int length, const gr_complex* input) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2831fd6f_9ff1a0c4 PS2, Line 135: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41cd000d_9a9e6784 PS2, Line 136: gr_complex result(0.0, 0.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98e40f03_37725da1 PS2, Line 137: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4efae0de_baafa6dd PS2, Line 138: for (int ii = 0; ii < length; ii++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa27213f_95485964 PS2, Line 139: result += sequence[ii] * input[ii * d_OSR]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e238b207_09d18bfe PS2, Line 140: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bed254c1_b5a1e823 PS2, Line 141: return conj(result) / gr_complex(length, 0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52a38925_c931964b PS2, Line 142: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2f335bc_acfa7c80 PS2, Line 143: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5391e810_4a881e39 PS2, Line 144: /* Computes autocorrelation for positive arguments */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/061df6c3_f78f4d50 PS2, Line 145: inline void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/269a6671_66eb8fab PS2, Line 146: autocorrelation(const gr_complex* input, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e28a1767_220b7b56 PS2, Line 147: gr_complex* out, int nitems) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c86a3865_be0f9231 PS2, Line 148: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7e4821e_ea02dcb1 PS2, Line 149: for (int k = nitems - 1; k >= 0; k--) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/714af8b8_e289411d PS2, Line 150: out[k] = gr_complex(0, 0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/861ae240_1aade934 PS2, Line 151: for (int i = k; i < nitems; i++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48454fcd_a49a7ad8 PS2, Line 152: out[k] += input[i] * conj(input[i - k]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8723254c_207c9f65 PS2, Line 153: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0c0b688_40320990 PS2, Line 154: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56118f00_2314cc8c PS2, Line 155: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71bbbd1d_daa9f13a PS2, Line 156: inline void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/627159e4_b0b7827c PS2, Line 157: mafi(const gr_complex* input, int nitems, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0039065_fb75f52b PS2, Line 158: gr_complex* filter, int filter_length, gr_complex* output) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8985e34_a1e5ff55 PS2, Line 159: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e974f64_1a29f78c PS2, Line 160: for (int n = 0; n < nitems; n++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/092740d8_6b11f2e5 PS2, Line 161: int a = n * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1acdc928_418bfebd PS2, Line 162: output[n] = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/159f3d4f_655091fb PS2, Line 163: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2413335_4bafc558 PS2, Line 164: for (int ii = 0; ii < filter_length; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/833a353a_b8412f76 PS2, Line 165: if ((a + ii) >= nitems * d_OSR) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44ed3846_f2718af5 PS2, Line 166: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f5cf3cb_75477e5d PS2, Line 167: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8bbd75c4_4c72abc3 PS2, Line 168: output[n] += input[a + ii] * filter[ii]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e48d59ad_09ebf5ef PS2, Line 169: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88364202_7a73291f PS2, Line 170: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d40f189d_bbfd2601 PS2, Line 171: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70c39134_3906d7e2 PS2, Line 172: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c6799b08_f4531c67 PS2, Line 173: int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/584c84ce_1be5a0eb PS2, Line 174: int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98f5db55_bb86a733 PS2, Line 175: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eb3feaa_e1b5808f PS2, Line 176: std::vector<gr_complex> correlation_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8140326_052e1fcb PS2, Line 177: std::vector<float> window_energy_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ba311ae_3eb6d8aa PS2, Line 178: std::vector<float> power_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bff55401_940e539a PS2, Line 179: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9b1f6fb_9fad2878 PS2, Line 180: for (int ii = search_start_pos; ii < search_stop_pos; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ce3fdd2_34f4ae09 PS2, Line 181: gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/16653094_93dc0bad PS2, Line 182: correlation_buffer.push_back(correlation); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84249996_8e0fbb40 PS2, Line 183: power_buffer.push_back(std::pow(abs(correlation), 2)); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f912ab75_7572d0b2 PS2, Line 184: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b749561_83bddacd PS2, Line 185: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2022f4c_b075b331 PS2, Line 186: int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae9f362c_da1e75d6 PS2, Line 187: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ab35979_dad3e595 PS2, Line 188: /* Compute window energies */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce9ebad8_75e5f7ea PS2, Line 189: auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f47c97d_3205c122 PS2, Line 190: window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range.. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4784eb3_06a0ec01 PS2, Line 191: auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ae9c5f9_00bc90c1 PS2, Line 192: auto iter = power_buffer.begin() + window_energy_start_offset; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0045676a_4a3aa790 PS2, Line 193: auto iter_end = power_buffer.begin() + window_energy_end_offset; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b76834a_ad9bbfab PS2, Line 194: while (iter != iter_end) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63434c2e_b6762ba6 PS2, Line 195: std::vector<float>::iterator iter_ii = iter; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41b2f892_31454b97 PS2, Line 196: bool loop_end = false; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f2b549e_4a498597 PS2, Line 197: float energy = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dca945f4_17ff79c3 PS2, Line 198: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6da41dd7_57194058 PS2, Line 199: int len = d_chan_imp_length * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb91881d_4866c120 PS2, Line 200: for (int ii = 0; ii < len; ii++, iter_ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5de69bb5_295fd0d5 PS2, Line 201: if (iter_ii == power_buffer.end()) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a556d73e_baef2e14 PS2, Line 202: loop_end = true; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c2491fe_d3915c13 PS2, Line 203: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8bb97e2_0ef6c3aa PS2, Line 204: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92ad3608_c22d03bd PS2, Line 205: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b57e47f1_3ee849e7 PS2, Line 206: energy += (*iter_ii); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54ed5296_46a5ca02 PS2, Line 207: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0bf516f_c041a695 PS2, Line 208: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8802f83_1b587d46 PS2, Line 209: if (loop_end) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e371f08b_d0f524d6 PS2, Line 210: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4be2b31_6782e8b3 PS2, Line 211: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94876ef2_5371db97 PS2, Line 212: window_energy_buffer.push_back(energy); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08e3cd2c_932fae36 PS2, Line 213: iter++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4697ef3e_c91aca24 PS2, Line 214: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a68dce1e_e96e36ac PS2, Line 215: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cb553c3_a1716b49 PS2, Line 216: /* Calculate the strongest window number */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b764f9a_0bbd1f70 PS2, Line 217: int strongest_window_nr = window_energy_start_offset + DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/777c1a1b_cfa20aeb PS2, Line 218: max_element(window_energy_buffer.begin(), window_energy_buffer.end()) - DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f580ec67_a0caa59c PS2, Line 219: window_energy_buffer.begin(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/496c7347_6c98f744 PS2, Line 220: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3ae57d8_1ea29abb PS2, Line 221: // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93b12981_00245c08 PS2, Line 222: // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7892d551_89818f51 PS2, Line 223: // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a8cb1e5_75ee557a PS2, Line 224: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab0bdebd_fc004e73 PS2, Line 225: // /* Calculate the strongest window number */ trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a9fc476_4f595dd0 PS2, Line 226: // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin(); trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a0a5a2d_2367151a PS2, Line 227: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94f66c4e_2554ffe4 PS2, Line 228: // if (strongest_window_nr < 0) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76e238be_8cd51982 PS2, Line 229: // strongest_window_nr = 0; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0cf060d_03038705 PS2, Line 230: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93afa4b4_cf3d6abf PS2, Line 231: float max_correlation = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3051e531_08dd04d9 PS2, Line 232: for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0759c57d_58ad5339 PS2, Line 233: gr_complex correlation = correlation_buffer[strongest_window_nr + ii]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d641dd4_e07c6e1a PS2, Line 234: if (abs(correlation) > max_correlation) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4fe5490_5bcbbf07 PS2, Line 235: max_correlation = abs(correlation); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92be661a_f0122346 PS2, Line 236: chan_imp_resp[ii] = correlation; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2494fc0_0883b8f0 PS2, Line 237: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60ca1135_a3da8f02 PS2, Line 238: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86ec2a48_6fd5f09a PS2, Line 239: *corr_max = max_correlation; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec0b0b22_98b6c75a PS2, Line 240: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7a33092_36cb089e PS2, Line 241: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4137c19_13a269b7 PS2, Line 242: * Compute first sample position, which corresponds trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/33b25a9f_8de20c52 PS2, Line 243: * to the first sample of the impulse response trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/582dea18_3e3391f3 PS2, Line 244: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32c129c0_84490318 PS2, Line 245: return search_start_pos + strongest_window_nr - search_center * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb6f4e09_a8c47228 PS2, Line 246: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4fc449d_402026b0 PS2, Line 247: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8af24a92_48418167 PS2, Line 248: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6ed7789_d7bfa7cb PS2, Line 249: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9014e059_f451e92c PS2, Line 250: 3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/14620605_0226868f PS2, Line 251: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cdce852c_c4e1f717 PS2, Line 252: search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5527936a_47d6a8b1 PS2, Line 253: this is +-5 samples around (+5 beginning) of truncated t16 tsc trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34ecf7b4_789eb48f PS2, Line 254: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11208750_a7712023 PS2, Line 255: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6355c88c_88ff85f3 PS2, Line 256: int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8e86cef0_bc5d0c0b PS2, Line 257: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/865ef4c7_7e253669 PS2, Line 258: const int search_center = TRAIN_POS; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d98aa050_39d94067 PS2, Line 259: const int search_start_pos = (search_center - 5) * d_OSR + 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69c970a0_7f14eef9 PS2, Line 260: const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d525bdb1_2e4ae1e3 PS2, Line 261: const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12737bd2_9a8ff5e5 PS2, Line 262: const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8c5efa9_6e04750a PS2, Line 263: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/891eda51_d82b0df4 PS2, Line 264: corr_max); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19ca6a5d_8270cb7d PS2, Line 265: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de4bee85_2a32980e PS2, Line 266: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc1d0a1e_bcc65024 PS2, Line 267: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ebf9bab_25e8a117 PS2, Line 268: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fb8a956_9eb841d7 PS2, Line 269: 3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02e25c91_dad5dff6 PS2, Line 270: start 3+39 - 10 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6973cfcb_2489cb98 PS2, Line 271: end 3+39 + SYNC_SEARCH_RANGE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0290757_9539734b PS2, Line 272: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/abe61aa0_44f16445 PS2, Line 273: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c432bf57_9fe313c4 PS2, Line 274: int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/311bcd60_2a7404f3 PS2, Line 275: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c4dfd24_f44ee54a PS2, Line 276: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/295d39db_e64ca420 PS2, Line 277: const int search_start_pos = (search_center - 10) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/207b95df_7f63745f PS2, Line 278: const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08d53b1e_b4f4c219 PS2, Line 279: const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aaf3543d_c6ef4e0d PS2, Line 280: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2131722_3fec9b07 PS2, Line 281: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c9828a4_57916d9a PS2, Line 282: // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5de6070a_cc197920 PS2, Line 283: float corr_max; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b02f0a4d_4ba86232 PS2, Line 284: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61eae032_f2422e25 PS2, Line 285: &corr_max); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce71dc8c_ff9f2c08 PS2, Line 286: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa73f80f_1cc9b5a4 PS2, Line 287: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b08fd195_e8d2dc83 PS2, Line 288: int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c64e395b_e11ba70f PS2, Line 289: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6debf3a2_457b711c PS2, Line 290: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1aaf46d9_5cd6bef0 PS2, Line 291: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5546cf23_214442b2 PS2, Line 292: const int search_start_pos = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d53cac52_5160ddeb PS2, Line 293: // FIXME: proper end offset trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c3200bb_33cb53c5 PS2, Line 294: const int search_stop_pos = len - (N_SYNC_BITS*8); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b0de97e_d7ceaede PS2, Line 295: auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d87277d6_1dfb85a0 PS2, Line 296: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af0b9752_f4498b9e PS2, Line 297: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c70a6d2_93026856 PS2, Line 298: corr_max); DOS line endings File Transceiver52M/grgsm_vitac/viterbi_detector.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c623c58_c0fdf09a PS2, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62e4e61c_8e99e164 PS2, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c3fd98e_81f242d1 PS2, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/96ee41c5_198c2259 PS2, Line 4: * @author (C) 2009 Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65306923_e37aec6f PS2, Line 5: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc7ef19d_24846f15 PS2, Line 6: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/daf638cf_06adbd31 PS2, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1058463e_3561a26b PS2, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41cdc45b_a8d56397 PS2, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4247d286_9c9f4d1d PS2, Line 10: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42e691bd_028cbbe7 PS2, Line 11: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a44be30d_5e63b8f7 PS2, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da07b282_3ac20db0 PS2, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71a1f95e_469c5408 PS2, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54296cdc_ec311ac3 PS2, Line 15: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26afdaa0_3b3ba30e PS2, Line 16: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62d030d2_69cbd881 PS2, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9726424_33b8311b PS2, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c312bf98_672af5bd PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f393144_f4d26294 PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c6b51ab_6269d309 PS2, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f1eec0d_ac189a4d PS2, Line 21: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90dc07cf_1b003cb9 PS2, Line 22: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72982f62_4c5e3939 PS2, Line 23: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b32792aa_2e5acd51 PS2, Line 24: * viterbi_detector: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ec21bbd_8e19c4e9 PS2, Line 25: * This part does the detection of received sequnece. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be3ec68b_15482483 PS2, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2dcfa1c0_c12b1d27 PS2, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f41fb318_dd3e0e98 PS2, Line 28: * it was designed with soft decisions in mind. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3380678e_9969a396 PS2, Line 29: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a86421d_9df44925 PS2, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ae4ee04_572057b5 PS2, Line 31: * const gr_complex * input, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3babcb2_80b89762 PS2, Line 32: * unsigned int samples_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59602858_27701523 PS2, Line 33: * gr_complex * rhh, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d191940a_bd1dcde3 PS2, Line 34: * unsigned int start_state, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5081b459_c41e56eb PS2, Line 35: * const unsigned int * stop_states, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ab9fc1e_0336a56f PS2, Line 36: * unsigned int stops_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4026303c_fe3c548f PS2, Line 37: * float * output) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f40ff196_9c38e19a PS2, Line 38: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/238e86e9_07eb6085 PS2, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0f555c1_fab23b8a PS2, Line 40: * samples_num: Number of samples in the input table. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b6e76f5c_0df1dfb5 PS2, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/498e2e6c_495bb13b PS2, Line 42: * impulse response. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10094083_3c1e4ed9 PS2, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3434cf36_2042d0ad PS2, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5dff827_a04b89ef PS2, Line 45: * indicates start point of the algorithm. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5dc2ba9_818d54cc PS2, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fbf3db56_9575815d PS2, Line 47: * stops_num: Number of possible stop states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11563be0_a398d71c PS2, Line 48: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2fb660a6_4f3ff1e4 PS2, Line 49: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9eb8a9aa_52b777ca PS2, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3eb6493_77d13bbe PS2, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5442ea1a_4db31ec7 PS2, Line 52: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30653fc6_eea5a15a PS2, Line 53: * SUB_FUNC: none trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e53ebee_cb8bf546 PS2, Line 54: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/745e22bf_afa178f4 PS2, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f11dfb5_ee380245 PS2, Line 56: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f3554f2_6d1166f8 PS2, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3359007f_1e8bd124 PS2, Line 58: #ifndef INCLUDED_VITERBI_DETECTOR_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b31f3e7_40c7f991 PS2, Line 59: #define INCLUDED_VITERBI_DETECTOR_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6607c979_b07f2b5e PS2, Line 60: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7179b3c5_adcfa63e PS2, Line 61: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b57c1458_0d26e29a PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f576c6cd_efbb80e1 PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d72bc681_36d95fa0 PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc160b85_0abaff67 PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0bae58b_0ff87a04 PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a9e1404_75a5ad4c PS2, Line 63: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de93af2d_57d46b2f PS2, Line 64: #endif /* INCLUDED_VITERBI_DETECTOR_H */ DOS line endings File Transceiver52M/grgsm_vitac/viterbi_detector.cc: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc04ebde_021355b1 PS2, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a431b13_eec16fe6 PS2, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4219d9b7_e0762416 PS2, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5636539c_c16bd9dd PS2, Line 4: * @author (C) 2009 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b43e870b_1b8bc300 PS2, Line 5: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad47af75_bb369bd1 PS2, Line 6: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/302452d9_7068813c PS2, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9faa189_631fcaa9 PS2, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/698f579e_a7e41d89 PS2, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2825f863_add84186 PS2, Line 10: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bf03c30_486be42f PS2, Line 11: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8e8f9397_fc88951d PS2, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d70d8d1_3b853e31 PS2, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5082c09e_fabf5a5d PS2, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03f5ef18_afeee957 PS2, Line 15: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64b876d0_aa28dbad PS2, Line 16: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/253fbf55_9e7e913a PS2, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc8c3b45_97a62634 PS2, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4707db8c_640434d6 PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0048b50f_600146fc PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97b64ed7_20c46039 PS2, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3fd15f62_419668a7 PS2, Line 21: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6faa9390_e54fdeb0 PS2, Line 22: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7f09e61_eb32c883 PS2, Line 23: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/819830e9_77271fad PS2, Line 24: * viterbi_detector: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f33c0a4_f9c2a63d PS2, Line 25: * This part does the detection of received sequnece. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70ed75e5_fd56f0ce PS2, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3b9a521_8eeb10b5 PS2, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5238d8cc_fc89be97 PS2, Line 28: * it was designed with soft decisions in mind. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a449fa2_4afe32f5 PS2, Line 29: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72f9cb76_08edd544 PS2, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf53c04a_95eb0e34 PS2, Line 31: * const gr_complex * input, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b95b1ef_8a6b7fa3 PS2, Line 32: * unsigned int samples_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2ec3ed5_accf841a PS2, Line 33: * gr_complex * rhh, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d816e8d1_05a19314 PS2, Line 34: * unsigned int start_state, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3ef5b49_55eef8ec PS2, Line 35: * const unsigned int * stop_states, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/173b18a6_e8ba9a47 PS2, Line 36: * unsigned int stops_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4560e92f_5a51130f PS2, Line 37: * float * output) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68e4b0ed_499c3711 PS2, Line 38: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e179d493_56a83d13 PS2, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/400048fe_225efc5b PS2, Line 40: * samples_num: Number of samples in the input table. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/33e85216_6a042029 PS2, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2065c050_1f449b62 PS2, Line 42: * impulse response. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3dc8cbed_51c44c63 PS2, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da706529_3364054b PS2, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef7e7360_538afd74 PS2, Line 45: * indicates start point of the algorithm. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be9af8a0_f20bdd2c PS2, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e5974ed_19688c0d PS2, Line 47: * stops_num: Number of possible stop states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e981ad7_ff67e430 PS2, Line 48: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/440cb688_0f8ac430 PS2, Line 49: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7433065_91d84f39 PS2, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d10c90bc_5cda359f PS2, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61a7fc74_df3dc71f PS2, Line 52: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/674feb0f_c509ce51 PS2, Line 53: * SUB_FUNC: none trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a29e3309_51edde61 PS2, Line 54: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eca89a1_d74c8149 PS2, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/22922396_79c81b7f PS2, Line 56: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6abf775e_4c383d37 PS2, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3cb97103_7691b881 PS2, Line 58: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c4694fa_31366f4b PS2, Line 59: #include <cmath> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78b017cf_26837483 PS2, Line 60: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf72937c_7e47f63f PS2, Line 61: #define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1)) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4318937_f714b726 PS2, Line 62: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9667a00_60f1e1ac PS2, Line 63: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74d62202_10cf182f PS2, Line 64: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/916aa0ac_7022bb34 PS2, Line 65: float increment[8]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c72e77a_263ea8cd PS2, Line 66: float path_metrics1[16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ade2a744_b2967a60 PS2, Line 67: float path_metrics2[16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2f5621f2_218a2f57 PS2, Line 68: float paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0976f82d_790cf349 PS2, Line 69: float * new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12cbc750_aa0ede7b PS2, Line 70: float * old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6e10f09_afbddd57 PS2, Line 71: float * tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f2afbe1_d132b2e1 PS2, Line 72: float trans_table[BURST_SIZE][16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a53a87a0_81007f3c PS2, Line 73: float pm_candidate1, pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21c3c1cf_048f5163 PS2, Line 74: bool real_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/949431f6_f87e28f6 PS2, Line 75: float input_symbol_real, input_symbol_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4731ace7_76164040 PS2, Line 76: unsigned int i, sample_nr; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c46db8b_609c49f7 PS2, Line 77: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0ccdada_b1c7ed08 PS2, Line 78: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/950b203a_d8dd0ffe PS2, Line 79: * Setup first path metrics, so only state pointed by start_state is possible. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e219638_8b015bcf PS2, Line 80: * Start_state metric is equal to zero, the rest is written with some very low value, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c337127_85f31b66 PS2, Line 81: * which makes them practically impossible to occur. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/373100ff_f11a3d10 PS2, Line 82: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f930d391_bfdcbeca PS2, Line 83: for(i=0; i<PATHS_NUM; i++){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5ec0073_10cac1f3 PS2, Line 84: path_metrics1[i]=(-10e30); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0245da7_f9792bd6 PS2, Line 85: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47dd04d1_8497190b PS2, Line 86: path_metrics1[start_state]=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0112194c_bd10946e PS2, Line 87: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92cfd1fe_5463ab3b PS2, Line 88: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf0b0f74_7e685184 PS2, Line 89: * Compute Increment - a table of values which does not change for subsequent input samples. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ebd52c2_71ee14f1 PS2, Line 90: * Increment is table of reference levels for computation of branch metrics: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d91e1a5f_be13f94b PS2, Line 91: * branch metric = (+/-)received_sample (+/-) reference_level trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1db81eb_cce51d50 PS2, Line 92: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f2fd93_0f0cb2c6 PS2, Line 93: increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6044b24_ca43e4ce PS2, Line 94: increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c24cb3d6_3aea0d79 PS2, Line 95: increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21537003_08aec9b4 PS2, Line 96: increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf830e57_881eab32 PS2, Line 97: increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ceeab1b9_06399b64 PS2, Line 98: increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9270e46b_a749e5f5 PS2, Line 99: increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d31a486_40e1b822 PS2, Line 100: increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23ccb7bd_f623b229 PS2, Line 101: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/885e927a_2731f854 PS2, Line 102: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efba4f87_7673f91c PS2, Line 103: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c21fbd8a_0ab720a4 PS2, Line 104: * Computation of path metrics and decisions (Add-Compare-Select). trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ed35a0d_ffb4480b PS2, Line 105: * It's composed of two parts: one for odd input samples (imaginary numbers) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0db49c31_065f5664 PS2, Line 106: * and one for even samples (real numbers). trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad811fd2_e0401fb1 PS2, Line 107: * Each part is composed of independent (parallelisable) statements like trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4515d5a1_d6494e00 PS2, Line 108: * this one: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6f057d3_f4035507 PS2, Line 109: * pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49fccf7f_f41ce239 PS2, Line 110: * pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c41d84f3_5f11f6f1 PS2, Line 111: * paths_difference=pm_candidate2-pm_candidate1; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88b5a4ca_6fc721a5 PS2, Line 112: * new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eb03c87_780f3a83 PS2, Line 113: * trans_table[sample_nr][1] = paths_difference; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adbe8da2_2b59ab4d PS2, Line 114: * This is very good point for optimisations (SIMD or OpenMP) as it's most time trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bac61b7e_d79773cc PS2, Line 115: * consuming part of this function. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfbb3284_ac44977b PS2, Line 116: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fd32232_02e29f44 PS2, Line 117: sample_nr=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ef22a13_98332cef PS2, Line 118: old_path_metrics=path_metrics1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8115928_ac827029 PS2, Line 119: new_path_metrics=path_metrics2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e70dd00_53702bb8 PS2, Line 120: while(sample_nr<samples_num){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6be6c1b_d9c8858a PS2, Line 121: //Processing imag states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/873052bb_7877e6f9 PS2, Line 122: real_imag=1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a87ab81_abf9008e PS2, Line 123: input_symbol_imag = input[sample_nr].imag(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e2f5347e_ba57be00 PS2, Line 124: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1d93d15_e14a5c0f PS2, Line 125: pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/029985b5_6da858aa PS2, Line 126: pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05ddeca5_4cc99647 PS2, Line 127: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18fa8fa4_430cfc3e PS2, Line 128: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0389fc2d_b1d38a6c PS2, Line 129: trans_table[sample_nr][0] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ed2e100_c5712e74 PS2, Line 130: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa43bfa5_1bef1ec0 PS2, Line 131: pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c410bc06_df85fec8 PS2, Line 132: pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11d2c1c0_be4d4117 PS2, Line 133: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a038a491_0eb2b56a PS2, Line 134: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1df2f367_7db04406 PS2, Line 135: trans_table[sample_nr][1] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6b26d22_ec7a5990 PS2, Line 136: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6b844d20_f5cf3307 PS2, Line 137: pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efafc8e6_c715772d PS2, Line 138: pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64a7cdbf_1646a64a PS2, Line 139: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf16e85d_1cd1a8d2 PS2, Line 140: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc668099_63e3f026 PS2, Line 141: trans_table[sample_nr][2] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02aacb14_16f5471f PS2, Line 142: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bce688e9_304a2fb7 PS2, Line 143: pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2beb671_be61ec4e PS2, Line 144: pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ac89e4a_3238ffe1 PS2, Line 145: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1efe3799_1a8011e7 PS2, Line 146: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f94f9a5_34dd0f01 PS2, Line 147: trans_table[sample_nr][3] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff854304_d1afffb6 PS2, Line 148: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fdffc65b_21a25693 PS2, Line 149: pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6835d625_d32a45d9 PS2, Line 150: pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e85a381b_9a022197 PS2, Line 151: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99afc4db_48e98fa0 PS2, Line 152: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cb72145_4c978279 PS2, Line 153: trans_table[sample_nr][4] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec2dedcc_943427c4 PS2, Line 154: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1220705_55996237 PS2, Line 155: pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e5e85ad_edf99f86 PS2, Line 156: pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5a285f5_da5d865e PS2, Line 157: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a58023f_5980b528 PS2, Line 158: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6151009e_ec46b8b1 PS2, Line 159: trans_table[sample_nr][5] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6bf3fcea_5e9339ef PS2, Line 160: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebcf668b_ddaa27f5 PS2, Line 161: pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f52903_24cc297f PS2, Line 162: pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/345668b4_5d192e69 PS2, Line 163: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/958874f9_e25d3931 PS2, Line 164: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b15f89e_6531789c PS2, Line 165: trans_table[sample_nr][6] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56d0ef03_f45df79d PS2, Line 166: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/642d74d6_9772f8b6 PS2, Line 167: pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9504855_b2e8e3df PS2, Line 168: pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b25c7f6_e2432f0a PS2, Line 169: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e529294d_4d43dc47 PS2, Line 170: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f9d5c10_f47e594e PS2, Line 171: trans_table[sample_nr][7] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9c5fdd6_b0de5144 PS2, Line 172: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fd9bb89_c0c1f782 PS2, Line 173: pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b5b6fd1_1a2d1383 PS2, Line 174: pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc04b7ef_045a9e47 PS2, Line 175: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/023767aa_72930671 PS2, Line 176: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/80d9ca01_c3c1f88f PS2, Line 177: trans_table[sample_nr][8] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd6f7496_8006f729 PS2, Line 178: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0541ae1_249039d3 PS2, Line 179: pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b58c726e_22292867 PS2, Line 180: pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a50b68f6_bdd0c431 PS2, Line 181: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42232426_cf18fdf3 PS2, Line 182: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4647c84_211baf75 PS2, Line 183: trans_table[sample_nr][9] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c111e70_c8196225 PS2, Line 184: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f66120cd_0e6cec5e PS2, Line 185: pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9abbff0_b2828809 PS2, Line 186: pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfa5bc56_0a1a9d20 PS2, Line 187: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/584c82db_53342f73 PS2, Line 188: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/052f0983_f5391273 PS2, Line 189: trans_table[sample_nr][10] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3856ca77_9e6eeac7 PS2, Line 190: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9ddcc1d_6d5d6de9 PS2, Line 191: pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32856c54_4261b11a PS2, Line 192: pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf89f191_98b66baf PS2, Line 193: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2cb3a4c_03fdb1c4 PS2, Line 194: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/384e1cec_4abe3c19 PS2, Line 195: trans_table[sample_nr][11] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/832bde5f_3fa895f4 PS2, Line 196: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c71accad_7aa4f17f PS2, Line 197: pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/431c699a_58fde763 PS2, Line 198: pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/008c2851_c2e3bd30 PS2, Line 199: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bde6818d_7d2bcbc5 PS2, Line 200: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4873a45_de170cab PS2, Line 201: trans_table[sample_nr][12] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7f5b567_9e763355 PS2, Line 202: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba826ad8_977cb4fb PS2, Line 203: pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63e065dc_dfedeadc PS2, Line 204: pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13f816db_f7ec9eda PS2, Line 205: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd973d7c_bb7f431e PS2, Line 206: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9d5c04d_6820a079 PS2, Line 207: trans_table[sample_nr][13] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cca0e12_54d46a36 PS2, Line 208: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/402ca9e8_d981ec51 PS2, Line 209: pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc178b3a_135732af PS2, Line 210: pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0790d2c_90c81d65 PS2, Line 211: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3210f2ef_9e88e7d2 PS2, Line 212: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3a099896_b7866b7b PS2, Line 213: trans_table[sample_nr][14] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d27cc067_cda544ab PS2, Line 214: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95413569_b37b5680 PS2, Line 215: pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58d15de8_7a9d1785 PS2, Line 216: pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90f2557d_3c4dc985 PS2, Line 217: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69b52a4a_37a500a5 PS2, Line 218: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87bc80ab_9a69f0c7 PS2, Line 219: trans_table[sample_nr][15] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/000bc266_dda2bd18 PS2, Line 220: tmp=old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79b69ce3_8fe4e952 PS2, Line 221: old_path_metrics=new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e6465af_83597879 PS2, Line 222: new_path_metrics=tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6308b1c2_dd1d00f6 PS2, Line 223: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c41b0e9d_dfa524af PS2, Line 224: sample_nr++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b459f88_b8e14e0c PS2, Line 225: if(sample_nr==samples_num) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2dca96db_50d41d85 PS2, Line 226: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0a258bf_9e024e07 PS2, Line 227: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a179653a_b6d6209b PS2, Line 228: //Processing real states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f48596e_18a54a12 PS2, Line 229: real_imag=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d0b8d38_18081dff PS2, Line 230: input_symbol_real = input[sample_nr].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e013d597_1d5bc2b2 PS2, Line 231: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/422ab2ce_836df58f PS2, Line 232: pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94d46ddc_09221c27 PS2, Line 233: pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4eb3655b_5824d3ad PS2, Line 234: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bbee17e_24615ead PS2, Line 235: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8310ff7_b268fe45 PS2, Line 236: trans_table[sample_nr][0] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72bdb613_51f34cda PS2, Line 237: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adf152bb_bdc51703 PS2, Line 238: pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ffca4a6b_5a2fd9d0 PS2, Line 239: pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d27a7547_88765d61 PS2, Line 240: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebc47d61_67ff024b PS2, Line 241: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff6b3f6f_2cc54f19 PS2, Line 242: trans_table[sample_nr][1] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0d84634_c99680ee PS2, Line 243: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1743cfa_3cd62672 PS2, Line 244: pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26e7f107_2c30d37a PS2, Line 245: pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de5b7134_58ea690b PS2, Line 246: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2672c2d_1d41f8df PS2, Line 247: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb64a506_15fcaafb PS2, Line 248: trans_table[sample_nr][2] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/902337c9_b1d96948 PS2, Line 249: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52e1c734_5b77d082 PS2, Line 250: pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3719268c_69a3a6ab PS2, Line 251: pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1523674_4cb730d5 PS2, Line 252: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec9c2d7b_815dde6a PS2, Line 253: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8bea1baa_3d35353d PS2, Line 254: trans_table[sample_nr][3] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02695e48_ec196933 PS2, Line 255: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3816ffac_b1926cc0 PS2, Line 256: pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/051002a5_12c91e62 PS2, Line 257: pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bd957a9_62dcc2f1 PS2, Line 258: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf7b5c94_a24b81d5 PS2, Line 259: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41724c00_5eca79c8 PS2, Line 260: trans_table[sample_nr][4] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b0c90fc_ded4dd39 PS2, Line 261: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30403e4f_cc0baca1 PS2, Line 262: pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e1a9b51_bd580567 PS2, Line 263: pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42e37ced_1fa6167a PS2, Line 264: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29e1699e_b996cb80 PS2, Line 265: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ac6212b_002a8334 PS2, Line 266: trans_table[sample_nr][5] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/891b46d8_6bad8f7d PS2, Line 267: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc44745a_a0a3076f PS2, Line 268: pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/407d7d21_af3f550b PS2, Line 269: pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7de9d0c9_645887bf PS2, Line 270: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eee8f66_de3ad06e PS2, Line 271: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/929247d8_8f3f60c5 PS2, Line 272: trans_table[sample_nr][6] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/935f7535_aab102ce PS2, Line 273: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c4cdade_71d5b744 PS2, Line 274: pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e7dd481_205f5843 PS2, Line 275: pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff36c88a_607bb23e PS2, Line 276: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67535253_561455a1 PS2, Line 277: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f26094ce_7c68b072 PS2, Line 278: trans_table[sample_nr][7] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ec1a6e4_37049d53 PS2, Line 279: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efe86f61_e1328a74 PS2, Line 280: pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30f8f786_0fed0194 PS2, Line 281: pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6167440_d6acf2e9 PS2, Line 282: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53ed12e1_1997c1f0 PS2, Line 283: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86479557_230eda83 PS2, Line 284: trans_table[sample_nr][8] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43ed253e_bee8e6f4 PS2, Line 285: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/868e1fab_3e437966 PS2, Line 286: pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f3055e2_38426aa6 PS2, Line 287: pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/160db78f_faa37840 PS2, Line 288: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12ca9f4b_2ad940a3 PS2, Line 289: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68732a27_23023b7b PS2, Line 290: trans_table[sample_nr][9] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f80bf6a9_fde1b085 PS2, Line 291: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fa8470f_cf09cd1f PS2, Line 292: pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5066ea20_0c370212 PS2, Line 293: pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3bd491c_a132d42d PS2, Line 294: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93f9709a_1c5955ee PS2, Line 295: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f1be962_5605a657 PS2, Line 296: trans_table[sample_nr][10] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea1fba33_d2a6de41 PS2, Line 297: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7977a4f4_f89c014d PS2, Line 298: pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad334b06_82b81949 PS2, Line 299: pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/424b1f8f_6dd578b2 PS2, Line 300: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b6ba883_4b3df351 PS2, Line 301: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89805ac3_ca3b9672 PS2, Line 302: trans_table[sample_nr][11] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db8e6784_a276158f PS2, Line 303: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f6ea85a_f0f04c68 PS2, Line 304: pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0d10a7c_0e5bc7dd PS2, Line 305: pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a07571a5_55f5d0c3 PS2, Line 306: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bcffd453_8f706ea8 PS2, Line 307: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2264f1b9_ac92c0f2 PS2, Line 308: trans_table[sample_nr][12] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2bd8be14_6e9d0a9e PS2, Line 309: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21f34d2b_f0c05478 PS2, Line 310: pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd4b69f7_f9e71ef2 PS2, Line 311: pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97b2cf3b_032ceec4 PS2, Line 312: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f7660db_ecae6c32 PS2, Line 313: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e1cec17_c647d4ca PS2, Line 314: trans_table[sample_nr][13] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/293c4368_e2478eb2 PS2, Line 315: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d0ffbb9c_ae321365 PS2, Line 316: pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/996edd06_3a152812 PS2, Line 317: pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d50fb25b_bd46a4c6 PS2, Line 318: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8cd001c6_f81632e9 PS2, Line 319: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/690449f9_2e937c84 PS2, Line 320: trans_table[sample_nr][14] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11958998_d3745c7c PS2, Line 321: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a340d57b_03ec149c PS2, Line 322: pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e70d9e6_1c063e49 PS2, Line 323: pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1741b036_b9939b86 PS2, Line 324: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4abd28b_31a4acd7 PS2, Line 325: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93578efd_801dc9b4 PS2, Line 326: trans_table[sample_nr][15] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9caa6199_6f7a306c PS2, Line 327: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dd50192_ef818950 PS2, Line 328: tmp=old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1aa72876_dfd6e0d4 PS2, Line 329: old_path_metrics=new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74351c9e_ae59317e PS2, Line 330: new_path_metrics=tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ef084d9_1f34fbbc PS2, Line 331: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0e48429_fe9a4a95 PS2, Line 332: sample_nr++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/207372f9_a3eef8df PS2, Line 333: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf29e22e_1ba94a7a PS2, Line 334: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/235a0004_267c78e0 PS2, Line 335: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2eae96b2_f90b55cd PS2, Line 336: * Find the best from the stop states by comparing their path metrics. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4445792b_62709909 PS2, Line 337: * Not every stop state is always possible, so we are searching in trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7ee8ea8_12b85e24 PS2, Line 338: * a subset of them. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f24188f9_b592a6db PS2, Line 339: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3bec72de_2287a20e PS2, Line 340: unsigned int best_stop_state; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10f4d59d_25d24d33 PS2, Line 341: float stop_state_metric, max_stop_state_metric; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c92ba95_06ffdc57 PS2, Line 342: best_stop_state = stop_states[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f96e79d_a93f361a PS2, Line 343: max_stop_state_metric = old_path_metrics[best_stop_state]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce538895_18ffb4ed PS2, Line 344: for(i=1; i< stops_num; i++){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a49b47cf_8bb6401c PS2, Line 345: stop_state_metric = old_path_metrics[stop_states[i]]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fa6f8bb_0b459d13 PS2, Line 346: if(stop_state_metric > max_stop_state_metric){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7db4a93b_c8f066f3 PS2, Line 347: max_stop_state_metric = stop_state_metric; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4eb7f996_c8a1c40a PS2, Line 348: best_stop_state = stop_states[i]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/31a8984b_baecd700 PS2, Line 349: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/119c92ca_da35633a PS2, Line 350: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ca0630e_8aba8405 PS2, Line 351: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64662e52_eda4fd69 PS2, Line 352: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f8ac0a0_c769eff4 PS2, Line 353: * This table was generated with hope that it gives a litle speedup during trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d651cda3_9533d5f8 PS2, Line 354: * traceback stage. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f092de25_8e09ee1e PS2, Line 355: * Received bit is related to the number of state in the trellis. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51c332b0_4755c715 PS2, Line 356: * I've numbered states so their parity (number of ones) is related trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/784c0511_54a67d37 PS2, Line 357: * to a received bit. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d4d08ba_c3006891 PS2, Line 358: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca702d3e_27533fb2 PS2, Line 359: static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/011155be_e253073c PS2, Line 360: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e41c12b9_b6a91ac0 PS2, Line 361: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b24edb7_b3e304c1 PS2, Line 362: * Table of previous states in the trellis diagram. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66bf3ffd_514f1885 PS2, Line 363: * For GMSK modulation every state has two previous states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b684734e_f0143d49 PS2, Line 364: * Example: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb9c71f3_c9b52bfe PS2, Line 365: * previous_state_nr1 = prev_table[current_state_nr][0] trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5cde8d6_3596a3b6 PS2, Line 366: * previous_state_nr2 = prev_table[current_state_nr][1] trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a022fdd8_cac044ea PS2, Line 367: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc469627_408067fb PS2, Line 368: static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68e7acd2_14bbf0de PS2, Line 369: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0742122_ec51659b PS2, Line 370: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af121191_d21f5098 PS2, Line 371: * Traceback and differential decoding of received sequence. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/342ce7d2_53141672 PS2, Line 372: * Decisions stored in trans_table are used to restore best path in the trellis. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58c19bcc_b7af9b7b PS2, Line 373: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d86a2985_82aae718 PS2, Line 374: sample_nr=samples_num; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad04b727_fee3ea90 PS2, Line 375: unsigned int state_nr=best_stop_state; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6befa393_038b9c8e PS2, Line 376: unsigned int decision; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a5330b0_66e9578d PS2, Line 377: bool out_bit=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f73019_6f742e81 PS2, Line 378: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e8c31e6_845867ea PS2, Line 379: while(sample_nr>0){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/049b4662_f2e1868e PS2, Line 380: sample_nr--; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8508af6e_57e34af4 PS2, Line 381: decision = (trans_table[sample_nr][state_nr]>0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c251cf75_e1da3f2d PS2, Line 382: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9abcadd9_a1a93e07 PS2, Line 383: if(decision != out_bit) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/16f86cd9_66152f86 PS2, Line 384: output[sample_nr]=-trans_table[sample_nr][state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2467bf22_49e9fbf9 PS2, Line 385: else DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e3dec2f3_39e89f36 PS2, Line 386: output[sample_nr]=trans_table[sample_nr][state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c4e5e3_041bddc8 PS2, Line 387: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce87ba0e_170a4348 PS2, Line 388: out_bit = out_bit ^ real_imag ^ parity_table[state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a7dbab3_cf2cb96f PS2, Line 389: state_nr = prev_table[state_nr][decision]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6da62953_37a882f5 PS2, Line 390: real_imag = !real_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b88674a_a078a257 PS2, Line 391: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e54f75c2_997b5000 PS2, Line 392: } DOS line endings -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:37:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Jump to page:

2025

2024

2023

2022

gerrit-log December 2022