December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-trx[master]: ignore vscode dirs

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 ) Change subject: ignore vscode dirs ...................................................................... ignore vscode dirs Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/.gitignore b/.gitignore index fec8fab..74e1d00 100644 --- a/.gitignore +++ b/.gitignore @@ -75,3 +75,6 @@ !contrib/osmo-trx.spec.in utils/osmo-prbs-tool +/.qtc_clangd/* +/.cache/* +/.vscode/* -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c Gerrit-Change-Number: 30410 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ignore vscode dirs

by Hoernchen

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 ) Change subject: ignore vscode dirs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c Gerrit-Change-Number: 30410 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:28:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/b75d13f9_13897a75 PS1, Line 1045: static void paging_dump_vty(struct vty *vty, struct gsm_paging_request *pag) : { : vty_out(vty, "Paging on BTS %u%s", pag->bts->nr, VTY_NEWLINE); : bsc_subscr_dump_vty(vty, pag->bsub); : } : : static void bts_paging_dump_vty(struct vty *vty, struct gsm_bts *bts) : { : struct gsm_paging_request *pag; : : llist_for_each_entry(pag, &bts->paging.initial_req_list, entry) : paging_dump_vty(vty, pag); : llist_for_each_entry(pag, &bts->paging.retrans_req_list, entry) : paging_dump_vty(vty, pag); > minor (can be follow-up patch): It might make sense to extend the vty dumping with some information […] Will be submitted as Change-ID I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:27:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ms-trx support

by fixeria

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 3: Code-Review-1 (16 comments) File Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b149085f_86bef51a PS3, Line 37: osmocom-bb/src/host/trxcon \ > osmocom-bb/src/host/trxcon is added twice? here and above Ack. Most likely he forgot to remove this line. File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d979a6e9_746c2026 PS3, Line 26: AM_CPPFLAGS '-I' stuff should be in CPPFLAGS only, it makes no sense to have it in CFLAGS/CXXFLAGS. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c6880f67_88b3bfc7 PS3, Line 77: LIBOSMOCODING_LIBS Having LIBOSMOCODING_LIBS in COMMON_LDADD makes all osmo-trx-* binaries depend on libosmocoding, while it's only needed for osmo-trx-ms-* and osmo-prbs-tool. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83a2d0fc_dd0a1d18 PS3, Line 90: noinst_HEADERS This should be done conditionally too, but not critical I guess. File Transceiver52M/ms/itrq.h: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16aab7e0_8f217ba5 PS3, Line 34: /* weird comment formatting, please make it consistent with the copyright header File Transceiver52M/ms/l1ctl_server_cb.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0c228dc_35756759 PS3, Line 65: osmocom_l2 TODO: make path configurable https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2921f8c4_7e180c4a PS3, Line 74: return so the app keeps running if l1ctl_server_alloc() fails? File Transceiver52M/ms/logging.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d82e3853_8e6bb5aa PS3, Line 54: loglevel = LOGL_NOTICE spacing issues https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8293fbce_b4ab0313 PS3, Line 57: DTRXC not used by libtrxcon nor needed https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98faf6d8_0b0b4d10 PS3, Line 64: DTRXD not used by libtrxcon nor needed https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ac236f1_1832c8bf PS3, Line 75: .loglevel = LOGL_NOTICE, spacing issues https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/577062e9_90eb9294 PS3, Line 76: enabled = 0, why disabled? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40fa09ba_dd2d7c09 PS3, Line 82: .loglevel = LOGL_NOTICE, spacing issues File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/668f1798_05ce8f1c PS3, Line 330: test -d osmocom-bb A proper approach would be making this configurable: --enable-ms or --with-ms. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/552f7b86_a9ccfcd7 PS3, Line 333: AC_MSG_NOTICE(["Enabling ms-trx..."]) spacing issues https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd88649c_69bebf3b PS3, Line 364: doc/manuals/Makefile \ > This looks like a separate patch. Ack, it's one of my fixups: https://cgit.osmocom.org/osmo-trx/commit/?h=fixeria/ms&id=8ed86879c4ea9a0ed… -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:26:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by fixeria

Attention is currently required from: laforge, pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/2862818f_ac66d84c PS1, Line 216: page_ms(request); > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:13:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by osmith

Attention is currently required from: fixeria, pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/da8d2c5e_062f6abb PS1, Line 216: > Is there a way to include this in our lint job? it could probably extended for that, but I don't think it's worth investigating right now. it's a perl script from the linux kernel (checkpatch). https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/215193ae_5e983785 PS1, Line 263: bts_pag_st->initial_req_list_len--; > Yeah, same behavior, just more encapsulated. […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/e8e95c19_df47880a PS1, Line 279: static unsigned int step_page_retrans_reqs(struct gsm_bts_paging_state *bts_pag_st, unsigned int max_page_req_per_iter, const struct timespec *now) > This line exceeds the 120 chars-per-line limit. Done https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/211fc5b0_7b325c6e PS1, Line 532: > indentation Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:03:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: vita demod by piotr krysik, modified

by fixeria

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 ) Change subject: vita demod by piotr krysik, modified ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dca47a9d_0effbb4b PS2, Line 7: by piotr krysik Commit message should ideally state where the code is imported from, including the commit hash if it's a repository. AFAICS it's from gr-gsm.git? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:51:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 ) Change subject: osmocom-bb for ms-trx side trxcon integration ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File .gitmodules: https://gerrit.osmocom.org/c/osmo-trx/+/30412/comment/5c8397f0_d47ef551 PS1, Line 4: branch = a4aac5c3554559c2c994609f90b92a9daf6e8a89 I wonder shouldn't this be set to track master in general? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61 Gerrit-Change-Number: 30412 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:42:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration

by fixeria

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 ) Change subject: osmocom-bb for ms-trx side trxcon integration ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61 Gerrit-Change-Number: 30412 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:39:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ignore vscode dirs

by fixeria

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 ) Change subject: ignore vscode dirs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c Gerrit-Change-Number: 30410 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:38:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022