gerrit-log December 2022

gerrit-log@lists.osmocom.org

1 participants
1979 discussions

Change in osmo-trx[master]: ill-fated ipcv2 for mstrx

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 ) Change subject: ill-fated ipcv2 for mstrx ...................................................................... Patch Set 2: (237 comments) File Transceiver52M/device/ipc2/IPCDevice.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5eb0c714_10ee29c1 PS2, Line 40: protected: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6651161_e98b5749 PS2, Line 41: std::vector<smpl_buf *> rx_buffers; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d1c36682_941a2da2 PS2, Line 41: std::vector<smpl_buf *> rx_buffers; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0309d99f_d325d12e PS2, Line 41: std::vector<smpl_buf *> rx_buffers; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/181f24ff_3c81b73c PS2, Line 41: std::vector<smpl_buf *> rx_buffers; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6390f5a_84f02b55 PS2, Line 48: std::vector<double> tx_gains, rx_gains; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/74f0c2d7_3b8f6326 PS2, Line 48: std::vector<double> tx_gains, rx_gains; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e28c3717_0e5bc19f PS2, Line 48: std::vector<double> tx_gains, rx_gains; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/14970ee1_c6aa8d34 PS2, Line 57: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c3b16b05_6d030687 PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ebba5fff_4b269633 PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5a91daa5_9433bcd3 PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0ac42c66_8d16cffb PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/389dc8c4_9fd06a79 PS2, Line 64: virtual int open(const std::string &args, int ref, bool swap_channels) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/60f3b4d1_f8c4a67c PS2, Line 67: virtual bool start() override; Bad function definition - virtual bool start() should probably be virtual bool start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01cdc5de_098ffd82 PS2, Line 70: virtual bool stop() override; Bad function definition - virtual bool stop() should probably be virtual bool stop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b0e01f01_2c6b7faa PS2, Line 73: enum TxWindowType getWindowType() override Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d448e734_fc23cd20 PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/aaa757a1_87ad6be3 PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b512702_3e193375 PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/280e3c99_4ec715d6 PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/313b4380_8034db45 PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d890133c_55ca5193 PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e1e8e0b_7910299f PS2, Line 98: TIMESTAMP timestamp = 0xffffffff) override; Statements should start on a tabstop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/05623a62_f45b2370 PS2, Line 116: virtual double fullScaleInputValue() override Bad function definition - virtual double fullScaleInputValue() should probably be virtual double fullScaleInputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e6fe73b2_79acfa36 PS2, Line 122: virtual double fullScaleOutputValue() override Bad function definition - virtual double fullScaleOutputValue() should probably be virtual double fullScaleOutputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/563a6b6b_eadaa9a7 PS2, Line 154: virtual bool setRxAntenna(const std::string &ant, size_t chan = 0) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3f3fe317_ffcfd8d4 PS2, Line 160: virtual bool setTxAntenna(const std::string &ant, size_t chan = 0) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1900fd3a_275c0587 PS2, Line 166: virtual bool requiresRadioAlign() override; Bad function definition - virtual bool requiresRadioAlign() should probably be virtual bool requiresRadioAlign(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4f8a6e9_f0f8af19 PS2, Line 180: virtual inline double getSampleRate() override Bad function definition - virtual inline double getSampleRate() should probably be virtual inline double getSampleRate(void) File Transceiver52M/device/ipc2/ipcif.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7156ba40_b312c199 PS2, Line 35: using sample_t = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fee2edef_3cac70b9 PS2, Line 35: using sample_t = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7c9d33b7_95085a2e PS2, Line 37: std::atomic<bool> ms_connected; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59a78da7_77505797 PS2, Line 37: std::atomic<bool> ms_connected; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6904fbb_07150c9b PS2, Line 37: std::atomic<bool> ms_connected; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b3974ff_e5789b98 PS2, Line 39: shm::sema r; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89a3fffe_65643b9a PS2, Line 40: shm::sema w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/beb8ed7b_acf6fac7 PS2, Line 41: std::atomic<uint64_t> ts; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/38fb8844_2dcfabdf PS2, Line 41: std::atomic<uint64_t> ts; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7cfbbf69_ec0c6aee PS2, Line 41: std::atomic<uint64_t> ts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fbf1e6ae_43c98e90 PS2, Line 42: std::atomic<uint64_t> ts_req; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8efd569_60c5b775 PS2, Line 42: std::atomic<uint64_t> ts_req; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/593e0c8f_1844ba23 PS2, Line 42: std::atomic<uint64_t> ts_req; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/194837c0_8000ed00 PS2, Line 43: std::atomic<size_t> len_written_sps; // -> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce257af0_156038c6 PS2, Line 43: std::atomic<size_t> len_written_sps; // -> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9a845225_9f4ac600 PS2, Line 43: std::atomic<size_t> len_written_sps; // -> labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1ba05bc2_7435f43b PS2, Line 47: shm::sema r; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/22053d07_5810e706 PS2, Line 48: shm::sema w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/44b3db41_65b7ce63 PS2, Line 49: std::atomic<uint64_t> ts; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f3ed677_2174adcf PS2, Line 49: std::atomic<uint64_t> ts; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c048fe0_42ba4889 PS2, Line 49: std::atomic<uint64_t> ts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36599d53_564249b6 PS2, Line 50: std::atomic<uint64_t> ts_req; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/bae00da5_75f5e75b PS2, Line 50: std::atomic<uint64_t> ts_req; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/28ec1a63_da15a818 PS2, Line 50: std::atomic<uint64_t> ts_req; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9086905a_01283fd8 PS2, Line 51: std::atomic<size_t> len_written_sps; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0d0cff4f_9af47237 PS2, Line 51: std::atomic<size_t> len_written_sps; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ed36f073_52466fa0 PS2, Line 51: std::atomic<size_t> len_written_sps; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/184a26e8_b330aaf8 PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5ce200e0_2d92dc62 PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abfdc864_72902c5f PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8cad5dfd_28ca9436 PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/88498a7c_28c05de3 PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6c0d245d_e49e9a50 PS2, Line 60: using stype = typename std::make_signed<A>::type; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2912444_75bbc1ed PS2, Line 60: using stype = typename std::make_signed<A>::type; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5aab985a_e2c132df PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/45d777bb_3cba3886 PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd47cd47_57d9fbd5 PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2842c9d1_7d08a76d PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0fce91ef_17a02c37 PS2, Line 90: template <unsigned int num_bursts> class ulburstprovider { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59d7ca3a_ba0a7c36 PS2, Line 90: template <unsigned int num_bursts> class ulburstprovider { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d0d7963b_00d5eb89 PS2, Line 91: std::mutex ul_q_m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/646c55cd_bcf6b799 PS2, Line 98: void cur_buf_done() Bad function definition - void cur_buf_done() should probably be void cur_buf_done(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8814733c_6624eced PS2, Line 98: void cur_buf_done() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d2123386_6029ea20 PS2, Line 103: bool is_empty() Bad function definition - bool is_empty() should probably be bool is_empty(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f7d4b763_7d26bf38 PS2, Line 103: bool is_empty() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4d4b6121_04cb1d91 PS2, Line 107: void reset() Bad function definition - void reset() should probably be void reset(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/685009e0_61ee5fde PS2, Line 107: void reset() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ac466315_88346419 PS2, Line 109: for (auto &i : foo) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9ca3ae6d_61f2063f PS2, Line 113: ulentry &find_free_at_end() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9708e2ed_08ffb55b PS2, Line 123: void push_back(ulentry &e) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afdb222e_0b15a608 PS2, Line 123: void push_back(ulentry &e) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01e5f853_6b5c4ccd PS2, Line 130: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/08b6858e_3879250f PS2, Line 131: void add(ulentry &e) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fe53ecb5_f45ca93f PS2, Line 131: void add(ulentry &e) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1525b4c3_a519002e PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/87a23cd3_2fcd6dfc PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e03c7c7a_05ce8b37 PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b4ae76d3_453be567 PS2, Line 136: void get(uint64_t requested_ts, unsigned int req_len_in_sps, sample_t *buf, unsigned int max_buf_write_len) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6dc104f_2162c7b2 PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd734b0b_27cb756e PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89adcdfc_abcc80f4 PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b209e52_8e8a9dc8 PS2, Line 149: memset((void*)buf, 0, samp2byte(req_len_in_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e2289784_ae5c19cf PS2, Line 159: memset((void*)buf, 0, samp2byte(req_len_in_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e8b3733_71999982 PS2, Line 171: memset((void*)buf, 0, samp2byte(req_len_in_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dc8c758b_4dd5b0e2 PS2, Line 176: memset((void*)buf, 0, samp2byte(to_pad_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ee5f6fb2_3c180621 PS2, Line 203: shm::shm<shm_if> m; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8b5bca22_4a30b325 PS2, Line 203: shm::shm<shm_if> m; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ca950797_63eb1a09 PS2, Line 203: shm::shm<shm_if> m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0d7347d_77bdf7d4 PS2, Line 206: ulburstprovider<10> p; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f91b6d2e_3a060b86 PS2, Line 206: ulburstprovider<10> p; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad1573f6_8e72f597 PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0566160d_cb81fae6 PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2ca303f5_b37008d8 PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d0b9388_85157e47 PS2, Line 217: shm::mtx_log::print_guard() << "\tr @" << direction.ts.load() << " " << readoffset_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29a83a99_ea999a57 PS2, Line 235: shm::mtx_log::print_guard() << "\tr+ " << *read_ts << " " << howmany_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/07f8d3d6_dfb53bd9 PS2, Line 247: shm::mtx_log::print_guard() << "\tr++ " << *read_ts << " " << howmany_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/18d29d35_593629fb PS2, Line 249: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ec0996e8_0b226007 PS2, Line 263: shm::mtx_log::print_guard() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/249099cf_bcde4534 PS2, Line 270: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2dd76bb9_367bca4f PS2, Line 275: bool create() Bad function definition - bool create() should probably be bool create(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9b01aef9_c2337ba9 PS2, Line 275: bool create() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/590aac2a_fde9acaf PS2, Line 281: bool connect() Bad function definition - bool connect() should probably be bool connect(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d2f702a_09524393 PS2, Line 281: bool connect() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cb6739b3_3f1194b1 PS2, Line 289: bool good() Bad function definition - bool good() should probably be bool good(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2bf91492_7a597009 PS2, Line 289: bool good() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8ffd5db3_a7616ad7 PS2, Line 293: bool is_connected() Bad function definition - bool is_connected() should probably be bool is_connected(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f9458b36_7c5c153e PS2, Line 293: bool is_connected() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6c7c4fb6_17bad2c7 PS2, Line 299: void read_dl(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6ca99336_f48faa03 PS2, Line 305: void read_ul(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f86345d9_af441b42 PS2, Line 308: memset((void*)outbuf, 0, samp2byte(howmany_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/97d9771c_6ae0586d PS2, Line 309: // return; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fa723613_f217bc71 PS2, Line 314: void write_dl(size_t howmany_sps, uint64_t write_ts, sample_t *inbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59c2feed_341009cd PS2, Line 316: auto &dl = ptr->dl; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4e49cd64_45664729 PS2, Line 325: shm::sema_wait_guard g(dl.w, dl.r); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad0f71a5_91013754 PS2, Line 331: shm::mtx_log::print_guard() << std::endl labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/76bf94c7_7f935e9a PS2, Line 336: void write_ul(size_t howmany_sps_sps, uint64_t write_ts, sample_t *inbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54ad6f8f_706b94a4 PS2, Line 338: auto &ul = ptr->ul; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab1a9da7_5dff33dd PS2, Line 351: shm::mtx_log::print_guard() << std::endl labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/771e2923_63e2f334 PS2, Line 356: void drive_tx() Bad function definition - void drive_tx() should probably be void drive_tx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b8d72181_ed656a07 PS2, Line 356: void drive_tx() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/318ad639_78ab26ac PS2, Line 358: auto &ul = ptr->ul; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/15e6dffb_ef0d3805 PS2, Line 384: void signal_read_start() Bad function definition - void signal_read_start() should probably be void signal_read_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/877dc66e_62b6b41d PS2, Line 384: void signal_read_start() open brace '{' following function definitions go on the next line File Transceiver52M/device/ipc2/shmif.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eb644607_9579c6f5 PS2, Line 46: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1693b05c_4bb74683 PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5b5bbfa5_1c8670d1 PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/aebeff6b_0459d5f1 PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/77c55d6f_dfef99da PS2, Line 50: std::cerr << str(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12cceaea_d6c1d40b PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0c928010_3bbd8cda PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c882d4b_4d36cebd PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d0c6ca60_6268763e PS2, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &)) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd0a84ff_367f7573 PS2, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &)) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4ced4462_4170fd83 PS2, Line 73: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9afff3ef_55d2d279 PS2, Line 89: void lock() Bad function definition - void lock() should probably be void lock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e3520517_7b7ea85b PS2, Line 89: void lock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fb636e5e_faa6fd87 PS2, Line 94: bool try_lock() Bad function definition - bool try_lock() should probably be bool try_lock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ef6b7112_fae2cba6 PS2, Line 94: bool try_lock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/90f7345f_c1af9d58 PS2, Line 99: void unlock() Bad function definition - void unlock() should probably be void unlock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abff3ac7_ef507452 PS2, Line 99: void unlock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/846764f3_24c01d36 PS2, Line 104: pthread_mutex_t *p() Bad function definition - pthread_mutex_t *p() should probably be pthread_mutex_t *p(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab804f25_91c09e89 PS2, Line 104: pthread_mutex_t *p() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72c380ce_cb1fd615 PS2, Line 109: shmmutex &operator=(const shmmutex &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5dd0aec1_206f7b7e PS2, Line 109: shmmutex &operator=(const shmmutex &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e9d9f048_bf8c7df3 PS2, Line 115: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/961dab4d_0a6761f7 PS2, Line 130: void wait(shmmutex *lock) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f61bada3_dff36445 PS2, Line 135: void signal() Bad function definition - void signal() should probably be void signal(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b48a1d13_a81d6db7 PS2, Line 135: void signal() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1877ddc9_18b81d69 PS2, Line 140: void signal_all() Bad function definition - void signal_all() should probably be void signal_all(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce5524ba_d16a1e47 PS2, Line 140: void signal_all() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/219eb1cc_89d7f6ae PS2, Line 145: shmcond &operator=(const shmcond &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eba2bf9a_5472fe0a PS2, Line 145: shmcond &operator=(const shmcond &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c83b8a93_a4cb8d6f PS2, Line 149: shmmutex &m; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12b2d928_fad62cdd PS2, Line 150: shmcond &s; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3a30ea83_fe27cfdd PS2, Line 152: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d121565f_fcd777b4 PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/734fe99f_9ca7d80e PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/84dc4439_dac707f5 PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c34827e1_54bbad7a PS2, Line 165: signal_guard &operator=(const signal_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1780f1a9_9bbacec6 PS2, Line 165: signal_guard &operator=(const signal_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d3c669ff_60e5125d PS2, Line 169: shmmutex &m; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eeb28922_b3870366 PS2, Line 171: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1d286ccd_38f19728 PS2, Line 173: explicit mutex_guard(shmmutex &m) : m(m) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/23b6a7d0_5061701b PS2, Line 182: mutex_guard &operator=(const mutex_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c63ecb3_925b6fb8 PS2, Line 182: mutex_guard &operator=(const mutex_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e080a1cc_42dc1735 PS2, Line 186: std::atomic<int> value; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2da29632_3b624ac9 PS2, Line 186: std::atomic<int> value; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0d1b2f2_e029394b PS2, Line 186: std::atomic<int> value; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29384ff2_faa033a4 PS2, Line 190: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/82c752e2_f164c4ca PS2, Line 198: void wait() Bad function definition - void wait() should probably be void wait(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5d21a9b8_b4be25b3 PS2, Line 198: void wait() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f77ff0c3_e09d6eb3 PS2, Line 202: void wait(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3660db1d_67bfbc58 PS2, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/189d621f_de541083 PS2, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ee4a9e4f_edf77e3e PS2, Line 205: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4896d3c6_d4b455a8 PS2, Line 210: void wait_and_reset() Bad function definition - void wait_and_reset() should probably be void wait_and_reset(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b0d9ee6_a2cc2395 PS2, Line 210: void wait_and_reset() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/64dbc8eb_e1b03cf3 PS2, Line 214: void wait_and_reset(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/39b3f525_24f813c2 PS2, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/001c3da9_1e06e8cc PS2, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01ec7353_26a6d2fb PS2, Line 217: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d46c281_0a713432 PS2, Line 223: void set() Bad function definition - void set() should probably be void set(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4c328d9_ae226303 PS2, Line 223: void set() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8a7c70f3_f161439e PS2, Line 227: void set(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e519b59_d35f0b65 PS2, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f9baeb0_0826a66c PS2, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2d07309f_8d3ee60c PS2, Line 230: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8f33930e_101905f3 PS2, Line 234: void reset_unsafe() Bad function definition - void reset_unsafe() should probably be void reset_unsafe(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2064dcd_39ea23bf PS2, Line 234: void reset_unsafe() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3bb61d37_5e091d92 PS2, Line 238: bool check_unsafe(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f39ccde_f6b5b66f PS2, Line 243: sema &operator=(const sema &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ada744ee_acaa6a36 PS2, Line 243: sema &operator=(const sema &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0388d9c3_795d2bf3 PS2, Line 247: sema &a; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3a94712c_d71ad545 PS2, Line 248: sema &b; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96e6a50f_e4f4a28f PS2, Line 250: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/60f42e38_e2f5cee4 PS2, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cb60795f_d3e13d5c PS2, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cdbf0ddd_f4cd39a0 PS2, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2dc97c45_1f6bfffe PS2, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/214ab49f_17437e32 PS2, Line 265: sema &a; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/33074b0c_2436e030 PS2, Line 266: sema &b; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2f06355_23f043c5 PS2, Line 268: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b232afdb_b9b3cbca PS2, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d41cbff9_5ae783ad PS2, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dca3451f_4ba4aa85 PS2, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afb11ee5_fac34b8e PS2, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/daa77e76_8048a624 PS2, Line 282: template <typename IFT> class shm { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd41f343_ae2a9602 PS2, Line 282: template <typename IFT> class shm { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e396ae3_fb4e01bd PS2, Line 287: int ipc_shm_setup(const char *shm_name) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/450e2df9_836fb384 PS2, Line 293: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) { Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/742af127_911a5c4f PS2, Line 310: shmptr = new (ptr) IFT(); //static_cast<IFT *>(ptr); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3ada4cde_49942d79 PS2, Line 315: int ipc_shm_connect(const char *shm_name) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b865db96_0ac48435 PS2, Line 321: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR)) < 0) { Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36035164_70bc0a8f PS2, Line 339: shmptr = static_cast<IFT *>(ptr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9cfe66c3_11aceee0 PS2, Line 339: shmptr = static_cast<IFT *>(ptr); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d00b8d1c_6187717b PS2, Line 339: shmptr = static_cast<IFT *>(ptr); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/71c58734_ccdbefc9 PS2, Line 344: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6affbb4d_01d5a5b8 PS2, Line 348: strncpy((char *)shmname, name, 512); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48cfa4a6_a0f6af2f PS2, Line 350: void create() Bad function definition - void create() should probably be void create(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4f0587c0_3cb673fc PS2, Line 350: void create() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad193449_65ce6949 PS2, Line 355: void open() Bad function definition - void open() should probably be void open(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd360768_d3ef3120 PS2, Line 355: void open() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f64c4e21_7482d277 PS2, Line 360: bool isgood() const Bad function definition - bool isgood() should probably be bool isgood(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5630194f_a38df97d PS2, Line 364: void close() Bad function definition - void close() should probably be void close(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0cf2e12_d08242a4 PS2, Line 364: void close() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d2b65f4e_7291a6d2 PS2, Line 369: IFT *p() Bad function definition - IFT *p() should probably be IFT *p(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3548f8a3_7a1a3521 PS2, Line 369: IFT *p() open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5 Gerrit-Change-Number: 30414 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: ill-fated ipcv2 for mstrx

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30414 to look at the new patch set (#2). Change subject: ill-fated ipcv2 for mstrx ...................................................................... ill-fated ipcv2 for mstrx The problem here is that the ipc if requires reducing the clock ind inteval to a few fn/ts on the trx side to work at all, but scheduling still does not work out, unless you start driving the IF using the tx side, at which point the approach is useless, because it does not really do more than a burst loopback that is easier to do with the higher layers/interfaces. The code is still useful should there be a reason to continue working on this. Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5 --- M Transceiver52M/device/Makefile.am A Transceiver52M/device/ipc2/IPCDevice.cpp A Transceiver52M/device/ipc2/IPCDevice.h A Transceiver52M/device/ipc2/Makefile.am A Transceiver52M/device/ipc2/ipcif.h A Transceiver52M/device/ipc2/shmif.h 6 files changed, 1,281 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/14/30414/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5 Gerrit-Change-Number: 30414 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

Change in osmo-trx[master]: ms-trx support

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 2: (408 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac398c1c_b77b843a PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8f013f6_0d2bcf94 PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/facaacf3_64db5128 PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b6c019d_aa7a430c PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3493d252_16566615 PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e76c7ce_defeab86 PS2, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8ad9870_e64ae3b1 PS2, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bb31d7a_b2b3951d PS2, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2583187b_d4262b90 PS2, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10ee9772_e31f5161 PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17d4672d_93ea4552 PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2284c66c_7c219fa3 PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c10657a_438c9110 PS2, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03f16073_facafa2d PS2, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcda8fd6_5a1aeed8 PS2, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e996809d_a4100ad3 PS2, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6004ca7_23b0e7a1 PS2, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8faa3170_f373e9bb PS2, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06074678_b51e6280 PS2, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/914c1e8a_8b96bf13 PS2, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8129465b_7158fe99 PS2, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c3f00b5_659efa9f PS2, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79cfc92f_171096ea PS2, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d57c7c48_7f9a0b66 PS2, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c205ac73_4a8da9ff PS2, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79d50ad1_07733d5f PS2, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b7aed85_d8facfa1 PS2, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58ba745a_6a570676 PS2, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ea732ac_903b1da2 PS2, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24164b66_780879ce PS2, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c762f18_b873fae3 PS2, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a3f696b_8c2c509e PS2, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a1ff4cf_7179fe65 PS2, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7aea4f2_014b0c98 PS2, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb633110_130cc80d PS2, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ffe4c6f_65caf1c2 PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5d7d863_e448474e PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a01f779_6dc0735c PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d503743f_d6db6b0f PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51c994f6_0fa8ffb7 PS2, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0cc504d_9a977458 PS2, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f0c1c62_63da7844 PS2, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f544051_c43a6cfb PS2, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4aafc47f_1a7f12d9 PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7076fa87_1c492939 PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8008f6e8_4595dfa4 PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4095380e_9b57b4ac PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8cf93ca0_174ce3e3 PS2, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ca2752e_b93cea8a PS2, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6766c182_ed789b10 PS2, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db9d4c23_3912098f PS2, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c293f74_39d667ae PS2, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cc89856_2850c22d PS2, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/caa19eec_f21a1e03 PS2, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c25896e6_57b28703 PS2, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08736312_ce6546c7 PS2, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9731e6da_32b8fbb7 PS2, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f83a2b9_e76b3158 PS2, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/947270ed_88040ea2 PS2, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef7f2b7c_0a39d7b4 PS2, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/348dda37_3f786b1b PS2, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d89625fe_3cdf625f PS2, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9d04593_bd5b1804 PS2, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e632f69_c83126d2 PS2, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19646b00_85d1edc9 PS2, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d8d6e43_d97c363d PS2, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51ce4983_99dc6d01 PS2, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63d10d14_6ebfcff3 PS2, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5840b3c_d9146e46 PS2, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11e6e464_df921290 PS2, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23fadae6_6c2158a8 PS2, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fde03432_a765a96d PS2, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02cf2806_d4dba24d PS2, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/008dfa47_46b90165 PS2, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c3a3a61_2f54bc23 PS2, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6a57cc_aba30eb7 PS2, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae83c964_4fae6268 PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0c5bf5b_f111079f PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ca2d6bc_46ed1b54 PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/43a2fbb5_0ca9562b PS2, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61ee3a27_1a9d1604 PS2, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a673fde2_939e168a PS2, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9553a025_ddc5d119 PS2, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/52d928b4_e9b7bd86 PS2, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d50a8e44_1ab699f7 PS2, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ea57201_2a323fd5 PS2, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1535610d_426589ed PS2, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a512f88_a81132d8 PS2, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49ac56d0_9e63cb91 PS2, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee369840_08598996 PS2, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eba2ad04_b1417ceb PS2, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10882bc5_f3b13cd3 PS2, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29940493_d0247f97 PS2, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e46d7c81_67a44129 PS2, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa7a3811_9b620740 PS2, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c666a4b_b5b421da PS2, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13da38ed_ed31fb12 PS2, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b49d024_65ac478f PS2, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11a22ff2_a4c76281 PS2, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4633e101_e7263baa PS2, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02faffd6_25752bfd PS2, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5df2a03_a8813ccf PS2, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f26512e9_1b44bf0d PS2, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b15ad8d_979a8eb0 PS2, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1a950ac_03be3621 PS2, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92fee962_138c157a PS2, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/732d6e9f_1fec785e PS2, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6411ccdd_28ef651c PS2, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8ed04a3_92e518b9 PS2, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8639436_abcf0b72 PS2, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d96b6727_959b8f71 PS2, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/230f92f7_3aad504b PS2, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daee3132_12cd9c52 PS2, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/ipc_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fb7c401_41d2c058 PS2, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a26047d8_9fcd12e0 PS2, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17ede36b_383dacf7 PS2, Line 45: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cdb8fe55_9cceaf6f PS2, Line 45: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1edbfd43_6acb2f8c PS2, Line 49: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56f6f013_b31bd14e PS2, Line 49: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/923cb376_3aede780 PS2, Line 53: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d73c3400_41ba8b87 PS2, Line 58: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35bf31f4_5c6e0ac7 PS2, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0123dd3_8c7aebb1 PS2, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c427cf2c_71380d73 PS2, Line 71: template <typename T> struct ipc_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f35c6428_a0a84447 PS2, Line 71: template <typename T> struct ipc_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f180f9bd_caaab3b1 PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/833ad6d6_e9c0f660 PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddae2912_94d39308 PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72c4e3a9_0cdd319f PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86fe3efa_64bcf9a0 PS2, Line 92: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bdc0968_f424f640 PS2, Line 99: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21ffd096_9e7a0930 PS2, Line 106: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a80c3a23_382c61be PS2, Line 111: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa7158f6_ab4f12da PS2, Line 119: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab3e3f91_86d8d264 PS2, Line 127: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/862edfd4_68c6de6f PS2, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f5d1c2f_c1775b11 PS2, Line 137: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9846cb8d_b8177dc5 PS2, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/366bf6df_88406df1 PS2, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/097d964a_97ad66b4 PS2, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e853008_8d3647c7 PS2, Line 166: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f238f19b_caecb91f PS2, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8bae041_97eb3160 PS2, Line 177: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c1de663d_6fb76c7f PS2, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/770c2ad4_aeb73237 PS2, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/43062a01_90429084 PS2, Line 193: void signal_start() Bad function definition - void signal_start() should probably be void signal_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74dacd07_f45e55aa PS2, Line 193: void signal_start() open brace '{' following function definitions go on the next line File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/805a658a_a6649f51 PS2, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fef7c90d_14c60f14 PS2, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eff8d83f_229375fd PS2, Line 52: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49de2144_f4f258d6 PS2, Line 53: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a868605c_ef0ccf44 PS2, Line 54: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04e1704e_39d91c98 PS2, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a88df88_769eb0bc PS2, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b58e43d6_9b6ac868 PS2, Line 65: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a8e76d3_a1f37664 PS2, Line 65: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85d36b5a_e907779b PS2, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5ee47da_00d44193 PS2, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d94a142_56d3773c PS2, Line 67: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f02b4a81_8d37af70 PS2, Line 73: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef3bcd20_c001c58d PS2, Line 73: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1ab9715_9b3b370a PS2, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bce293ab_08bcb368 PS2, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3021a7d5_30cbc351 PS2, Line 75: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ed5d007_c1f0d1c6 PS2, Line 81: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ebdfce0_a0c9f8c5 PS2, Line 81: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/afa06b44_acfcbe05 PS2, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6d7ef54_ff2a5b75 PS2, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b982ee8_a8206daa PS2, Line 83: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99ad0c14_8eaff6b7 PS2, Line 87: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0751689_02967fad PS2, Line 87: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/65837489_e502f78b PS2, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e527369c_fe214f37 PS2, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bef5700_65c6d88e PS2, Line 89: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f4f2f1c_9f04cdd8 PS2, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7a2e9db9_40691450 PS2, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a084cf8_22586c71 PS2, Line 99: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e36864a5_bf9a860d PS2, Line 100: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b8e8b43_a53c4989 PS2, Line 111: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9dfd037b_148bb38d PS2, Line 111: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/38359cc0_9b6f5cf4 PS2, Line 116: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7edd4f2_0342b6a3 PS2, Line 116: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3bce982f_8c808462 PS2, Line 121: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26303265_6b7d41dd PS2, Line 121: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f885732_2d375112 PS2, Line 126: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8d01d9e_fd0b6db4 PS2, Line 126: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/626489da_c0b10d5a PS2, Line 131: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f51f435_62c6e067 PS2, Line 131: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f687d017_f12730e9 PS2, Line 135: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95a220c7_88e5ca8a PS2, Line 135: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad6294e0_6ca0bcdd PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/807a4bda_7ecc3b84 PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b284723d_9b7d702a PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d31d197_578aebe0 PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53a4925f_75a64bed PS2, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87dafb2b_31eeb866 PS2, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2ea72a85_e1de608a PS2, Line 144: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/178e37b0_4381b5c8 PS2, Line 144: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86d554c2_c87ccd7f PS2, Line 144: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b619e4d3_d9516d94 PS2, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/355f16db_c4d92f19 PS2, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bdb36439_6de575ea PS2, Line 145: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20b0c12e_a8dd4d78 PS2, Line 149: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1b7674ce_23faa831 PS2, Line 150: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39f48482_45487798 PS2, Line 150: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e0c2e7b_8dfb546f PS2, Line 152: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1afbd55d_2a08ba4a PS2, Line 163: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0512508_25083ab7 PS2, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95ae9c67_15be7a12 PS2, Line 176: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f225590_a319e27c PS2, Line 183: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b9c5bc56_5d91b150 PS2, Line 195: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab87e5ef_e0507192 PS2, Line 202: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6042f9b_14039555 PS2, Line 202: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/324e1d15_d2656793 PS2, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ca1683b_15d9a4a1 PS2, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68512c8d_3520e851 PS2, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d8c2da4_33d95ff3 PS2, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ab241d7_afdcabb3 PS2, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a6e13f4_af7c4a98 PS2, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79004e00_c6f9d6fe PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de4a1b43_e055b541 PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0ab1582_3892f89f PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/logging.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/865eb3a0_2ae3b1f1 PS2, Line 83: .enabled = 0, trailing whitespace File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95b56a27_964f7bdc PS2, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b994966d_a92afde8 PS2, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/465213ec_dfc467c8 PS2, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c45b81b_c860676f PS2, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2999fa2c_4e8a2332 PS2, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c580a354_2cff24aa PS2, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76a89e4a_740a5bfe PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c79096f7_b61f987b PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27d4b37e_b97de5f6 PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07ce88e6_5d4885ef PS2, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5dbd9e2_9d12e084 PS2, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9df6e966_c3f44a50 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f89128a9_539a1057 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37400f40_a8d674d8 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78bcaffc_bd47c9bd PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcc2b7d2_bd605cf7 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/936da6d0_23400de3 PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b99c338f_f485964f PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aff69de4_6e883f1f PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6228cc7e_7a0040bd PS2, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d17ae6b_4b9add35 PS2, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f58bf6b0_a16da5fc PS2, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01a68954_c70951df PS2, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d4e2fe4_7eacb915 PS2, Line 75: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e183f15_486ceef0 PS2, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7c908880_6f49fd8a PS2, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c6c1024_b253a743 PS2, Line 87: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a7a6219_818a8466 PS2, Line 89: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96e2aa27_b6985563 PS2, Line 90: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f32615b_7b029abe PS2, Line 92: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0fc09b7_b9591198 PS2, Line 92: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0e3a0f8_cea448be PS2, Line 104: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5b522b7_87dd95e9 PS2, Line 106: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d7bac078_b76c78cd PS2, Line 108: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b0e0ff2_de040450 PS2, Line 113: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b10767e_328525e6 PS2, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4e0f3d0_4f2bf30d PS2, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2cd5f698_1d379f6d PS2, Line 115: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8855f4ed_8cbc1a9a PS2, Line 119: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4dda287c_eede24d7 PS2, Line 119: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55b366db_4731de88 PS2, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f3fa857_c7204759 PS2, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3575f302_0ceb7f4a PS2, Line 121: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19fb5fc7_54b5a7dd PS2, Line 125: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8687152d_812c5c28 PS2, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbb94964_31ebb703 PS2, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/decee943_d584f6e2 PS2, Line 127: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9309d335_cb849bc6 PS2, Line 132: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8cb6ab3_5db8e5ca PS2, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba72a718_9745abf0 PS2, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97162c89_9332e1b8 PS2, Line 134: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f28b6a2a_236b789f PS2, Line 142: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d427cb21_85a48306 PS2, Line 142: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93dfe7e0_fbe7d794 PS2, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39c1f362_52438e48 PS2, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cff87fe_95f9440a PS2, Line 144: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/412d55c6_c341ae04 PS2, Line 148: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82ced194_e0c514d9 PS2, Line 148: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4d31dae_ee0c44bc PS2, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8ce3124_f3dd8a7c PS2, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8067df9c_9ed9cde3 PS2, Line 150: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b271f9c3_9b70b2a5 PS2, Line 153: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1c146e2_62fcec8d PS2, Line 153: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9419931a_da76f90b PS2, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe0c13db_a94a7c2a PS2, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71490996_77a53e2d PS2, Line 155: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fed0b9bb_b1071370 PS2, Line 158: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f66bdf06_0bdd98aa PS2, Line 158: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd45cce2_2dbd107d PS2, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a50abdf1_6538f769 PS2, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e1fbdad_c0e174f9 PS2, Line 160: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ff5f6c5_fe629dff PS2, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10bf98f8_17e81be0 PS2, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/414b11d5_73637894 PS2, Line 176: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9755754d_6ee983c3 PS2, Line 177: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aef4a099_c39f761e PS2, Line 178: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fd40f7c_f0a69952 PS2, Line 178: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a8eb9f3_5f716e79 PS2, Line 189: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/89a49d0c_2b972ac8 PS2, Line 189: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb61630d_1f2a8513 PS2, Line 189: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce6b2be8_09ca15be PS2, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3befff9_d7a44d44 PS2, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4c50341_5ae7c582 PS2, Line 190: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6f2ae87_ea9e5531 PS2, Line 197: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31139cf3_7af35fa6 PS2, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32feaa6a_19ccb291 PS2, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f8289a1_ed97aafd PS2, Line 198: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3d91393_24acc846 PS2, Line 201: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d3072fe_f11e2486 PS2, Line 207: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53054c84_6b209720 PS2, Line 208: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3eb711f4_a3666ea2 PS2, Line 209: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7441feab_a3df5f5d PS2, Line 211: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68a4e779_813e745c PS2, Line 212: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b4ccf39_d744d0b6 PS2, Line 225: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1444e982_1f4c9a00 PS2, Line 226: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e48b00b1_0864b183 PS2, Line 229: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a10ffe2c_1829813d PS2, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/074d44a2_7588e3c5 PS2, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/305bab73_b4ccbbb7 PS2, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4084a0d8_e72349a5 PS2, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/210b7aeb_896c1b97 PS2, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/316c15d2_0b712f37 PS2, Line 44: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f414477_66610c77 PS2, Line 45: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ebb43ae_7155557d PS2, Line 46: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bcd6f3d_f12fd28e PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b28085a_e533507a PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18bc8f38_68b2d62d PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ec9be35_c7cfb2e5 PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/46bb9bb1_a656a05f PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9c98d55_7e259344 PS2, Line 50: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20883957_2648112b PS2, Line 52: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/89f66281_6e2802d9 PS2, Line 53: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/452a6bf8_955ff2d1 PS2, Line 54: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f9736d9_63ed5b14 PS2, Line 56: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/561a1011_4fe3fd9a PS2, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3db20e4f_85f12762 PS2, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6e7ae78_e412c5e6 PS2, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd1437bb_79fc71a4 PS2, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da78706f_1701e0c6 PS2, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c00205cf_3287c219 PS2, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aed017f7_1fa05b5a PS2, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5e537e0_045f80c7 PS2, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae124ede_440eeb28 PS2, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5db93485_e6721615 PS2, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d20a7cc_d38ab782 PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84ce0cda_61978db2 PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b16732fc_c85145b0 PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3664e39_195c68a8 PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8cba79be_bbf76d67 PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0c09973_6aa5e9cb PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62078d28_3a1b6a28 PS2, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/242c1c9b_e9c1a5d4 PS2, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75f01dec_1fe9c42c PS2, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f043012_a17c445f PS2, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3881609_47e19272 PS2, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6ab496_9d7bcf64 PS2, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bde09a4b_2662aa77 PS2, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa19381d_274e5151 PS2, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee3156f2_93f7671b PS2, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24443202_55319b90 PS2, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a9316799_99b4a15f PS2, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f58a521a_7a8bda6d PS2, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/046d1195_f9c65e4d PS2, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7317e6fd_37c50faf PS2, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/294d445e_5493aa72 PS2, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08daf9f0_135e736a PS2, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa3da926_9d8cc89b PS2, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e350667_cbcaf3a7 PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d4030cb_ec8e415b PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e9ef2b4f_5482524a PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5cef973_45437a6b PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1163c37_6a84399b PS2, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa9dcd65_ee9fa117 PS2, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d8c4aa0_e9e6be7a PS2, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9c48af9_cf912c56 PS2, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa37e21e_69b72f03 PS2, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fdd81261_9285956e PS2, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8de6c3a0_10c428e5 PS2, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71a36148_e4045277 PS2, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68a4e6a5_5e7cb5f5 PS2, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72d9156b_47753f88 PS2, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/409406e3_4f41e69e PS2, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03560bfe_1c4a4cc5 PS2, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af64fcbf_1fbd3bda PS2, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef84a8d1_cc7d0583 PS2, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66dfbdd0_7c78e9e4 PS2, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b214a91a_09dcb8ef PS2, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc9f9cf1_817bb6f3 PS2, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07327356_0977f702 PS2, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c37ee65_74c183a2 PS2, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e309200_00d118c7 PS2, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24c2261c_cd13a929 PS2, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/730873d6_6c0e7484 PS2, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bdabc96_9aebecc6 PS2, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fed190f4_a987f005 PS2, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f756c13_048d4a3a PS2, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc252526_f5505ce7 PS2, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f986189_730186cd PS2, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34540695_3147c90b PS2, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a8ecf8a4_4f4c060a PS2, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d273c053_0a1546df PS2, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/703a0df4_e7c8b909 PS2, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01e75ac1_3e130836 PS2, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dce1bfd1_67a1843a PS2, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49aca56e_59596b2a PS2, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:24:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: ms-trx support

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 to look at the new patch set (#2). Change subject: ms-trx support ...................................................................... ms-trx support This is basically a trxcon that includes a transceiver, and can just be used with existing and future apps supporting the trxcon interface, i.e. mobile or ccch_scan. Supports bladerf and uhd, binaries are automatically built if those libs are detected + the osmocom-bb submodule exists. Currently using hardcoded sched/prios aimed at a setup with working, reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3, not 2, not any other version) Additionally builds test tools used for development: osmo-trx-syncthing* Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 --- M .gitignore M Makefile.am M Transceiver52M/Makefile.am A Transceiver52M/ms/bladerf_specific.h A Transceiver52M/ms/ipc_specific.h A Transceiver52M/ms/itrq.h A Transceiver52M/ms/l1ctl_server.c A Transceiver52M/ms/l1ctl_server_cb.cpp A Transceiver52M/ms/logging.cpp A Transceiver52M/ms/ms.cpp A Transceiver52M/ms/ms.h A Transceiver52M/ms/ms_rx_burst.h A Transceiver52M/ms/ms_rx_burst_test.cpp A Transceiver52M/ms/ms_rx_lower.cpp A Transceiver52M/ms/ms_upper.cpp A Transceiver52M/ms/ms_upper.h A Transceiver52M/ms/sch.c A Transceiver52M/ms/sch.h A Transceiver52M/ms/uhd_specific.h M configure.ac 20 files changed, 3,730 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

Change in osmo-trx[master]: rename noisevector class -> avgvector

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 ) Change subject: rename noisevector class -> avgvector ...................................................................... Patch Set 1: (3 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1508): https://gerrit.osmocom.org/c/osmo-trx/+/30411/comment/7e73e6d6_d5484956 PS1, Line 83: avgVector mNoises; please, no spaces at the start of a line File Transceiver52M/radioVector.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1508): https://gerrit.osmocom.org/c/osmo-trx/+/30411/comment/c30a0037_6bf461da PS1, Line 51: class avgVector : std::vector<float> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1508): https://gerrit.osmocom.org/c/osmo-trx/+/30411/comment/7a4ed35c_041745c6 PS1, Line 51: class avgVector : std::vector<float> { spaces required around that '>' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Dec 2022 11:02:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: bladerf xa4 support

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 1: (57 comments) File Transceiver52M/device/bladerf/bladerf.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bca2278b_a36b586f PS1, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/24d40c12_9293db06 PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bfceb675_607f2e6e PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ab43e3fd_62ef6efe PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/83db1139_040c1275 PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0850ff55_ac646b5a PS1, Line 61: int open(const std::string &args, int ref, bool swap_channels); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/6a0e8967_7008fa3f PS1, Line 62: bool start(); Bad function definition - bool start() should probably be bool start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5feb8566_d801bd6c PS1, Line 63: bool stop(); Bad function definition - bool stop() should probably be bool stop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/26820d48_de022792 PS1, Line 64: bool restart(); Bad function definition - bool restart() should probably be bool restart(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ca3a2797_3a18b370 PS1, Line 65: enum TxWindowType getWindowType() Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/91a6d585_d69e0639 PS1, Line 65: enum TxWindowType getWindowType() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/fb491306_992d04bf PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bfed8f8d_aedb231d PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c854d89e_fa959d4f PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d3b66a52_6ee30203 PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/46b8a722_a5100a97 PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7aeeb97b_29f6809e PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3b5ffdb2_5ecf8684 PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); function definition argument 'short *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/59b0a455_0cf2b4e0 PS1, Line 79: TIMESTAMP initialWriteTimestamp(); Bad function definition - TIMESTAMP initialWriteTimestamp() should probably be TIMESTAMP initialWriteTimestamp(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5d806beb_f7fec483 PS1, Line 80: TIMESTAMP initialReadTimestamp(); Bad function definition - TIMESTAMP initialReadTimestamp() should probably be TIMESTAMP initialReadTimestamp(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/03eab3ca_15ffc725 PS1, Line 82: double fullScaleInputValue(); Bad function definition - double fullScaleInputValue() should probably be double fullScaleInputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bc1b1539_9230b2a9 PS1, Line 83: double fullScaleOutputValue(); Bad function definition - double fullScaleOutputValue() should probably be double fullScaleOutputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/23dd8e5b_2c975ba2 PS1, Line 87: double maxRxGain(void) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/416e026b_3aa5766c PS1, Line 91: double minRxGain(void) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0af1117f_3fe8ab1d PS1, Line 104: double getRxFreq(); Bad function definition - double getRxFreq() should probably be double getRxFreq(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/84e8dfaf_4792f18b PS1, Line 106: bool setRxAntenna(const std::string &ant, size_t chan) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/34afb39e_0c0ccac0 PS1, Line 106: bool setRxAntenna(const std::string &ant, size_t chan) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/76a028d7_19cb6b50 PS1, Line 110: std::string getRxAntenna(size_t chan) labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/50c48b94_4eecb2e4 PS1, Line 114: bool setTxAntenna(const std::string &ant, size_t chan) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/67f2d6d4_daedd21f PS1, Line 114: bool setTxAntenna(const std::string &ant, size_t chan) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8d3da6cb_241defd3 PS1, Line 118: std::string getTxAntenna(size_t chan) labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3e1da1d6_67153f2a PS1, Line 123: bool requiresRadioAlign(); Bad function definition - bool requiresRadioAlign() should probably be bool requiresRadioAlign(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d7f5a78a_e43f0222 PS1, Line 125: GSM::Time minLatency(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a1384af4_9b1fe7a5 PS1, Line 127: inline double getSampleRate() Bad function definition - double getSampleRate() should probably be double getSampleRate(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5f51b6ca_3cc50e9c PS1, Line 135: bool recv_async_msg(); Bad function definition - bool recv_async_msg() should probably be bool recv_async_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/36c70268_5df31bc1 PS1, Line 144: protected: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d44686cf_bcbdf7df PS1, Line 155: std::vector<double> tx_gains, rx_gains; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/24e11f17_453353e7 PS1, Line 155: std::vector<double> tx_gains, rx_gains; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e9e8c6e1_81ef3142 PS1, Line 155: std::vector<double> tx_gains, rx_gains; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/50040567_f9317f72 PS1, Line 156: std::vector<double> tx_freqs, rx_freqs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1ec98268_c7e3122c PS1, Line 156: std::vector<double> tx_freqs, rx_freqs; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3799ee8b_e7c9f999 PS1, Line 156: std::vector<double> tx_freqs, rx_freqs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/49329394_fd0f1b38 PS1, Line 169: std::vector<smpl_buf *> rx_buffers; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c6943008_44cee1cc PS1, Line 169: std::vector<smpl_buf *> rx_buffers; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0083b7c9_ea8af053 PS1, Line 169: std::vector<smpl_buf *> rx_buffers; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/768422f1_6b1dc3aa PS1, Line 169: std::vector<smpl_buf *> rx_buffers; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/010b711e_bc7d4e65 PS1, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/95926dc9_78d8e7c0 PS1, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/32fe518d_9ea59c7e PS1, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/eec062fd_0c681c84 PS1, Line 171: std::vector<std::vector<short> > pkt_bufs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/53dff1f5_45272f96 PS1, Line 174: std::vector<short *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1b442535_1dc1ae89 PS1, Line 174: std::vector<short *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0b49c0f6_c9feffd2 PS1, Line 174: std::vector<short *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e59cfb6a_1dd7943b PS1, Line 174: std::vector<short *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1d0122a9_76d03002 PS1, Line 176: void init_gains(); Bad function definition - void init_gains() should probably be void init_gains(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/4e8aa58f_7bf4946c PS1, Line 178: void set_rates(); Bad function definition - void set_rates() should probably be void set_rates(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/97453589_e3e61b48 PS1, Line 182: void get_dev_band_desc(dev_band_desc &desc); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: vita demod by piotr krysik, modified

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 ) Change subject: vita demod by piotr krysik, modified ...................................................................... Patch Set 1: (946 comments) File Transceiver52M/grgsm_vitac/constants.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c765206_28929c41 PS1, Line 1: #pragma once DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/250b56b8_6998c832 PS1, Line 2: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a8e58380_ab353244 PS1, Line 3: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bbd76eb_8ad83e0e PS1, Line 4: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bcc44498_f146212a PS1, Line 5: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78ac416e_b0e69b54 PS1, Line 6: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36453a23_27b1c099 PS1, Line 7: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d9ac085_c9939edc PS1, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a929f71_797eb401 PS1, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2e2a0ac_976a95f9 PS1, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71230916_cdd72af8 PS1, Line 11: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d3cdce5_206bc841 PS1, Line 12: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef22c058_bda85972 PS1, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a7ae5d1_2d48edc1 PS1, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bd26d71_1746d0dd PS1, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b3a6c98_278b329b PS1, Line 16: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15630a2a_e5dacf42 PS1, Line 17: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be3dde20_c73f9125 PS1, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/791803ae_72348dce PS1, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1790ffec_94b444b6 PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4aff52df_96acdf98 PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/413b8940_3a2c7659 PS1, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c67528de_2e056cb4 PS1, Line 22: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27beaac5_0bf5c52b PS1, Line 23: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c7e0363_0c9e4acf PS1, Line 24: #include <complex> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5e5efaa_b581901b PS1, Line 25: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aea7ce8f_2b5e49bb PS1, Line 26: #define gr_complex std::complex<float> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08a2c2b3_eedce1d9 PS1, Line 26: #define gr_complex std::complex<float> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b32d756a_83a54211 PS1, Line 26: #define gr_complex std::complex<float> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2616a319_1ac735dc PS1, Line 27: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5893403a_ef75b046 PS1, Line 28: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/613391fc_8f2c5929 PS1, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53ca57ff_81e53370 PS1, Line 30: #define GSM_SYMBOL_PERIOD (1.0/GSM_SYMBOL_RATE) //seconds per symbol trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/622e8ead_86fa8e27 PS1, Line 31: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4841e8f_36182df7 PS1, Line 32: //Burst timing trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fe198116_b43a2b45 PS1, Line 33: #define TAIL_BITS 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/513fd8d2_d275fbc7 PS1, Line 34: #define GUARD_BITS 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37514408_b13c3517 PS1, Line 35: #define GUARD_FRACTIONAL 0.25 //fractional part of guard period trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36902134_ad2549c3 PS1, Line 36: #define GUARD_PERIOD GUARD_BITS + GUARD_FRACTIONAL DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01724171_7f26917a PS1, Line 37: #define DATA_BITS 57 //size of 1 data block in normal burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a202eb5_eb062a70 PS1, Line 38: #define STEALING_BIT 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/966fb927_0c7bfe40 PS1, Line 39: #define N_TRAIN_BITS 26 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d434c6a1_256c57e9 PS1, Line 40: #define N_SYNC_BITS 64 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c621408_220202fa PS1, Line 41: #define USEFUL_BITS 142 //(2*(DATA_BITS+STEALING_BIT) + N_TRAIN_BITS ) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/39f1fc5c_53b5a75a PS1, Line 42: #define FCCH_BITS USEFUL_BITS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/710bc0e9_462ffc89 PS1, Line 43: #define BURST_SIZE (USEFUL_BITS+2*TAIL_BITS) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9e48e15_edc84899 PS1, Line 44: #define ACCESS_BURST_SIZE 88 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/972dc4d3_78689808 PS1, Line 45: #define PROCESSED_CHUNK BURST_SIZE+2*GUARD_PERIOD DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1342ecf_08493315 PS1, Line 46: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0f52a5d_3ed2b69a PS1, Line 47: #define SCH_DATA_LEN 39 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d198e39_d21d1e7f PS1, Line 48: #define TS_BITS (TAIL_BITS+USEFUL_BITS+TAIL_BITS+GUARD_BITS) //a full TS (156 bits) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf394a14_3f04d6e5 PS1, Line 49: #define TS_PER_FRAME 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e49b753f_509985c4 PS1, Line 50: #define FRAME_BITS (TS_PER_FRAME * TS_BITS + 2) // 156.25 * 8 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7a179d2_05a6d9b4 PS1, Line 51: #define FCCH_POS TAIL_BITS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42440848_b119a77b PS1, Line 52: #define SYNC_POS (TAIL_BITS + 39) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/149a24f4_08598026 PS1, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d54b5ad0_93c25c9f PS1, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e77131a5_6dd73eab PS1, Line 54: //aren't used for channel impulse response estimation trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/297aa079_125f5791 PS1, Line 55: #define TRAIN_BEGINNING 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7d1aa34_b7649147 PS1, Line 56: #define SAFETY_MARGIN 6 // trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19e26741_af0c1f07 PS1, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/443339b1_baadc3c1 PS1, Line 58: #define FCCH_HITS_NEEDED (USEFUL_BITS - 4) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77f3383e_980a48c8 PS1, Line 59: #define FCCH_MAX_MISSES 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c541c4a_c7951267 PS1, Line 60: #define FCCH_MAX_FREQ_OFFSET 100 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/593bfe4f_e742f9c4 PS1, Line 61: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1351f17_892e7d56 PS1, Line 62: #define CHAN_IMP_RESP_LENGTH 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f503c4d_b224b4e8 PS1, Line 63: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2c0f49a_bf2ecba6 PS1, Line 64: #define MAX_SCH_ERRORS 10 //maximum number of subsequent sch errors after which gsm receiver goes to find_next_fcch state trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/817b6e83_c4e037fc PS1, Line 65: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5fdf0e9_36c3addd PS1, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1adffe2f_98eff1ea PS1, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e2af1517_5469e19e PS1, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a41306db_2e9bf8ed PS1, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b425568_1ba2b4f0 PS1, Line 68: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3500c1f1_d4ecce6f PS1, Line 69: static const unsigned char SYNC_BITS[] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c25a2e5_337ddd6a PS1, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dee1b668_5340f777 PS1, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cab3188_11cc06a6 PS1, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8283ff5_48aff324 PS1, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ced30781_8d92f890 PS1, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0eb09f22_baa279ce PS1, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02bb6a45_71633152 PS1, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/771e3d1e_2762251b PS1, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca223170_91aec175 PS1, Line 74: }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0150c868_73d5beda PS1, Line 75: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1ae47b8_51ab1197 PS1, Line 76: const unsigned FCCH_FRAMES[] = { 0, 10, 20, 30, 40 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/090335e9_013732c1 PS1, Line 77: const unsigned SCH_FRAMES[] = { 1, 11, 21, 31, 41 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6993f3cd_b01ad354 PS1, Line 78: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83c4d3d5_03ce16b0 PS1, Line 79: const unsigned BCCH_FRAMES[] = { 2, 3, 4, 5 }; //!!the receiver shouldn't care about logical trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21c7d31a_7948b2da PS1, Line 80: //!!channels so this will be removed from this header trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66ef0223_41d99c89 PS1, Line 81: const unsigned TEST_CCH_FRAMES[] = { 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39, 42, 43, 44, 45, 46, 47, 48, 49 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e7a30ef_cdb49fbc PS1, Line 82: const unsigned TRAFFIC_CHANNEL_F[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f476616d_dcf283ad PS1, Line 83: const unsigned TEST51[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4469eab_6e584bcd PS1, Line 84: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b12a5518_51e8d668 PS1, Line 85: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e81046c8_89bffc11 PS1, Line 86: #define TSC0 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/083aa607_729b5177 PS1, Line 87: #define TSC1 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9ceb949_e257dad6 PS1, Line 88: #define TSC2 2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/521d7950_c975d27c PS1, Line 89: #define TSC3 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46937a45_143bdc5c PS1, Line 90: #define TSC4 4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0dd1923_772c8d96 PS1, Line 91: #define TSC5 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f59c29de_b50fe42e PS1, Line 92: #define TSC6 6 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68b09481_51c3b64e PS1, Line 93: #define TSC7 7 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43ac62d7_2be838ac PS1, Line 94: #define TS_DUMMY 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e196663b_60289e82 PS1, Line 95: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cda597e_a50f60d3 PS1, Line 96: #define TRAIN_SEQ_NUM 9 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d99f6502_fdbaa4f2 PS1, Line 97: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d7947c0_4b684dd8 PS1, Line 98: #define TIMESLOT0 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/588adf83_f28bddea PS1, Line 99: #define TIMESLOT1 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3be8da3a_f8357069 PS1, Line 100: #define TIMESLOT2 2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1aa3427d_3ee7e06b PS1, Line 101: #define TIMESLOT3 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db6acf66_61d96d63 PS1, Line 102: #define TIMESLOT4 4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92699d73_95bf00f9 PS1, Line 103: #define TIMESLOT5 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f4228d4_574db7e7 PS1, Line 104: #define TIMESLOT6 6 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/562ea229_0de9b05a PS1, Line 105: #define TIMESLOT7 7 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2799eb4e_ccecfb9e PS1, Line 106: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/279fc43c_b217a68a PS1, Line 107: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/373d978e_cf16342f PS1, Line 108: static const unsigned char train_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/179c0224_dae2cb90 PS1, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd39411b_467c2dac PS1, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a8d17d3_5504f188 PS1, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a1c1d54_6f572df9 PS1, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f081c838_f080f1f7 PS1, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66a3655f_d2f8a928 PS1, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6957beb8_637a09ca PS1, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74216fc5_c296bef4 PS1, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8410d7f6_4379b418 PS1, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3461c2e6_4336502a PS1, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eaba18d5_d00d217c PS1, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68a4128b_8716da72 PS1, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/daabad89_8d5a8be4 PS1, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95cb21e9_5bfd9945 PS1, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c91e97e_6229b943 PS1, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c280b845_2f3cdb14 PS1, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56a56934_0f85b845 PS1, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a10f61f8_0c4e83d5 PS1, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a15bf9e5_5df1d822 PS1, Line 118: }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/179674a4_256d7ce1 PS1, Line 119: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/821983bf_58529e35 PS1, Line 120: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a957b17a_86f7cd7b PS1, Line 121: //Dummy burst 0xFB 76 0A 4E 09 10 1F 1C 5C 5C 57 4A 33 39 E9 F1 2F A8 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c004521_284e3c28 PS1, Line 122: static const unsigned char dummy_burst[] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/470d6721_73c9d20f PS1, Line 123: 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94624cc5_3934d621 PS1, Line 123: 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a02a0559_d6ffe612 PS1, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9cf91cda_2d7181a7 PS1, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1ab605f_692b4270 PS1, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23539071_453c1bbe PS1, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d64fab7_b464cdff PS1, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/563e3a72_1456ee59 PS1, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11e4ae72_16872808 PS1, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa7012bb_e34b1aa4 PS1, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4077095b_3e0ce536 PS1, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48f13672_6aa387fe PS1, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6db899d0_becd5dda PS1, Line 129: 0, 1, 1, 1, 1, 1, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b936c234_10121971 PS1, Line 129: 0, 1, 1, 1, 1, 1, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/593d5ee3_fbdd8b90 PS1, Line 130: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab770e95_7e0ca95c PS1, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb6715ff_1acc5ae6 PS1, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/faf50c0c_38637a19 PS1, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e7e3dc74_31aef2a3 PS1, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1968a1d_e1c79484 PS1, Line 133: 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/861c3c02_a5a96e0a PS1, Line 133: 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8206cd08_d7c1075f PS1, Line 134: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6f3664c_1471e5c9 PS1, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/470305f0_c02f5109 PS1, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa56e667_dcb3a76e PS1, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/551b49aa_96c22632 PS1, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/031d5186_7cb28672 PS1, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09fec686_68bcd2d2 PS1, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/958e19a8_66e2385e PS1, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9a2e76d5_7bfcdd46 PS1, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9381a29_41e9007c PS1, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b93e5a41_405c534d PS1, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db9b8795_30c5875e PS1, Line 140: 1, 1, 1, 0, 1, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b6a124e_661b5c95 PS1, Line 140: 1, 1, 1, 0, 1, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad09e3cf_93d98360 PS1, Line 141: 0, 0, 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c92c6e6_734a572b PS1, Line 141: 0, 0, 0 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b990414_589c4398 PS1, Line 142: }; DOS line endings File Transceiver52M/grgsm_vitac/grgsm_vitac.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1148acb5_bad53f0a PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5bf11ce9_cfb2920c PS1, Line 38: void initvita(); Bad function definition - void initvita() should probably be void initvita(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27dba7f0_3ad9739c PS1, Line 59: std::string fpath; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4722701c_7ef552b2 PS1, Line 60: std::vector<gr_complex> data; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3298974a_413c4e4a PS1, Line 60: std::vector<gr_complex> data; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f44a7eae_d69145aa PS1, Line 60: std::vector<gr_complex> data; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/00fd018a_5e3ab623 PS1, Line 62: }; adding a line without newline at end of file File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9e404a4_220bb2c1 PS1, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/31021824_ef89c294 PS1, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8fb9091_3152b7f1 PS1, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb15089d_55a0baa6 PS1, Line 4: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/742eba2b_b1fe2445 PS1, Line 5: * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild <ewild(a)sysmocom.de> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1553997_e73af833 PS1, Line 6: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/598a472e_9abb75d3 PS1, Line 7: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c04ead3e_4b26b5e0 PS1, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5b38038_7d0b021e PS1, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e1ca4c0_081865ce PS1, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65395f49_3b599d0e PS1, Line 11: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06a0756c_4008e2ce PS1, Line 12: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b520ced_30692def PS1, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9939643_48e4894c PS1, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29735ff0_91f0ff1d PS1, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98f37b70_a5978e62 PS1, Line 16: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab7fab40_d1f63522 PS1, Line 17: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa10b383_bb8050cd PS1, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f100b2a_9d7cb489 PS1, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d4f628f_9800947c PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4086fa39_44067ad6 PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/724bf63c_a36a1dae PS1, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2c12303_6a313ce1 PS1, Line 22: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69640a0c_dee8ac8c PS1, Line 23: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a9765dd_49a02b6e PS1, Line 24: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/555c976d_484982fe PS1, Line 25: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cef5791f_19012566 PS1, Line 26: #ifdef HAVE_CONFIG_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b86cc147_edc03925 PS1, Line 27: #include "config.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8d683f0_91f70a24 PS1, Line 28: #endif DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7be12d56_ef28de9f PS1, Line 29: #include <complex> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce6be2fa_0da118c6 PS1, Line 30: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2427629_74ac9f6a PS1, Line 31: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0632632e_db4ef010 PS1, Line 32: #include <algorithm> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2f7cd34_a8d2ef20 PS1, Line 33: #include <string.h> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c87136c_af5af13f PS1, Line 34: #include <iostream> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcbfabfe_f4f6c693 PS1, Line 35: #include <numeric> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17ccb919_e5857cff PS1, Line 36: #include <vector> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7294e941_a29053e1 PS1, Line 37: #include <fstream> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db12aa74_ce18fc9e PS1, Line 38: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7230647_17f6b557 PS1, Line 39: #include "viterbi_detector.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f65719e_97393535 PS1, Line 40: #include "grgsm_vitac.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb4aa1fe_a91464ad PS1, Line 41: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/116e9b2d_686de85e PS1, Line 42: //signalVector mChanResp; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c9be3ce_13b94574 PS1, Line 43: gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5cf5952_7486067c PS1, Line 44: gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1c3fa6d_58b3dbb7 PS1, Line 45: const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08e6f578_5eadd93d PS1, Line 46: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff08f065_44c0ba89 PS1, Line 47: void initvita() { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d57ebb10_74f49821 PS1, Line 48: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a1866fc_76ca241a PS1, Line 49: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85cc1489_91d4a1b0 PS1, Line 50: * Prepare SCH sequence bits trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a6d037a_264d92cd PS1, Line 51: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4a3c722_5e8c206e PS1, Line 52: * (TS_BITS + 2 * GUARD_PERIOD) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0317ceb_a9942226 PS1, Line 53: * Burst and two guard periods trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3dbf4760_6957fe1b PS1, Line 54: * (one guard period is an arbitrary overlap) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ecfadf6_5e22ace9 PS1, Line 55: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d043030_8288781d PS1, Line 56: gmsk_mapper(SYNC_BITS, N_SYNC_BITS, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0ac8e5c_4619f9db PS1, Line 57: d_sch_training_seq, gr_complex(0.0, -1.0)); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5e72d24_236b7e9f PS1, Line 58: for (auto &i : d_sch_training_seq) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77242751_c2337426 PS1, Line 59: i = conj(i); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b94286fe_3b6eb654 PS1, Line 60: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67370989_2f770a54 PS1, Line 61: /* Prepare bits of training sequences */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d7267a3_7461436b PS1, Line 62: for (int i = 0; i < TRAIN_SEQ_NUM; i++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d446e2a8_b539ddf2 PS1, Line 63: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eaf63a51_7831cd59 PS1, Line 64: * If first bit of the sequence is 0 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43594d44_2710bc0e PS1, Line 65: * => first symbol is 1, else -1 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f0c4151_5a483d35 PS1, Line 66: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b6478a8_1ed88113 PS1, Line 67: gr_complex startpoint = train_seq[i][0] == 0 ? DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85025519_e3644c4d PS1, Line 68: gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb4b8205_a6fe3c21 PS1, Line 69: gmsk_mapper(train_seq[i], N_TRAIN_BITS, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c74dfc36_91856a08 PS1, Line 70: d_norm_training_seq[i], startpoint); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b5e37e8c_1e1e280f PS1, Line 71: for (auto &i : d_norm_training_seq[i]) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b668bab_3c412cb8 PS1, Line 72: i = conj(i); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61a4e590_b229abb5 PS1, Line 73: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/161f5af4_d13026f2 PS1, Line 74: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2fd93b40_ef3548bc PS1, Line 75: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c35b931a_332ed84d PS1, Line 76: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83fbad3b_e6a71bcb PS1, Line 77: MULTI_VER_TARGET_ATTR DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b560c2b0_ceaea2d7 PS1, Line 78: void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b885f7bf_5ea964c3 PS1, Line 79: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f528346_ef12fab2 PS1, Line 80: std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77c30bbb_f4b32395 PS1, Line 81: unsigned int stop_states[2] = { 4, 12 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d2ab2cd_017dc840 PS1, Line 82: gr_complex filtered_burst[BURST_SIZE]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/047cc16e_f0c75c48 PS1, Line 83: gr_complex rhh[CHAN_IMP_RESP_LENGTH]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7e5db3f_23f6d63b PS1, Line 84: float output[BURST_SIZE]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74425755_56be3fa6 PS1, Line 85: int start_state = 3; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c64be620_d3e157c8 PS1, Line 86: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e46bcfe3_f4d3731d PS1, Line 87: // if(burst_start < 0 ||burst_start > 10) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fe6e5f6_a555936f PS1, Line 88: // fprintf(stderr, "bo %d\n", burst_start); trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5ac5f68_54cdced1 PS1, Line 89: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2d6f57e_285ef5de PS1, Line 90: // burst_start = burst_start >= 0 ? burst_start : 0; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8abf6f6_603504a9 PS1, Line 91: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c18ace1_9c740b73 PS1, Line 92: autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2280a4fe_47d8c400 PS1, Line 93: for (int ii = 0; ii < d_chan_imp_length; ii++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0eefc283_b591397d PS1, Line 94: rhh[ii] = conj(rhh_temp[ii * d_OSR]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/206cc349_1913931c PS1, Line 95: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f23305f_f027fbbc PS1, Line 96: mafi(&input[burst_start], BURST_SIZE, chan_imp_resp, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75225d72_f21cc922 PS1, Line 97: d_chan_imp_length * d_OSR, filtered_burst); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a236678f_3d3afac0 PS1, Line 98: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1703ddae_94cf8609 PS1, Line 99: viterbi_detector(filtered_burst, BURST_SIZE, rhh, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2e7e788_80b21358 PS1, Line 100: start_state, stop_states, 2, output); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da936f22_d3252f40 PS1, Line 101: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/806e6462_18785811 PS1, Line 102: for (int i = 0; i < BURST_SIZE; i++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1eae63d_eecb3f3b PS1, Line 103: output_binary[i] = output[i] * -127; // pre flip bits! trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e5e4c05_abc2aed4 PS1, Line 104: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/858a7d53_0a148cb6 PS1, Line 105: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56221b57_336f2aa6 PS1, Line 106: void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/230d302c_caaff3c6 PS1, Line 107: gmsk_mapper(const unsigned char* input, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1624464_d2c79968 PS1, Line 108: int nitems, gr_complex* gmsk_output, gr_complex start_point) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10593ae2_0ea0cbce PS1, Line 109: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c175bc8_eb179b68 PS1, Line 110: gr_complex j = gr_complex(0.0, 1.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3001784c_1fe391ca PS1, Line 111: gmsk_output[0] = start_point; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03b12e64_10f7b7ab PS1, Line 112: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8fbd021_d99f8f96 PS1, Line 113: int previous_symbol = 2 * input[0] - 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e630620_21fc05a1 PS1, Line 114: int current_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/088c1c84_460d88d4 PS1, Line 115: int encoded_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3788ef4_d9ac705d PS1, Line 116: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fdac0868_f61c303a PS1, Line 117: for (int i = 1; i < nitems; i++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb639e2b_f457ebff PS1, Line 118: /* Change bits representation to NRZ */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e445d07_2d9b59bf PS1, Line 119: current_symbol = 2 * input[i] - 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38173571_faf0f362 PS1, Line 120: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8eb98aa_18b253ff PS1, Line 121: /* Differentially encode */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c8dc633_82d391d0 PS1, Line 122: encoded_symbol = current_symbol * previous_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/544ffc81_4d3d0a37 PS1, Line 123: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60563ef2_c7e3a579 PS1, Line 124: /* And do GMSK mapping */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09a70bef_ad9d739b PS1, Line 125: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/841317b3_88a7f4dd PS1, Line 126: * gmsk_output[i - 1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4912945a_c0641d41 PS1, Line 127: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e18ef5e9_e28ba415 PS1, Line 128: previous_symbol = current_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63c5b308_8827a4f0 PS1, Line 129: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/455a8b76_21553993 PS1, Line 130: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5fa0e55_dde0a027 PS1, Line 131: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47d2e6e6_8d1dba84 PS1, Line 132: gr_complex DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a41b98b6_67428d81 PS1, Line 133: correlate_sequence(const gr_complex* sequence, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ebefeb3_2fbb0c9f PS1, Line 134: int length, const gr_complex* input) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ffd4523_01c81f30 PS1, Line 135: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6689cbdd_6880a03b PS1, Line 136: gr_complex result(0.0, 0.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29af4bd3_8fc42b25 PS1, Line 137: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7acb0cb7_9c8a8e49 PS1, Line 138: for (int ii = 0; ii < length; ii++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e225057d_47470d62 PS1, Line 139: result += sequence[ii] * input[ii * d_OSR]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ba97877_be69a929 PS1, Line 140: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3aa04e6_b2191241 PS1, Line 141: return conj(result) / gr_complex(length, 0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89379e99_b42231a2 PS1, Line 142: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46c4f687_136e9f7c PS1, Line 143: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7d48bccc_4eb35635 PS1, Line 144: /* Computes autocorrelation for positive arguments */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9d1cd84_351f0596 PS1, Line 145: inline void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e606c7db_770dcb1c PS1, Line 146: autocorrelation(const gr_complex* input, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76016e6c_59b60b5d PS1, Line 147: gr_complex* out, int nitems) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44505148_7be409d9 PS1, Line 148: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8eb1c353_bba187a0 PS1, Line 149: for (int k = nitems - 1; k >= 0; k--) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d5efdaa_c0d1794c PS1, Line 150: out[k] = gr_complex(0, 0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45d751bd_bdf024ff PS1, Line 151: for (int i = k; i < nitems; i++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a75e118a_b1bd2901 PS1, Line 152: out[k] += input[i] * conj(input[i - k]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b706f05_d969edec PS1, Line 153: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93ed32a4_12a02f36 PS1, Line 154: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72ac2348_84916138 PS1, Line 155: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d640c407_941c6dbd PS1, Line 156: inline void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa36a971_0ba48c41 PS1, Line 157: mafi(const gr_complex* input, int nitems, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18f1e14f_25850106 PS1, Line 158: gr_complex* filter, int filter_length, gr_complex* output) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/702e537f_fb40650b PS1, Line 159: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/337aa758_f5242c08 PS1, Line 160: for (int n = 0; n < nitems; n++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99d8f70b_b52021e4 PS1, Line 161: int a = n * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0177bb38_d6a457fa PS1, Line 162: output[n] = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0985947b_872cc124 PS1, Line 163: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e937bc8_a0287c33 PS1, Line 164: for (int ii = 0; ii < filter_length; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dabbae92_c318299d PS1, Line 165: if ((a + ii) >= nitems * d_OSR) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0bd67994_b90fa247 PS1, Line 166: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32381b37_f44fefbc PS1, Line 167: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4025de39_c35809c7 PS1, Line 168: output[n] += input[a + ii] * filter[ii]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f55cec5_8f2c3c40 PS1, Line 169: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7fbacb57_9b2de919 PS1, Line 170: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4db40936_19dc18b3 PS1, Line 171: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f59f5f63_b2bc6fd3 PS1, Line 172: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac3e1c49_d66b7e2f PS1, Line 173: int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99d9e938_891f8f6c PS1, Line 174: int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dda903c_9f49d9f6 PS1, Line 175: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7e8de0c_262f7515 PS1, Line 176: std::vector<gr_complex> correlation_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70638c2c_b95c2963 PS1, Line 177: std::vector<float> window_energy_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4423495c_61fd40b8 PS1, Line 178: std::vector<float> power_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c82f55c_b3303916 PS1, Line 179: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/546a31f1_5c55531b PS1, Line 180: for (int ii = search_start_pos; ii < search_stop_pos; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ca953a3_e3b0b8c1 PS1, Line 181: gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88d3832f_134abc71 PS1, Line 182: correlation_buffer.push_back(correlation); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/817e81fa_ae558516 PS1, Line 183: power_buffer.push_back(std::pow(abs(correlation), 2)); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c261914_0ddb5ba6 PS1, Line 184: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98b458a3_03105150 PS1, Line 185: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f29f47e5_e77da77b PS1, Line 186: int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d51211f_f7d56857 PS1, Line 187: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c69b16e_9c026675 PS1, Line 188: /* Compute window energies */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67529bc2_2b121102 PS1, Line 189: auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4de45a69_dc805e2d PS1, Line 190: window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range.. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99965d58_f97f01ff PS1, Line 191: auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29e3f492_652d32e9 PS1, Line 192: auto iter = power_buffer.begin() + window_energy_start_offset; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62bc3791_c85ccdaa PS1, Line 193: auto iter_end = power_buffer.begin() + window_energy_end_offset; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4919dfaf_9c6e7ab4 PS1, Line 194: while (iter != iter_end) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/835cf9e8_60d49b7a PS1, Line 195: std::vector<float>::iterator iter_ii = iter; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d54fdea2_d0785171 PS1, Line 196: bool loop_end = false; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b0bf954_11423535 PS1, Line 197: float energy = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3343352e_a2a43d0b PS1, Line 198: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b62bbe2f_170195fe PS1, Line 199: int len = d_chan_imp_length * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9da97551_76cdc61d PS1, Line 200: for (int ii = 0; ii < len; ii++, iter_ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eda4f08a_fb43c649 PS1, Line 201: if (iter_ii == power_buffer.end()) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b5231a4_fd7f6baf PS1, Line 202: loop_end = true; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46a44baf_9df5e5db PS1, Line 203: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d060ada_2ae99286 PS1, Line 204: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08f73589_f8774aac PS1, Line 205: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfdd4c4a_1f001342 PS1, Line 206: energy += (*iter_ii); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6247c1f3_d959d8c5 PS1, Line 207: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5bccaa7_6ed98836 PS1, Line 208: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2c1a409_6ee259e7 PS1, Line 209: if (loop_end) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7328f2c6_239543ff PS1, Line 210: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c440e268_d9c813e2 PS1, Line 211: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f85e5830_a6564754 PS1, Line 212: window_energy_buffer.push_back(energy); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/368aea5f_a341565d PS1, Line 213: iter++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9805e073_6b485d55 PS1, Line 214: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9fcbd990_5e3262b1 PS1, Line 215: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/868bcf36_3c21b009 PS1, Line 216: /* Calculate the strongest window number */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3bb7195a_e24178ae PS1, Line 217: int strongest_window_nr = window_energy_start_offset + DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35b9d108_50a190ba PS1, Line 218: max_element(window_energy_buffer.begin(), window_energy_buffer.end()) - DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/784941e8_aaca1f5e PS1, Line 219: window_energy_buffer.begin(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4110531d_48d1044c PS1, Line 220: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c354686_9ff40f86 PS1, Line 221: // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26cc24c7_a4fb91e8 PS1, Line 222: // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/399cd6f4_523cadf2 PS1, Line 223: // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60ac2630_fc4a8375 PS1, Line 224: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4557be85_251577da PS1, Line 225: // /* Calculate the strongest window number */ trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/292f598d_8ff6c06f PS1, Line 226: // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin(); trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4873eb7_de85b17f PS1, Line 227: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66625436_7d45a9c7 PS1, Line 228: // if (strongest_window_nr < 0) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfba0679_27fb2f11 PS1, Line 229: // strongest_window_nr = 0; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfa755f6_f281bd88 PS1, Line 230: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ba2f678_79a3c6b6 PS1, Line 231: float max_correlation = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4556d6c0_04dc8551 PS1, Line 232: for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a071c768_fbc67baa PS1, Line 233: gr_complex correlation = correlation_buffer[strongest_window_nr + ii]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e53164d9_8a80bdf2 PS1, Line 234: if (abs(correlation) > max_correlation) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e97ac0d7_bb6736ca PS1, Line 235: max_correlation = abs(correlation); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b140faf7_381a5f23 PS1, Line 236: chan_imp_resp[ii] = correlation; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/257c9d99_7f5b4de8 PS1, Line 237: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/248ea18a_cd10f604 PS1, Line 238: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2a94f80_a8ebd754 PS1, Line 239: *corr_max = max_correlation; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/028916d1_8bc52a61 PS1, Line 240: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a97f47c_4adf996a PS1, Line 241: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/864ce688_448dedce PS1, Line 242: * Compute first sample position, which corresponds trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4239c1d3_086ea676 PS1, Line 243: * to the first sample of the impulse response trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/357ffb1b_0a8febbe PS1, Line 244: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8d04f7d_e9088a03 PS1, Line 245: return search_start_pos + strongest_window_nr - search_center * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2b9e93f_8da93440 PS1, Line 246: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/00e8be9d_56ca1f41 PS1, Line 247: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82e5109c_20d38b22 PS1, Line 248: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/572bded8_ef921073 PS1, Line 249: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/921e1ca5_1758b401 PS1, Line 250: 3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fed511d5_039abdb8 PS1, Line 251: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4b9e73a_92a1085f PS1, Line 252: search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58f6453d_6247c090 PS1, Line 253: this is +-5 samples around (+5 beginning) of truncated t16 tsc trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ef37545_3bc2dcac PS1, Line 254: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/967dbd41_021231cc PS1, Line 255: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a79237a8_d5991adc PS1, Line 256: int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0d33a1d_e7dc206a PS1, Line 257: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89beaaa8_30832a0c PS1, Line 258: const int search_center = TRAIN_POS; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa37f4cf_0faeb7a8 PS1, Line 259: const int search_start_pos = (search_center - 5) * d_OSR + 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbe4e830_d6c3f2de PS1, Line 260: const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c1e5cdb_70ea18e9 PS1, Line 261: const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/690cf127_f7967ab8 PS1, Line 262: const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8eb14204_8b43fd34 PS1, Line 263: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/129e3ed0_a2052e38 PS1, Line 264: corr_max); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/859cb1ab_86f60fcb PS1, Line 265: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfdae906_e582462d PS1, Line 266: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9ab6340_6fc46593 PS1, Line 267: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed76cca5_65768fdd PS1, Line 268: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/543451d8_123a22ac PS1, Line 269: 3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/123e3a3c_39dc6ead PS1, Line 270: start 3+39 - 10 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/574ecffb_18cc1f72 PS1, Line 271: end 3+39 + SYNC_SEARCH_RANGE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b823e2c_e6b626a7 PS1, Line 272: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ca8d150_32ac2e2c PS1, Line 273: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75e33fa5_9edc9014 PS1, Line 274: int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aaba0fbb_4f35a4da PS1, Line 275: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e4b0fd8_aa9cac34 PS1, Line 276: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7d5755dc_2338c3fb PS1, Line 277: const int search_start_pos = (search_center - 10) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ed78992_619eef0d PS1, Line 278: const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/abc704d6_598a3ef6 PS1, Line 279: const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69db3703_ce73ea70 PS1, Line 280: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c36fe036_7bd7400a PS1, Line 281: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec98c67e_6d47c6ce PS1, Line 282: // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b740fede_312bdb43 PS1, Line 283: float corr_max; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dcd4f0a_001f1afb PS1, Line 284: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/662e4b36_5c9f6812 PS1, Line 285: &corr_max); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c9b874b_0f400604 PS1, Line 286: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1880709_345396ab PS1, Line 287: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dcc13c3f_42043493 PS1, Line 288: int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/065e1095_8fe1418f PS1, Line 289: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27fb4041_9c2302f2 PS1, Line 290: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26747407_4abd0f9b PS1, Line 291: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c96417dc_db1d7517 PS1, Line 292: const int search_start_pos = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b8c8dde_fb9fec1d PS1, Line 293: // FIXME: proper end offset trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fe935329_6be24d2c PS1, Line 294: const int search_stop_pos = len - (N_SYNC_BITS*8); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad2e1bc7_56d038d1 PS1, Line 295: auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3cac809e_1dd1601e PS1, Line 296: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/494b90c7_54d40315 PS1, Line 297: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ac8f901_dcd845a7 PS1, Line 298: corr_max); DOS line endings File Transceiver52M/grgsm_vitac/viterbi_detector.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/662c38f3_e0be7afd PS1, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/976087be_0aacee39 PS1, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37797e43_4585d15c PS1, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1ecbb7d_2ba63274 PS1, Line 4: * @author (C) 2009 Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a250ad34_c899f019 PS1, Line 5: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9240db04_c21d9fae PS1, Line 6: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ee3634f0_92a4e290 PS1, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e3e965f_ea0ea430 PS1, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37b2225c_5aca0a6e PS1, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b64bad2b_d4bc8aca PS1, Line 10: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15a37a30_1ade9ad4 PS1, Line 11: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9454edf1_f5b5b36e PS1, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9db7e52a_eff98d53 PS1, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4c24a31_572844b6 PS1, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a11403fa_a2ab9885 PS1, Line 15: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2fe6059_33324288 PS1, Line 16: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4cc72c0_05fd07b6 PS1, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9d7c7b3_d1297d7c PS1, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7287f36a_52eacc0f PS1, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/253e903d_4fd2d0ec PS1, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1164c2f9_1310a332 PS1, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ddbf25e_04a4fef2 PS1, Line 21: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23331ffc_25902a4c PS1, Line 22: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e284283_565db17c PS1, Line 23: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7601ec7_0c4b0803 PS1, Line 24: * viterbi_detector: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ffef8e3_5c1a7f13 PS1, Line 25: * This part does the detection of received sequnece. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e7f6660e_8dbb93cb PS1, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b1f4b89_25c0c26a PS1, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0101c8c_abf595b6 PS1, Line 28: * it was designed with soft decisions in mind. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8dc804c_6def203e PS1, Line 29: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2a11e3e_64c603ee PS1, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a040bc84_664197a1 PS1, Line 31: * const gr_complex * input, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ba0a889_34e29705 PS1, Line 32: * unsigned int samples_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf13daed_e8c803d3 PS1, Line 33: * gr_complex * rhh, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82f5a71a_3205f3f3 PS1, Line 34: * unsigned int start_state, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7d1fa5e7_cd38f709 PS1, Line 35: * const unsigned int * stop_states, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/73d3b597_b7811ac0 PS1, Line 36: * unsigned int stops_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/564bc931_253716c7 PS1, Line 37: * float * output) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2641bcf3_f14c1526 PS1, Line 38: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c66e296_d34673e7 PS1, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48398d39_200b11b3 PS1, Line 40: * samples_num: Number of samples in the input table. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12f3e976_215d150b PS1, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a22e2bfd_2d1e1b72 PS1, Line 42: * impulse response. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ccac45de_19c8f274 PS1, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f7d9377_1a1b5694 PS1, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dc435d3_27d846a4 PS1, Line 45: * indicates start point of the algorithm. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a43da85_5973f853 PS1, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67c0e3a7_2861f743 PS1, Line 47: * stops_num: Number of possible stop states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/815ab3f3_4dee3e7d PS1, Line 48: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a10ea126_c5ff80ab PS1, Line 49: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/529c19f8_a6fcd83d PS1, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/232666fd_8206f9f5 PS1, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05dda335_009295bf PS1, Line 52: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17d91056_105cfc84 PS1, Line 53: * SUB_FUNC: none trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52d05470_a6fb399c PS1, Line 54: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6bec1f8_ee0be1be PS1, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f59fdb8_7f19c2f9 PS1, Line 56: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/381faa86_34062ff5 PS1, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21225442_5442f21f PS1, Line 58: #ifndef INCLUDED_VITERBI_DETECTOR_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bed1136_b614b0eb PS1, Line 59: #define INCLUDED_VITERBI_DETECTOR_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/883b7a8e_e2ad83a2 PS1, Line 60: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4116c73d_511a7184 PS1, Line 61: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e788e12_01951a5a PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fd208121_4e5fd3ef PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b13bf4dc_1d3a64ce PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75887d14_572d934c PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6144a080_e69f4c66 PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d4fccee_913bad81 PS1, Line 63: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8159a93_b5794ab9 PS1, Line 64: #endif /* INCLUDED_VITERBI_DETECTOR_H */ DOS line endings File Transceiver52M/grgsm_vitac/viterbi_detector.cc: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47100dcb_98d4e0ad PS1, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bba8cb5a_1c01ff96 PS1, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75f1baa1_9e0b9139 PS1, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a76e2e69_be2b8a07 PS1, Line 4: * @author (C) 2009 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32018799_d8ecba86 PS1, Line 5: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c277b59_8ebffdf2 PS1, Line 6: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f940e04f_c1bd61ba PS1, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a9343b8_9225dafa PS1, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3aa5e09c_679cbc34 PS1, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95c35409_89029d88 PS1, Line 10: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54d21c68_b819951c PS1, Line 11: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/695776a0_acf2200e PS1, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6faef23a_d2f67eec PS1, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b9db5f8_b560f21b PS1, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be91d9d3_d5934204 PS1, Line 15: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a615c678_9c46c921 PS1, Line 16: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/513f9e68_179770e4 PS1, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/130cd4da_80ff5978 PS1, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60853de6_3ffd6743 PS1, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ea3d2b0_caa553e3 PS1, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d0b3ebf6_4a0a3a99 PS1, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d278f34_3ed32355 PS1, Line 21: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/931ebd31_05021684 PS1, Line 22: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3711940d_d333a81a PS1, Line 23: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/172281b1_850874b0 PS1, Line 24: * viterbi_detector: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f1ac61a_43feba14 PS1, Line 25: * This part does the detection of received sequnece. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b355beb_6034bde7 PS1, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/822b6b74_fcf0d5ec PS1, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9cf71941_abe88bc3 PS1, Line 28: * it was designed with soft decisions in mind. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8e9b72ce_dc2b53ca PS1, Line 29: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87b1ed02_4a96eb2c PS1, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e7af52b_435dd11c PS1, Line 31: * const gr_complex * input, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dbdb93e1_54ca2faf PS1, Line 32: * unsigned int samples_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b43c07d_328bb1fc PS1, Line 33: * gr_complex * rhh, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc7e4271_96b3113d PS1, Line 34: * unsigned int start_state, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/14ffd48c_615fcd97 PS1, Line 35: * const unsigned int * stop_states, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5215a13_be1f9731 PS1, Line 36: * unsigned int stops_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/053a1ed1_bfda3cdc PS1, Line 37: * float * output) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94823fb7_0282c857 PS1, Line 38: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9eb807ca_078cdebf PS1, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d380d68_2640bb6f PS1, Line 40: * samples_num: Number of samples in the input table. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc3a3f0c_9dd32866 PS1, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab6bd4b9_c247c1a6 PS1, Line 42: * impulse response. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02113a4a_ccc661d8 PS1, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c9ef86c_2f3e9a63 PS1, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/07c6df30_5ece326c PS1, Line 45: * indicates start point of the algorithm. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7408f587_90ba13c8 PS1, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/098f9077_aad287a6 PS1, Line 47: * stops_num: Number of possible stop states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5b830da_490388d3 PS1, Line 48: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c4083c9_1a25973e PS1, Line 49: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c84b46d4_ca1c90d3 PS1, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bfc20b4_320487e3 PS1, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/282041d6_156fd5ea PS1, Line 52: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1d5d7bb_bbf468af PS1, Line 53: * SUB_FUNC: none trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e18a49ad_21d5c1eb PS1, Line 54: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d688c8f6_769ee3b0 PS1, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf29c01b_eaf16c59 PS1, Line 56: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e03eaf39_90347a3a PS1, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fda8c54f_f2e2864b PS1, Line 58: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c98bd7b_44caa744 PS1, Line 59: #include <cmath> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb7c01ac_727279d6 PS1, Line 60: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0550bccd_7d661381 PS1, Line 61: #define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1)) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c33d8aa_9341bf3b PS1, Line 62: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dd370e2_2fa8ab89 PS1, Line 63: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a6ab2f1_48eaa8ba PS1, Line 64: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f69872f_a0fd0a5d PS1, Line 65: float increment[8]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b31217a9_ffc2f0ff PS1, Line 66: float path_metrics1[16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b59f8ce_004c7ebe PS1, Line 67: float path_metrics2[16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90d42655_2fa9ca18 PS1, Line 68: float paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4cecc630_838ad142 PS1, Line 69: float * new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/262a1e01_68d52532 PS1, Line 70: float * old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4687c928_3b7d9f9a PS1, Line 71: float * tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9ca21f0_0d8decc3 PS1, Line 72: float trans_table[BURST_SIZE][16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02ef9230_56ce4398 PS1, Line 73: float pm_candidate1, pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78d0bbac_a8f3b821 PS1, Line 74: bool real_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bb66eee9_bf25aa28 PS1, Line 75: float input_symbol_real, input_symbol_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a79fd2ae_8146b2cf PS1, Line 76: unsigned int i, sample_nr; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c7d549e_640a68ae PS1, Line 77: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bcaa116_2bffb995 PS1, Line 78: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d10bb7c2_2956531d PS1, Line 79: * Setup first path metrics, so only state pointed by start_state is possible. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1baf6be2_c1161cbd PS1, Line 80: * Start_state metric is equal to zero, the rest is written with some very low value, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc7d87ee_14051203 PS1, Line 81: * which makes them practically impossible to occur. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1d8c56d_3fb02ef0 PS1, Line 82: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7fc661b4_c4d90e61 PS1, Line 83: for(i=0; i<PATHS_NUM; i++){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/648dc41f_6c699e69 PS1, Line 84: path_metrics1[i]=(-10e30); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d9a6f80_d0edfec1 PS1, Line 85: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ff0c175_c9d87162 PS1, Line 86: path_metrics1[start_state]=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2aebce47_89e918e9 PS1, Line 87: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1841d021_c3d3a2a2 PS1, Line 88: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/600271fc_22152fa8 PS1, Line 89: * Compute Increment - a table of values which does not change for subsequent input samples. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e488d1c_0f74a371 PS1, Line 90: * Increment is table of reference levels for computation of branch metrics: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dccf12c2_ffe3f3f8 PS1, Line 91: * branch metric = (+/-)received_sample (+/-) reference_level trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f1fc050_d77b0914 PS1, Line 92: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0bd679d_02413e8d PS1, Line 93: increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9fdc635_1b0feefc PS1, Line 94: increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fece56a0_e7b48a8f PS1, Line 95: increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70cf5e3d_6963e5b2 PS1, Line 96: increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98ee6bc1_be8e6d89 PS1, Line 97: increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcac4b33_00240c08 PS1, Line 98: increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d76c078_6b87074e PS1, Line 99: increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4fbcf33f_5f8502f6 PS1, Line 100: increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa640ead_1084ae3a PS1, Line 101: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c42b44e_4936da86 PS1, Line 102: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/beed48ac_564c36d3 PS1, Line 103: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03fc7661_518d5927 PS1, Line 104: * Computation of path metrics and decisions (Add-Compare-Select). trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/614313eb_9d6be5ae PS1, Line 105: * It's composed of two parts: one for odd input samples (imaginary numbers) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/909518a1_d46691b9 PS1, Line 106: * and one for even samples (real numbers). trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6352eadf_5b898828 PS1, Line 107: * Each part is composed of independent (parallelisable) statements like trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6492ba9a_1313d989 PS1, Line 108: * this one: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05a2d638_17ffc025 PS1, Line 109: * pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81fb42d5_77542a76 PS1, Line 110: * pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8c761f2_f1505b73 PS1, Line 111: * paths_difference=pm_candidate2-pm_candidate1; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7acc0de2_67299dc0 PS1, Line 112: * new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0dd2f53f_22ceb4c2 PS1, Line 113: * trans_table[sample_nr][1] = paths_difference; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8669d7e6_524cd5a4 PS1, Line 114: * This is very good point for optimisations (SIMD or OpenMP) as it's most time trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0a813eb_7258d34b PS1, Line 115: * consuming part of this function. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ea58225_e37f7c89 PS1, Line 116: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae3ed814_720ab091 PS1, Line 117: sample_nr=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83bbe402_317b7078 PS1, Line 118: old_path_metrics=path_metrics1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd9f060a_df4bcf7d PS1, Line 119: new_path_metrics=path_metrics2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f52def7b_732611bb PS1, Line 120: while(sample_nr<samples_num){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d40c2dbb_6d199cce PS1, Line 121: //Processing imag states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df9fb690_14a78787 PS1, Line 122: real_imag=1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/184dee4e_04f8eb79 PS1, Line 123: input_symbol_imag = input[sample_nr].imag(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b29eeca_984e52bf PS1, Line 124: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71c7c4a1_f9d42b5a PS1, Line 125: pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/00423798_727de65e PS1, Line 126: pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/959cfaea_3eb00a94 PS1, Line 127: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/282a822f_d6c9633f PS1, Line 128: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/142243df_0b127503 PS1, Line 129: trans_table[sample_nr][0] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5aa86f4b_b6691b3a PS1, Line 130: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/daca533d_1e8a9b47 PS1, Line 131: pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d52ce12_ee6bc1fd PS1, Line 132: pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6363531_5939f7b4 PS1, Line 133: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c8f10ee_52c82707 PS1, Line 134: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01a7cbd4_555a617a PS1, Line 135: trans_table[sample_nr][1] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97241962_6e537e59 PS1, Line 136: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db0549c1_c8a60aa1 PS1, Line 137: pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/babe4176_ae83a43b PS1, Line 138: pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23bd46af_53560d5d PS1, Line 139: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cdbb9d2b_b0c7a82f PS1, Line 140: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a0439cc_36217136 PS1, Line 141: trans_table[sample_nr][2] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/25d0ef96_19bd8222 PS1, Line 142: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8b0ea012_5995c6c1 PS1, Line 143: pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f912019_ac03e311 PS1, Line 144: pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a15be528_a897bd8f PS1, Line 145: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b37e4cb8_ee3318ab PS1, Line 146: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/806debc8_f6d15ea2 PS1, Line 147: trans_table[sample_nr][3] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57ac6b6f_1ee4dfc5 PS1, Line 148: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c7df3b6_81cc8209 PS1, Line 149: pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da088555_ded10c14 PS1, Line 150: pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83157fa7_09c8f80a PS1, Line 151: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/910e9178_7f7bcac1 PS1, Line 152: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b22d38e_9d84bce2 PS1, Line 153: trans_table[sample_nr][4] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bdf9c4a_e5522f38 PS1, Line 154: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebff2b25_83ae7f1a PS1, Line 155: pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bea3a47_45fd5f62 PS1, Line 156: pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be798fa5_d5db3c77 PS1, Line 157: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e152594_5d29253e PS1, Line 158: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ab890a8_b2954ae3 PS1, Line 159: trans_table[sample_nr][5] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8b39d07_a7678662 PS1, Line 160: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7b65f96_dbc85c37 PS1, Line 161: pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0403357_5fcb4b9e PS1, Line 162: pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/73d182f2_493afaae PS1, Line 163: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be51455b_4acb4840 PS1, Line 164: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbef8ae0_2ec335f3 PS1, Line 165: trans_table[sample_nr][6] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c32c5ccb_4054fdc7 PS1, Line 166: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be6b0ea4_7acc8d72 PS1, Line 167: pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8075dfe_4b6fe825 PS1, Line 168: pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/20d5aa09_644fd319 PS1, Line 169: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa50915a_8b9415bc PS1, Line 170: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4000dd9_95ca42ad PS1, Line 171: trans_table[sample_nr][7] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43f47227_974d5c07 PS1, Line 172: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ee23460_b328f966 PS1, Line 173: pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/083c2998_3b4703cd PS1, Line 174: pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9de0a49d_f96dc466 PS1, Line 175: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98579fa0_c74e8374 PS1, Line 176: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21fd1842_d710b1b9 PS1, Line 177: trans_table[sample_nr][8] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acd0ce29_c9a54276 PS1, Line 178: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95a34f67_daeece82 PS1, Line 179: pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34209d5d_c5f87a0b PS1, Line 180: pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/940f1793_a6c21a38 PS1, Line 181: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ddcd727_853e396f PS1, Line 182: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46d645b7_e9dfbe21 PS1, Line 183: trans_table[sample_nr][9] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df0abbb5_178b6bab PS1, Line 184: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95d9d47a_c5c4e898 PS1, Line 185: pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/716eadb0_74a0e045 PS1, Line 186: pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4ae42d8_b0202cd9 PS1, Line 187: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/622e603e_bc21d87e PS1, Line 188: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c7cf284_d11c580a PS1, Line 189: trans_table[sample_nr][10] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff18c9df_373fc333 PS1, Line 190: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17645e49_558da642 PS1, Line 191: pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70a3e789_e2503545 PS1, Line 192: pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3718558c_9d735f32 PS1, Line 193: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/beb36811_4e7febc8 PS1, Line 194: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18832505_ebd4d456 PS1, Line 195: trans_table[sample_nr][11] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c951bdb8_e9bd8da7 PS1, Line 196: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3210dcc_1734a0db PS1, Line 197: pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bb16f29_a845f7a1 PS1, Line 198: pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efec955a_5f817a20 PS1, Line 199: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0bb68bc_f16cc533 PS1, Line 200: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a673b02d_b992bf5b PS1, Line 201: trans_table[sample_nr][12] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/430fc63f_36777a8b PS1, Line 202: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/beaeb508_038077a5 PS1, Line 203: pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dfa064c_9139066e PS1, Line 204: pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d72a8f4_9aaf8d08 PS1, Line 205: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f821ca81_f9bff86a PS1, Line 206: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b55896d_20d90eaa PS1, Line 207: trans_table[sample_nr][13] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df7fac54_2af5ff62 PS1, Line 208: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bc1f9df_1e56f859 PS1, Line 209: pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/854d12db_5d979823 PS1, Line 210: pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2f67a7e_6b152a43 PS1, Line 211: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/159fa760_85d214cf PS1, Line 212: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a668ab0_45feb57b PS1, Line 213: trans_table[sample_nr][14] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f49e174e_47adbe6b PS1, Line 214: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d84a0028_c5c4bcfe PS1, Line 215: pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52e3ac98_7d9eeee7 PS1, Line 216: pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ff5a5c5_0e951b2b PS1, Line 217: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05306f47_51aa311c PS1, Line 218: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d22827c1_52c872f0 PS1, Line 219: trans_table[sample_nr][15] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5544e3d8_588d9bed PS1, Line 220: tmp=old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0254f4f0_e9803d1b PS1, Line 221: old_path_metrics=new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce898082_d795bb2b PS1, Line 222: new_path_metrics=tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/283006b3_d457865c PS1, Line 223: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12e3ac69_fc4f382e PS1, Line 224: sample_nr++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcffc68f_a7031af2 PS1, Line 225: if(sample_nr==samples_num) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4c93154_986a997e PS1, Line 226: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8971bdf4_ae47ed96 PS1, Line 227: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e28ad15e_c48a96f4 PS1, Line 228: //Processing real states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1e0b033_47465ab8 PS1, Line 229: real_imag=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06ccfbc5_323e1354 PS1, Line 230: input_symbol_real = input[sample_nr].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2aab164_5c239432 PS1, Line 231: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9008c217_30a48ca2 PS1, Line 232: pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2620cc69_7d71c43c PS1, Line 233: pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8e98f06_60674545 PS1, Line 234: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9fe0008_21664d5d PS1, Line 235: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bba38c80_711d548c PS1, Line 236: trans_table[sample_nr][0] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d64d6c7_2f426423 PS1, Line 237: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67e86ded_626f116e PS1, Line 238: pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6e72e17_e8df01dc PS1, Line 239: pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fef25226_e9018d41 PS1, Line 240: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f06adfb9_dd60ceec PS1, Line 241: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/add3b8f4_be962251 PS1, Line 242: trans_table[sample_nr][1] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/525b6b24_c4f3395a PS1, Line 243: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d24e69ca_dca81121 PS1, Line 244: pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5b482f7_114d0b57 PS1, Line 245: pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a090bab_12da33e2 PS1, Line 246: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8da9bced_b590a700 PS1, Line 247: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0072efca_ae7ff7b9 PS1, Line 248: trans_table[sample_nr][2] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8565e567_61fd0c46 PS1, Line 249: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13ce4532_94c26304 PS1, Line 250: pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5169946c_a27e0328 PS1, Line 251: pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da530a0a_f3fea4b0 PS1, Line 252: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48b85f26_0f7fae73 PS1, Line 253: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2180431_3bd4740a PS1, Line 254: trans_table[sample_nr][3] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f7a31500_4a20d5e8 PS1, Line 255: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a16a65eb_3bf33f36 PS1, Line 256: pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61833c9e_2bfa4fce PS1, Line 257: pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6300a8ea_c49daace PS1, Line 258: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9352498a_0f497f37 PS1, Line 259: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2357b0cb_63206282 PS1, Line 260: trans_table[sample_nr][4] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/91600e2d_fc86990a PS1, Line 261: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89ac36b5_673e510d PS1, Line 262: pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d3312dc_6ea303e5 PS1, Line 263: pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3dbe6bd_56a1c404 PS1, Line 264: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79fdb15a_47209c68 PS1, Line 265: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/292c80a1_d79da118 PS1, Line 266: trans_table[sample_nr][5] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e2d30c8f_38ba362f PS1, Line 267: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/50072ee6_1ed8187f PS1, Line 268: pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed4f1d97_10adaef7 PS1, Line 269: pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d0189c2f_96e06e45 PS1, Line 270: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de6a123e_a6e325e1 PS1, Line 271: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e7feaa62_2f1cb8b3 PS1, Line 272: trans_table[sample_nr][6] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5ea70ea_1657609a PS1, Line 273: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/792ac9fb_5a7f0fd9 PS1, Line 274: pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8693d874_c825b97e PS1, Line 275: pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ffaa48f5_fe693c13 PS1, Line 276: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/481fddff_5a106165 PS1, Line 277: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4674531_c036e809 PS1, Line 278: trans_table[sample_nr][7] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e4f75b4_bdbc3931 PS1, Line 279: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76a0e764_06d5cf8e PS1, Line 280: pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64b86e89_8d880ac4 PS1, Line 281: pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6d4b857_10ff2c99 PS1, Line 282: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79b96e41_e7dd9877 PS1, Line 283: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/665397dc_bd80f6a0 PS1, Line 284: trans_table[sample_nr][8] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87c1b180_7d637587 PS1, Line 285: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7aa54df3_37101eb5 PS1, Line 286: pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3325eb4a_663d3f60 PS1, Line 287: pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b38f1735_314ba8aa PS1, Line 288: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b793811c_ee48e7be PS1, Line 289: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15c6850e_62f59543 PS1, Line 290: trans_table[sample_nr][9] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/973531c9_69e6db25 PS1, Line 291: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23e228f7_fb64e813 PS1, Line 292: pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b6f1a689_f2e2e6d9 PS1, Line 293: pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/893f8180_42a69f2b PS1, Line 294: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9ede1ca_19439b87 PS1, Line 295: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ac2e66e_69b00f62 PS1, Line 296: trans_table[sample_nr][10] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/180d112b_532653c0 PS1, Line 297: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c852c0e_9866ccce PS1, Line 298: pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ec994e3_b9f75bae PS1, Line 299: pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eed40f1d_cc60bedb PS1, Line 300: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/313a0128_a62c2133 PS1, Line 301: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81ae8055_47c038b5 PS1, Line 302: trans_table[sample_nr][11] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b9978b6_da4e6f72 PS1, Line 303: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47e13116_c97d21e6 PS1, Line 304: pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fe10866a_3237147e PS1, Line 305: pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9df8ae59_6416091d PS1, Line 306: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/719e552b_d5e6ea7b PS1, Line 307: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a95b823c_89072084 PS1, Line 308: trans_table[sample_nr][12] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e5e3eeb_066dbf86 PS1, Line 309: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/039130fb_769ef6eb PS1, Line 310: pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38d3f4c6_04a6c7f3 PS1, Line 311: pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/91b2070e_0e03f83a PS1, Line 312: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7bfb1152_6cb75672 PS1, Line 313: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32db60e2_8b277681 PS1, Line 314: trans_table[sample_nr][13] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b991cea_5cf7d1da PS1, Line 315: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae45cadb_76fb5235 PS1, Line 316: pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d063cb9_2a8f68c2 PS1, Line 317: pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35382050_3a03a95d PS1, Line 318: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37cc8b7d_361f72dd PS1, Line 319: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c2839d7_9b6e3f20 PS1, Line 320: trans_table[sample_nr][14] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75cfe80b_ff9f05a9 PS1, Line 321: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5598d564_eec28d25 PS1, Line 322: pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0160bd6a_a6ad917f PS1, Line 323: pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09cc86bd_57fc06e9 PS1, Line 324: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1152a7fb_1196bf26 PS1, Line 325: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac36e45d_f58ec05c PS1, Line 326: trans_table[sample_nr][15] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9bda11c_0aca7720 PS1, Line 327: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc74852d_bd448fed PS1, Line 328: tmp=old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6fff0e8_1749cd26 PS1, Line 329: old_path_metrics=new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e9bc89f_c48367bc PS1, Line 330: new_path_metrics=tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2f3ac20_8fecb2d7 PS1, Line 331: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8a70ed1_cc719f8a PS1, Line 332: sample_nr++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5762bd21_63eb39c5 PS1, Line 333: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/662bbd03_5b2dbc90 PS1, Line 334: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46c904af_c3e52303 PS1, Line 335: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45c70800_7cf59a3d PS1, Line 336: * Find the best from the stop states by comparing their path metrics. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d9ae2b6_bed11905 PS1, Line 337: * Not every stop state is always possible, so we are searching in trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebacecb4_372ee6f4 PS1, Line 338: * a subset of them. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79e302d4_01880b9f PS1, Line 339: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d26cdf3_0ed58a4e PS1, Line 340: unsigned int best_stop_state; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5713a8d_20a93206 PS1, Line 341: float stop_state_metric, max_stop_state_metric; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d1ae503_ad299835 PS1, Line 342: best_stop_state = stop_states[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6415217a_4228fdbf PS1, Line 343: max_stop_state_metric = old_path_metrics[best_stop_state]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/986e109d_59eb2cac PS1, Line 344: for(i=1; i< stops_num; i++){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca1b17a0_205b534e PS1, Line 345: stop_state_metric = old_path_metrics[stop_states[i]]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8282d8d1_3ab5ffa0 PS1, Line 346: if(stop_state_metric > max_stop_state_metric){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2dabac3_6f99830d PS1, Line 347: max_stop_state_metric = stop_state_metric; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09d0c6cc_33fe2c50 PS1, Line 348: best_stop_state = stop_states[i]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7732e0c2_9624dead PS1, Line 349: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae66af10_6b98677d PS1, Line 350: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6968f787_6108eb6d PS1, Line 351: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e54dcf13_338084ae PS1, Line 352: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03644ff4_5c840238 PS1, Line 353: * This table was generated with hope that it gives a litle speedup during trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4575d080_0bb273a5 PS1, Line 354: * traceback stage. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c51fa26a_742f789a PS1, Line 355: * Received bit is related to the number of state in the trellis. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/965d3147_5307f43b PS1, Line 356: * I've numbered states so their parity (number of ones) is related trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cf8fc63_a91d84da PS1, Line 357: * to a received bit. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53205755_b9c3d0ce PS1, Line 358: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b1e4f9e5_ff74a1f1 PS1, Line 359: static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d07b1e73_1f5c1d74 PS1, Line 360: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19737de4_a357a571 PS1, Line 361: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aba66beb_a6996d3a PS1, Line 362: * Table of previous states in the trellis diagram. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b8d13d1_aff6be1f PS1, Line 363: * For GMSK modulation every state has two previous states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/25ab5e0a_3fc0df16 PS1, Line 364: * Example: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b87da34_56f17026 PS1, Line 365: * previous_state_nr1 = prev_table[current_state_nr][0] trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4429ed4_98a42e0f PS1, Line 366: * previous_state_nr2 = prev_table[current_state_nr][1] trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51895b1d_bb347523 PS1, Line 367: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dd4c77b_ceb52f8a PS1, Line 368: static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bbf2031d_5f48e8fb PS1, Line 369: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85ea2a49_ab90c2aa PS1, Line 370: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/289ef068_9dbb5de0 PS1, Line 371: * Traceback and differential decoding of received sequence. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5895a578_6d2a4c30 PS1, Line 372: * Decisions stored in trans_table are used to restore best path in the trellis. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2814559_93038728 PS1, Line 373: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/067ac8a2_8031e94e PS1, Line 374: sample_nr=samples_num; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5cca4631_d2fa6338 PS1, Line 375: unsigned int state_nr=best_stop_state; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0aaddb9_cfbf046a PS1, Line 376: unsigned int decision; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c1ab6ce_0c5814c4 PS1, Line 377: bool out_bit=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79843aac_9caf3bc8 PS1, Line 378: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba85b924_e05db597 PS1, Line 379: while(sample_nr>0){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc7ee93b_4b25d8b4 PS1, Line 380: sample_nr--; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3477f6f_f956487c PS1, Line 381: decision = (trans_table[sample_nr][state_nr]>0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6af7b2c_e385cfde PS1, Line 382: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3853e4db_bcd3a90f PS1, Line 383: if(decision != out_bit) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ba87194_c3d11a12 PS1, Line 384: output[sample_nr]=-trans_table[sample_nr][state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed25fef3_72c8019a PS1, Line 385: else DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81bc2acb_6edab099 PS1, Line 386: output[sample_nr]=trans_table[sample_nr][state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93bcd35f_846bd7f5 PS1, Line 387: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95504d15_7ea9e435 PS1, Line 388: out_bit = out_bit ^ real_imag ^ parity_table[state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a22aa961_a22ae9ec PS1, Line 389: state_nr = prev_table[state_nr][decision]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72753e0c_48ca644c PS1, Line 390: real_imag = !real_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d486fbc_1afa69b5 PS1, Line 391: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13f52779_b79c4e7d PS1, Line 392: } DOS line endings -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: ill-fated ipcv2 for mstrx

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 ) Change subject: ill-fated ipcv2 for mstrx ...................................................................... Patch Set 1: (232 comments) File Transceiver52M/device/ipc2/IPCDevice.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/faf18f78_3b209a88 PS1, Line 40: protected: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/da8d7c47_5fd8a540 PS1, Line 41: std::vector<smpl_buf *> rx_buffers; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f69eb1be_69eaf196 PS1, Line 41: std::vector<smpl_buf *> rx_buffers; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b9107110_710b313e PS1, Line 41: std::vector<smpl_buf *> rx_buffers; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cbbd83e0_d13e25d2 PS1, Line 41: std::vector<smpl_buf *> rx_buffers; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72a2874e_a3f1954f PS1, Line 48: std::vector<double> tx_gains, rx_gains; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6979dd75_8841521b PS1, Line 48: std::vector<double> tx_gains, rx_gains; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d05158dd_fb2c4e9e PS1, Line 48: std::vector<double> tx_gains, rx_gains; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7db861c9_8de7fd5f PS1, Line 57: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9e90e2aa_c0d4de9f PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/88e59e92_82680afd PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e73d2cce_f61ca6c4 PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e0507434_8aadde25 PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/08c161e8_bb98c15d PS1, Line 64: virtual int open(const std::string &args, int ref, bool swap_channels) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/67482bc7_a94fb6e3 PS1, Line 67: virtual bool start() override; Bad function definition - virtual bool start() should probably be virtual bool start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e878f243_24916a65 PS1, Line 70: virtual bool stop() override; Bad function definition - virtual bool stop() should probably be virtual bool stop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7df02f44_d668940e PS1, Line 73: enum TxWindowType getWindowType() override Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/992891d8_db1f3c9a PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/507b7ee6_79626fcf PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/caa4c961_e0b82ea9 PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/41d143a0_80f7ded6 PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/27ea8225_ec0d95cd PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/666021b0_eccdcd2e PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/49d88170_f87ddf0a PS1, Line 98: TIMESTAMP timestamp = 0xffffffff) override; Statements should start on a tabstop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3351f992_ffd7be67 PS1, Line 116: virtual double fullScaleInputValue() override Bad function definition - virtual double fullScaleInputValue() should probably be virtual double fullScaleInputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93771c33_90a1f643 PS1, Line 122: virtual double fullScaleOutputValue() override Bad function definition - virtual double fullScaleOutputValue() should probably be virtual double fullScaleOutputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a161827f_06e035fd PS1, Line 154: virtual bool setRxAntenna(const std::string &ant, size_t chan = 0) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4f0cb189_c3bd5331 PS1, Line 160: virtual bool setTxAntenna(const std::string &ant, size_t chan = 0) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a2b65b79_834023a0 PS1, Line 166: virtual bool requiresRadioAlign() override; Bad function definition - virtual bool requiresRadioAlign() should probably be virtual bool requiresRadioAlign(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/03bedd64_63b903c6 PS1, Line 180: virtual inline double getSampleRate() override Bad function definition - virtual inline double getSampleRate() should probably be virtual inline double getSampleRate(void) File Transceiver52M/device/ipc2/ipcif.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b4d5bbd_29008425 PS1, Line 35: using sample_t = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b2b40b0_699fd266 PS1, Line 35: using sample_t = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48cb7dde_91a4b7c2 PS1, Line 37: std::atomic<bool> ms_connected; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a3fbf5c4_9313d15b PS1, Line 37: std::atomic<bool> ms_connected; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9d885201_4dc2bf4a PS1, Line 37: std::atomic<bool> ms_connected; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8e81637_e3113ace PS1, Line 39: shm::sema r; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b692d8e5_30a41e2b PS1, Line 40: shm::sema w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6cac1365_2d9e0cab PS1, Line 41: std::atomic<uint64_t> ts; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/603a594a_36f213e5 PS1, Line 41: std::atomic<uint64_t> ts; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f59e436_fe52c740 PS1, Line 41: std::atomic<uint64_t> ts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b7f1fc7a_69b1c861 PS1, Line 42: std::atomic<uint64_t> ts_req; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e7ba404_581d44fa PS1, Line 42: std::atomic<uint64_t> ts_req; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48f357b6_912a4f3a PS1, Line 42: std::atomic<uint64_t> ts_req; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12ec6fd1_6ef7ee5f PS1, Line 43: std::atomic<size_t> len_written_sps; // -> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3564acc8_ebdd6fcf PS1, Line 43: std::atomic<size_t> len_written_sps; // -> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d59929e4_6c981aca PS1, Line 43: std::atomic<size_t> len_written_sps; // -> labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f682e3dc_f23fb5ca PS1, Line 47: shm::sema r; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/47c17d48_8e5fa5fb PS1, Line 48: shm::sema w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b930362b_8721c36e PS1, Line 49: std::atomic<uint64_t> ts; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f982104_deeec94a PS1, Line 49: std::atomic<uint64_t> ts; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b8074b27_515476bf PS1, Line 49: std::atomic<uint64_t> ts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4f0433a_2a4a6394 PS1, Line 50: std::atomic<uint64_t> ts_req; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5e4c73e8_82739732 PS1, Line 50: std::atomic<uint64_t> ts_req; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/62830640_67a1c69d PS1, Line 50: std::atomic<uint64_t> ts_req; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/590e9e5c_da6c4596 PS1, Line 51: std::atomic<size_t> len_written_sps; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9ad3d947_9b8fda3c PS1, Line 51: std::atomic<size_t> len_written_sps; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/032ab91f_f574d9aa PS1, Line 51: std::atomic<size_t> len_written_sps; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6f137bf4_7a1585c7 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89bb5ddb_d9b18b04 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54d96d29_df6d3e34 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5a6c5c6e_4d8a0841 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9c61ab70_a8449ad0 PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f34afbd6_a839699a PS1, Line 60: using stype = typename std::make_signed<A>::type; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36db1e31_f6681fab PS1, Line 60: using stype = typename std::make_signed<A>::type; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7ece2b1d_4f899fb8 PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b001c953_7656615f PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ff41568e_d7fd9071 PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e69f945_32b57171 PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c3a56e88_be00741e PS1, Line 90: template <unsigned int num_bursts> class ulburstprovider { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/310e18b9_633a28e2 PS1, Line 90: template <unsigned int num_bursts> class ulburstprovider { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/975d32e8_d6acda13 PS1, Line 91: std::mutex ul_q_m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c6ff45c_7a7398e3 PS1, Line 98: void cur_buf_done() Bad function definition - void cur_buf_done() should probably be void cur_buf_done(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abe16f1d_66a88857 PS1, Line 98: void cur_buf_done() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99e0c51a_1dd96696 PS1, Line 103: bool is_empty() Bad function definition - bool is_empty() should probably be bool is_empty(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/98a2aa1c_27d25c70 PS1, Line 103: bool is_empty() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/de023be0_d76497e8 PS1, Line 107: void reset() Bad function definition - void reset() should probably be void reset(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/57c93392_307d6a96 PS1, Line 107: void reset() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd616170_033aaccb PS1, Line 109: for (auto &i : foo) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96f7b2bd_3b06f62d PS1, Line 113: ulentry &find_free_at_end() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9cb1d4fe_bd0fbddf PS1, Line 123: void push_back(ulentry &e) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4c3864a_cd39c420 PS1, Line 123: void push_back(ulentry &e) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/75a0769a_a22c2094 PS1, Line 130: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/673db00e_ce570434 PS1, Line 131: void add(ulentry &e) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/39da4ffa_71b81bcc PS1, Line 131: void add(ulentry &e) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c785a7e0_498f33d0 PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d714364e_44e3059b PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/49418a20_21c97e5b PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/deb7feac_97c57f8d PS1, Line 136: void get(uint64_t requested_ts, unsigned int req_len_in_sps, sample_t *buf, unsigned int max_buf_write_len) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0afc5520_5c14c39f PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5cb43d88_00d8b808 PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e94aae72_ce5fccdf PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c995a2a1_b3a813bd PS1, Line 203: shm::shm<shm_if> m; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e50c228d_f4bb6911 PS1, Line 203: shm::shm<shm_if> m; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/78164afb_a2619e0e PS1, Line 203: shm::shm<shm_if> m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd209117_38482000 PS1, Line 206: ulburstprovider<10> p; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/783d6c2d_b32df518 PS1, Line 206: ulburstprovider<10> p; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/136259d0_54500fb7 PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/46bfa34c_21bacf57 PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/56a7c510_8c1402bb PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3f08fdbd_df063cbe PS1, Line 217: shm::mtx_log::print_guard() << "\tr @" << direction.ts.load() << " " << readoffset_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5deb2d8e_bdcb2b5d PS1, Line 235: shm::mtx_log::print_guard() << "\tr+ " << *read_ts << " " << howmany_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/56c7c09f_37751282 PS1, Line 247: shm::mtx_log::print_guard() << "\tr++ " << *read_ts << " " << howmany_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/81437850_877af9b7 PS1, Line 249: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/95d532c2_9ba61f3e PS1, Line 263: shm::mtx_log::print_guard() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e1bd5e81_5f0fe87d PS1, Line 270: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab367ed9_735f408d PS1, Line 275: bool create() Bad function definition - bool create() should probably be bool create(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c1f7f3f3_24ee5f6d PS1, Line 275: bool create() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99d97af4_c10dfc68 PS1, Line 281: bool connect() Bad function definition - bool connect() should probably be bool connect(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8a569ff6_0ad86d1b PS1, Line 281: bool connect() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f60377a1_0fc6fdc9 PS1, Line 289: bool good() Bad function definition - bool good() should probably be bool good(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6353524e_0c0bd3e3 PS1, Line 289: bool good() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/80475acb_8ed1ec9b PS1, Line 293: bool is_connected() Bad function definition - bool is_connected() should probably be bool is_connected(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c7155efd_5931a8f7 PS1, Line 293: bool is_connected() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/38122db5_c4a32d88 PS1, Line 299: void read_dl(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/418406bb_06ce036a PS1, Line 305: void read_ul(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0f33af9_290941f5 PS1, Line 309: // return; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54a026bc_a08db990 PS1, Line 314: void write_dl(size_t howmany_sps, uint64_t write_ts, sample_t *inbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0a0cc41d_b082e43e PS1, Line 316: auto &dl = ptr->dl; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e2c028bf_9be23356 PS1, Line 325: shm::sema_wait_guard g(dl.w, dl.r); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/03b0fc44_b8f56c2b PS1, Line 331: shm::mtx_log::print_guard() << std::endl labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/50c3d639_1a937ad2 PS1, Line 336: void write_ul(size_t howmany_sps_sps, uint64_t write_ts, sample_t *inbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b049e060_0a12ff93 PS1, Line 338: auto &ul = ptr->ul; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/794dac31_79323e42 PS1, Line 351: shm::mtx_log::print_guard() << std::endl labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fd9b08bb_e5225a11 PS1, Line 356: void drive_tx() Bad function definition - void drive_tx() should probably be void drive_tx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/61488fb1_bba7f263 PS1, Line 356: void drive_tx() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4bd8fba_ed7fd4dc PS1, Line 358: auto &ul = ptr->ul; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b54fe19_23780f4a PS1, Line 384: void signal_read_start() Bad function definition - void signal_read_start() should probably be void signal_read_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a4da10c3_f74d5e2b PS1, Line 384: void signal_read_start() open brace '{' following function definitions go on the next line File Transceiver52M/device/ipc2/shmif.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b7dbc6a_2d4f9e8f PS1, Line 46: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c083523_82714d9b PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/591ce811_b64ba584 PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/022a0800_235c9a1b PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2cb0a9f6_be0a9126 PS1, Line 50: std::cerr << str(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72933e3a_24cd22d4 PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96f42e91_3d10bb14 PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/02eb618e_74874020 PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/79d2b144_36b28c4c PS1, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &)) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5b9516d2_3a29038a PS1, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &)) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b608f401_5d461917 PS1, Line 73: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c72ab1d_b46c6541 PS1, Line 89: void lock() Bad function definition - void lock() should probably be void lock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6168b6f6_4d5cd647 PS1, Line 89: void lock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8082436a_e82146a0 PS1, Line 94: bool try_lock() Bad function definition - bool try_lock() should probably be bool try_lock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9eb03bf6_daa5a3ce PS1, Line 94: bool try_lock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/813b617d_bb0810b5 PS1, Line 99: void unlock() Bad function definition - void unlock() should probably be void unlock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6bbc2f6a_411cf0d0 PS1, Line 99: void unlock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/def2b641_14fc2dd4 PS1, Line 104: pthread_mutex_t *p() Bad function definition - pthread_mutex_t *p() should probably be pthread_mutex_t *p(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/df47252f_076a8602 PS1, Line 104: pthread_mutex_t *p() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/564a05c0_fcddf8bd PS1, Line 109: shmmutex &operator=(const shmmutex &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9039e2e5_e026b35e PS1, Line 109: shmmutex &operator=(const shmmutex &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/47f1348e_f41ef512 PS1, Line 115: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c12647c3_a69ff939 PS1, Line 130: void wait(shmmutex *lock) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/817489f5_f3742b53 PS1, Line 135: void signal() Bad function definition - void signal() should probably be void signal(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72f3323f_713e300b PS1, Line 135: void signal() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/da823f35_64c3271f PS1, Line 140: void signal_all() Bad function definition - void signal_all() should probably be void signal_all(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ef8323e7_7a935b3f PS1, Line 140: void signal_all() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ba8b3c75_7fa86b2f PS1, Line 145: shmcond &operator=(const shmcond &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/712164c8_b2de9079 PS1, Line 145: shmcond &operator=(const shmcond &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1d29dca2_b85af691 PS1, Line 149: shmmutex &m; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6f9dd390_d74f1a12 PS1, Line 150: shmcond &s; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/af20f095_f52d6222 PS1, Line 152: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/76139a73_55e8ee36 PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ca08be2f_47f41cf7 PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/631d17b5_d496185f PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/61331542_bca4d452 PS1, Line 165: signal_guard &operator=(const signal_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/143d0c12_df9be473 PS1, Line 165: signal_guard &operator=(const signal_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/140c1c80_8900a9f9 PS1, Line 169: shmmutex &m; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/78512a2d_c31bf64b PS1, Line 171: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/db6dab36_89a9406f PS1, Line 173: explicit mutex_guard(shmmutex &m) : m(m) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d4d22ab8_1fb85e1b PS1, Line 182: mutex_guard &operator=(const mutex_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8e03339_5da0763a PS1, Line 182: mutex_guard &operator=(const mutex_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/701b2f6d_1cf99a77 PS1, Line 186: std::atomic<int> value; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/854190c8_6e5e987a PS1, Line 186: std::atomic<int> value; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93503d51_ba408a55 PS1, Line 186: std::atomic<int> value; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7721f677_8a237cff PS1, Line 190: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce064d68_e8213f4a PS1, Line 198: void wait() Bad function definition - void wait() should probably be void wait(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f651b64d_11bd25a4 PS1, Line 198: void wait() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2259fecb_442146bc PS1, Line 202: void wait(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fdba8b0a_00a6ad2a PS1, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/45dbaaab_da28562f PS1, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1abede98_ca99a563 PS1, Line 205: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/80952fea_25547cb1 PS1, Line 210: void wait_and_reset() Bad function definition - void wait_and_reset() should probably be void wait_and_reset(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6ea7712a_38e72f42 PS1, Line 210: void wait_and_reset() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/595bbe7b_6cfba558 PS1, Line 214: void wait_and_reset(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/157d4220_2d5c47d7 PS1, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd063074_14221f5e PS1, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cc84898d_20baf114 PS1, Line 217: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4400fd8_d06be084 PS1, Line 223: void set() Bad function definition - void set() should probably be void set(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e70912a4_4629ec31 PS1, Line 223: void set() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01aa0533_7b069011 PS1, Line 227: void set(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0282c5de_60b08046 PS1, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c5676052_f0b4fd61 PS1, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d004ea89_93e83d9c PS1, Line 230: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3d65daef_d35a76d9 PS1, Line 234: void reset_unsafe() Bad function definition - void reset_unsafe() should probably be void reset_unsafe(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/23fa7cfb_86288edb PS1, Line 234: void reset_unsafe() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6020f137_521133fd PS1, Line 238: bool check_unsafe(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8af80bdc_8687baed PS1, Line 243: sema &operator=(const sema &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/81d5d6c8_2b443de6 PS1, Line 243: sema &operator=(const sema &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/69a924e9_8b2dafd8 PS1, Line 247: sema &a; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cfbbe01d_32e26ff2 PS1, Line 248: sema &b; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/995dd13e_5957bcf1 PS1, Line 250: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a0315420_729979e4 PS1, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9c09e1ff_32fbd6cf PS1, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89c213e4_f9242f39 PS1, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/999672fc_5e31a25a PS1, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7c630848_2193cf4b PS1, Line 265: sema &a; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a74e400b_ea4b3e69 PS1, Line 266: sema &b; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/10b57a15_4a4479c4 PS1, Line 268: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afc3dd65_953719c4 PS1, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a3b06361_b9300cae PS1, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f7d5271_57395807 PS1, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9e3d3262_f923306d PS1, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d4edb02b_409eb610 PS1, Line 282: template <typename IFT> class shm { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/00a7e5a6_69b1d24d PS1, Line 282: template <typename IFT> class shm { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b18896f4_6e759e1e PS1, Line 287: int ipc_shm_setup(const char *shm_name) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1a0503dc_9dd1f393 PS1, Line 293: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) { Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29dc7ec8_e2a85cbd PS1, Line 310: shmptr = new (ptr) IFT(); //static_cast<IFT *>(ptr); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96430888_d69dbf40 PS1, Line 315: int ipc_shm_connect(const char *shm_name) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99bd7396_b995416b PS1, Line 321: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR)) < 0) { Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93482a09_4be20edf PS1, Line 339: shmptr = static_cast<IFT *>(ptr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5f50bb97_4450ea8f PS1, Line 339: shmptr = static_cast<IFT *>(ptr); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d735996c_a35a65ba PS1, Line 339: shmptr = static_cast<IFT *>(ptr); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab39457b_0ece9f1f PS1, Line 344: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7840db88_5ce8d4ca PS1, Line 348: strncpy((char *)shmname, name, 512); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b7cc284a_d9bfb239 PS1, Line 350: void create() Bad function definition - void create() should probably be void create(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a48f2fd9_8b9db6b1 PS1, Line 350: void create() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d10aa3e7_1993c519 PS1, Line 355: void open() Bad function definition - void open() should probably be void open(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/186221ff_5aa1f0ce PS1, Line 355: void open() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c2e3cabd_4e83605d PS1, Line 360: bool isgood() const Bad function definition - bool isgood() should probably be bool isgood(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/87617113_0c31b708 PS1, Line 364: void close() Bad function definition - void close() should probably be void close(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b4456f6b_48c15615 PS1, Line 364: void close() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad6daf91_32144a1e PS1, Line 369: IFT *p() Bad function definition - IFT *p() should probably be IFT *p(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fd443659_128f8239 PS1, Line 369: IFT *p() open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5 Gerrit-Change-Number: 30414 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: ms-trx support

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 1: (408 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/301ce7d7_7ed6cfc8 PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08a8afc4_5b2ba3a8 PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16f36076_513dd188 PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01bea4ec_7230dc08 PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e675d0e6_9718d66d PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5faf79a_84304375 PS1, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d908d42_6f5f60e4 PS1, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78a8f0f8_8acb2a5c PS1, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/154531ec_43bf2cde PS1, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01981329_f3ce9af4 PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9bdb9cf7_821efbf4 PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d62cfb92_211c1bd5 PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b8bdcb9_52667f40 PS1, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c4edfe7_52cefc12 PS1, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fe1db58_e9836067 PS1, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6318e05a_3dfef53f PS1, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf6dd794_9c27d17a PS1, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d9721a3_6e2ef504 PS1, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6056e394_536aaf0d PS1, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c962abe7_b164aa10 PS1, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ece88b78_e0e5d340 PS1, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c28afd41_2c4456c7 PS1, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f06d08e5_93a83bba PS1, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63189dea_e3d1bf5d PS1, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bb5aadd_f6b619ce PS1, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf012ab9_6309c48e PS1, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22a249c9_50bd86e8 PS1, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02cd1b21_7fbb7b12 PS1, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8ab72df_407feeac PS1, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ee1ccdf_2b1f1909 PS1, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/939af6a4_2bd3faf0 PS1, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1567216_e6f68775 PS1, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f6105ea_616e26f6 PS1, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/964463cd_bc433ceb PS1, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3efd1c5f_b4984842 PS1, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d8120ba_fd063611 PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82e0e1de_488c5df7 PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6008f4ec_00c212c4 PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fd6c900_8504f04f PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78132836_ee953dfb PS1, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/051277aa_a37eb15d PS1, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01769f58_01a1e64d PS1, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efaef42d_2999ba4f PS1, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a0db27b_e000b09e PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7b58e8a_e317eef3 PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81a562ef_ef4b8e0d PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28c9fe46_6c129f82 PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53cb9e14_51e8a58d PS1, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36b12ae6_46146924 PS1, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3f1ee94_8bcc0572 PS1, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85ca58f5_9d382110 PS1, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2a2315b_47c10ed6 PS1, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2314ebc0_685e4e43 PS1, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b32c82b2_39ed8ae0 PS1, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99edde0b_8692f8c3 PS1, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1166ba10_a7a7409a PS1, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31e3b4c4_f1eabc7a PS1, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f40f8255_59b4032c PS1, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb22ab73_89802fee PS1, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9baee26d_ccd18a3a PS1, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80dc2994_8f4c8263 PS1, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8de2500_2077d78b PS1, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a799672_df328cf9 PS1, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59f92ec7_5e6e79da PS1, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e6d41f75_7ec4f481 PS1, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab4a0d97_0588984c PS1, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8110999_33b766d0 PS1, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/195b14fa_d79e36d2 PS1, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9773256d_6a1e9558 PS1, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e75d2bb_3626816b PS1, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05f36874_985c3bd0 PS1, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6aa3c78e_119ba458 PS1, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/573e0a61_ba791209 PS1, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b2d90d2e_d49ff7bf PS1, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71208f5e_a2f62333 PS1, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f377375_694adc76 PS1, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f089d25_ec2a22df PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f287a6d_69d65a2a PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/09dbe486_e5c9f1e3 PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e8ca0784_f15328d8 PS1, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a991272f_7f9c64fb PS1, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9053bb89_aac2f11d PS1, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4de598a_3094df6a PS1, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcc4ecf9_a88fde9c PS1, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14cd08b2_8411d9cb PS1, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76303387_3fcf4894 PS1, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/149efb8c_a7d66365 PS1, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4ebe99d_7f028b9f PS1, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6eb53714_f95a6f41 PS1, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cbdd29d5_2025ad77 PS1, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3dd9e8a7_b78dadb8 PS1, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd5d26d4_3b495644 PS1, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/521602c2_c630e488 PS1, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f6ae613_ab4da7df PS1, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30b84aeb_5cda4ea7 PS1, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/174ad80b_de954a6a PS1, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a20ad618_fa1c6192 PS1, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20b1d771_b671fdd8 PS1, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f54cab92_218d1e0b PS1, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58ee0d83_a0ca2729 PS1, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ecf1219_d61b1067 PS1, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3c379c0_45f13802 PS1, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e310768_126066e9 PS1, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bda9e2f_b43cef6b PS1, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47ca03f3_efc013a3 PS1, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1567cc5e_7c6f90b5 PS1, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63aab3aa_eb97a5b4 PS1, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa56d10f_03ae9cf5 PS1, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/545e5612_aaf912c3 PS1, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08fd9bc4_2fb9d25a PS1, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25cb3aa6_d6683eb8 PS1, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14fac554_de2c2187 PS1, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9db1e49a_ea6fe9d4 PS1, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/ipc_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c54bbdf6_d4cdeb06 PS1, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daf18400_2bed079c PS1, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e22466e9_0769f938 PS1, Line 45: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e54dab24_2d28d3db PS1, Line 45: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0afc2910_b9eab8c8 PS1, Line 49: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/466329d2_bafb9e77 PS1, Line 49: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56feb6f9_d962ea9a PS1, Line 53: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f23088c8_f7a8757a PS1, Line 58: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b7e6417_609ce6e0 PS1, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db770060_9d26b5d4 PS1, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/691248ab_6fe4bddd PS1, Line 71: template <typename T> struct ipc_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44b9787b_5bbce496 PS1, Line 71: template <typename T> struct ipc_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80aa389c_e1406a4f PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6a19bcc_3e60def3 PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37d938aa_aa1898b3 PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb7b1257_2acce708 PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c75148b7_56fa1bd2 PS1, Line 92: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ffa89cb7_f7f058b4 PS1, Line 99: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7d55c422_a3be8e50 PS1, Line 106: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f39a0a03_78f9706f PS1, Line 111: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2fd44612_70f63f64 PS1, Line 119: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9315089b_76fd5027 PS1, Line 127: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a6e065d_07da1742 PS1, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f9b607a_f3f9f282 PS1, Line 137: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d17e052_5c95c31e PS1, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75764492_cbd4b50d PS1, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3d69e3c_2e5f84d1 PS1, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a19c76a_be13c44b PS1, Line 166: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6b9df0_58f5c06a PS1, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb923f6b_6e18e1ea PS1, Line 177: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05c7bf4e_5ef5ea00 PS1, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86894aa3_698fbb39 PS1, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a39540d_7992d228 PS1, Line 193: void signal_start() Bad function definition - void signal_start() should probably be void signal_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/beab08b0_65c5e97e PS1, Line 193: void signal_start() open brace '{' following function definitions go on the next line File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a40b1748_e9aeafb8 PS1, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf58fb03_4671cd1d PS1, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efb5b464_6d81a601 PS1, Line 52: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b9af9f8_b6615fe6 PS1, Line 53: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63ace79c_56b17246 PS1, Line 54: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/192ee704_54eb2b0e PS1, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d51d3ccf_1d47342d PS1, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e52fe76_801f2d65 PS1, Line 65: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/472302d0_59b7a8b0 PS1, Line 65: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0d76b57_36c4a98d PS1, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7e365ea_635201f2 PS1, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc0265fd_3dd08d08 PS1, Line 67: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ecc82fbe_a0eb1403 PS1, Line 73: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25c38939_4f8c7beb PS1, Line 73: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18e8412b_e65d2f31 PS1, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8616ff9f_553740c9 PS1, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb8f3d1c_03c86f0e PS1, Line 75: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c89dac6_b2c1ca27 PS1, Line 81: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9aaba957_d3160e5f PS1, Line 81: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7795df8_16d48f24 PS1, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3786239_1f8f5e35 PS1, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b57715ee_68fbdb6a PS1, Line 83: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1c47424_1ff2e83d PS1, Line 87: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e81bdba3_6f2be5fa PS1, Line 87: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8dc3426a_275a3870 PS1, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78ed56bb_2cf51434 PS1, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3459026_207c06ac PS1, Line 89: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/abc3dabb_9fbc75ea PS1, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05284692_ea8ea07f PS1, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e79ca070_8187c70f PS1, Line 99: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/597f2530_557ca964 PS1, Line 100: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1498c20_ad3e294f PS1, Line 111: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9be71eb_027f43b3 PS1, Line 111: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32796c89_19706f34 PS1, Line 116: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d8a04bd_b4735503 PS1, Line 116: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e766b06_09664752 PS1, Line 121: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/634adde1_8f337d61 PS1, Line 121: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47a6e82e_5e696a25 PS1, Line 126: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfb5eeba_28410b4e PS1, Line 126: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f435ccf3_c56467fc PS1, Line 131: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9249a9c_5ddc9c44 PS1, Line 131: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c48de86e_dbe7f5bf PS1, Line 135: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c8c731e_05308e1d PS1, Line 135: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9721164e_d5ed5b39 PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/079a3f73_233d02bf PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28806554_53dcc5ba PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/702271f9_353206e8 PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7aaa8c5_73b12601 PS1, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99493986_53707b94 PS1, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e120f5e1_1f726d8d PS1, Line 144: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d34b077d_291a6d7b PS1, Line 144: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5961918_7982c4e4 PS1, Line 144: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7dd54bef_600af7ac PS1, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7d0b0481_9a8c641e PS1, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc79892b_c5365fac PS1, Line 145: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c535969_2ec0d346 PS1, Line 149: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16e8844f_8e97353c PS1, Line 150: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fe2bc7d_0f9e003a PS1, Line 150: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/305ce30f_8f70a680 PS1, Line 152: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56737532_d05bfc8a PS1, Line 163: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6b04f7_469b17b9 PS1, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b83b97ee_892c276f PS1, Line 176: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71f9b123_cbbecd2a PS1, Line 183: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b80b366_e2b56d3f PS1, Line 195: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3043ddd_dc9801a1 PS1, Line 202: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4299147_3f6cba0e PS1, Line 202: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3454dde2_151969dc PS1, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c08a57a9_61392d71 PS1, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4993ba93_f02177fd PS1, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fdbbd050_9a1c24e5 PS1, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/15a8fb04_4e3bd526 PS1, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fc6db9c_1a0aa9b9 PS1, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cde2496_56afe477 PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35b6ce23_e973a6df PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78d7f45f_56d9f026 PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/logging.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58c0929e_df0ee555 PS1, Line 83: .enabled = 0, trailing whitespace File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d65ecbf8_d8376c7b PS1, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d39d9f27_d057b972 PS1, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/41a86583_973a21ae PS1, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e72dde31_db26f166 PS1, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df6b1bde_2c32d5d6 PS1, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d139ca74_0208ec25 PS1, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec87ccbe_9a214938 PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dfcc88f7_a74109cc PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f34dfc8_cb6137b8 PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/935c1713_b3ab6a52 PS1, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79e68de3_a992c7ea PS1, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd3e5b7a_54045c3f PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8394694_12b06794 PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d076a1d5_d1529c37 PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aae9ce48_d916d378 PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6499b796_7a43c2dd PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d21e3e47_71098a72 PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c88434a5_56af990a PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18da3d8b_d478c0fd PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44e72462_eca7d6ef PS1, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f501fa47_666e4273 PS1, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/64d83cde_dd7b4229 PS1, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc376c22_743b138a PS1, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/215d7852_373306e5 PS1, Line 75: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ff77589_9618d4c7 PS1, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8be4f8d_0ca85f71 PS1, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04a95bba_e4d28e0a PS1, Line 87: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27aff2c7_d975e140 PS1, Line 89: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a9d17a6_5942e9e5 PS1, Line 90: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a49bd9f9_d80107e8 PS1, Line 92: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19fdc277_761b7e19 PS1, Line 92: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ceac5ba1_4c895bfd PS1, Line 104: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03e2889e_9e2d54d2 PS1, Line 106: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9a60dd8_b04b4a44 PS1, Line 108: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a7bc769_ef60a158 PS1, Line 113: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/873483ae_dccf9053 PS1, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b69d80a4_978c49f8 PS1, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87c52991_b77df29b PS1, Line 115: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b137272_6db2b612 PS1, Line 119: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/454a7caf_5da9472c PS1, Line 119: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efc9b098_7bb34677 PS1, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42c29045_751d8254 PS1, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e655276f_b4fa02f6 PS1, Line 121: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcf9df63_1ebf32e9 PS1, Line 125: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e18186c_a4619166 PS1, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f94053bf_7d33d025 PS1, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7799adbd_b1473cfd PS1, Line 127: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48375d69_29d5e966 PS1, Line 132: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82d3b2c2_acd4f8b2 PS1, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b9a470c6_3ed35c52 PS1, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e116a931_c5dad632 PS1, Line 134: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/083ebfa3_43edb5f3 PS1, Line 142: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44f97cd9_9b3a3442 PS1, Line 142: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86c34a2a_4d61a9eb PS1, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c05abb3e_af917fb5 PS1, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8046fd7_16ea16ee PS1, Line 144: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/584e27f5_35d7917c PS1, Line 148: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4853b4c9_c236d8ae PS1, Line 148: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/767ee6a6_b921d194 PS1, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e43f29ce_da3ead7c PS1, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/370bb821_67accdcf PS1, Line 150: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/94073af6_8d8236fa PS1, Line 153: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1101986_18019820 PS1, Line 153: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/12a8413c_7ffbfbb2 PS1, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60621d30_673401e6 PS1, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3eb5ac7_e6140418 PS1, Line 155: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/499d4927_9d705bdb PS1, Line 158: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3de5e2b6_ec4766e3 PS1, Line 158: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b375110_6df9083f PS1, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e3760e1_ae2f7b53 PS1, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82255939_8eb3d8e8 PS1, Line 160: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80c6c57b_cf59499b PS1, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f541de2_fadc0f76 PS1, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f031d52_44e76319 PS1, Line 176: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/616999b9_7d2882b0 PS1, Line 177: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cbd69a0_75cd13e3 PS1, Line 178: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5504c484_a550396d PS1, Line 178: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c0ef1ab_c9091643 PS1, Line 189: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f89b471_26bbc774 PS1, Line 189: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23077ac2_968434a0 PS1, Line 189: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/591305be_a83102aa PS1, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1dee4091_864b6e01 PS1, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1223e246_e4152e6e PS1, Line 190: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/925f126b_54dfd381 PS1, Line 197: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19d6c92e_31f71adc PS1, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/deeb7108_8c37f669 PS1, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1b08c2ef_837e7a81 PS1, Line 198: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f217aa7_b1dc2fe7 PS1, Line 201: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7d33626_0ed06c08 PS1, Line 207: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/965dac1a_30824d87 PS1, Line 208: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/67805988_665e05fa PS1, Line 209: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44d50bf2_5149fa16 PS1, Line 211: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/381a128c_7e83dcbb PS1, Line 212: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c13b9979_e8e86a4c PS1, Line 225: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad808354_f86047e5 PS1, Line 226: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60a2ad9d_c5f6d991 PS1, Line 229: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf418435_bbf337ae PS1, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83b1961e_6f811538 PS1, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c5183d2_c2df9c6b PS1, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/801d5967_6774036d PS1, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c56c7cc_7fa218ab PS1, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7213c8f_edc77838 PS1, Line 44: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f06cbdcf_c0dc974f PS1, Line 45: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3cfdc50_42432fb3 PS1, Line 46: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af574952_68c5ab1a PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7e5a58d_eb955538 PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a1cea60e_5d2e21b3 PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48741846_45c4d958 PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83e3fb27_0b4e5b29 PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b94c85e1_52fd85bc PS1, Line 50: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/455cb909_eabbcc02 PS1, Line 52: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e67088d9_69e1dccb PS1, Line 53: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bc68e2d_7259925d PS1, Line 54: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61211e94_6dd40260 PS1, Line 56: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/443eed6e_9706ba60 PS1, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/125adda5_fb3963f0 PS1, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9352bb4b_4be9805a PS1, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f275701b_8fba1c0d PS1, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f6defda_fabd227a PS1, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a340882_2f3bfee6 PS1, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/654de55d_8ba7a168 PS1, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/561454a4_ae39c6ba PS1, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11fca725_2be43cf7 PS1, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5683fa52_0d94b7b6 PS1, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bd3bd59_6d216316 PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5610906_ac7aee74 PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6ee80b5d_9239c3c2 PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/732121ab_9ecc6408 PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b43028c_59b07a90 PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/77c0945a_25d8c39d PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8dc9e9f_7ccd5f21 PS1, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d08b327a_9f8b7b2c PS1, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb2cf9c1_2ae6e05c PS1, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b26fec6_360059e4 PS1, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/94cda8ec_519594ab PS1, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/413b8ea4_d5889f9d PS1, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ddea827_cf4c8b35 PS1, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/848f2347_92c71b88 PS1, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/57ccc6fc_1d2c0ddd PS1, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc70be74_28c9067c PS1, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/09971353_e75781c8 PS1, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c278d934_928a93b9 PS1, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d67521a_f2a981f0 PS1, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/637f711c_332bbaa4 PS1, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3261757c_e2608a3a PS1, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f222fdfe_04b7ab37 PS1, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f2e0bff_55255261 PS1, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f719c36c_eedc9d24 PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c0868317_7a81547c PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f6bb05f_982f250a PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0acc953_ae9e35b3 PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a90de279_f6609c98 PS1, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6a75ba3_3383e88f PS1, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/314b1835_9e689fe6 PS1, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9748f253_40f167a0 PS1, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f8e216c_3b3c0b4c PS1, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/096aaaf1_ba77b8be PS1, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/824eab77_c6bc3e68 PS1, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/474c972a_6a419c16 PS1, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9439b519_ec31eef5 PS1, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79def50a_00a498a1 PS1, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7517389a_cfc54473 PS1, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/412385d4_b19b17be PS1, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c92c8e7a_41d13972 PS1, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17c4a48c_746015e4 PS1, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a4a0234e_a2c96c33 PS1, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74376215_85e3f7a0 PS1, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a73375dc_dff67b05 PS1, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfb4eb24_3af1105e PS1, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1e88918_6b8dcda2 PS1, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d5e215b_1a083e50 PS1, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/055c876c_4b8756b2 PS1, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b05aa8bf_58b9bd3f PS1, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/606a84e7_809d91c3 PS1, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/270d661e_e7c27982 PS1, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7cb63d98_67d20081 PS1, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2daa4ac5_88f74c48 PS1, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18dfb3e0_9ca9aaa1 PS1, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab5d0165_f821b4ed PS1, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3edc6ee2_b42f5263 PS1, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/481e9f1b_787d70a5 PS1, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff1995f3_4e0ced24 PS1, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a660f80_6cdd329b PS1, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/64a23066_d5d2cbc0 PS1, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3680243_929f7ba0 PS1, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

Change in osmo-trx[master]: vita demod by piotr krysik, modified

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 ) Change subject: vita demod by piotr krysik, modified ...................................................................... vita demod by piotr krysik, modified Had a few rounds of extensive cleanup. Uses gcc multiversioning for x86 targets. Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f --- A Transceiver52M/grgsm_vitac/constants.h A Transceiver52M/grgsm_vitac/grgsm_vitac.cpp A Transceiver52M/grgsm_vitac/grgsm_vitac.h A Transceiver52M/grgsm_vitac/viterbi_detector.cc A Transceiver52M/grgsm_vitac/viterbi_detector.h 5 files changed, 959 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/15/30415/1 diff --git a/Transceiver52M/grgsm_vitac/constants.h b/Transceiver52M/grgsm_vitac/constants.h new file mode 100644 index 0000000..0bcfd59 --- /dev/null +++ b/Transceiver52M/grgsm_vitac/constants.h @@ -0,0 +1,142 @@ +#pragma once +/* -*- c++ -*- */ +/* + * @file + * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> + * @section LICENSE + * + * Gr-gsm is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 3, or (at your option) + * any later version. + * + * Gr-gsm is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with gr-gsm; see the file COPYING. If not, write to + * the Free Software Foundation, Inc., 51 Franklin Street, + * Boston, MA 02110-1301, USA. + */ + +#include <complex> + +#define gr_complex std::complex<float> + + +#define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second +#define GSM_SYMBOL_PERIOD (1.0/GSM_SYMBOL_RATE) //seconds per symbol + +//Burst timing +#define TAIL_BITS 3 +#define GUARD_BITS 8 +#define GUARD_FRACTIONAL 0.25 //fractional part of guard period +#define GUARD_PERIOD GUARD_BITS + GUARD_FRACTIONAL +#define DATA_BITS 57 //size of 1 data block in normal burst +#define STEALING_BIT 1 +#define N_TRAIN_BITS 26 +#define N_SYNC_BITS 64 +#define USEFUL_BITS 142 //(2*(DATA_BITS+STEALING_BIT) + N_TRAIN_BITS ) +#define FCCH_BITS USEFUL_BITS +#define BURST_SIZE (USEFUL_BITS+2*TAIL_BITS) +#define ACCESS_BURST_SIZE 88 +#define PROCESSED_CHUNK BURST_SIZE+2*GUARD_PERIOD + +#define SCH_DATA_LEN 39 +#define TS_BITS (TAIL_BITS+USEFUL_BITS+TAIL_BITS+GUARD_BITS) //a full TS (156 bits) +#define TS_PER_FRAME 8 +#define FRAME_BITS (TS_PER_FRAME * TS_BITS + 2) // 156.25 * 8 +#define FCCH_POS TAIL_BITS +#define SYNC_POS (TAIL_BITS + 39) +#define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence + //aren't used for channel impulse response estimation +#define TRAIN_BEGINNING 5 +#define SAFETY_MARGIN 6 // + +#define FCCH_HITS_NEEDED (USEFUL_BITS - 4) +#define FCCH_MAX_MISSES 1 +#define FCCH_MAX_FREQ_OFFSET 100 + +#define CHAN_IMP_RESP_LENGTH 5 + +#define MAX_SCH_ERRORS 10 //maximum number of subsequent sch errors after which gsm receiver goes to find_next_fcch state + +typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; +typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; + +static const unsigned char SYNC_BITS[] = { + 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, + 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, + 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, + 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 +}; + +const unsigned FCCH_FRAMES[] = { 0, 10, 20, 30, 40 }; +const unsigned SCH_FRAMES[] = { 1, 11, 21, 31, 41 }; + +const unsigned BCCH_FRAMES[] = { 2, 3, 4, 5 }; //!!the receiver shouldn't care about logical + //!!channels so this will be removed from this header +const unsigned TEST_CCH_FRAMES[] = { 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39, 42, 43, 44, 45, 46, 47, 48, 49 }; +const unsigned TRAFFIC_CHANNEL_F[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24 }; +const unsigned TEST51[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 }; + + +#define TSC0 0 +#define TSC1 1 +#define TSC2 2 +#define TSC3 3 +#define TSC4 4 +#define TSC5 5 +#define TSC6 6 +#define TSC7 7 +#define TS_DUMMY 8 + +#define TRAIN_SEQ_NUM 9 + +#define TIMESLOT0 0 +#define TIMESLOT1 1 +#define TIMESLOT2 2 +#define TIMESLOT3 3 +#define TIMESLOT4 4 +#define TIMESLOT5 5 +#define TIMESLOT6 6 +#define TIMESLOT7 7 + + +static const unsigned char train_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS] = { + {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, + {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, + {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, + {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, + {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, + {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, + {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, + {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, + {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY +}; + + +//Dummy burst 0xFB 76 0A 4E 09 10 1F 1C 5C 5C 57 4A 33 39 E9 F1 2F A8 +static const unsigned char dummy_burst[] = { + 0, 0, 0, + 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, + 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, + 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, + 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, + 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, + 0, 1, 1, 1, 1, 1, 0, 0, + + 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, + 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, + 0, 0, 0, 1, 0, 1, + + 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, + 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, + 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, + 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, + 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, + 1, 1, 1, 0, 1, 0, 1, 0, + 0, 0, 0 +}; diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp new file mode 100644 index 0000000..aa2ab6f --- /dev/null +++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp @@ -0,0 +1,299 @@ +/* -*- c++ -*- */ +/* + * @file + * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> + * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild <ewild(a)sysmocom.de> + * @section LICENSE + * + * Gr-gsm is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 3, or (at your option) + * any later version. + * + * Gr-gsm is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with gr-gsm; see the file COPYING. If not, write to + * the Free Software Foundation, Inc., 51 Franklin Street, + * Boston, MA 02110-1301, USA. + */ + +#include "constants.h" + +#ifdef HAVE_CONFIG_H +#include "config.h" +#endif +#include <complex> + + +#include <algorithm> +#include <string.h> +#include <iostream> +#include <numeric> +#include <vector> +#include <fstream> + +#include "viterbi_detector.h" +#include "grgsm_vitac.h" + +//signalVector mChanResp; +gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst +gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst +const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH; + +void initvita() { + + /** + * Prepare SCH sequence bits + * + * (TS_BITS + 2 * GUARD_PERIOD) + * Burst and two guard periods + * (one guard period is an arbitrary overlap) + */ + gmsk_mapper(SYNC_BITS, N_SYNC_BITS, + d_sch_training_seq, gr_complex(0.0, -1.0)); + for (auto &i : d_sch_training_seq) + i = conj(i); + + /* Prepare bits of training sequences */ + for (int i = 0; i < TRAIN_SEQ_NUM; i++) { + /** + * If first bit of the sequence is 0 + * => first symbol is 1, else -1 + */ + gr_complex startpoint = train_seq[i][0] == 0 ? + gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0); + gmsk_mapper(train_seq[i], N_TRAIN_BITS, + d_norm_training_seq[i], startpoint); + for (auto &i : d_norm_training_seq[i]) + i = conj(i); + } + +} + +MULTI_VER_TARGET_ATTR +void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) +{ + std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR); + unsigned int stop_states[2] = { 4, 12 }; + gr_complex filtered_burst[BURST_SIZE]; + gr_complex rhh[CHAN_IMP_RESP_LENGTH]; + float output[BURST_SIZE]; + int start_state = 3; + + // if(burst_start < 0 ||burst_start > 10) + // fprintf(stderr, "bo %d\n", burst_start); + + // burst_start = burst_start >= 0 ? burst_start : 0; + + autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR); + for (int ii = 0; ii < d_chan_imp_length; ii++) + rhh[ii] = conj(rhh_temp[ii * d_OSR]); + + mafi(&input[burst_start], BURST_SIZE, chan_imp_resp, + d_chan_imp_length * d_OSR, filtered_burst); + + viterbi_detector(filtered_burst, BURST_SIZE, rhh, + start_state, stop_states, 2, output); + + for (int i = 0; i < BURST_SIZE; i++) + output_binary[i] = output[i] * -127; // pre flip bits! +} + +void +gmsk_mapper(const unsigned char* input, + int nitems, gr_complex* gmsk_output, gr_complex start_point) +{ + gr_complex j = gr_complex(0.0, 1.0); + gmsk_output[0] = start_point; + + int previous_symbol = 2 * input[0] - 1; + int current_symbol; + int encoded_symbol; + + for (int i = 1; i < nitems; i++) { + /* Change bits representation to NRZ */ + current_symbol = 2 * input[i] - 1; + + /* Differentially encode */ + encoded_symbol = current_symbol * previous_symbol; + + /* And do GMSK mapping */ + gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0) + * gmsk_output[i - 1]; + + previous_symbol = current_symbol; + } +} + +gr_complex +correlate_sequence(const gr_complex* sequence, + int length, const gr_complex* input) +{ + gr_complex result(0.0, 0.0); + + for (int ii = 0; ii < length; ii++) + result += sequence[ii] * input[ii * d_OSR]; + + return conj(result) / gr_complex(length, 0); +} + +/* Computes autocorrelation for positive arguments */ +inline void +autocorrelation(const gr_complex* input, + gr_complex* out, int nitems) +{ + for (int k = nitems - 1; k >= 0; k--) { + out[k] = gr_complex(0, 0); + for (int i = k; i < nitems; i++) + out[k] += input[i] * conj(input[i - k]); + } +} + +inline void +mafi(const gr_complex* input, int nitems, + gr_complex* filter, int filter_length, gr_complex* output) +{ + for (int n = 0; n < nitems; n++) { + int a = n * d_OSR; + output[n] = 0; + + for (int ii = 0; ii < filter_length; ii++) { + if ((a + ii) >= nitems * d_OSR) + break; + + output[n] += input[a + ii] * filter[ii]; + } + } +} + +int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos, + int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max) +{ + std::vector<gr_complex> correlation_buffer; + std::vector<float> window_energy_buffer; + std::vector<float> power_buffer; + + for (int ii = search_start_pos; ii < search_stop_pos; ii++) { + gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]); + correlation_buffer.push_back(correlation); + power_buffer.push_back(std::pow(abs(correlation), 2)); + } + + int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin(); + + /* Compute window energies */ + auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR; + window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range.. + auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR; + auto iter = power_buffer.begin() + window_energy_start_offset; + auto iter_end = power_buffer.begin() + window_energy_end_offset; + while (iter != iter_end) { + std::vector<float>::iterator iter_ii = iter; + bool loop_end = false; + float energy = 0; + + int len = d_chan_imp_length * d_OSR; + for (int ii = 0; ii < len; ii++, iter_ii++) { + if (iter_ii == power_buffer.end()) { + loop_end = true; + break; + } + + energy += (*iter_ii); + } + + if (loop_end) + break; + + window_energy_buffer.push_back(energy); + iter++; + } + + /* Calculate the strongest window number */ + int strongest_window_nr = window_energy_start_offset + + max_element(window_energy_buffer.begin(), window_energy_buffer.end()) - + window_energy_buffer.begin(); + + // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR; + // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR; + // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end; + + // /* Calculate the strongest window number */ + // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin(); + + // if (strongest_window_nr < 0) + // strongest_window_nr = 0; + + float max_correlation = 0; + for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) { + gr_complex correlation = correlation_buffer[strongest_window_nr + ii]; + if (abs(correlation) > max_correlation) + max_correlation = abs(correlation); + chan_imp_resp[ii] = correlation; + } + + *corr_max = max_correlation; + + /** + * Compute first sample position, which corresponds + * to the first sample of the impulse response + */ + return search_start_pos + strongest_window_nr - search_center * d_OSR; +} + +/* + +3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25 + +search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split) +this is +-5 samples around (+5 beginning) of truncated t16 tsc + +*/ +int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc) +{ + const int search_center = TRAIN_POS; + const int search_start_pos = (search_center - 5) * d_OSR + 1; + const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR; + const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING]; + const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING); + return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, + corr_max); +} + +/* + +3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard +start 3+39 - 10 +end 3+39 + SYNC_SEARCH_RANGE + +*/ +int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp) +{ + const int search_center = SYNC_POS + TRAIN_BEGINNING; + const int search_start_pos = (search_center - 10) * d_OSR; + const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR; + const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; + const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); + + // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ; + float corr_max; + return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, + &corr_max); +} + +int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max) +{ + const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); + const int search_center = SYNC_POS + TRAIN_BEGINNING; + const int search_start_pos = 0; + // FIXME: proper end offset + const int search_stop_pos = len - (N_SYNC_BITS*8); + auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; + + return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, + corr_max); +} \ No newline at end of file diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.h b/Transceiver52M/grgsm_vitac/grgsm_vitac.h new file mode 100644 index 0000000..41fe4b6 --- /dev/null +++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.h @@ -0,0 +1,62 @@ +#pragma once +/* -*- c++ -*- */ +/* + * @file + * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> + * @section LICENSE + * + * Gr-gsm is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 3, or (at your option) + * any later version. + * + * Gr-gsm is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with gr-gsm; see the file COPYING. If not, write to + * the Free Software Foundation, Inc., 51 Franklin Street, + * Boston, MA 02110-1301, USA. + */ + +#include <vector> +#include "constants.h" + +#if defined(__has_attribute) +#if __has_attribute(target_clones) && defined(__x86_64) && true +#define MULTI_VER_TARGET_ATTR __attribute__((target_clones("avx", "sse4.2", "sse3", "sse2", "sse", "default"))) +#else +#define MULTI_VER_TARGET_ATTR +#endif +#endif + +#define SYNC_SEARCH_RANGE 30 +const int d_OSR(4); + +void initvita(); + +int process_vita_burst(gr_complex *input, int tsc, unsigned char *output_binary); +int process_vita_sc_burst(gr_complex *input, int tsc, unsigned char *output_binary, int *offset); + +MULTI_VER_TARGET_ATTR +void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary); +void gmsk_mapper(const unsigned char *input, int nitems, gr_complex *gmsk_output, gr_complex start_point); +gr_complex correlate_sequence(const gr_complex *sequence, int length, const gr_complex *input); +inline void autocorrelation(const gr_complex *input, gr_complex *out, int nitems); +inline void mafi(const gr_complex *input, int nitems, gr_complex *filter, int filter_length, gr_complex *output); +int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp); +int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc); +int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max); + +enum class btype { NB, SCH }; +struct fdata { + btype t; + unsigned int fn; + int tn; + int bcc; + std::string fpath; + std::vector<gr_complex> data; + unsigned int data_start_offset; +}; \ No newline at end of file diff --git a/Transceiver52M/grgsm_vitac/viterbi_detector.cc b/Transceiver52M/grgsm_vitac/viterbi_detector.cc new file mode 100644 index 0000000..beee386 --- /dev/null +++ b/Transceiver52M/grgsm_vitac/viterbi_detector.cc @@ -0,0 +1,392 @@ +/* -*- c++ -*- */ +/* + * @file + * @author (C) 2009 by Piotr Krysik <ptrkrysik(a)gmail.com> + * @section LICENSE + * + * Gr-gsm is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 3, or (at your option) + * any later version. + * + * Gr-gsm is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with gr-gsm; see the file COPYING. If not, write to + * the Free Software Foundation, Inc., 51 Franklin Street, + * Boston, MA 02110-1301, USA. + */ + +/* + * viterbi_detector: + * This part does the detection of received sequnece. + * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. + * At this moment it gives hard decisions on the output, but + * it was designed with soft decisions in mind. + * + * SYNTAX: void viterbi_detector( + * const gr_complex * input, + * unsigned int samples_num, + * gr_complex * rhh, + * unsigned int start_state, + * const unsigned int * stop_states, + * unsigned int stops_num, + * float * output) + * + * INPUT: input: Complex received signal afted matched filtering. + * samples_num: Number of samples in the input table. + * rhh: The autocorrelation of the estimated channel + * impulse response. + * start_state: Number of the start point. In GSM each burst + * starts with sequence of three bits (0,0,0) which + * indicates start point of the algorithm. + * stop_states: Table with numbers of possible stop states. + * stops_num: Number of possible stop states + * + * + * OUTPUT: output: Differentially decoded hard output of the algorithm: + * -1 for logical "0" and 1 for logical "1" + * + * SUB_FUNC: none + * + * TEST(S): Tested with real world normal burst. + */ + +#include "constants.h" +#include <cmath> + +#define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1)) + +void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output) +{ + float increment[8]; + float path_metrics1[16]; + float path_metrics2[16]; + float paths_difference; + float * new_path_metrics; + float * old_path_metrics; + float * tmp; + float trans_table[BURST_SIZE][16]; + float pm_candidate1, pm_candidate2; + bool real_imag; + float input_symbol_real, input_symbol_imag; + unsigned int i, sample_nr; + +/* +* Setup first path metrics, so only state pointed by start_state is possible. +* Start_state metric is equal to zero, the rest is written with some very low value, +* which makes them practically impossible to occur. +*/ + for(i=0; i<PATHS_NUM; i++){ + path_metrics1[i]=(-10e30); + } + path_metrics1[start_state]=0; + +/* +* Compute Increment - a table of values which does not change for subsequent input samples. +* Increment is table of reference levels for computation of branch metrics: +* branch metric = (+/-)received_sample (+/-) reference_level +*/ + increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); + increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); + increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); + increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); + increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); + increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); + increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); + increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); + + +/* +* Computation of path metrics and decisions (Add-Compare-Select). +* It's composed of two parts: one for odd input samples (imaginary numbers) +* and one for even samples (real numbers). +* Each part is composed of independent (parallelisable) statements like +* this one: +* pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; +* pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; +* paths_difference=pm_candidate2-pm_candidate1; +* new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; +* trans_table[sample_nr][1] = paths_difference; +* This is very good point for optimisations (SIMD or OpenMP) as it's most time +* consuming part of this function. +*/ + sample_nr=0; + old_path_metrics=path_metrics1; + new_path_metrics=path_metrics2; + while(sample_nr<samples_num){ + //Processing imag states + real_imag=1; + input_symbol_imag = input[sample_nr].imag(); + + pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2]; + pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][0] = paths_difference; + + pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; + pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][1] = paths_difference; + + pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3]; + pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][2] = paths_difference; + + pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3]; + pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][3] = paths_difference; + + pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0]; + pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][4] = paths_difference; + + pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0]; + pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][5] = paths_difference; + + pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1]; + pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][6] = paths_difference; + + pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1]; + pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][7] = paths_difference; + + pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6]; + pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][8] = paths_difference; + + pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6]; + pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][9] = paths_difference; + + pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7]; + pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][10] = paths_difference; + + pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7]; + pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][11] = paths_difference; + + pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4]; + pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][12] = paths_difference; + + pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4]; + pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][13] = paths_difference; + + pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5]; + pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][14] = paths_difference; + + pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5]; + pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][15] = paths_difference; + tmp=old_path_metrics; + old_path_metrics=new_path_metrics; + new_path_metrics=tmp; + + sample_nr++; + if(sample_nr==samples_num) + break; + + //Processing real states + real_imag=0; + input_symbol_real = input[sample_nr].real(); + + pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7]; + pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][0] = paths_difference; + + pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7]; + pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][1] = paths_difference; + + pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6]; + pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][2] = paths_difference; + + pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6]; + pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][3] = paths_difference; + + pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5]; + pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][4] = paths_difference; + + pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5]; + pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][5] = paths_difference; + + pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4]; + pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][6] = paths_difference; + + pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4]; + pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][7] = paths_difference; + + pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3]; + pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][8] = paths_difference; + + pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3]; + pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][9] = paths_difference; + + pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2]; + pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][10] = paths_difference; + + pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2]; + pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][11] = paths_difference; + + pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1]; + pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][12] = paths_difference; + + pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1]; + pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][13] = paths_difference; + + pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0]; + pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][14] = paths_difference; + + pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0]; + pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7]; + paths_difference=pm_candidate2-pm_candidate1; + new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; + trans_table[sample_nr][15] = paths_difference; + + tmp=old_path_metrics; + old_path_metrics=new_path_metrics; + new_path_metrics=tmp; + + sample_nr++; + } + +/* +* Find the best from the stop states by comparing their path metrics. +* Not every stop state is always possible, so we are searching in +* a subset of them. +*/ + unsigned int best_stop_state; + float stop_state_metric, max_stop_state_metric; + best_stop_state = stop_states[0]; + max_stop_state_metric = old_path_metrics[best_stop_state]; + for(i=1; i< stops_num; i++){ + stop_state_metric = old_path_metrics[stop_states[i]]; + if(stop_state_metric > max_stop_state_metric){ + max_stop_state_metric = stop_state_metric; + best_stop_state = stop_states[i]; + } + } + +/* +* This table was generated with hope that it gives a litle speedup during +* traceback stage. +* Received bit is related to the number of state in the trellis. +* I've numbered states so their parity (number of ones) is related +* to a received bit. +*/ + static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, }; + +/* +* Table of previous states in the trellis diagram. +* For GMSK modulation every state has two previous states. +* Example: +* previous_state_nr1 = prev_table[current_state_nr][0] +* previous_state_nr2 = prev_table[current_state_nr][1] +*/ + static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, }; + +/* +* Traceback and differential decoding of received sequence. +* Decisions stored in trans_table are used to restore best path in the trellis. +*/ + sample_nr=samples_num; + unsigned int state_nr=best_stop_state; + unsigned int decision; + bool out_bit=0; + + while(sample_nr>0){ + sample_nr--; + decision = (trans_table[sample_nr][state_nr]>0); + + if(decision != out_bit) + output[sample_nr]=-trans_table[sample_nr][state_nr]; + else + output[sample_nr]=trans_table[sample_nr][state_nr]; + + out_bit = out_bit ^ real_imag ^ parity_table[state_nr]; + state_nr = prev_table[state_nr][decision]; + real_imag = !real_imag; + } +} diff --git a/Transceiver52M/grgsm_vitac/viterbi_detector.h b/Transceiver52M/grgsm_vitac/viterbi_detector.h new file mode 100644 index 0000000..2595343 --- /dev/null +++ b/Transceiver52M/grgsm_vitac/viterbi_detector.h @@ -0,0 +1,64 @@ +/* -*- c++ -*- */ +/* + * @file + * @author (C) 2009 Piotr Krysik <ptrkrysik(a)gmail.com> + * @section LICENSE + * + * Gr-gsm is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 3, or (at your option) + * any later version. + * + * Gr-gsm is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with gr-gsm; see the file COPYING. If not, write to + * the Free Software Foundation, Inc., 51 Franklin Street, + * Boston, MA 02110-1301, USA. + */ + +/* + * viterbi_detector: + * This part does the detection of received sequnece. + * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. + * At this moment it gives hard decisions on the output, but + * it was designed with soft decisions in mind. + * + * SYNTAX: void viterbi_detector( + * const gr_complex * input, + * unsigned int samples_num, + * gr_complex * rhh, + * unsigned int start_state, + * const unsigned int * stop_states, + * unsigned int stops_num, + * float * output) + * + * INPUT: input: Complex received signal afted matched filtering. + * samples_num: Number of samples in the input table. + * rhh: The autocorrelation of the estimated channel + * impulse response. + * start_state: Number of the start point. In GSM each burst + * starts with sequence of three bits (0,0,0) which + * indicates start point of the algorithm. + * stop_states: Table with numbers of possible stop states. + * stops_num: Number of possible stop states + * + * + * OUTPUT: output: Differentially decoded hard output of the algorithm: + * -1 for logical "0" and 1 for logical "1" + * + * SUB_FUNC: none + * + * TEST(S): Tested with real world normal burst. + */ + +#ifndef INCLUDED_VITERBI_DETECTOR_H +#define INCLUDED_VITERBI_DETECTOR_H +#include "constants.h" + +void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); + +#endif /* INCLUDED_VITERBI_DETECTOR_H */ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

Jump to page:

2025

2024

2023

2022

gerrit-log December 2022