Attention is currently required from: Hoernchen.
fixeria has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 )
Change subject: rename noisevector class -> avgvector
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927
Gerrit-Change-Number: 30411
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: deleteVote
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30417 )
Change subject: ansible: coverity: update version to 22.06
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30417
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4
Gerrit-Change-Number: 30417
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:33:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 )
Change subject: vita demod by piotr krysik, modified
......................................................................
Patch Set 2:
(5 comments)
File Transceiver52M/grgsm_vitac/constants.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc5d57fe_d5da79bd
PS2, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second
Having "//" comments in a define looks dangerous to me, I'm not sure if first the comments are dropped or firt the preprocessor is run.
In any case, I think we tend to use /**/ everywhere.
File Transceiver52M/grgsm_vitac/grgsm_vitac.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ba59ef2_8eef2d3b
PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
> Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Please fix.
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c865ad_68bde2ad
PS2, Line 38: void initvita();
> Bad function definition - void initvita() should probably be void initvita(void)
Please fix.
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2bd6c0cd_05adc4da
PS2, Line 62: };
> adding a line without newline at end of file
Please fix.
File Transceiver52M/grgsm_vitac/viterbi_detector.cc:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3fd9ef39_33dcc2b5
PS2, Line 1: /* -*- c++ -*- */
All files are named ".cpp", why is this one named ".cc"?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f
Gerrit-Change-Number: 30415
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:22:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 )
Change subject: ill-fated ipcv2 for mstrx
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a0027ad1_fde20f25
PS2, Line 10: inteval to a few fn/ts on the trx side to work at all, but scheduling
interval
Patchset:
PS2:
so the outcome is that this is actually not going to be used for now?
Then let's better keep it in a separate branch to avoid having to maintain even more interfaces, implementations, etc.
Let's also avoid this way someone using it to implement a a device without us knowing and having to keep the interface around in the future until it has been proven to be useful.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30419 )
Change subject: hosts: update coverity-slaves
......................................................................
hosts: update coverity-slaves
Remove the deb9 lxcs as they are being retired, and add two deb11 lxcs.
Coverity is quite big with 1.2 GiB, so deploying and upgrading this
takes some time. Having it on two hosts should be enough.
Related: OS#5793
Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0
---
M ansible/hosts
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/19/30419/1
diff --git a/ansible/hosts b/ansible/hosts
index e1756be..cc19dfe 100644
--- a/ansible/hosts
+++ b/ansible/hosts
@@ -3,9 +3,8 @@
osmo-gsm-tester-prod ansible_host=10.9.25.107
[coverity-slaves]
-admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300
-build2-deb9build-ansible ansible_host=2a01:4f8:10b:2ad9::1:6
-host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3
+build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13
+build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3
[jenkins-slaves]
admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 osmocom_jenkins_slave_fstrim=True
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30419
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0
Gerrit-Change-Number: 30419
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
