December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-trx[master]: ms-trx support

by fixeria

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 3: (21 comments) File Transceiver52M/ms/ms_upper.h: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de8e74a6_3a259a08 PS3, Line 1: ws https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a302518_73cc4d5c PS3, Line 36: trx_if do you really need/use TRXC/TRXD here? File Transceiver52M/ms/ms_upper.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32a010d7_8a17baca PS3, Line 61: #include <osmocom/core/gsmtap_util.h> you're not using GSMTAP API here... https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/226cc199_31255475 PS3, Line 64: // #include <osmocom/core/application.h> removeme https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93fc1081_e6a4c799 PS3, Line 71: trx_if do you really need/use TRXC/TRXD here? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fef1b6b3_90d5b9f3 PS3, Line 74: #include <osmocom/bb/l1sched/l1sched.h> I don't see any l1sched_* API used in this file. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7aa85f32_4e0185b4 PS3, Line 177: return trash can you clarify this a bit further? thrash? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b6afa5b_a3a7daf3 PS3, Line 184: RSSI = 10 why 10? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3aeccd0b_dd0bd268 PS3, Line 223: timingOffset = (int)round(0); TODO/FIXME? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/164d3c60_0da5723e PS3, Line 238: trx_data_rx_handler removeme https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f5c1c4f_7ee4a937 PS3, Line 246: trxcon_phyif_handle_clock_ind removeme https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d43344cf_b38b007c PS3, Line 304: case trxcon::TRXCON_PHYIF_CMDT_RESET Better use value-string for that. Ideally such a value string should be part of libtrxcon, so it's always in sync with the TRXCON_PHYIF_CMDT_* values. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2faadf5a_771fc6f7 PS3, Line 352: set_ta Shouldn't this be done on receipt of TRXCON_PHYIF_CMDT_RESET instead? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86b41add_7e99a70e PS3, Line 357: dbm = -80 please add a FIXME or TODO, so it's clear that the measurement logic is missing https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d17174c_41e5bdcd PS3, Line 364: gsm_arfcn2freq10 careful, this function may return 0xffff https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76523f1d_1714766d PS3, Line 385: assert OSMO_ASSERT? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32cb86c8_4b13670b PS3, Line 425: trxcon it's not trxcon app anymore https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/46c73659_9bc25e02 PS3, Line 429: 3 pass 0 to avoid confusion, we're not using fn_advance here https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17f43833_0f042a41 PS3, Line 430: gsmtap = 0; gsmtap is a pointer, so = NULL https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9efc989_1a4b0ef7 PS3, Line 431: 0x1234 What's this? Why not NULL? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31d216f3_ce23d1ec PS3, Line 433: trxc I would avoid using 'trxc' here to avoid confusion with the TRXC protocol. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: vty: Write amount of timeouts elapsed for a paging request

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30402 ) Change subject: vty: Write amount of timeouts elapsed for a paging request ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a Gerrit-Change-Number: 30402 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:44:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 ) Change subject: paging: Optimize retrieving number of request per paging group ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 Gerrit-Change-Number: 30370 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:44:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Replace reqs waiting for retransmission with new incoming ini...

by laforge

Attention is currently required from: neels, pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30347 ) Change subject: paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d Gerrit-Change-Number: 30347 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:43:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by laforge

Attention is currently required from: pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/fdf6f1dc_453418b5 PS1, Line 1045: static void paging_dump_vty(struct vty *vty, struct gsm_paging_request *pag) : { : vty_out(vty, "Paging on BTS %u%s", pag->bts->nr, VTY_NEWLINE); : bsc_subscr_dump_vty(vty, pag->bsub); : } : : static void bts_paging_dump_vty(struct vty *vty, struct gsm_bts *bts) : { : struct gsm_paging_request *pag; : : llist_for_each_entry(pag, &bts->paging.initial_req_list, entry) : paging_dump_vty(vty, pag); : llist_for_each_entry(pag, &bts->paging.retrans_req_list, entry) : paging_dump_vty(vty, pag); > Will be submitted as Change-ID I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:42:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: vty: Write amount of timeouts elapsed for a paging request

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30402 ) Change subject: vty: Write amount of timeouts elapsed for a paging request ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a Gerrit-Change-Number: 30402 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:41:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 ) Change subject: paging: Optimize retrieving number of request per paging group ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 Gerrit-Change-Number: 30370 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:41:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 ) Change subject: osmocom-bb for ms-trx side trxcon integration ...................................................................... osmocom-bb for ms-trx side trxcon integration Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61 --- A .gitmodules A osmocom-bb 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..bc94e80 --- /dev/null +++ b/.gitmodules @@ -0,0 +1,4 @@ +[submodule "osmocom-bb"] + path = osmocom-bb + url = https://gitea.osmocom.org/phone-side/osmocom-bb.git + branch = a4aac5c3554559c2c994609f90b92a9daf6e8a89 diff --git a/osmocom-bb b/osmocom-bb new file mode 160000 index 0000000..a4aac5c --- /dev/null +++ b/osmocom-bb @@ -0,0 +1 @@ +Subproject commit a4aac5c3554559c2c994609f90b92a9daf6e8a89 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61 Gerrit-Change-Number: 30412 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: ansible/coverity: extract into subdirectory

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30418 ) Change subject: ansible/coverity: extract into subdirectory ...................................................................... ansible/coverity: extract into subdirectory The tarball provided by coverity doesn't have the same version in the name as in the directory inside the tarball. Tarball: cov-analysis-linux64-2022.06.tar.gz Directory: cov-analysis-linux64-2022.6.0 Work around this by extracting it into a subdirectory and using glob to match the directory name. Related: OS#5793 Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b --- M ansible/roles/install-coverity/tasks/main.yml 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml index 5baf6f3..4047fb8 100644 --- a/ansible/roles/install-coverity/tasks/main.yml +++ b/ansible/roles/install-coverity/tasks/main.yml @@ -13,9 +13,9 @@ ignore_errors: yes tags: [coverity] -- name: create /opt/coverity +- name: create /opt/coverity/{{ coverity_version }}/ file: - path: /opt/coverity/ + path: /opt/coverity/{{ coverity_version }}/ state: directory when: coverity_copy.failed == False tags: [coverity] @@ -23,16 +23,15 @@ - name: unpack coverity unarchive: src: "/tmp/{{ coverity_installer_file }}" - dest: /opt/coverity/ + dest: /opt/coverity/{{ coverity_version }} remote_src: yes when: coverity_copy.failed == False tags: [coverity] -- name: create link /opt/coverity/last - file: - src: /opt/coverity/cov-analysis-linux64-{{ coverity_version }} - dest: /opt/coverity/current - state: link +- name: create link /opt/coverity/current + shell: ln -sf /opt/coverity/{{ coverity_version }}/* /opt/coverity/current + args: + warn: false when: coverity_copy.failed == False tags: [coverity] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b Gerrit-Change-Number: 30418 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: hosts: update coverity-slaves

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30419 ) Change subject: hosts: update coverity-slaves ...................................................................... hosts: update coverity-slaves Remove the deb9 lxcs as they are being retired, and add two deb11 lxcs. Coverity is quite big with 1.2 GiB, so deploying and upgrading this takes some time. Having it on two hosts should be enough. Related: OS#5793 Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0 --- M ansible/hosts 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/hosts b/ansible/hosts index e1756be..cc19dfe 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -3,9 +3,8 @@ osmo-gsm-tester-prod ansible_host=10.9.25.107 [coverity-slaves] -admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 -build2-deb9build-ansible ansible_host=2a01:4f8:10b:2ad9::1:6 -host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3 +build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 +build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 [jenkins-slaves] admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 osmocom_jenkins_slave_fstrim=True -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0 Gerrit-Change-Number: 30419 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022