Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 3: (10 comments) File .gitignore: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0086bac1_ac4d05be PS3, Line 10: Transceiver52M/osmo-trx-ipc2 This doesn't belong to this commit afaiu. Patchset: PS3: Why is the ms-trx put into a subdir under Transceiver52M? Can we have the Transceiver52M directory converted to libtransceiver.la or alike, then have an osmo-trx and osmo-trx-ms directories so that we don't merged stuf even more? File Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0296f7c1_dc193b65 PS3, Line 37: osmocom-bb/src/host/trxcon \ osmocom-bb/src/host/trxcon is added twice? here and above File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9911755_990eb911 PS3, Line 27: AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/ Is it OK if the submodule isn't there and the patch doesn't exist? I guess it's fine, the compiler just ignores that one. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2448b1a0_d64369bb PS3, Line 28: AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/ What about filling a LIBTRXCON_CFLAGS/LIBS in configure? It would be way more cleaner. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3233721a_fa3176d3 PS3, Line 82: $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1sched.a \ LIBTRXCON_LIBS in configure.ac https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f68ebf93_26c3e026 PS3, Line 115: $(TRXCON_LDADD) LIBTRXCON_LIBS in configure.ac https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c867b9e_ec7f24a0 PS3, Line 124: $(TRXCON_LDADD) LIBTRXCON_LIBS in configure.ac https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3405ad0d_6ed50393 PS3, Line 187: # bin_PROGRAMS += osmo-trx-ipc2 This doesn't belong to this patch. File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f629f50e_a7357ce6 PS3, Line 364: doc/manuals/Makefile \ This looks like a separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 12:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment