Attention is currently required from: Hoernchen.
10 comments:
File .gitignore:
Patch Set #3, Line 10: Transceiver52M/osmo-trx-ipc2
This doesn't belong to this commit afaiu.
Patchset:
Why is the ms-trx put into a subdir under Transceiver52M?
Can we have the Transceiver52M directory converted to libtransceiver.la or alike, then have an osmo-trx and osmo-trx-ms directories so that we don't merged stuf even more?
File Makefile.am:
Patch Set #3, Line 37: osmocom-bb/src/host/trxcon \
osmocom-bb/src/host/trxcon is added twice? here and above
File Transceiver52M/Makefile.am:
Patch Set #3, Line 27: AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
Is it OK if the submodule isn't there and the patch doesn't exist? I guess it's fine, the compiler just ignores that one.
Patch Set #3, Line 28: AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
What about filling a LIBTRXCON_CFLAGS/LIBS in configure? It would be way more cleaner.
Patch Set #3, Line 82: $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1sched.a \
LIBTRXCON_LIBS in configure.ac
Patch Set #3, Line 115: $(TRXCON_LDADD)
LIBTRXCON_LIBS in configure.ac
Patch Set #3, Line 124: $(TRXCON_LDADD)
LIBTRXCON_LIBS in configure.ac
Patch Set #3, Line 187: # bin_PROGRAMS += osmo-trx-ipc2
This doesn't belong to this patch.
File configure.ac:
Patch Set #3, Line 364: doc/manuals/Makefile \
This looks like a separate patch.
To view, visit change 30416. To unsubscribe, or for help writing mail filters, visit settings.