Attention is currently required from: fixeria, pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/da8d2c5e_062f6abb PS1, Line 216:

Is there a way to include this in our lint job? it could probably extended for that, but I don't think it's worth investigating right now. it's a perl script from the linux kernel (checkpatch).

https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/215193ae_5e983785 PS1, Line 263: bts_pag_st->initial_req_list_len--;

Yeah, same behavior, just more encapsulated. […] Done

https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/e8e95c19_df47880a PS1, Line 279: static unsigned int step_page_retrans_reqs(struct gsm_bts_paging_state *bts_pag_st, unsigned int max_page_req_per_iter, const struct timespec *now)

This line exceeds the 120 chars-per-line limit. Done

https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/211fc5b0_7b325c6e PS1, Line 532:

indentation Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:03:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Gerrit-MessageType: comment