Attention is currently required from: fixeria, pespin, daniel.

Patch set 2:Code-Review +1

View Change

4 comments:

• File src/osmo-bsc/paging.c:

  • Patch Set #1, Line 216:

    Is there a way to include this in our lint job?

    it could probably extended for that, but I don't think it's worth investigating right now. it's a perl script from the linux kernel (checkpatch).

  • Patch Set #1, Line 263: bts_pag_st->initial_req_list_len--;

    Yeah, same behavior, just more encapsulated. […]

    Done

  • Patch Set #1, Line 279: static unsigned int step_page_retrans_reqs(struct gsm_bts_paging_state *bts_pag_st, unsigned int max_page_req_per_iter, const struct timespec *now)

    This line exceeds the 120 chars-per-line limit.

    Done

  • Patch Set #1, Line 532:

    indentation

    Done

To view, visit change 30363. To unsubscribe, or for help writing mail filters, visit settings.