November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: rework l1sched_trigger(), split l1sched_pull_burst()

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30239 ) Change subject: trxcon: rework l1sched_trigger(), split l1sched_pull_burst() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibb7f9d7de26733f21b0753a2c655a250286bf1f0 Gerrit-Change-Number: 30239 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 23:22:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: contrib/jenkins.sh : build and publish combined targets

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30151 ) Change subject: contrib/jenkins.sh : build and publish combined targets ...................................................................... contrib/jenkins.sh : build and publish combined targets This makes production a bit easier. Related: OS#5722 Change-Id: I32f9a0213aaefa50232a3d8dc2e7a4f2f44dbae1 --- M contrib/jenkins.sh 1 file changed, 24 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1c2e2ea..be6bda1 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -27,20 +27,37 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -BUILDS="" -BUILDS+="simtrace/dfu simtrace/blupdate simtrace/trace simtrace/cardem " -BUILDS+="qmod/dfu qmod/blupdate qmod/cardem " -BUILDS+="owhw/dfu owhw/blupdate owhw/cardem " -BUILDS+="octsimtest/cardem " -BUILDS+="ngff_cardem/dfu ngff_cardem/blupdate ngff_cardem/cardem ngff_cardem/trace " +# dfu target MUST be built first, the combined targets need a bl that can be combined.. +BUILDS="simtrace/dfu qmod/dfu owhw/dfu ngff_cardem/dfu " +# +BUILDS+="simtrace/blupdate qmod/blupdate owhw/blupdate ngff_cardem/blupdate " +BUILDS+="simtrace/cardem qmod/cardem owhw/cardem octsimtest/cardem ngff_cardem/cardem " +BUILDS+="simtrace/trace ngff_cardem/trace " cd $TOPDIR/firmware for build in $BUILDS; do board=`echo $build | cut -d "/" -f 1` app=`echo $build | cut -d "/" -f 2` + case "$build" in + "owhw/cardem") + comb="combined" + ;; + "qmod/cardem") + comb="combined" + ;; + "ngff_cardem/cardem") + comb="combined" + ;; + "simtrace/trace") + comb="combined" + ;; + *) + comb="" + ;; + esac echo echo "=============== $board / $app START ==============" - PATH="/opt/llvm-arm/bin:$PATH" make USE_CLANG=1 BOARD="$board" APP="$app" + PATH="/opt/llvm-arm/bin:$PATH" make USE_CLANG=1 BOARD="$board" APP="$app" $comb echo "=============== $board / $app RES:$? ==============" done 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32f9a0213aaefa50232a3d8dc2e7a4f2f44dbae1 Gerrit-Change-Number: 30151 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: contrib/jenkins.sh : build and publish combined targets

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30151 ) Change subject: contrib/jenkins.sh : build and publish combined targets ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32f9a0213aaefa50232a3d8dc2e7a4f2f44dbae1 Gerrit-Change-Number: 30151 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 21:54:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: contrib/jenkins.sh : build and publish combined targets

by laforge

Attention is currently required from: Hoernchen. laforge has uploaded a new patch set (#2) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/30151 ) Change subject: contrib/jenkins.sh : build and publish combined targets ...................................................................... contrib/jenkins.sh : build and publish combined targets This makes production a bit easier. Related: OS#5722 Change-Id: I32f9a0213aaefa50232a3d8dc2e7a4f2f44dbae1 --- M contrib/jenkins.sh 1 file changed, 24 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/51/30151/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32f9a0213aaefa50232a3d8dc2e7a4f2f44dbae1 Gerrit-Change-Number: 30151 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: HACK: Solve weird problem wih lost OUT transfer on ping-pong endpoint

by laforge

Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16910 ) Change subject: HACK: Solve weird problem wih lost OUT transfer on ping-pong endpoint ...................................................................... Patch Set 4: Verified+1 -Code-Review -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I18ed530e617baddf76e8f9829512443ce2a76e0d Gerrit-Change-Number: 16910 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 21:20:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: HACK: Solve weird problem wih lost OUT transfer on ping-pong endpoint

by laforge

Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16910 ) Change subject: HACK: Solve weird problem wih lost OUT transfer on ping-pong endpoint ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: tab indent not applicable in atmel code -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I18ed530e617baddf76e8f9829512443ce2a76e0d Gerrit-Change-Number: 16910 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 21:19:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: HACK: Solve weird problem wih lost OUT transfer on ping-pong endpoint

by laforge

Attention is currently required from: laforge, jtavares. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16910 ) Change subject: HACK: Solve weird problem wih lost OUT transfer on ping-pong endpoint ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I18ed530e617baddf76e8f9829512443ce2a76e0d Gerrit-Change-Number: 16910 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jtavares <jtavares(a)kvh.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: deleteVote

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: HACK: Solve weird problem wih lost OUT transfer on ping-pong endpoint

by laforge

Attention is currently required from: laforge. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16910 ) Change subject: HACK: Solve weird problem wih lost OUT transfer on ping-pong endpoint ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I18ed530e617baddf76e8f9829512443ce2a76e0d Gerrit-Change-Number: 16910 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 22 Nov 2022 21:18:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: simtrace2-tool: hack: kick the comms by sending a fake message

by James Tavares

James Tavares has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26864 ) Change subject: simtrace2-tool: hack: kick the comms by sending a fake message ...................................................................... simtrace2-tool: hack: kick the comms by sending a fake message This is a workaround until the root cause of the communications failure between simtrace2-tool and simtrace2 firmware is identified. Additional details provided on simtrace mailing list. Change-Id: I40fa06bee5d8194516497e16597e069124ddf0fb --- M host/include/osmocom/simtrace2/simtrace2_api.h M host/lib/simtrace2_api.c M host/src/simtrace2-tool.c 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/64/26864/1 diff --git a/host/include/osmocom/simtrace2/simtrace2_api.h b/host/include/osmocom/simtrace2/simtrace2_api.h index d658d16..3a7e5ae 100644 --- a/host/include/osmocom/simtrace2/simtrace2_api.h +++ b/host/include/osmocom/simtrace2/simtrace2_api.h @@ -44,6 +44,7 @@ int osmo_st2_slot_tx_msg(struct osmo_st2_slot *slot, struct msgb *msg, uint8_t msg_class, uint8_t msg_type); +int osmo_st2_generic_do_error_none(struct osmo_st2_cardem_inst *ci); int osmo_st2_cardem_request_card_insert(struct osmo_st2_cardem_inst *ci, bool inserted); int osmo_st2_cardem_request_pb_and_rx(struct osmo_st2_cardem_inst *ci, uint8_t pb, uint8_t le); diff --git a/host/lib/simtrace2_api.c b/host/lib/simtrace2_api.c index 4ad7eb7..beb6de4 100644 --- a/host/lib/simtrace2_api.c +++ b/host/lib/simtrace2_api.c @@ -155,6 +155,24 @@ } /*********************************************************************** + * Generic protocol + ***********************************************************************/ + +/*! \brief Send an empty DO_ERROR message to the simtrace2 board */ +int osmo_st2_generic_do_error_none(struct osmo_st2_cardem_inst *ci) +{ + struct msgb *msg = st_msgb_alloc(); + struct cardemu_usb_msg_error *err; + + LOGSLOT(ci->slot, LOGL_NOTICE, "<= %s\n", __func__); + + err = (struct cardemu_usb_msg_error *) msgb_put(msg, sizeof(*err)); + memset(err, 0, sizeof(*err)); + + return osmo_st2_slot_tx_msg(ci->slot, msg, SIMTRACE_MSGC_GENERIC, SIMTRACE_CMD_DO_ERROR); +} + +/*********************************************************************** * Card Emulation protocol ***********************************************************************/ diff --git a/host/src/simtrace2-tool.c b/host/src/simtrace2-tool.c index d92638f..407eac9 100644 --- a/host/src/simtrace2-tool.c +++ b/host/src/simtrace2-tool.c @@ -297,6 +297,10 @@ fprintf(stderr, "can't obtain EP addrs; rc=%d\n", rc); goto close_exit; } + + // HACK: kick the board with a fake message to get subsequent messages to be accepted + // TODO: figure out the real problem, and remove this + osmo_st2_generic_do_error_none(ci); } if (argc - optind <= 0) { -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I40fa06bee5d8194516497e16597e069124ddf0fb Gerrit-Change-Number: 26864 Gerrit-PatchSet: 1 Gerrit-Owner: James Tavares <jtavares(a)kvh.com> Gerrit-MessageType: newchange

2 years, 7 months

3
5
0 0

Change in osmo-bsc[master]: paging: Use bsub->active_paging_requests to optimize cancelling based...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30275 ) Change subject: paging: Use bsub->active_paging_requests to optimize cancelling based on reason ...................................................................... paging: Use bsub->active_paging_requests to optimize cancelling based on reason Prior to this patch the whole paging queue of each BTS was iterated. After the patch only the active paging_req for a given subscriber are iterated. Related: SYS#6200 Change-Id: I225d5e08427c6bb9d92ce6a1dccb6ce36053eab5 --- M src/osmo-bsc/paging.c 1 file changed, 18 insertions(+), 10 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index b73578e..3909a7f 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -577,20 +577,28 @@ /* Remove all paging requests, for specific reasons only. */ void paging_request_cancel(struct bsc_subscr *bsub, enum bsc_paging_reason reasons) { - struct gsm_bts *bts; + struct gsm_paging_request *req, *req2; OSMO_ASSERT(bsub); - llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) { - struct gsm_paging_request *req, *req2; + /* Avoid accessing bsub after reaching 0 active_paging_request_len, + * since it could be freed during put(): */ + unsigned remaining = bsub->active_paging_requests_len; - llist_for_each_entry_safe(req, req2, &bts->paging.pending_requests, entry) { - if (req->bsub != bsub) - continue; - if (!(req->reason & reasons)) - continue; - LOG_PAGING_BTS(req, bts, DPAG, LOGL_DEBUG, "Cancel paging\n"); - paging_remove_request(&bts->paging, req); + llist_for_each_entry_safe(req, req2, &bsub->active_paging_requests, bsub_entry) { + if (!(req->reason & reasons)) + continue; + LOG_PAGING_BTS(req, req->bts, DPAG, LOGL_DEBUG, "Cancel paging reasons=0x%x\n", + reasons); + if (req->reason & ~reasons) { + /* Other reasons are active, simply drop the reasons from func arg: */ + req->reason &= ~reasons; + continue; } + /* No reason to keep the paging, remove it: */ + paging_remove_request(&req->bts->paging, req); + remaining--; + if (remaining == 0) + break; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I225d5e08427c6bb9d92ce6a1dccb6ce36053eab5 Gerrit-Change-Number: 30275 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022